From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] package/libwebsockets: fix static build with openssl
Date: Fri, 18 Oct 2019 08:54:11 +0200 [thread overview]
Message-ID: <20191018085411.61f0da4e@windsurf> (raw)
In-Reply-To: <CAPi7W81sWZ2yD00gnaBA+VV6vviNXc5zn8GsvFiTves0+ckTuQ@mail.gmail.com>
On Thu, 17 Oct 2019 18:57:43 +0200
Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:
> > Then:
> >
> > find_package(PkgConfig QUIET)
> > if(whatever is the right way to check if pkg-config was found)
> > pkg_check_modules(PC_OPENSSL openssl QUIET)
> > ... adjust LIBS/CFLAGS ...
> > else()
> > find_package(OpenSSL REQUIRED)
> > endif()
> Upstream merged the patch as is, should I sent them a new PR with your updates?
If upstream was happy with your patch as-is, I'm fine with it :-)
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2019-10-18 6:54 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-16 20:41 [Buildroot] [PATCH 1/1] package/libwebsockets: fix static build with openssl Fabrice Fontaine
2019-10-16 20:48 ` Thomas Petazzoni
2019-10-16 21:08 ` Fabrice Fontaine
2019-10-16 21:10 ` Thomas Petazzoni
2019-10-17 16:57 ` Fabrice Fontaine
2019-10-18 6:54 ` Thomas Petazzoni [this message]
2019-10-21 20:01 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191018085411.61f0da4e@windsurf \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.