From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,PDS_TONAME_EQ_TOLOCAL_SHORT,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 76613CA9EA0 for ; Fri, 18 Oct 2019 10:51:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4B36021897 for ; Fri, 18 Oct 2019 10:51:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389105AbfJRKv0 (ORCPT ); Fri, 18 Oct 2019 06:51:26 -0400 Received: from Chamillionaire.breakpoint.cc ([193.142.43.52]:34344 "EHLO Chamillionaire.breakpoint.cc" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725906AbfJRKvZ (ORCPT ); Fri, 18 Oct 2019 06:51:25 -0400 Received: from fw by Chamillionaire.breakpoint.cc with local (Exim 4.92) (envelope-from ) id 1iLPqp-0002g3-LZ; Fri, 18 Oct 2019 12:51:19 +0200 Date: Fri, 18 Oct 2019 12:51:19 +0200 From: Florian Westphal To: wenxu Cc: Florian Westphal , pablo@netfilter.org, netfilter-devel@vger.kernel.org Subject: Re: [PATCH nf-next] netfilter: nf_tables: add vlan support Message-ID: <20191018105119.GZ25052@breakpoint.cc> References: <1571392968-1263-1-git-send-email-wenxu@ucloud.cn> <20191018102402.GY25052@breakpoint.cc> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: netfilter-devel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netfilter-devel@vger.kernel.org wenxu wrote: > > If you plan to extend this in the future then I'm fine with keeping it > > as a module. > It can add vlan tci / proto "get" expr and It also can support offload things in the future. Ok, lets keep it as a module then.