All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: rtl8723bs: reduce stack usage of rtw_cfg80211_unlink_bss
Date: Fri, 18 Oct 2019 14:30:17 +0300	[thread overview]
Message-ID: <20191018113017.GG24678@kadam> (raw)
In-Reply-To: <20191018104837.23246-1-sudipm.mukherjee@gmail.com>

On Fri, Oct 18, 2019 at 11:48:37AM +0100, Sudip Mukherjee wrote:
> The build of xtensa allmodconfig gives warning of:
> In function 'rtw_cfg80211_unlink_bss':
> warning: the frame size of 1136 bytes is larger than 1024 bytes
> 
> Instead of having 'select_network' structure as a variable use it as a
> pointer.
> 
> Signed-off-by: Sudip Mukherjee <sudipm.mukherjee@gmail.com>

Heh.  Nice.

Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>

regards,
dan carpenter


      reply	other threads:[~2019-10-18 11:30 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-18 10:48 [PATCH] staging: rtl8723bs: reduce stack usage of rtw_cfg80211_unlink_bss Sudip Mukherjee
2019-10-18 11:30 ` Dan Carpenter [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191018113017.GG24678@kadam \
    --to=dan.carpenter@oracle.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sudipm.mukherjee@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.