From: Christoph Hellwig <hch@infradead.org>
To: Philippe Liard <pliard@google.com>
Cc: phillip@squashfs.org.uk, linux-kernel@vger.kernel.org,
groeck@chromium.org
Subject: Re: [PATCH] squashfs: Migrate from ll_rw_block usage to BIO
Date: Fri, 18 Oct 2019 09:32:22 -0700 [thread overview]
Message-ID: <20191018163222.GA32033@infradead.org> (raw)
In-Reply-To: <20191018010846.186484-1-pliard@google.com>
I don't see why you still need buffer_heads at all. Basically
if you replace each of your allocated buffer heads with a
simple page allocation the code will be much simpler (this version
adds more than 100 lines of code!) and probaby still a bit faster
as you don't need the squashfs_bio_request allocation either.
next prev parent reply other threads:[~2019-10-18 16:32 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-18 1:08 [PATCH] squashfs: Migrate from ll_rw_block usage to BIO Philippe Liard
2019-10-18 16:32 ` Christoph Hellwig [this message]
2019-10-24 1:23 ` Philippe Liard
2019-10-24 5:41 ` Gao Xiang
2019-10-25 0:45 ` Philippe Liard
2019-10-25 2:53 ` Gao Xiang
2019-10-25 2:53 ` Gao Xiang
2019-10-25 3:02 ` Guenter Roeck via Linux-erofs
2019-10-25 3:12 ` Gao Xiang
2019-10-25 3:12 ` Gao Xiang
2019-10-29 4:10 ` Philippe Liard
2019-10-29 7:49 ` Christoph Hellwig
2019-10-30 1:19 ` Philippe Liard
2019-10-30 14:01 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191018163222.GA32033@infradead.org \
--to=hch@infradead.org \
--cc=groeck@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=phillip@squashfs.org.uk \
--cc=pliard@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.