From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5B789CA9EAC for ; Sat, 19 Oct 2019 09:39:30 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2F114222C2 for ; Sat, 19 Oct 2019 09:39:30 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="cqPL4KDx" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2F114222C2 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=QQ3NPICD0QHURj3cZgl/rCQm+Gps+n9uKna8FiVeF3s=; b=cqPL4KDxbal1bT 6wL372u5HqFspVD+exdf4a2w05rP15oDKlA2k+d7ktplkQedl18nE6L5uZXcHUoXRc+rXnDOvsE5s slxq39LAMc6sOquvf63xQMhV8w4eyrHpWpT9EuThLXabbiPBOxv1l4TRwBuSsw00wIssIIer2Roys lsTyfZPcFsD8zREk/HcRihYuhjjrlYuO5zFboi0jHu8TFhjsmiZibt9zfVsMgVnVS2TX6McazDvVR BO5oO2UZec3phZFGTBtQZuOPRJ3qGN0vSobkwQulFHrVI7LryFgQoobFFkQ5OvFFRG1eqKKPJ8aZn SE7GwLRoBTf6RcUp4C2g==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iLlCq-00034n-OM; Sat, 19 Oct 2019 09:39:28 +0000 Received: from relay7-d.mail.gandi.net ([217.70.183.200]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iLlCe-0002v6-QN; Sat, 19 Oct 2019 09:39:18 +0000 X-Originating-IP: 91.224.148.103 Received: from xps13 (unknown [91.224.148.103]) (Authenticated sender: miquel.raynal@bootlin.com) by relay7-d.mail.gandi.net (Postfix) with ESMTPSA id 43C3A20002; Sat, 19 Oct 2019 09:39:01 +0000 (UTC) Date: Sat, 19 Oct 2019 11:39:00 +0200 From: Miquel Raynal To: Florian Fainelli Subject: Re: [PATCH] mtd: rawnand: brcmnand: Fix sparse warning in has_flash_dma() Message-ID: <20191019113824.15fa4f52@xps13> In-Reply-To: <20191018233844.23838-1-f.fainelli@gmail.com> References: <20191018233844.23838-1-f.fainelli@gmail.com> Organization: Bootlin X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191019_023916_992260_42A91E2A X-CRM114-Status: GOOD ( 13.23 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Vignesh Raghavendra , Kamal Dasu , Richard Weinberger , open list , Marek Vasut , "open list:BROADCOM STB NAND FLASH DRIVER" , "open list:BROADCOM STB NAND FLASH DRIVER" , Brian Norris , David Woodhouse , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org SGkgRmxvcmlhbiwKCkZsb3JpYW4gRmFpbmVsbGkgPGYuZmFpbmVsbGlAZ21haWwuY29tPiB3cm90 ZSBvbiBGcmksIDE4IE9jdCAyMDE5CjE2OjM4OjQ0IC0wNzAwOgoKPiBTcGFyc2UgcmlnaHRmdWxs eSBjb21wbGFpbmVkIGFib3V0IGhhc19mbGFzaF9kbWEoKToKPiArZHJpdmVycy9tdGQvbmFuZC9i cmNtbmFuZC9icmNtbmFuZC5jOjk1MTo0MDogd2FybmluZzogVXNpbmcgcGxhaW4gaW50ZWdlciBh cyBOVUxMIHBvaW50ZXIgW3NwYXJzZV0KCkkgZG9uJ3QgZ2V0IHdoeSB3b3VsZCBzcGFyc2UgY29t cGxhaW4gYWJvdXQgdGhpcy4uLiBBbnl3YXkgSSBwcmVmZXIKdGhlICEhKDxwb2ludGVyPikgYWx0 ZXJuYXRpdmUgaWYgeW91IGRvbid0IG1pbmQuIE90aGVyd2lzZSB0aGUgIiE9Ck5VTEwiIGNvbXBh cmlzb24gZmVlbHMgd3JvbmcuCgo+IAo+IEZpeGVzOiAyN2M1YjE3Y2QxYjEgKCJtdGQ6IG5hbmQ6 IGFkZCBOQU5EIGRyaXZlciAibGlicmFyeSIgZm9yIEJyb2FkY29tIFNUQiBOQU5EIGNvbnRyb2xs ZXIiKQo+IFNpZ25lZC1vZmYtYnk6IEZsb3JpYW4gRmFpbmVsbGkgPGYuZmFpbmVsbGlAZ21haWwu Y29tPgo+IC0tLQo+ICBkcml2ZXJzL210ZC9uYW5kL3Jhdy9icmNtbmFuZC9icmNtbmFuZC5jIHwg MiArLQo+ICAxIGZpbGUgY2hhbmdlZCwgMSBpbnNlcnRpb24oKyksIDEgZGVsZXRpb24oLSkKPiAK PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9tdGQvbmFuZC9yYXcvYnJjbW5hbmQvYnJjbW5hbmQuYyBi L2RyaXZlcnMvbXRkL25hbmQvcmF3L2JyY21uYW5kL2JyY21uYW5kLmMKPiBpbmRleCAxNWVmMzBi MzY4YTUuLjczZjdhMDk0NTM5OSAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL210ZC9uYW5kL3Jhdy9i cmNtbmFuZC9icmNtbmFuZC5jCj4gKysrIGIvZHJpdmVycy9tdGQvbmFuZC9yYXcvYnJjbW5hbmQv YnJjbW5hbmQuYwo+IEBAIC05MDksNyArOTA5LDcgQEAgc3RhdGljIGlubGluZSB2b2lkIGJyY21u YW5kX3NldF93cChzdHJ1Y3QgYnJjbW5hbmRfY29udHJvbGxlciAqY3RybCwgYm9vbCBlbikKPiAg Cj4gIHN0YXRpYyBpbmxpbmUgYm9vbCBoYXNfZmxhc2hfZG1hKHN0cnVjdCBicmNtbmFuZF9jb250 cm9sbGVyICpjdHJsKQo+ICB7Cj4gLQlyZXR1cm4gY3RybC0+Zmxhc2hfZG1hX2Jhc2U7Cj4gKwly ZXR1cm4gY3RybC0+Zmxhc2hfZG1hX2Jhc2UgIT0gTlVMTDsKPiAgfQo+ICAKPiAgc3RhdGljIGlu bGluZSB2b2lkIGRpc2FibGVfY3RybF9pcnFzKHN0cnVjdCBicmNtbmFuZF9jb250cm9sbGVyICpj dHJsKQoKClRoYW5rcywKTWlxdcOobAoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fCkxpbnV4IE1URCBkaXNjdXNzaW9uIG1haWxpbmcgbGlzdApo dHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LW10ZC8K From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 784B6CA9EAC for ; Sat, 19 Oct 2019 09:39:32 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 35DD62082F for ; Sat, 19 Oct 2019 09:39:32 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="cfVLNLZa" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 35DD62082F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=HgMmZCLdBOP4KDQq6W/8WqQOs5HtS+x4FIUHeGQ86Bk=; b=cfVLNLZajBl/dY ZHg4duDyAY7BknxVBH1auY6+E//XsWIBv02+bhh0qOoJlBGUcI4OparivDtBugBhVxsGzVzM/R/us 2FMHZUilpHBTFAogyWJ9CLQYujxCsKijpmMZKOMk8nQV8t46XPjxrzbRKADfK0m6l8dakBGTwM63y tYXN1rDqt8eQpm26jkHZk6/zPugNI6Jt/Jj/R4yvAXlPkJ1WWR/3uJo9eBp0e9H7EIDuz+vOBoG6y r1T59yliZz+yP2j53FRsj+vzIZudRytxwHw9ZSmIsh/8Sb824EZG//9v0eEEPTItHCpOxTE3Eb23x OLnveXrk1kAeAhTbDOlA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iLlCj-0002w4-EH; Sat, 19 Oct 2019 09:39:21 +0000 Received: from relay7-d.mail.gandi.net ([217.70.183.200]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iLlCe-0002v6-QN; Sat, 19 Oct 2019 09:39:18 +0000 X-Originating-IP: 91.224.148.103 Received: from xps13 (unknown [91.224.148.103]) (Authenticated sender: miquel.raynal@bootlin.com) by relay7-d.mail.gandi.net (Postfix) with ESMTPSA id 43C3A20002; Sat, 19 Oct 2019 09:39:01 +0000 (UTC) Date: Sat, 19 Oct 2019 11:39:00 +0200 From: Miquel Raynal To: Florian Fainelli Subject: Re: [PATCH] mtd: rawnand: brcmnand: Fix sparse warning in has_flash_dma() Message-ID: <20191019113824.15fa4f52@xps13> In-Reply-To: <20191018233844.23838-1-f.fainelli@gmail.com> References: <20191018233844.23838-1-f.fainelli@gmail.com> Organization: Bootlin X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191019_023916_992260_42A91E2A X-CRM114-Status: GOOD ( 13.23 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Vignesh Raghavendra , Kamal Dasu , Richard Weinberger , open list , Marek Vasut , "open list:BROADCOM STB NAND FLASH DRIVER" , "open list:BROADCOM STB NAND FLASH DRIVER" , Brian Norris , David Woodhouse , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org SGkgRmxvcmlhbiwKCkZsb3JpYW4gRmFpbmVsbGkgPGYuZmFpbmVsbGlAZ21haWwuY29tPiB3cm90 ZSBvbiBGcmksIDE4IE9jdCAyMDE5CjE2OjM4OjQ0IC0wNzAwOgoKPiBTcGFyc2UgcmlnaHRmdWxs eSBjb21wbGFpbmVkIGFib3V0IGhhc19mbGFzaF9kbWEoKToKPiArZHJpdmVycy9tdGQvbmFuZC9i cmNtbmFuZC9icmNtbmFuZC5jOjk1MTo0MDogd2FybmluZzogVXNpbmcgcGxhaW4gaW50ZWdlciBh cyBOVUxMIHBvaW50ZXIgW3NwYXJzZV0KCkkgZG9uJ3QgZ2V0IHdoeSB3b3VsZCBzcGFyc2UgY29t cGxhaW4gYWJvdXQgdGhpcy4uLiBBbnl3YXkgSSBwcmVmZXIKdGhlICEhKDxwb2ludGVyPikgYWx0 ZXJuYXRpdmUgaWYgeW91IGRvbid0IG1pbmQuIE90aGVyd2lzZSB0aGUgIiE9Ck5VTEwiIGNvbXBh cmlzb24gZmVlbHMgd3JvbmcuCgo+IAo+IEZpeGVzOiAyN2M1YjE3Y2QxYjEgKCJtdGQ6IG5hbmQ6 IGFkZCBOQU5EIGRyaXZlciAibGlicmFyeSIgZm9yIEJyb2FkY29tIFNUQiBOQU5EIGNvbnRyb2xs ZXIiKQo+IFNpZ25lZC1vZmYtYnk6IEZsb3JpYW4gRmFpbmVsbGkgPGYuZmFpbmVsbGlAZ21haWwu Y29tPgo+IC0tLQo+ICBkcml2ZXJzL210ZC9uYW5kL3Jhdy9icmNtbmFuZC9icmNtbmFuZC5jIHwg MiArLQo+ICAxIGZpbGUgY2hhbmdlZCwgMSBpbnNlcnRpb24oKyksIDEgZGVsZXRpb24oLSkKPiAK PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9tdGQvbmFuZC9yYXcvYnJjbW5hbmQvYnJjbW5hbmQuYyBi L2RyaXZlcnMvbXRkL25hbmQvcmF3L2JyY21uYW5kL2JyY21uYW5kLmMKPiBpbmRleCAxNWVmMzBi MzY4YTUuLjczZjdhMDk0NTM5OSAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL210ZC9uYW5kL3Jhdy9i cmNtbmFuZC9icmNtbmFuZC5jCj4gKysrIGIvZHJpdmVycy9tdGQvbmFuZC9yYXcvYnJjbW5hbmQv YnJjbW5hbmQuYwo+IEBAIC05MDksNyArOTA5LDcgQEAgc3RhdGljIGlubGluZSB2b2lkIGJyY21u YW5kX3NldF93cChzdHJ1Y3QgYnJjbW5hbmRfY29udHJvbGxlciAqY3RybCwgYm9vbCBlbikKPiAg Cj4gIHN0YXRpYyBpbmxpbmUgYm9vbCBoYXNfZmxhc2hfZG1hKHN0cnVjdCBicmNtbmFuZF9jb250 cm9sbGVyICpjdHJsKQo+ICB7Cj4gLQlyZXR1cm4gY3RybC0+Zmxhc2hfZG1hX2Jhc2U7Cj4gKwly ZXR1cm4gY3RybC0+Zmxhc2hfZG1hX2Jhc2UgIT0gTlVMTDsKPiAgfQo+ICAKPiAgc3RhdGljIGlu bGluZSB2b2lkIGRpc2FibGVfY3RybF9pcnFzKHN0cnVjdCBicmNtbmFuZF9jb250cm9sbGVyICpj dHJsKQoKClRoYW5rcywKTWlxdcOobAoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QKbGludXgtYXJtLWtl cm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxt YW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C4CFDCA9EAB for ; Sat, 19 Oct 2019 09:39:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A4DF8222C2 for ; Sat, 19 Oct 2019 09:39:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726381AbfJSJjO convert rfc822-to-8bit (ORCPT ); Sat, 19 Oct 2019 05:39:14 -0400 Received: from relay7-d.mail.gandi.net ([217.70.183.200]:57969 "EHLO relay7-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726143AbfJSJjN (ORCPT ); Sat, 19 Oct 2019 05:39:13 -0400 X-Originating-IP: 91.224.148.103 Received: from xps13 (unknown [91.224.148.103]) (Authenticated sender: miquel.raynal@bootlin.com) by relay7-d.mail.gandi.net (Postfix) with ESMTPSA id 43C3A20002; Sat, 19 Oct 2019 09:39:01 +0000 (UTC) Date: Sat, 19 Oct 2019 11:39:00 +0200 From: Miquel Raynal To: Florian Fainelli Cc: linux-arm-kernel@lists.infradead.org, Brian Norris , Kamal Dasu , Richard Weinberger , David Woodhouse , Marek Vasut , Vignesh Raghavendra , linux-mtd@lists.infradead.org (open list:BROADCOM STB NAND FLASH DRIVER), bcm-kernel-feedback-list@broadcom.com (open list:BROADCOM STB NAND FLASH DRIVER), linux-kernel@vger.kernel.org (open list) Subject: Re: [PATCH] mtd: rawnand: brcmnand: Fix sparse warning in has_flash_dma() Message-ID: <20191019113824.15fa4f52@xps13> In-Reply-To: <20191018233844.23838-1-f.fainelli@gmail.com> References: <20191018233844.23838-1-f.fainelli@gmail.com> Organization: Bootlin X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Florian, Florian Fainelli wrote on Fri, 18 Oct 2019 16:38:44 -0700: > Sparse rightfully complained about has_flash_dma(): > +drivers/mtd/nand/brcmnand/brcmnand.c:951:40: warning: Using plain integer as NULL pointer [sparse] I don't get why would sparse complain about this... Anyway I prefer the !!() alternative if you don't mind. Otherwise the "!= NULL" comparison feels wrong. > > Fixes: 27c5b17cd1b1 ("mtd: nand: add NAND driver "library" for Broadcom STB NAND controller") > Signed-off-by: Florian Fainelli > --- > drivers/mtd/nand/raw/brcmnand/brcmnand.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/mtd/nand/raw/brcmnand/brcmnand.c b/drivers/mtd/nand/raw/brcmnand/brcmnand.c > index 15ef30b368a5..73f7a0945399 100644 > --- a/drivers/mtd/nand/raw/brcmnand/brcmnand.c > +++ b/drivers/mtd/nand/raw/brcmnand/brcmnand.c > @@ -909,7 +909,7 @@ static inline void brcmnand_set_wp(struct brcmnand_controller *ctrl, bool en) > > static inline bool has_flash_dma(struct brcmnand_controller *ctrl) > { > - return ctrl->flash_dma_base; > + return ctrl->flash_dma_base != NULL; > } > > static inline void disable_ctrl_irqs(struct brcmnand_controller *ctrl) Thanks, Miquèl