From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9C672CA9EA9 for ; Sun, 20 Oct 2019 05:44:17 +0000 (UTC) Received: from isis.lip6.fr (isis.lip6.fr [132.227.60.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 382AA21929 for ; Sun, 20 Oct 2019 05:44:17 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 382AA21929 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=cocci-bounces@systeme.lip6.fr Received: from systeme.lip6.fr (systeme.lip6.fr [132.227.104.7]) by isis.lip6.fr (8.15.2/8.15.2) with ESMTP id x9K5i2TZ001523; Sun, 20 Oct 2019 07:44:02 +0200 (CEST) Received: from systeme.lip6.fr (systeme.lip6.fr [127.0.0.1]) by systeme.lip6.fr (Postfix) with ESMTP id 9099C7792; Sun, 20 Oct 2019 07:44:02 +0200 (CEST) Received: from isis.lip6.fr (isis.lip6.fr [132.227.60.2]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by systeme.lip6.fr (Postfix) with ESMTPS id 94FC67792 for ; Sat, 19 Oct 2019 14:09:46 +0200 (CEST) Received: from relay8-d.mail.gandi.net (relay8-d.mail.gandi.net [217.70.183.201]) by isis.lip6.fr (8.15.2/8.15.2) with ESMTP id x9JC9ilV029148 for ; Sat, 19 Oct 2019 14:09:44 +0200 (CEST) X-Originating-IP: 86.202.229.42 Received: from localhost (lfbn-lyo-1-146-42.w86-202.abo.wanadoo.fr [86.202.229.42]) (Authenticated sender: alexandre.belloni@bootlin.com) by relay8-d.mail.gandi.net (Postfix) with ESMTPSA id 79C991BF208; Sat, 19 Oct 2019 12:09:41 +0000 (UTC) Date: Sat, 19 Oct 2019 14:09:41 +0200 From: Alexandre Belloni To: Markus Elfring Message-ID: <20191019120941.GL3125@piout.net> References: <20191017142237.9734-1-alexandre.belloni@bootlin.com> <81269cd6-e26d-b8aa-cf17-3a2285851564@web.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <81269cd6-e26d-b8aa-cf17-3a2285851564@web.de> User-Agent: Mutt/1.12.1 (2019-06-15) X-Greylist: Sender IP whitelisted, Sender e-mail whitelisted, not delayed by milter-greylist-4.4.3 (isis.lip6.fr [132.227.60.2]); Sun, 20 Oct 2019 07:44:02 +0200 (CEST) X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.4.3 (isis.lip6.fr [132.227.60.2]); Sat, 19 Oct 2019 14:09:44 +0200 (CEST) X-Scanned-By: MIMEDefang 2.78 on 132.227.60.2 X-Scanned-By: MIMEDefang 2.78 on 132.227.60.2 X-Mailman-Approved-At: Sun, 20 Oct 2019 07:43:59 +0200 Cc: Nicolas Palix , Michal Marek , Arnd Bergmann , Bartosz Golaszewski , Marc Zyngier , Linus Walleij , kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org, Linus Torvalds , Greg Kroah-Hartman , Thomas Gleixner , Andy Shevchenko , Coccinelle Subject: Re: [Cocci] [PATCH] coccinelle: api/devm_platform_ioremap_resource: remove useless script X-BeenThere: cocci@systeme.lip6.fr X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: cocci-bounces@systeme.lip6.fr Errors-To: cocci-bounces@systeme.lip6.fr On 19/10/2019 11:00:47+0200, Markus Elfring wrote: > > While it is useful for new drivers to use devm_platform_ioremap_resource, > > This is nice. > > > > this script is currently used to spam maintainers, > > This view is unfortunate. > > Do we stumble on a target conflict again? > > > > often updating very old drivers. > > This can also happen. > > > > The net benefit is the removal of 2 lines of code in the driver > > Additional effects can be reconsidered, can't they? > What are the additional effects? What is the end goal of converting all the existing drivers to devm_platform_ioremap_resource? The existing code is currently always correct and it is difficult to see how this would lead to any bug avoidance in the long term. > > but the review load for the maintainers is huge. > > Does collateral evolution trigger a remarkable amount of changes occasionally? > This is not an evolution, it is unnecessary churn. Those patches have no benefit and eat up very valuable reviewer time. > > How will such feedback influence the development and integration of > further scripts for the semantic patch language (Coccinelle software)? > There are a few other scripts that have no added value when applied to existing code, like ptr_ret.cocci. -- Alexandre Belloni, Bootlin Embedded Linux and Kernel engineering https://bootlin.com _______________________________________________ Cocci mailing list Cocci@systeme.lip6.fr https://systeme.lip6.fr/mailman/listinfo/cocci From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alexandre Belloni Date: Sat, 19 Oct 2019 12:09:41 +0000 Subject: Re: [PATCH] coccinelle: api/devm_platform_ioremap_resource: remove useless script Message-Id: <20191019120941.GL3125@piout.net> List-Id: References: <20191017142237.9734-1-alexandre.belloni@bootlin.com> <81269cd6-e26d-b8aa-cf17-3a2285851564@web.de> In-Reply-To: <81269cd6-e26d-b8aa-cf17-3a2285851564@web.de> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Markus Elfring Cc: Nicolas Palix , Michal Marek , Arnd Bergmann , Bartosz Golaszewski , Marc Zyngier , Linus Walleij , kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org, Linus Torvalds , Greg Kroah-Hartman , Thomas Gleixner , Andy Shevchenko , Coccinelle On 19/10/2019 11:00:47+0200, Markus Elfring wrote: > > While it is useful for new drivers to use devm_platform_ioremap_resource, > > This is nice. > > > > this script is currently used to spam maintainers, > > This view is unfortunate. > > Do we stumble on a target conflict again? > > > > often updating very old drivers. > > This can also happen. > > > > The net benefit is the removal of 2 lines of code in the driver > > Additional effects can be reconsidered, can't they? > What are the additional effects? What is the end goal of converting all the existing drivers to devm_platform_ioremap_resource? The existing code is currently always correct and it is difficult to see how this would lead to any bug avoidance in the long term. > > but the review load for the maintainers is huge. > > Does collateral evolution trigger a remarkable amount of changes occasionally? > This is not an evolution, it is unnecessary churn. Those patches have no benefit and eat up very valuable reviewer time. > > How will such feedback influence the development and integration of > further scripts for the semantic patch language (Coccinelle software)? > There are a few other scripts that have no added value when applied to existing code, like ptr_ret.cocci. -- Alexandre Belloni, Bootlin Embedded Linux and Kernel engineering https://bootlin.com From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F0AABCA9EAB for ; Sat, 19 Oct 2019 12:09:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C3CF320869 for ; Sat, 19 Oct 2019 12:09:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726078AbfJSMJr (ORCPT ); Sat, 19 Oct 2019 08:09:47 -0400 Received: from relay8-d.mail.gandi.net ([217.70.183.201]:40641 "EHLO relay8-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725777AbfJSMJr (ORCPT ); Sat, 19 Oct 2019 08:09:47 -0400 X-Originating-IP: 86.202.229.42 Received: from localhost (lfbn-lyo-1-146-42.w86-202.abo.wanadoo.fr [86.202.229.42]) (Authenticated sender: alexandre.belloni@bootlin.com) by relay8-d.mail.gandi.net (Postfix) with ESMTPSA id 79C991BF208; Sat, 19 Oct 2019 12:09:41 +0000 (UTC) Date: Sat, 19 Oct 2019 14:09:41 +0200 From: Alexandre Belloni To: Markus Elfring Cc: Julia Lawall , Himanshu Jha , kernel-janitors@vger.kernel.org, Coccinelle , Arnd Bergmann , linux-kernel@vger.kernel.org, Marc Zyngier , Thomas Gleixner , Linus Torvalds , Andy Shevchenko , Bartosz Golaszewski , Gilles Muller , Greg Kroah-Hartman , Linus Walleij , Masahiro Yamada , Michal Marek , Nicolas Palix Subject: Re: [PATCH] coccinelle: api/devm_platform_ioremap_resource: remove useless script Message-ID: <20191019120941.GL3125@piout.net> References: <20191017142237.9734-1-alexandre.belloni@bootlin.com> <81269cd6-e26d-b8aa-cf17-3a2285851564@web.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <81269cd6-e26d-b8aa-cf17-3a2285851564@web.de> User-Agent: Mutt/1.12.1 (2019-06-15) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 19/10/2019 11:00:47+0200, Markus Elfring wrote: > > While it is useful for new drivers to use devm_platform_ioremap_resource, > > This is nice. > > > > this script is currently used to spam maintainers, > > This view is unfortunate. > > Do we stumble on a target conflict again? > > > > often updating very old drivers. > > This can also happen. > > > > The net benefit is the removal of 2 lines of code in the driver > > Additional effects can be reconsidered, can't they? > What are the additional effects? What is the end goal of converting all the existing drivers to devm_platform_ioremap_resource? The existing code is currently always correct and it is difficult to see how this would lead to any bug avoidance in the long term. > > but the review load for the maintainers is huge. > > Does collateral evolution trigger a remarkable amount of changes occasionally? > This is not an evolution, it is unnecessary churn. Those patches have no benefit and eat up very valuable reviewer time. > > How will such feedback influence the development and integration of > further scripts for the semantic patch language (Coccinelle software)? > There are a few other scripts that have no added value when applied to existing code, like ptr_ret.cocci. -- Alexandre Belloni, Bootlin Embedded Linux and Kernel engineering https://bootlin.com