From: Dan Carpenter <dan.carpenter@oracle.com>
To: Jules Irenge <jbi.octave@gmail.com>
Cc: devel@driverdev.osuosl.org, outreachy-kernel@googlegroups.com,
linux-kernel@vger.kernel.org, gregkh@linuxfoundation.org
Subject: Re: [PATCH v1 1/5] staging: wfx: fix warnings of no space is necessary
Date: Sat, 19 Oct 2019 21:05:14 +0300 [thread overview]
Message-ID: <20191019180514.GI24678@kadam> (raw)
In-Reply-To: <alpine.LFD.2.21.1910191603520.6740@ninjahub.org>
On Sat, Oct 19, 2019 at 04:09:03PM +0100, Jules Irenge wrote:
> Checkpatch was complaining about space between type cast and the
> variable. I just get rid of the space. Well I don't know whether this was
> false positive one.
>
> Thanks for the feedback. I will update the patch.
No no. The patch is fine. I was saying that in the *future* you might
want to look at the void casts. Some of them are not required and
others are buggy code.
regards,
dan carpenter
next prev parent reply other threads:[~2019-10-19 18:07 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-19 14:07 [PATCH v1 0/5] staging: wfx: fix checkpatch warnings Jules Irenge
2019-10-19 14:07 ` [PATCH v1 1/5] staging: wfx: fix warnings of no space is necessary Jules Irenge
2019-10-19 14:24 ` Dan Carpenter
2019-10-19 15:09 ` Jules Irenge
2019-10-19 15:17 ` [Outreachy kernel] " Julia Lawall
2019-10-19 18:05 ` Dan Carpenter [this message]
2019-10-19 20:02 ` Joe Perches
2019-10-20 19:17 ` Dan Carpenter
2019-10-20 19:29 ` [Outreachy kernel] " Julia Lawall
2019-10-20 19:36 ` Joe Perches
2019-10-20 19:48 ` [Outreachy kernel] " Julia Lawall
2019-10-20 19:52 ` Julia Lawall
2019-10-20 20:16 ` Joe Perches
2019-10-20 20:29 ` Julia Lawall
2019-10-21 6:52 ` Julia Lawall
2019-10-21 8:54 ` Joe Perches
2019-10-22 8:57 ` Dan Carpenter
2019-10-21 8:21 ` Jerome Pouiller
2019-10-19 14:07 ` [PATCH v1 2/5] staging: wfx: fix warning of line over 80 characters Jules Irenge
2019-10-19 14:07 ` [PATCH v1 3/5] staging: wfx: fix warnings of logical continuation Jules Irenge
2019-10-19 14:07 ` [PATCH v1 4/5] staging: wfx: correct misspelled words Jules Irenge
2019-10-19 14:07 ` [PATCH v1 5/5] staging: wfx: fix warnings of alignment should match open parenthesis Jules Irenge
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191019180514.GI24678@kadam \
--to=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=jbi.octave@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=outreachy-kernel@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.