All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alexey Dobriyan <adobriyan@gmail.com>
To: yamada.masahiro@socionext.com
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH] tags: fix "config ..." false positives
Date: Sun, 20 Oct 2019 19:48:48 +0300	[thread overview]
Message-ID: <20191020164848.GA13623@avx2> (raw)

"config" regex is too loose, giving a few false positives

	CONFIG_and     drivers/pci/controller/Kconfig  /^        config and MMIO accesses.$/;" r
	CONFIG_option  arch/x86/Kconfig        /^        config option.$/;"    r
	CONFIG_option  init/Kconfig    /^        config option determines the parameter's default value.$/;"   r
	and    drivers/pci/controller/Kconfig  /^        config and MMIO accesses.$/;" r
	option arch/x86/Kconfig        /^        config option.$/;"    r
	option init/Kconfig    /^        config option determines the parameter's default value.$/;"   r

Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
---

 scripts/tags.sh |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

--- a/scripts/tags.sh
+++ b/scripts/tags.sh
@@ -213,8 +213,8 @@ regex_c=(
 	'/\<\(DEFINE\|DECLARE\)_STATIC_KEY_\(TRUE\|FALSE\)\(\|_RO\)(\([[:alnum:]_]\+\)/\4/'
 )
 regex_kconfig=(
-	'/^[[:blank:]]*\(menu\|\)config[[:blank:]]\+\([[:alnum:]_]\+\)/\2/'
-	'/^[[:blank:]]*\(menu\|\)config[[:blank:]]\+\([[:alnum:]_]\+\)/CONFIG_\2/'
+	'/^[[:blank:]]*\(menu\|\)config[[:blank:]]\+\([[:alnum:]_]\+\)$/\2/'
+	'/^[[:blank:]]*\(menu\|\)config[[:blank:]]\+\([[:alnum:]_]\+\)$/CONFIG_\2/'
 )
 setup_regex()
 {

                 reply	other threads:[~2019-10-20 16:48 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191020164848.GA13623@avx2 \
    --to=adobriyan@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=yamada.masahiro@socionext.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.