From: Stephen Boyd <sboyd@kernel.org>
To: Johannes Sixt <j6t@kdbg.org>
Cc: git@vger.kernel.org, Adrian Johnson <ajohnson@redneon.com>,
Junio C Hamano <gitster@pobox.com>,
devicetree@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
Frank Rowand <frowand.list@gmail.com>
Subject: Re: [PATCH v2] userdiff: Fix some corner cases in dts regex
Date: Sun, 20 Oct 2019 11:27:08 -0700 [thread overview]
Message-ID: <20191020182709.CC74A218BA@mail.kernel.org> (raw)
In-Reply-To: <4f8e8a13-c41f-558f-18c3-b2bda178a06b@kdbg.org>
Quoting Johannes Sixt (2019-10-16 14:10:09)
> [Removed bouncing addresses of Matthieu Moy and William Duclot from Cc]
>
> Am 16.10.19 um 22:32 schrieb Stephen Boyd:
> > diff --git a/t/t4018/dts-nodes-multiline-prop b/t/t4018/dts-nodes-multiline-prop
> > new file mode 100644
> > index 000000000000..db4b4bdda686
> > --- /dev/null
> > +++ b/t/t4018/dts-nodes-multiline-prop
> > @@ -0,0 +1,14 @@
> > +/ {
> > + label_1: node1@ff00 {
> > + RIGHT@deadf00,4000 {
> > + multilineprop = <3>,
> > +
> > +
> > + <4>;
>
> I was actually thinking about something like
>
> multilineprop = <3>,
> <0xabcd>,
> "text",
> name,
> <4>;
>
> or something like that -- whatever occurs in the real world.
>
Ok sure. I can have a list of numbers that spans four or five lines.
> > +
> > +
> > +
> > + ChangeMe = <0xffeedd00>;
> > + };
> > + };
> > +};
>
> Apart from that, the patch looks good.
>
Cool. I'll resend.
prev parent reply other threads:[~2019-10-20 18:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-16 20:32 [PATCH v2] userdiff: Fix some corner cases in dts regex Stephen Boyd
2019-10-16 21:10 ` Johannes Sixt
2019-10-20 18:27 ` Stephen Boyd [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191020182709.CC74A218BA@mail.kernel.org \
--to=sboyd@kernel.org \
--cc=ajohnson@redneon.com \
--cc=devicetree@vger.kernel.org \
--cc=frowand.list@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=j6t@kdbg.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.