From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: kholk11@gmail.com
Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
ccross@android.com, mark.rutland@arm.com, robh+dt@kernel.org,
agross@kernel.org, marijns95@gmail.com
Subject: Re: [PATCH 3/5] arm64: dts: qcom: Add configuration for PM8950 and PMI8950 peripherals
Date: Sun, 20 Oct 2019 22:38:48 -0700 [thread overview]
Message-ID: <20191021053848.GI4500@tuxbook-pro> (raw)
In-Reply-To: <20191020150746.64114-4-kholk11@gmail.com>
On Sun 20 Oct 08:07 PDT 2019, kholk11@gmail.com wrote:
> From: AngeloGioacchino Del Regno <kholk11@gmail.com>
>
> The PM(I)8950 feature integrated peripherals like ADC, GPIO
> controller, MPPs, PON keys and others.
> Add them to DT files that will be imported on boards having
> this PMIC combo (or one of them, anyways).
>
> Signed-off-by: Angelo G. Del Regno <kholk11@gmail.com>
> ---
> arch/arm64/boot/dts/qcom/pm8950.dtsi | 187 ++++++++++++++++++++++++++
> arch/arm64/boot/dts/qcom/pmi8950.dtsi | 98 ++++++++++++++
> 2 files changed, 285 insertions(+)
> create mode 100644 arch/arm64/boot/dts/qcom/pm8950.dtsi
> create mode 100644 arch/arm64/boot/dts/qcom/pmi8950.dtsi
>
> diff --git a/arch/arm64/boot/dts/qcom/pm8950.dtsi b/arch/arm64/boot/dts/qcom/pm8950.dtsi
> new file mode 100644
> index 000000000000..c5041349bfe1
> --- /dev/null
> +++ b/arch/arm64/boot/dts/qcom/pm8950.dtsi
> @@ -0,0 +1,187 @@
> +// SPDX-License-Identifier: GPL-2.0
> +// Copyright (c) 2019, AngeloGioacchino Del Regno <kholk11@gmail.com>
> +
> +#include <dt-bindings/iio/qcom,spmi-vadc.h>
> +#include <dt-bindings/input/linux-event-codes.h>
> +#include <dt-bindings/interrupt-controller/irq.h>
> +#include <dt-bindings/pinctrl/qcom,pmic-mpp.h>
> +#include <dt-bindings/spmi/spmi.h>
> +
> +&spmi_bus {
> + pm8950_lsid0: pm8950@0 {
> + compatible = "qcom,pm8950", "qcom,spmi-pmic";
> + reg = <0x0 SPMI_USID>;
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + pm8950_gpios: gpio@c000 {
> + compatible = "qcom,pm8950-gpio", "qcom,spmi-gpio";
> + reg = <0xc000>;
> + gpio-controller;
> + #gpio-cells = <2>;
> + interrupts = <0 0xc0 0 IRQ_TYPE_NONE>,
> + <0 0xc1 0 IRQ_TYPE_NONE>,
> + <0 0xc3 0 IRQ_TYPE_NONE>,
> + <0 0xc4 0 IRQ_TYPE_NONE>,
> + <0 0xc5 0 IRQ_TYPE_NONE>,
> + <0 0xc6 0 IRQ_TYPE_NONE>,
> + <0 0xc7 0 IRQ_TYPE_NONE>;
> + };
> +
> + pm8950_mpps: mpps@a000 {
> + compatible = "qcom,pm8950-mpp", "qcom,spmi-mpp";
> + reg = <0xa000>;
> + gpio-controller;
> + #gpio-cells = <2>;
> + interrupts = <0 0xa0 0 IRQ_TYPE_NONE>,
> + <0 0xa1 0 IRQ_TYPE_NONE>,
> + <0 0xa2 0 IRQ_TYPE_NONE>,
> + <0 0xa3 0 IRQ_TYPE_NONE>;
> +
> + /* MPP_2: PA_THERM1 */
> + pa_therm {
> + pm8950_mpp2_def: pa_therm1_default {
> + pins = "mpp2";
> + function = "analog";
> + input-enable;
> + qcom,amux-route =
> + <PMIC_MPP_AMUX_ROUTE_CH6>;
> + };
> + };
> +
> + /* MPP_4: QUIET_THERM */
> + case_therm {
> + pm8950_mpp4_def: case_therm_default {
> + pins = "mpp4";
> + function = "analog";
> + input-enable;
> + qcom,amux-route =
> + <PMIC_MPP_AMUX_ROUTE_CH8>;
> + };
> + };
> + };
> +
> + pon@800 {
> + compatible = "qcom,pm8916-pon";
> + reg = <0x0800>;
> + mode-bootloader = <0x2>;
> + mode-recovery = <0x1>;
> +
> + pwrkey {
> + compatible = "qcom,pm8941-pwrkey";
> + interrupts = <0x0 0x8 0 IRQ_TYPE_EDGE_BOTH>;
> + debounce = <15625>;
> + bias-pull-up;
> + linux,code = <KEY_POWER>;
> + };
> + };
> +
> + pm8950_temp: temp-alarm@2400 {
> + compatible = "qcom,spmi-temp-alarm";
> + reg = <0x2400>;
> + interrupts = <0 0x24 0 IRQ_TYPE_EDGE_RISING>;
> + io-channels = <&pm8950_adc VADC_DIE_TEMP>;
> + io-channel-names = "thermal";
> + #thermal-sensor-cells = <0>;
> + };
> +
> + pm8950_adc: adc@3100 {
> + compatible = "qcom,spmi-vadc";
> + reg = <0x3100>;
> + interrupts = <0x0 0x31 0x0 IRQ_TYPE_EDGE_RISING>;
> + #address-cells = <1>;
> + #size-cells = <0>;
> + #io-channel-cells = <1>;
> +
> + vcoin {
> + label = "vcoin";
> + reg = <VADC_VCOIN>;
> + qcom,pre-scaling = <1 1>;
> + };
> + vph_pwr {
> + label = "vph_pwr";
> + reg = <VADC_VSYS>;
> + qcom,pre-scaling = <1 1>;
> + };
> + die_temp {
> + label = "die_temp";
> + reg = <VADC_DIE_TEMP>;
> + qcom,pre-scaling = <1 1>;
> + };
> + ref_625mv {
> + label = "ref_625mv";
> + reg = <VADC_REF_625MV>;
> + qcom,pre-scaling = <1 1>;
> + };
> + ref_1250v {
> + label = "ref_1250v";
> + reg = <VADC_REF_1250MV>;
> + qcom,pre-scaling = <1 1>;
> + };
> + ref_buf_625mv {
> + label = "ref_buf_625mv";
> + reg = <VADC_SPARE1>;
> + qcom,pre-scaling = <1 1>;
> + };
> + ref_gnd {
> + reg = <VADC_GND_REF>;
> + };
> + ref_vdd {
> + reg = <VADC_VDD_VADC>;
> + };
> + pa_therm0 {
> + label = "pa_therm0";
> + reg = <VADC_LR_MUX7_HW_ID>;
> + qcom,pre-scaling = <1 1>;
> + qcom,ratiometric;
> + qcom,hw-settle-time = <200>;
> + };
> + pa_therm1 {
> + label = "pa_therm1";
> + reg = <VADC_P_MUX2_1_1>;
> + qcom,pre-scaling = <1 1>;
> + qcom,ratiometric;
> + qcom,hw-settle-time = <200>;
> + };
> + xo_therm {
> + label = "xo_therm";
> + reg = <VADC_LR_MUX3_XO_THERM>;
> + qcom,pre-scaling = <1 1>;
> + qcom,ratiometric;
> + qcom,hw-settle-time = <200>;
> + };
> + xo_therm_buf {
> + label = "xo_therm_buf";
> + reg = <VADC_LR_MUX3_BUF_XO_THERM>;
> + qcom,pre-scaling = <1 1>;
> + qcom,ratiometric;
> + qcom,hw-settle-time = <200>;
> + };
> + case_therm {
> + label = "case_therm";
> + reg = <VADC_P_MUX4_1_1>;
> + qcom,pre-scaling = <1 1>;
> + qcom,ratiometric;
> + qcom,hw-settle-time = <200>;
> + };
> + };
> +
> + rtc@6000 {
> + compatible = "qcom,pm8941-rtc";
> + reg = <0x6000>;
> + reg-names = "rtc", "alarm";
> + interrupts = <0x0 0x61 0x1 IRQ_TYPE_NONE>;
> + };
> + };
> +
> + pm8950_1: pm8950@1 {
> + compatible = "qcom,pm8950", "qcom,spmi-pmic";
> + reg = <0x1 SPMI_USID>;
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + pm8950_spmi_regulators: regulators {
> + compatible = "qcom,pm8950-regulators";
> + };
> + };
> +};
> diff --git a/arch/arm64/boot/dts/qcom/pmi8950.dtsi b/arch/arm64/boot/dts/qcom/pmi8950.dtsi
> new file mode 100644
> index 000000000000..15c3e47bab0c
> --- /dev/null
> +++ b/arch/arm64/boot/dts/qcom/pmi8950.dtsi
> @@ -0,0 +1,98 @@
> +// SPDX-License-Identifier: GPL-2.0
> +// Copyright (c) 2019, AngeloGioacchino Del Regno <kholk11@gmail.com>
> +
> +#include <dt-bindings/iio/qcom,spmi-vadc.h>
> +#include <dt-bindings/interrupt-controller/irq.h>
> +#include <dt-bindings/spmi/spmi.h>
> +
> +&spmi_bus {
> + pmi8950_lsid0: pmic@2 {
> + compatible = "qcom,pmi8950", "qcom,spmi-pmic";
> + reg = <0x2 SPMI_USID>;
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + pmi8950_adc: adc@3100 {
> + compatible = "qcom,spmi-vadc";
> + reg = <0x3100>;
> + interrupts = <0x2 0x31 0x0 IRQ_TYPE_EDGE_RISING>;
> + #address-cells = <1>;
> + #size-cells = <0>;
> + #io-channel-cells = <1>;
> +
> + usbin {
> + label = "usbin";
> + reg = <VADC_USBIN>;
> + qcom,pre-scaling = <1 4>;
> + };
> + dcin {
> + label = "dcin";
> + reg = <VADC_DCIN>;
> + qcom,pre-scaling = <1 4>;
> + };
> + vchg_sns {
> + label = "vchg_sns";
> + reg = <VADC_VCHG_SNS>;
> + qcom,pre-scaling = <1 1>;
> + };
> + ref_625mv {
> + label = "ref_625mv";
> + reg = <VADC_REF_625MV>;
> + qcom,pre-scaling = <1 1>;
> + };
> + ref_1250v {
> + label = "ref_1250v";
> + reg = <VADC_REF_1250MV>;
> + qcom,pre-scaling = <1 1>;
> + };
> + ref_gnd {
> + reg = <VADC_GND_REF>;
> + };
> + ref_vdd {
> + reg = <VADC_VDD_VADC>;
> + };
> + chg_temp {
> + label = "chg_temp";
> + reg = <VADC_SPARE2>;
> + qcom,pre-scaling = <1 1>;
> + };
> + usb_dp {
> + label = "usb_dp";
> + reg = <VADC_USB_DP>;
> + qcom,pre-scaling = <1 1>;
> + };
> + usb_dm {
> + label = "usb_dm";
> + reg = <VADC_USB_DM>;
> + qcom,pre-scaling = <1 1>;
> + };
> + };
> +
> + pmi8950_gpio: gpios@c000 {
Please sort nodes by unit address, then name.
Apart from that, this looks good.
Regards,
Bjorn
> + compatible = "qcom,pmi8950-gpio", "qcom,spmi-gpio";
> + reg = <0xc000>;
> + gpio-controller;
> + #gpio-cells = <2>;
> + interrupts = <0 0xc0 0 IRQ_TYPE_NONE>,
> + <0 0xc1 0 IRQ_TYPE_NONE>;
> + };
> +
> + pmi8950_mpp: mpps@a000 {
> + compatible = "qcom,pmi8950-mpp", "qcom,spmi-mpp";
> + reg = <0xa000>;
> + gpio-controller;
> + #gpio-cells = <2>;
> + interrupts = <0x2 0xa0 0 IRQ_TYPE_NONE>,
> + <0x2 0xa1 0 IRQ_TYPE_NONE>,
> + <0x2 0xa2 0 IRQ_TYPE_NONE>,
> + <0x2 0xa3 0 IRQ_TYPE_NONE>;
> + };
> + };
> +
> + pmi8950_lsid1: pmic@3 {
> + compatible = "qcom,pmi8950", "qcom,spmi-pmic";
> + reg = <0x3 SPMI_USID>;
> + #address-cells = <1>;
> + #size-cells = <0>;
> + };
> +};
> --
> 2.21.0
>
next prev parent reply other threads:[~2019-10-21 5:38 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-20 15:07 [PATCH 0/5] MSM8976/56 Sony Xperia Loire (X/XCompact) smartphones kholk11
2019-10-20 15:07 ` [PATCH 1/5] dt-bindings: iio: spmi-vadc: Add definitions for USB DP/DM VADCs kholk11
2019-10-29 15:28 ` Rob Herring
2019-10-20 15:07 ` [PATCH 2/5] arm64: dts: pm8004: Add SPMI regulator and add phandles to lsids kholk11
2019-10-21 5:37 ` Bjorn Andersson
2019-10-20 15:07 ` [PATCH 3/5] arm64: dts: qcom: Add configuration for PM8950 and PMI8950 peripherals kholk11
2019-10-21 5:38 ` Bjorn Andersson [this message]
2019-10-20 15:07 ` [PATCH 4/5] arm64: dts: qcom: Add MSM8976 SoC support dts files kholk11
2019-10-21 5:52 ` Bjorn Andersson
2019-10-21 7:50 ` AngeloGioacchino Del Regno
2019-10-20 15:07 ` [PATCH 5/5] arm64: dts: qcom: Add Sony Xperia (Loire) X and X Compact support kholk11
2019-10-21 6:04 ` Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191021053848.GI4500@tuxbook-pro \
--to=bjorn.andersson@linaro.org \
--cc=agross@kernel.org \
--cc=ccross@android.com \
--cc=devicetree@vger.kernel.org \
--cc=kholk11@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=marijns95@gmail.com \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.