From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0A7F9CA9EB7 for ; Mon, 21 Oct 2019 11:33:23 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D46F62089C for ; Mon, 21 Oct 2019 11:33:22 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="hx5kC1HZ"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Oy1bDj8c" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D46F62089C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=IFM6UvKpbMHNSd4iUR4csQd7eYswBQ3CNglAdNbEQA4=; b=hx5kC1HZc6W2x8 2STgwl7ZKx2ldb+HzYeOdpMwcw4xKl+RP2yLSqOEokQQntq4LLvnhQMBYxzF4Tq9st3ASRT2uR/z5 TQWJ5Tzj04BqPLZ5yLRxImjOUdGbirIhcz77OLTVy7xu1D/wwidXMA7nsb74GfFjjFh78OAd0jrZy RCoVsGDy/Xw9MjcotQTsi3TvGXoOaEXpSnJd6JZT+atjhFPfL7vRjNIg3JoZMQyCUtfiTwzNVYzu5 Bur4mtAGh3wbaztQh2WxYGRIHZK0nW5X/7N5Ldxbf7PSbKO1gE8TB0pEG45y/CwfvkpRIOK7wSq9/ oNjptT+CwX5TqIRK6+bg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iMVwA-00029p-Du; Mon, 21 Oct 2019 11:33:22 +0000 Received: from mail-wr1-x442.google.com ([2a00:1450:4864:20::442]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iMVw7-00029E-Jt for linux-arm-kernel@lists.infradead.org; Mon, 21 Oct 2019 11:33:21 +0000 Received: by mail-wr1-x442.google.com with SMTP id s1so4786560wro.0 for ; Mon, 21 Oct 2019 04:33:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=NvogyYcPH5HiSpRRQoQRP+VJ8MEq3onz6Q0+j4Mfoeg=; b=Oy1bDj8cgdLtX4MeiPkZTXa0D+BsfxOlUyDd1G94MhAQlyikxatILkupmu8WpJHKhr vZ6WT8psdPmKrzaYFRunzvze6/aEy3RAYxWRZ8qtAZfTLsmd1GTW7hyrkb/T/Ov1mNNk NX/X/sYIS9v7KTaHCJD11X4THvbgd53xXx/rnoHat2Y5X5uDlVHoneJklSnl439iAGoj 76f8ZodNxPqIBfxoy2YpqezgC4NBmmSdYwvu8vPOKJS4E0UsbD6q3IFIj3bV9pn6KOic 4I2FslXSg2psH7JqqY3h0d4EQ0S+I6rz1WxJqctQNUkJBMiSb4+9CC3hPSo1jg34a7pE u6Ag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=NvogyYcPH5HiSpRRQoQRP+VJ8MEq3onz6Q0+j4Mfoeg=; b=F3eGO6nkUdi6VksF+czTHFFf+eCnug5V91ZpsGEETIPsN9Neubsr6ywdB7BXtN+8Iz hWsCAPvpWzSbqJTCH8DgEmGEidhDyqc/sTf8estwOd8VOb8sXG057DaGH4H0H+skduYM FWfQBT1sZ4xpbEwH/FiVfUqO/TPx0zHpZ0Zdcf+UmZHbjp4mHUa4c1tkNWFj1zmdccZw itM5G5Myer/LmsMB9yo6Nc9/S1yzsdbIsdysh1SAWJ7zYC+JVLtk0UNd262l5+0JZTIR 1jBM86t841qZ8kw1VJYn77ifOMO/ywBHDkpq/Hd2l7f9Np5QKKGAIx1q7OOf8SXPab3j fgeA== X-Gm-Message-State: APjAAAWLZAiAhxlEqMlCetHjVdaTxjc0MLzUN7Pa8gO7oVJMc5Xbae2o gttmHhC/CiXsLRNgh23hQkwudw== X-Google-Smtp-Source: APXvYqyMIAyEPCNwcjoYQRMWKDg+5l3URiHknN8ipHfDzYk/6uRZQr+BzUbWIv6eq6k9BO1W7E1c+Q== X-Received: by 2002:a5d:678e:: with SMTP id v14mr12033062wru.393.1571657598261; Mon, 21 Oct 2019 04:33:18 -0700 (PDT) Received: from dell ([95.149.164.99]) by smtp.gmail.com with ESMTPSA id l7sm5284560wro.17.2019.10.21.04.33.17 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 21 Oct 2019 04:33:17 -0700 (PDT) Date: Mon, 21 Oct 2019 12:33:16 +0100 From: Lee Jones To: Daniel Thompson Subject: Re: [PATCH v2 1/9] mfd: cs5535-mfd: Use PLATFORM_DEVID_* defines and tidy error message Message-ID: <20191021113316.GA4365@dell> References: <20191021105822.20271-1-lee.jones@linaro.org> <20191021105822.20271-2-lee.jones@linaro.org> <20191021111555.zsvvdfun3gqhrurw@holly.lan> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20191021111555.zsvvdfun3gqhrurw@holly.lan> User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191021_043319_686055_A8DA145E X-CRM114-Status: GOOD ( 21.19 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: baohua@kernel.org, stephan@gerhold.net, arnd@arndb.de, linus.walleij@linaro.org, linux-kernel@vger.kernel.org, broonie@kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gTW9uLCAyMSBPY3QgMjAxOSwgRGFuaWVsIFRob21wc29uIHdyb3RlOgoKPiBPbiBNb24sIE9j dCAyMSwgMjAxOSBhdCAxMTo1ODoxNEFNICswMTAwLCBMZWUgSm9uZXMgd3JvdGU6Cj4gPiBJbiBt b3N0IGNvbnRleHRzICctMScgZG9lc24ndCByZWFsbHkgbWVhbiBtdWNoIHRvIHRoZSBjYXN1YWwg b2JzZXJ2ZXIuCj4gPiBJbiBhbG1vc3QgYWxsIGNhc2VzLCBpdCdzIGJldHRlciB0byB1c2UgYSBo dW1hbiByZWFkYWJsZSBkZWZpbmUuICBJbgo+ID4gdGhpcyBjYXNlIFBMQVRGT1JNX0RFVklEXyog ZGVmaW5lcyBoYXZlIGFscmVhZHkgYmVlbiBwcm92aWRlZCBmb3IgdGhpcwo+ID4gcHVycG9zZS4K PiA+IAo+ID4gV2hpbGUgd2UncmUgaGVyZSwgbGV0J3MgYmUgc3BlY2lmaWMgYWJvdXQgdGhlICdN RkQgZGV2aWNlcycgd2hpY2gKPiA+IGZhaWxlZC4gIEl0IHdpbGwgaGVscCB3aGVuIHRyeWluZyB0 byBkaXN0aW5ndWlzaCB3aGljaCBvZiB0aGUgMiBzZXRzCj4gPiBvZiBzdWItZGV2aWNlcyB3ZSBh Y3R1YWxseSBmYWlsZWQgdG8gcmVnaXN0ZXIuCj4gCj4gTm8gb2JqZWN0aW9ucy4uLiBidXQgd29u J3QgdGhlIHRhZyBhZGRlZCBieSBkZXZfZXJyKCkgYWxyZWFkeQo+IGRpc2FtYmlndWF0ZT8KClRo ZSBkaWZmZXJlbmNlIHdpbGwgYmUgYmV0d2VlbiBDUzU1MzIgYW5kICBDUzU1MzIgT0xQQy4KClBs ZWFzZSBzZWUgcGF0Y2ggNCBpbiB0aGUgc2VyaWVzLgoKPiA+IFNpZ25lZC1vZmYtYnk6IExlZSBK b25lcyA8bGVlLmpvbmVzQGxpbmFyby5vcmc+Cj4gPiAtLS0KPiA+ICBkcml2ZXJzL21mZC9jczU1 MzUtbWZkLmMgfCA1ICsrKy0tCj4gPiAgMSBmaWxlIGNoYW5nZWQsIDMgaW5zZXJ0aW9ucygrKSwg MiBkZWxldGlvbnMoLSkKPiA+IAo+ID4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvbWZkL2NzNTUzNS1t ZmQuYyBiL2RyaXZlcnMvbWZkL2NzNTUzNS1tZmQuYwo+ID4gaW5kZXggZjE4MjVjMGNjYmQwLi4y YzQ3YWZjMjJkMjQgMTAwNjQ0Cj4gPiAtLS0gYS9kcml2ZXJzL21mZC9jczU1MzUtbWZkLmMKPiA+ ICsrKyBiL2RyaXZlcnMvbWZkL2NzNTUzNS1tZmQuYwo+ID4gQEAgLTEyNywxMCArMTI3LDExIEBA IHN0YXRpYyBpbnQgY3M1NTM1X21mZF9wcm9iZShzdHJ1Y3QgcGNpX2RldiAqcGRldiwKPiA+ICAJ CWNzNTUzNV9tZmRfY2VsbHNbaV0uaWQgPSAwOwo+ID4gIAl9Cj4gPiAgCj4gPiAtCWVyciA9IG1m ZF9hZGRfZGV2aWNlcygmcGRldi0+ZGV2LCAtMSwgY3M1NTM1X21mZF9jZWxscywKPiA+ICsJZXJy ID0gbWZkX2FkZF9kZXZpY2VzKCZwZGV2LT5kZXYsIFBMQVRGT1JNX0RFVklEX05PTkUsIGNzNTUz NV9tZmRfY2VsbHMsCj4gPiAgCQkJICAgICAgQVJSQVlfU0laRShjczU1MzVfbWZkX2NlbGxzKSwg TlVMTCwgMCwgTlVMTCk7Cj4gPiAgCWlmIChlcnIpIHsKPiA+IC0JCWRldl9lcnIoJnBkZXYtPmRl diwgIk1GRCBhZGQgZGV2aWNlcyBmYWlsZWQ6ICVkXG4iLCBlcnIpOwo+ID4gKwkJZGV2X2Vycigm cGRldi0+ZGV2LAo+ID4gKwkJCSJGYWlsZWQgdG8gYWRkIENTNTUzMiBzdWItZGV2aWNlczogJWRc biIsIGVycik7Cj4gCj4gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg IF5eXgo+IAo+IFR5cG8gKGFuZCBNT0RVTEVfREVTQ1JJUFRJT04oKSBzYXlzIHRoaXMgaXMgYSBk cml2ZXIgZm9yIENTNTUzNiB0b28pLgo+IE9uY2UgdGhhdCBpcyBmaXhlZDoKPiBSZXZpZXdlZC1i eTogRGFuaWVsIFRob21wc29uIDxkYW5pZWwudGhvbXBzb25AbGluYXJvLm9yZz4KClRhLgoKLS0g CkxlZSBKb25lcyBb5p2O55C85pavXQpMaW5hcm8gU2VydmljZXMgVGVjaG5pY2FsIExlYWQKTGlu YXJvLm9yZyDilIIgT3BlbiBzb3VyY2Ugc29mdHdhcmUgZm9yIEFSTSBTb0NzCkZvbGxvdyBMaW5h cm86IEZhY2Vib29rIHwgVHdpdHRlciB8IEJsb2cKCl9fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4 LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9y Zy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0A231CA9EAF for ; Mon, 21 Oct 2019 11:33:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D06F62089C for ; Mon, 21 Oct 2019 11:33:21 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Oy1bDj8c" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728467AbfJULdU (ORCPT ); Mon, 21 Oct 2019 07:33:20 -0400 Received: from mail-wr1-f65.google.com ([209.85.221.65]:43902 "EHLO mail-wr1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727685AbfJULdU (ORCPT ); Mon, 21 Oct 2019 07:33:20 -0400 Received: by mail-wr1-f65.google.com with SMTP id c2so8306532wrr.10 for ; Mon, 21 Oct 2019 04:33:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=NvogyYcPH5HiSpRRQoQRP+VJ8MEq3onz6Q0+j4Mfoeg=; b=Oy1bDj8cgdLtX4MeiPkZTXa0D+BsfxOlUyDd1G94MhAQlyikxatILkupmu8WpJHKhr vZ6WT8psdPmKrzaYFRunzvze6/aEy3RAYxWRZ8qtAZfTLsmd1GTW7hyrkb/T/Ov1mNNk NX/X/sYIS9v7KTaHCJD11X4THvbgd53xXx/rnoHat2Y5X5uDlVHoneJklSnl439iAGoj 76f8ZodNxPqIBfxoy2YpqezgC4NBmmSdYwvu8vPOKJS4E0UsbD6q3IFIj3bV9pn6KOic 4I2FslXSg2psH7JqqY3h0d4EQ0S+I6rz1WxJqctQNUkJBMiSb4+9CC3hPSo1jg34a7pE u6Ag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=NvogyYcPH5HiSpRRQoQRP+VJ8MEq3onz6Q0+j4Mfoeg=; b=sNUgIj0LLzImkqxgKeU5/QchZHyWQTCprQjrp1ix28Nu3OUkuriOLY47OcViN3XUMC cHlDeRN/7N6zxsucL8XzZqunbCSEKi3PCPEfGThm4olFu+LXI/B5bzUWVTkx4y83potR ub0tofPbDh/w+EC5tdeVfAt+qDJJr/FnImPjiYg9PGkK5S0fIh3LQ3zC6v9wwRzJ/isq 7kFXgLlTDmmC4U1vROH6PKfdml+jDUpPNJq0+ZtR1bPuZdidWrvqV03SwW/d/wuEL0Ce 7ejBt6fzBgS4AAGtiTv9IATiKz2KAayby9q8SVhPEb2Tx3Y0Am9UGz0adObCVslMTwVk eTPA== X-Gm-Message-State: APjAAAU3mX3AyW2lT+bgyRK/LFuM8DBiFxLfss3g7MPCAji+uMk1SD1c 60DtdK9AC69XnUTPsoleflLOKg== X-Google-Smtp-Source: APXvYqyMIAyEPCNwcjoYQRMWKDg+5l3URiHknN8ipHfDzYk/6uRZQr+BzUbWIv6eq6k9BO1W7E1c+Q== X-Received: by 2002:a5d:678e:: with SMTP id v14mr12033062wru.393.1571657598261; Mon, 21 Oct 2019 04:33:18 -0700 (PDT) Received: from dell ([95.149.164.99]) by smtp.gmail.com with ESMTPSA id l7sm5284560wro.17.2019.10.21.04.33.17 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 21 Oct 2019 04:33:17 -0700 (PDT) Date: Mon, 21 Oct 2019 12:33:16 +0100 From: Lee Jones To: Daniel Thompson Cc: arnd@arndb.de, broonie@kernel.org, linus.walleij@linaro.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, baohua@kernel.org, stephan@gerhold.net Subject: Re: [PATCH v2 1/9] mfd: cs5535-mfd: Use PLATFORM_DEVID_* defines and tidy error message Message-ID: <20191021113316.GA4365@dell> References: <20191021105822.20271-1-lee.jones@linaro.org> <20191021105822.20271-2-lee.jones@linaro.org> <20191021111555.zsvvdfun3gqhrurw@holly.lan> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20191021111555.zsvvdfun3gqhrurw@holly.lan> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 21 Oct 2019, Daniel Thompson wrote: > On Mon, Oct 21, 2019 at 11:58:14AM +0100, Lee Jones wrote: > > In most contexts '-1' doesn't really mean much to the casual observer. > > In almost all cases, it's better to use a human readable define. In > > this case PLATFORM_DEVID_* defines have already been provided for this > > purpose. > > > > While we're here, let's be specific about the 'MFD devices' which > > failed. It will help when trying to distinguish which of the 2 sets > > of sub-devices we actually failed to register. > > No objections... but won't the tag added by dev_err() already > disambiguate? The difference will be between CS5532 and CS5532 OLPC. Please see patch 4 in the series. > > Signed-off-by: Lee Jones > > --- > > drivers/mfd/cs5535-mfd.c | 5 +++-- > > 1 file changed, 3 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/mfd/cs5535-mfd.c b/drivers/mfd/cs5535-mfd.c > > index f1825c0ccbd0..2c47afc22d24 100644 > > --- a/drivers/mfd/cs5535-mfd.c > > +++ b/drivers/mfd/cs5535-mfd.c > > @@ -127,10 +127,11 @@ static int cs5535_mfd_probe(struct pci_dev *pdev, > > cs5535_mfd_cells[i].id = 0; > > } > > > > - err = mfd_add_devices(&pdev->dev, -1, cs5535_mfd_cells, > > + err = mfd_add_devices(&pdev->dev, PLATFORM_DEVID_NONE, cs5535_mfd_cells, > > ARRAY_SIZE(cs5535_mfd_cells), NULL, 0, NULL); > > if (err) { > > - dev_err(&pdev->dev, "MFD add devices failed: %d\n", err); > > + dev_err(&pdev->dev, > > + "Failed to add CS5532 sub-devices: %d\n", err); > > ^^^ > > Typo (and MODULE_DESCRIPTION() says this is a driver for CS5536 too). > Once that is fixed: > Reviewed-by: Daniel Thompson Ta. -- Lee Jones [李琼斯] Linaro Services Technical Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog