From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 10850CA9EAF for ; Mon, 21 Oct 2019 12:46:40 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D91F82089C for ; Mon, 21 Oct 2019 12:46:39 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="I2mDwO8g"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="HE5jNR0m" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D91F82089C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Nh/q3Qp40JBdQVBxwDuNRs2WnNWrTCXy3lSWLlwdJZk=; b=I2mDwO8gI7DTSL qYeQhEcBhCSUk8wFGPzo9HDRDwoYP7kWydZ+NtQ0I58Pp3zYyBQlhje2hGj2N4HeDd6DMqnNS0ocZ 1v2MRxEPemCIHRiTHQbHRjE8nrCBOYkPnn5JC4oLPwyXae7kIzxNgGiWV/nt8dOwW0ayM4pd0ctfG P4ODrpZavm4SlbnYOuYWPfJ9f4uGSDAghule799oKt1wetM2H2ExE/TbB9Dn+vHtPN80cTIn+Rsnc F33BaivghZIl8OYyFqmehIedmJiv++mn9u5sY/3l59DaZ7pq/onpccLi4H/JF4X7iKXtrilFustgg cq4wDoUF3isc65R+25JA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iMX55-0005yS-AJ; Mon, 21 Oct 2019 12:46:39 +0000 Received: from mail-wm1-x341.google.com ([2a00:1450:4864:20::341]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iMX52-0005y6-82 for linux-arm-kernel@lists.infradead.org; Mon, 21 Oct 2019 12:46:37 +0000 Received: by mail-wm1-x341.google.com with SMTP id 3so12659823wmi.3 for ; Mon, 21 Oct 2019 05:46:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=oxlugiViiQE3cSKhufhby1ti8KNom5JSbs6PQgpr2f4=; b=HE5jNR0m/8rCwUemPzMdlN05lJ+BtFDbrnxh1nyjX6n4kA0QGZCHW0p8ybDWYI2Fyl SSW3rtr0Xx8IOJ7EmV6C1jYIWURaAevNwN+YRk+XxTvVLNomfz1+tTejV7v4yv2zddpq 5LztFvZNYJHd/rTBr1EXQ3ZM/5kG25+ixWmEwz2o9x54YrmW5P+JlketwitxX/0rxG1B 0IKlkOgXQoZ1eqKUQ1zL4WjlcOIGRb6Lqp+2GNbadLJjTRccTE5jIe1ompVqCxVHAPlh G2NSWukRHIGZYd4GXkcmWePz/hzTZfrF6yRAIS5f3gDiEI6us0xiNDRFYf4s+AExOzIf py1g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=oxlugiViiQE3cSKhufhby1ti8KNom5JSbs6PQgpr2f4=; b=Pbe8x6Yh+3pPshhFURNUPeFdOGJLozH8Ln2PbL/DhHtoElfbirSGs9/Le2s6+JcCAY XMNoafGOaFrZi8ggdrmuDqOyhtC/S1QR2n1T7VnF9LEVKCKoir0SxaiBJYB50qQapHTP 3ku0rBgiioYvKZnozbwieYWsDHLH7lAalt3fz2bafGuttr2wTa6qrnmvtGLuANDDf1rs ZMzy8uHbuaO95jFbSJbpgm0wR0FMmNKxMRTTK8sbeMVAubgp9a3QbOQOafhC9DZoEd4D +Gr+g5+XXzFcjdvY77l/SXcIbppUlobxSvQzqbbLJHPiPoXWrOYcfWKwP1Ume2u2rrt+ 0X0g== X-Gm-Message-State: APjAAAVWYdc+SiSAzMmTPENuvPlp11tdv+ZKL8RKoIIQZ3fGQCyHx0D/ nJAbkih2cAuTODSMvkDpHTM+2g== X-Google-Smtp-Source: APXvYqzN83CIOvU7h1VI/upm+FMF8KlXoDHQuZQPMn0sUbaplEuqAC9iJ5IdsyG4SkF4yRVs8RanRg== X-Received: by 2002:a1c:1f14:: with SMTP id f20mr5765595wmf.147.1571661994201; Mon, 21 Oct 2019 05:46:34 -0700 (PDT) Received: from dell ([95.149.164.99]) by smtp.gmail.com with ESMTPSA id z1sm14850654wrn.57.2019.10.21.05.46.33 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 21 Oct 2019 05:46:33 -0700 (PDT) Date: Mon, 21 Oct 2019 13:46:32 +0100 From: Lee Jones To: Daniel Thompson Subject: Re: [PATCH v2 3/9] mfd: cs5535-mfd: Request shared IO regions centrally Message-ID: <20191021124632.GH4365@dell> References: <20191021105822.20271-1-lee.jones@linaro.org> <20191021105822.20271-4-lee.jones@linaro.org> <20191021122606.5q22j6wtyslwljco@holly.lan> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20191021122606.5q22j6wtyslwljco@holly.lan> User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191021_054636_293304_5447D6F9 X-CRM114-Status: GOOD ( 23.38 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: baohua@kernel.org, stephan@gerhold.net, arnd@arndb.de, linus.walleij@linaro.org, linux-kernel@vger.kernel.org, broonie@kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gTW9uLCAyMSBPY3QgMjAxOSwgRGFuaWVsIFRob21wc29uIHdyb3RlOgoKPiBPbiBNb24sIE9j dCAyMSwgMjAxOSBhdCAxMTo1ODoxNkFNICswMTAwLCBMZWUgSm9uZXMgd3JvdGU6Cj4gPiBQcmlv ciB0byB0aGlzIHBhdGNoLCBJTyByZWdpb25zIHdlcmUgcmVxdWVzdGVkIHZpYSBhbiBNRkQgc3Vi c3l0ZW0tbGV2ZWwKPiA+IC5lbmFibGUoKSBjYWxsLWJhY2sgYW5kIHNpbWlsYXJseSByZWxlYXNl ZCBieSBhIC5kaXNhYmxlKCkgY2FsbC1iYWNrLgo+ID4gRG91YmxlIHJlcXVlc3RzL3JlbGVhc2Vz IHdlcmUgYXZvaWRlZCBieSBhIGNlbnRyYWxseSBoYW5kbGVkIHVzYWdlIGNvdW50Cj4gPiBtZWNo YW5pc20uCj4gPiAKPiA+IFRoaXMgY29tcGxleGl0eSBjYW4gYWxsIGJlIGF2b2lkZWQgYnkgaGFu ZGxpbmcgSU8gcmVnaW9ucyBvbmx5IG9uY2UgZHVyaW5nCj4gPiAucHJvYmUoKSBhbmQgLnJlbW92 ZSgpIG9mIHRoZSBwYXJlbnQgZGV2aWNlLiAgU2luY2UgdGhpcyBpcyB0aGUgb25seQo+ID4gbGVn aXRpbWF0ZSB1c2VyIG9mIHRoZSBhZm9yZW1lbnRpb25lZCB1c2FnZSBjb3VudCBtZWNoYW5pc20s IHRoaXMgcGF0Y2gKPiA+IHdpbGwgYWxsb3cgaXQgdG8gYmUgcmVtb3ZlZCBmcm9tIE1GRCBjb3Jl IGluIHN1YnNlcXVlbnQgc3RlcHMuCj4gPiAKPiA+IFN1Z2dlc3RlZC1ieTogRGFuaWVsIFRob21w c29uIDxkYW5pZWwudGhvbXBzb25AbGluYXJvLm9yZz4KPiA+IFNpZ25lZC1vZmYtYnk6IExlZSBK b25lcyA8bGVlLmpvbmVzQGxpbmFyby5vcmc+Cj4gPiAtLS0KPiA+ICBkcml2ZXJzL21mZC9jczU1 MzUtbWZkLmMgfCA3MiArKysrKysrKysrKysrKysrKy0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tCj4g PiAgMSBmaWxlIGNoYW5nZWQsIDMwIGluc2VydGlvbnMoKyksIDQyIGRlbGV0aW9ucygtKQo+ID4g Cj4gPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9tZmQvY3M1NTM1LW1mZC5jIGIvZHJpdmVycy9tZmQv Y3M1NTM1LW1mZC5jCj4gPiBpbmRleCA5Y2U2YmJjZGJkYTEuLjA1M2UzMzQ0NzgwOCAxMDA2NDQK PiA+IC0tLSBhL2RyaXZlcnMvbWZkL2NzNTUzNS1tZmQuYwo+ID4gKysrIGIvZHJpdmVycy9tZmQv Y3M1NTM1LW1mZC5jCj4gPiBAQCAtMjcsMzggKzI3LDYgQEAgZW51bSBjczU1MzVfbWZkX2JhcnMg ewo+ID4gIAlOUl9CQVJTLAo+ID4gIH07Cj4gPiAgCj4gPiAtc3RhdGljIGludCBjczU1MzVfbWZk X3Jlc19lbmFibGUoc3RydWN0IHBsYXRmb3JtX2RldmljZSAqcGRldikKPiA+IC17Cj4gPiAtCXN0 cnVjdCByZXNvdXJjZSAqcmVzOwo+ID4gLQo+ID4gLQlyZXMgPSBwbGF0Zm9ybV9nZXRfcmVzb3Vy Y2UocGRldiwgSU9SRVNPVVJDRV9JTywgMCk7Cj4gPiAtCWlmICghcmVzKSB7Cj4gPiAtCQlkZXZf ZXJyKCZwZGV2LT5kZXYsICJjYW4ndCBmZXRjaCBkZXZpY2UgcmVzb3VyY2UgaW5mb1xuIik7Cj4g PiAtCQlyZXR1cm4gLUVJTzsKPiA+IC0JfQo+ID4gLQo+ID4gLQlpZiAoIXJlcXVlc3RfcmVnaW9u KHJlcy0+c3RhcnQsIHJlc291cmNlX3NpemUocmVzKSwgRFJWX05BTUUpKSB7Cj4gPiAtCQlkZXZf ZXJyKCZwZGV2LT5kZXYsICJjYW4ndCByZXF1ZXN0IHJlZ2lvblxuIik7Cj4gPiAtCQlyZXR1cm4g LUVJTzsKPiA+IC0JfQo+ID4gLQo+ID4gLQlyZXR1cm4gMDsKPiA+IC19Cj4gPiAtCj4gPiAtc3Rh dGljIGludCBjczU1MzVfbWZkX3Jlc19kaXNhYmxlKHN0cnVjdCBwbGF0Zm9ybV9kZXZpY2UgKnBk ZXYpCj4gPiAtewo+ID4gLQlzdHJ1Y3QgcmVzb3VyY2UgKnJlczsKPiA+IC0KPiA+IC0JcmVzID0g cGxhdGZvcm1fZ2V0X3Jlc291cmNlKHBkZXYsIElPUkVTT1VSQ0VfSU8sIDApOwo+ID4gLQlpZiAo IXJlcykgewo+ID4gLQkJZGV2X2VycigmcGRldi0+ZGV2LCAiY2FuJ3QgZmV0Y2ggZGV2aWNlIHJl c291cmNlIGluZm9cbiIpOwo+ID4gLQkJcmV0dXJuIC1FSU87Cj4gPiAtCX0KPiA+IC0KPiA+IC0J cmVsZWFzZV9yZWdpb24ocmVzLT5zdGFydCwgcmVzb3VyY2Vfc2l6ZShyZXMpKTsKPiA+IC0JcmV0 dXJuIDA7Cj4gPiAtfQo+ID4gLQo+ID4gIHN0YXRpYyBzdHJ1Y3QgcmVzb3VyY2UgY3M1NTM1X21m ZF9yZXNvdXJjZXNbTlJfQkFSU107Cj4gPiAgCj4gPiAgc3RhdGljIHN0cnVjdCBtZmRfY2VsbCBj czU1MzVfbWZkX2NlbGxzW10gPSB7Cj4gPiBAQCAtODEsMTcgKzQ5LDExIEBAIHN0YXRpYyBzdHJ1 Y3QgbWZkX2NlbGwgY3M1NTM1X21mZF9jZWxsc1tdID0gewo+ID4gIAkJLm5hbWUgPSAiY3M1NTM1 LXBtcyIsCj4gPiAgCQkubnVtX3Jlc291cmNlcyA9IDEsCj4gPiAgCQkucmVzb3VyY2VzID0gJmNz NTUzNV9tZmRfcmVzb3VyY2VzW1BNU19CQVJdLAo+ID4gLQo+ID4gLQkJLmVuYWJsZSA9IGNzNTUz NV9tZmRfcmVzX2VuYWJsZSwKPiA+IC0JCS5kaXNhYmxlID0gY3M1NTM1X21mZF9yZXNfZGlzYWJs ZSwKPiA+ICAJfSwKPiA+ICAJW0FDUElfQkFSXSA9IHsKPiA+ICAJCS5uYW1lID0gImNzNTUzNS1h Y3BpIiwKPiA+ICAJCS5udW1fcmVzb3VyY2VzID0gMSwKPiA+ICAJCS5yZXNvdXJjZXMgPSAmY3M1 NTM1X21mZF9yZXNvdXJjZXNbQUNQSV9CQVJdLAo+ID4gLQo+ID4gLQkJLmVuYWJsZSA9IGNzNTUz NV9tZmRfcmVzX2VuYWJsZSwKPiA+IC0JCS5kaXNhYmxlID0gY3M1NTM1X21mZF9yZXNfZGlzYWJs ZSwKPiA+ICAJfSwKPiA+ICB9Owo+ID4gIAo+ID4gQEAgLTEwOSw3ICs3MSw2IEBAIHN0YXRpYyBp bnQgY3M1NTM1X21mZF9wcm9iZShzdHJ1Y3QgcGNpX2RldiAqcGRldiwKPiA+ICAJaWYgKGVycikK PiA+ICAJCXJldHVybiBlcnI7Cj4gPiAgCj4gPiAtCS8qIGZpbGwgaW4gSU8gcmFuZ2UgZm9yIGVh Y2ggY2VsbDsgc3ViZHJpdmVycyBoYW5kbGUgdGhlIHJlZ2lvbiAqLwo+ID4gIAlmb3IgKGkgPSAw OyBpIDwgTlJfQkFSUzsgaSsrKSB7Cj4gPiAgCQlzdHJ1Y3QgbWZkX2NlbGwgKmNlbGwgPSAmY3M1 NTM1X21mZF9jZWxsc1tpXTsKPiA+ICAJCXN0cnVjdCByZXNvdXJjZSAqciA9ICZjczU1MzVfbWZk X3Jlc291cmNlc1tpXTsKPiA+IEBAIC0xMjIsMjIgKzgzLDQ3IEBAIHN0YXRpYyBpbnQgY3M1NTM1 X21mZF9wcm9iZShzdHJ1Y3QgcGNpX2RldiAqcGRldiwKPiA+ICAJCXItPmVuZCA9IHBjaV9yZXNv dXJjZV9lbmQocGRldiwgaSk7Cj4gPiAgCX0KPiA+ICAKPiA+ICsJZXJyID0gcGNpX3JlcXVlc3Rf cmVnaW9uKHBkZXYsIFBNU19CQVIsIERSVl9OQU1FKTsKPiA+ICsJaWYgKGVycikgewo+ID4gKwkJ ZGV2X2VycigmcGRldi0+ZGV2LCAiRmFpbGVkIHRvIHJlcXVlc3QgUE1TX0JBUidzIElPIHJlZ2lv blxuIik7Cj4gPiArCQlnb3RvIGVycl9kaXNhYmxlOwo+ID4gKwl9Cj4gPiArCj4gPiAgCWVyciA9 IG1mZF9hZGRfZGV2aWNlcygmcGRldi0+ZGV2LCBQTEFURk9STV9ERVZJRF9OT05FLCBjczU1MzVf bWZkX2NlbGxzLAo+ID4gIAkJCSAgICAgIEFSUkFZX1NJWkUoY3M1NTM1X21mZF9jZWxscyksIE5V TEwsIDAsIE5VTEwpOwo+ID4gIAlpZiAoZXJyKSB7Cj4gPiAgCQlkZXZfZXJyKCZwZGV2LT5kZXYs Cj4gPiAgCQkJIkZhaWxlZCB0byBhZGQgQ1M1NTMyIHN1Yi1kZXZpY2VzOiAlZFxuIiwgZXJyKTsK PiA+IC0JCWdvdG8gZXJyX2Rpc2FibGU7Cj4gPiArCQlnb3RvIGVycl9yZWxlYXNlX3BtczsKPiA+ ICAJfQo+ID4gIAo+ID4gLQlpZiAobWFjaGluZV9pc19vbHBjKCkpCj4gPiAtCQltZmRfY2xvbmVf Y2VsbCgiY3M1NTM1LWFjcGkiLCBvbHBjX2FjcGlfY2xvbmVzLCBBUlJBWV9TSVpFKG9scGNfYWNw aV9jbG9uZXMpKTsKPiA+ICsJaWYgKG1hY2hpbmVfaXNfb2xwYygpKSB7Cj4gPiArCQllcnIgPSBw Y2lfcmVxdWVzdF9yZWdpb24ocGRldiwgQUNQSV9CQVIsIERSVl9OQU1FKTsKPiA+ICsJCWlmIChl cnIpIHsKPiA+ICsJCQlkZXZfZXJyKCZwZGV2LT5kZXYsCj4gPiArCQkJCSJGYWlsZWQgdG8gcmVx dWVzdCBBQ1BJX0JBUidzIElPIHJlZ2lvblxuIik7Cj4gPiArCQkJZ290byBlcnJfcmVtb3ZlX2Rl dmljZXM7Cj4gPiArCQl9Cj4gPiArCj4gPiArCQllcnIgPSBtZmRfY2xvbmVfY2VsbCgiY3M1NTM1 LWFjcGkiLCBvbHBjX2FjcGlfY2xvbmVzLAo+ID4gKwkJCQkgICAgIEFSUkFZX1NJWkUob2xwY19h Y3BpX2Nsb25lcykpOwo+ID4gKwkJaWYgKGVycikgewo+ID4gKwkJCWRldl9lcnIoJnBkZXYtPmRl diwgIkZhaWxlZCB0byBjbG9uZSBNRkQgY2VsbFxuIik7Cj4gPiArCQkJZ290byBlcnJfcmVsZWFz ZV9hY3BpOwo+ID4gKwkJfQo+ID4gKwl9Cj4gCj4gTWFraW5nIHRoZSByZXF1ZXN0X3JlZ2lvbigp IGNvbmRpdGlvbmFsIG9uIG1hY2hpbmVfaXNfb2xwYygpIHNlZW1zIHRvIGJlCj4gYmVzdCBvbiB0 aGUgYXNzdW1wdGlvbiB0aGF0IHRoZSBjczU1MzUtYWNwaSBpcyBub3Qgb3RoZXJ3aXNlIHVzZWQu Cj4gCj4gSSBzdXNwZWN0IHRoZSBhc3N1bXB0aW9uIGlzIHRydWUgYnV0IHlvdSBoYXZlIHRvIGNv bWJpbmUga25vd2xlZGdlIGZyb20KPiBzZXZlcmFsIGJpdHMgb2YgY29kZSB0byBmaWd1cmUgdGhh dCBvdXQuCgpJdCBpcyBub3QgdXNlZC4KCldpbGwgcmVwbHkgdG8geW91ciBvdGhlciBjb21tZW50 LgoKLS0gCkxlZSBKb25lcyBb5p2O55C85pavXQpMaW5hcm8gU2VydmljZXMgVGVjaG5pY2FsIExl YWQKTGluYXJvLm9yZyDilIIgT3BlbiBzb3VyY2Ugc29mdHdhcmUgZm9yIEFSTSBTb0NzCkZvbGxv dyBMaW5hcm86IEZhY2Vib29rIHwgVHdpdHRlciB8IEJsb2cKCl9fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0 CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFk ZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5911CCA9EB0 for ; Mon, 21 Oct 2019 12:46:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 242B12089C for ; Mon, 21 Oct 2019 12:46:38 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="HE5jNR0m" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728750AbfJUMqh (ORCPT ); Mon, 21 Oct 2019 08:46:37 -0400 Received: from mail-wm1-f68.google.com ([209.85.128.68]:36829 "EHLO mail-wm1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727256AbfJUMqg (ORCPT ); Mon, 21 Oct 2019 08:46:36 -0400 Received: by mail-wm1-f68.google.com with SMTP id c22so3544712wmd.1 for ; Mon, 21 Oct 2019 05:46:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=oxlugiViiQE3cSKhufhby1ti8KNom5JSbs6PQgpr2f4=; b=HE5jNR0m/8rCwUemPzMdlN05lJ+BtFDbrnxh1nyjX6n4kA0QGZCHW0p8ybDWYI2Fyl SSW3rtr0Xx8IOJ7EmV6C1jYIWURaAevNwN+YRk+XxTvVLNomfz1+tTejV7v4yv2zddpq 5LztFvZNYJHd/rTBr1EXQ3ZM/5kG25+ixWmEwz2o9x54YrmW5P+JlketwitxX/0rxG1B 0IKlkOgXQoZ1eqKUQ1zL4WjlcOIGRb6Lqp+2GNbadLJjTRccTE5jIe1ompVqCxVHAPlh G2NSWukRHIGZYd4GXkcmWePz/hzTZfrF6yRAIS5f3gDiEI6us0xiNDRFYf4s+AExOzIf py1g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=oxlugiViiQE3cSKhufhby1ti8KNom5JSbs6PQgpr2f4=; b=IDhavDuSdDQrsw9QnNA7Lcul5LKGMVnPdrU/omKcnO+KxMeqQq+j6pIidfxSgz92GZ WQgKkqtBegI3ySHhB26C3RS5bg6D6ghEq7Bo65aXIbtgwwqdyPC1jFNJhblihmm6mj+m IvMa9mBDgY709FqS4ll2XfI8TF1R3jPgpO8g6RelK6AGVW1LPYmIvhbW8NQ0RS7z1Cfj p/BlSaVgLZh+s7LYF+Rtdfd9c2PoHz4fpljI2LGxMDfvkDIsXc74l0HK6i6cQXP+/CiH 4x/WldMaUlnVC4ulDKPBTjPyFQpo5FzBV4UCqvi1Vr/46jRrwWhud4jffuP9fMxgHsY9 TTbQ== X-Gm-Message-State: APjAAAWyvy09cFA41U/pkxupthzGTuOg26Nz3OpFWvgktAqgkNUgrmqI w4Ana/MOw0h/xylZUKalX4806w== X-Google-Smtp-Source: APXvYqzN83CIOvU7h1VI/upm+FMF8KlXoDHQuZQPMn0sUbaplEuqAC9iJ5IdsyG4SkF4yRVs8RanRg== X-Received: by 2002:a1c:1f14:: with SMTP id f20mr5765595wmf.147.1571661994201; Mon, 21 Oct 2019 05:46:34 -0700 (PDT) Received: from dell ([95.149.164.99]) by smtp.gmail.com with ESMTPSA id z1sm14850654wrn.57.2019.10.21.05.46.33 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 21 Oct 2019 05:46:33 -0700 (PDT) Date: Mon, 21 Oct 2019 13:46:32 +0100 From: Lee Jones To: Daniel Thompson Cc: arnd@arndb.de, broonie@kernel.org, linus.walleij@linaro.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, baohua@kernel.org, stephan@gerhold.net Subject: Re: [PATCH v2 3/9] mfd: cs5535-mfd: Request shared IO regions centrally Message-ID: <20191021124632.GH4365@dell> References: <20191021105822.20271-1-lee.jones@linaro.org> <20191021105822.20271-4-lee.jones@linaro.org> <20191021122606.5q22j6wtyslwljco@holly.lan> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20191021122606.5q22j6wtyslwljco@holly.lan> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 21 Oct 2019, Daniel Thompson wrote: > On Mon, Oct 21, 2019 at 11:58:16AM +0100, Lee Jones wrote: > > Prior to this patch, IO regions were requested via an MFD subsytem-level > > .enable() call-back and similarly released by a .disable() call-back. > > Double requests/releases were avoided by a centrally handled usage count > > mechanism. > > > > This complexity can all be avoided by handling IO regions only once during > > .probe() and .remove() of the parent device. Since this is the only > > legitimate user of the aforementioned usage count mechanism, this patch > > will allow it to be removed from MFD core in subsequent steps. > > > > Suggested-by: Daniel Thompson > > Signed-off-by: Lee Jones > > --- > > drivers/mfd/cs5535-mfd.c | 72 +++++++++++++++++----------------------- > > 1 file changed, 30 insertions(+), 42 deletions(-) > > > > diff --git a/drivers/mfd/cs5535-mfd.c b/drivers/mfd/cs5535-mfd.c > > index 9ce6bbcdbda1..053e33447808 100644 > > --- a/drivers/mfd/cs5535-mfd.c > > +++ b/drivers/mfd/cs5535-mfd.c > > @@ -27,38 +27,6 @@ enum cs5535_mfd_bars { > > NR_BARS, > > }; > > > > -static int cs5535_mfd_res_enable(struct platform_device *pdev) > > -{ > > - struct resource *res; > > - > > - res = platform_get_resource(pdev, IORESOURCE_IO, 0); > > - if (!res) { > > - dev_err(&pdev->dev, "can't fetch device resource info\n"); > > - return -EIO; > > - } > > - > > - if (!request_region(res->start, resource_size(res), DRV_NAME)) { > > - dev_err(&pdev->dev, "can't request region\n"); > > - return -EIO; > > - } > > - > > - return 0; > > -} > > - > > -static int cs5535_mfd_res_disable(struct platform_device *pdev) > > -{ > > - struct resource *res; > > - > > - res = platform_get_resource(pdev, IORESOURCE_IO, 0); > > - if (!res) { > > - dev_err(&pdev->dev, "can't fetch device resource info\n"); > > - return -EIO; > > - } > > - > > - release_region(res->start, resource_size(res)); > > - return 0; > > -} > > - > > static struct resource cs5535_mfd_resources[NR_BARS]; > > > > static struct mfd_cell cs5535_mfd_cells[] = { > > @@ -81,17 +49,11 @@ static struct mfd_cell cs5535_mfd_cells[] = { > > .name = "cs5535-pms", > > .num_resources = 1, > > .resources = &cs5535_mfd_resources[PMS_BAR], > > - > > - .enable = cs5535_mfd_res_enable, > > - .disable = cs5535_mfd_res_disable, > > }, > > [ACPI_BAR] = { > > .name = "cs5535-acpi", > > .num_resources = 1, > > .resources = &cs5535_mfd_resources[ACPI_BAR], > > - > > - .enable = cs5535_mfd_res_enable, > > - .disable = cs5535_mfd_res_disable, > > }, > > }; > > > > @@ -109,7 +71,6 @@ static int cs5535_mfd_probe(struct pci_dev *pdev, > > if (err) > > return err; > > > > - /* fill in IO range for each cell; subdrivers handle the region */ > > for (i = 0; i < NR_BARS; i++) { > > struct mfd_cell *cell = &cs5535_mfd_cells[i]; > > struct resource *r = &cs5535_mfd_resources[i]; > > @@ -122,22 +83,47 @@ static int cs5535_mfd_probe(struct pci_dev *pdev, > > r->end = pci_resource_end(pdev, i); > > } > > > > + err = pci_request_region(pdev, PMS_BAR, DRV_NAME); > > + if (err) { > > + dev_err(&pdev->dev, "Failed to request PMS_BAR's IO region\n"); > > + goto err_disable; > > + } > > + > > err = mfd_add_devices(&pdev->dev, PLATFORM_DEVID_NONE, cs5535_mfd_cells, > > ARRAY_SIZE(cs5535_mfd_cells), NULL, 0, NULL); > > if (err) { > > dev_err(&pdev->dev, > > "Failed to add CS5532 sub-devices: %d\n", err); > > - goto err_disable; > > + goto err_release_pms; > > } > > > > - if (machine_is_olpc()) > > - mfd_clone_cell("cs5535-acpi", olpc_acpi_clones, ARRAY_SIZE(olpc_acpi_clones)); > > + if (machine_is_olpc()) { > > + err = pci_request_region(pdev, ACPI_BAR, DRV_NAME); > > + if (err) { > > + dev_err(&pdev->dev, > > + "Failed to request ACPI_BAR's IO region\n"); > > + goto err_remove_devices; > > + } > > + > > + err = mfd_clone_cell("cs5535-acpi", olpc_acpi_clones, > > + ARRAY_SIZE(olpc_acpi_clones)); > > + if (err) { > > + dev_err(&pdev->dev, "Failed to clone MFD cell\n"); > > + goto err_release_acpi; > > + } > > + } > > Making the request_region() conditional on machine_is_olpc() seems to be > best on the assumption that the cs5535-acpi is not otherwise used. > > I suspect the assumption is true but you have to combine knowledge from > several bits of code to figure that out. It is not used. Will reply to your other comment. -- Lee Jones [李琼斯] Linaro Services Technical Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog