From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2AB9DCA9EB7 for ; Mon, 21 Oct 2019 13:01:19 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id F035B20B7C for ; Mon, 21 Oct 2019 13:01:18 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="QQ4sY7yM"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="bqsYQfQL" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F035B20B7C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=+VHY0Xby9LgSrj5jMJXOrwlfhjU6GDJ9HaFugwFqpqQ=; b=QQ4sY7yMzLAAKf TiXZRTQVsfmOqdmpi072V7xiPfx/6KcDnxwv55B/fHwore85/rXgaJ1UCZHagGffg4o9orQ0/+cYk GzPdv+I/EDZV5D6Lo5V53PFdy2MTl1Er3Q58a6iftuzEgZic6wLKEICfq6Qh0bDSS1DROMiAXy7ys +n1IAsfdJVKPX5plozJibJ9j+JVYXhFvQF8yDDCx/tUq+fmiBhyzBF/W7sC+PKilLCtLCRGwH/qiH HAj1USJAjJlhGAC2TFzhuKK71pwsSoioXrIhE3P2RbOf7O4kNWAM2BCNgff7qbhPFKAmCZ/g2VKXa vcL/L95uWc0+52k+3rJg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iMXJG-00052Z-HY; Mon, 21 Oct 2019 13:01:18 +0000 Received: from mail-wr1-x443.google.com ([2a00:1450:4864:20::443]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iMXJC-00051x-R0 for linux-arm-kernel@lists.infradead.org; Mon, 21 Oct 2019 13:01:16 +0000 Received: by mail-wr1-x443.google.com with SMTP id o28so13882600wro.7 for ; Mon, 21 Oct 2019 06:01:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=8ZUCK76p+L2E8XTaNFobsobEPp230uUztFZ+QUtxrJ0=; b=bqsYQfQLKVQEksQEka8qdQpOPv3Ecy1ekA081bTj5eFCNFe4tRrAwwR9PH9ag2FLhM o/GaIsZ4Z2z5CmY+sIlD7R3ELdggCmO0QeyoqbhsSNydKVlCUefXFaagUn0L3xAZhon5 pqWBG5SD25e/zXBCFmRfXrijjd1E+DBFNYrczBqQkEwciC0n/JuP08iqFPm3CHLMyrAz xUled2mExTdgE3v8Y86UbpWGzvghEIALYj0sBwaWbrp5kvf5PtFbRK6AdEQIeU+/flBD ewk9bs7wOUJg2jEm2X2wXmpeqrCEZjpIWXm83cnSA0bQNtxqC4ZG9cJbTI/QVLtyBtny zudQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=8ZUCK76p+L2E8XTaNFobsobEPp230uUztFZ+QUtxrJ0=; b=CSR2khYpoEUNEFRPpH7rQ+1UpxyckWzIut+yWknPeXDfcj4qQI+Pug2s5UcXUwuxol QVUOyOX/GyU13b1ocDKGC+7h7HtBmhLmpKpqjyLVoEXuiZnAP39aeMEmQsEfiT+/7odB yAH3/hkZyF2yTjeeuEsDxZp9hTaMjUJdO61QQUGfNKS7ExeQJeHH6i5GaCnQOwbBhbsh NeTxruZQh5Oeaq47iCsxts7biCpHhdZRjNRPm6HuatKTmNF1I6QsdS7JVfVFx6n208cl qfPjnjx22RMi6sjdt5WVU7qSYnkqV3+BENKnfWgV4yncdbhH50Vlj29eo5vCPyDikrq4 cinQ== X-Gm-Message-State: APjAAAWpT1o5q5QGUs9k8cwPIkfBb1WSQV7bWBYeq70H4y/MgDGCxfEJ cr2VLV1f/SEOjLBdZOHPiEBqF9DaqII= X-Google-Smtp-Source: APXvYqxCVuBt/shwrkMerW0kYmwBSZSGSE1GeIcI+E/tc+cZf82WHNc4SssGKl6JqbUSFwEXQIWc2A== X-Received: by 2002:a5d:6a02:: with SMTP id m2mr5033679wru.304.1571662873352; Mon, 21 Oct 2019 06:01:13 -0700 (PDT) Received: from dell ([95.149.164.99]) by smtp.gmail.com with ESMTPSA id a192sm18678335wma.1.2019.10.21.06.01.12 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 21 Oct 2019 06:01:12 -0700 (PDT) Date: Mon, 21 Oct 2019 14:01:11 +0100 From: Lee Jones To: Lubomir Rintel Subject: Re: [PATCH v2 0/9] Simplify MFD Core Message-ID: <20191021130111.GI4365@dell> References: <20191021105822.20271-1-lee.jones@linaro.org> <20191021115339.GF4365@dell> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191021_060114_886824_442971F1 X-CRM114-Status: GOOD ( 28.25 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Barry Song , Arnd Bergmann , stephan@gerhold.net, Linus Walleij , Daniel Thompson , "linux-kernel@vger.kernel.org" , Mark Brown , Daniel Drake , Linux ARM , James Cameron Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gTW9uLCAyMSBPY3QgMjAxOSwgTHVib21pciBSaW50ZWwgd3JvdGU6Cgo+IE9uIE1vbiwgMjAx OS0xMC0yMSBhdCAxMjo1MyArMDEwMCwgTGVlIEpvbmVzIHdyb3RlOgo+ID4gT24gTW9uLCAyMSBP Y3QgMjAxOSwgTHVib21pciBSaW50ZWwgd3JvdGU6Cj4gPiAKPiA+ID4gT24gTW9uLCAyMDE5LTEw LTIxIGF0IDEzOjI5ICswMjAwLCBBcm5kIEJlcmdtYW5uIHdyb3RlOgo+ID4gPiA+IE9uIE1vbiwg T2N0IDIxLCAyMDE5IGF0IDEyOjU4IFBNIExlZSBKb25lcyA8bGVlLmpvbmVzQGxpbmFyby5vcmc+ IHdyb3RlOgo+ID4gPiA+ID4gTUZEIGN1cnJlbnRseSBoYXMgb25lIG92ZXItY29tcGxpY2F0ZWQg dXNlci4gIENTNTUzNSB1c2VzIGEgbWl4dHVyZSBvZgo+ID4gPiA+ID4gY2VsbCBjbG9uaW5nLCBy ZWZlcmVuY2UgY291bnRpbmcgYW5kIHN1YnN5c3RlbS1sZXZlbCBjYWxsLWJhY2tzIHRvCj4gPiA+ ID4gPiBhY2hpZXZlIGl0cyBnb2FsIG9mIHJlcXVlc3RpbmcgYW4gSU8gbWVtb3J5IHJlZ2lvbiBv bmx5IG9uY2UgYWNyb3NzIDMKPiA+ID4gPiA+IGNvbnN1bWVycy4gIFRoZSBzYW1lIGNhbiBiZSBh Y2hpZXZlZCBieSBoYW5kbGluZyB0aGUgcmVnaW9uIGNlbnRyYWxseQo+ID4gPiA+ID4gZHVyaW5n IHRoZSBwYXJlbnQgZGV2aWNlJ3MgLnByb2JlKCkgc2VxdWVuY2UuICBSZWxlYXNpbmcgY2FuIGJl IGhhbmRlZAo+ID4gPiA+ID4gaW4gYSBzaW1pbGFyIHdheSBkdXJpbmcgLnJlbW92ZSgpLgo+ID4g PiA+ID4gCj4gPiA+ID4gPiBXaGlsZSB3ZSdyZSBoZXJlLCB0YWtlIHRoZSBvcHBvcnR1bml0eSB0 byBwcm92aWRlIHNvbWUgY2xlYW4tdXBzIGFuZAo+ID4gPiA+ID4gZXJyb3IgY2hlY2tpbmcgdG8g aXNzdWVzIG5vdGljZWQgYWxvbmcgdGhlIHdheS4KPiA+ID4gPiA+IAo+ID4gPiA+ID4gVGhpcyBh bHNvIHBhdmVzIHRoZSB3YXkgZm9yIGNsZWFuIGNlbGwgZGlzYWJsaW5nIHZpYSBEZXZpY2UgVHJl ZSBiZWluZwo+ID4gPiA+ID4gZGlzY3Vzc2VkIGF0IFswXQo+ID4gPiA+ID4gCj4gPiA+ID4gPiBb MF0gaHR0cHM6Ly9sa21sLm9yZy9sa21sLzIwMTkvMTAvMTgvNjEyLgo+ID4gPiA+IAo+ID4gPiA+ IEFzIHRoZSBDUzU1MzUgaXMgcHJpbWFyaWx5IHVzZWQgb24gdGhlIE9MUEMgWE8xLCBpdCB3b3Vs ZCBiZQo+ID4gPiA+IGdvb2QgdG8gaGF2ZSBzb21lb25lIHRlc3QgdGhlIHNlcmllcyBvbiBzdWNo IGEgbWFjaGluZS4KPiA+ID4gPiAKPiA+ID4gPiBJJ3ZlIGFkZGVkIGEgZmV3IHBlb3BsZSB0byBD YyB0aGF0IG1heSBiZSBhYmxlIHRvIGhlbHAgdGVzdCBpdCwgb3IKPiA+ID4gPiBrbm93IHNvbWVv bmUgd2hvIGNhbi4KPiA+ID4gPiAKPiA+ID4gPiBGb3IgdGhlIGFjdHVhbCBwYXRjaGVzLCBzZWUK PiA+ID4gPiBodHRwczovL2xvcmUua2VybmVsLm9yZy9sa21sLzIwMTkxMDIxMTA1ODIyLjIwMjcx LTEtbGVlLmpvbmVzQGxpbmFyby5vcmcvVC8jdAo+ID4gPiAKPiA+ID4gVGhhbmtzIGZvciB0aGUg cG9pbnRlci4gSSdkIGJ5IGhhcHB5IHRvIHRlc3QgdGhpcy4KPiA+ID4gCj4gPiA+IFdoaWNoIHRy ZWUgZG8gdGhlIHBhdGNoZXMgYXBwbHkgdG8/Cj4gPiA+IE9yLCBiZXR0ZXIsIGlzIHRoZXJlIGEg dHJlZSB3aXRoIHRoZSBwYXRjaGVzIGFwcGxpZWQgdGhhdCBJIGNvdWxkIHVzZT8KPiA+IAo+ID4g SWRlYWwuICBUaGFuayB5b3UuCj4gPiAKPiA+IGh0dHA6Ly9naXQubGluYXJvLm9yZy9wZW9wbGUv bGVlLmpvbmVzL2xpbnV4LmdpdC9sb2cvP2g9dG9waWMvbWZkLXJlbW92ZS1jbG9uZS1jczU1MzUt bWZkCj4gCj4gVGhhbmtzLiBNeSBib290IGF0dGVtcHQgZW5kcyB1cCBpbiBhIHBhbmljIFsxXToK CkFoIHllcywgdGhhdCBtYWtlcyBzZW5zZS4KCkkgZ3Vlc3MgdGhlIHN1YnN5c3RlbSBkb2Vzbid0 IGxpa2UgdGhlcmUgYmVpbmcgZW1wdHkgY2VsbHMuCgpQbGVhc2UgYmVhciB3aXRoIG1lLgoKPiBb ICAgIDIuMDkwOTQzXSBjczU1MzUtZ3BpbyBjczU1MzUtZ3BpbzogcmVzZXJ2ZWQgcmVzb3VyY2Ug cmVnaW9uIFtpbyAgMHgxMDAwLTB4MTBmZl0KPiBbICAgIDIuMTI5MDg0XSBjczU1MzUtbWZncHQg Y3M1NTM1LW1mZ3B0OiByZXNlcnZlZCByZXNvdXJjZSByZWdpb24gW2lvICAweDE4MDAtMHgxODNm XQo+IFsgICAgMi4xNzM0NTddIGNzNTUzNS1tZmdwdCBjczU1MzUtbWZncHQ6IDggTUZHUFQgdGlt ZXJzIGF2YWlsYWJsZQo+IFsgICAgMi4yMDA3MzFdIEJVRzoga2VybmVsIE5VTEwgcG9pbnRlciBk ZXJlZmVyZW5jZSwgYWRkcmVzczogMDAwMDAwMDAKPiBbICAgIDIuMjEwNjU1XSAjUEY6IHN1cGVy dmlzb3IgcmVhZCBhY2Nlc3MgaW4ga2VybmVsIG1vZGUKPiBbICAgIDIuMjEwNjU1XSAjUEY6IGVy cm9yX2NvZGUoMHgwMDAwKSAtIG5vdC1wcmVzZW50IHBhZ2UKPiBbICAgIDIuMjEwNjU1XSAqcGRl ID0gMDAwMDAwMDAgCj4gWyAgICAyLjIxMDY1NV0gT29wczogMDAwMCBbIzFdIFBSRUVNUFQgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAKPiBbICAgIDIuMjEwNjU1XSBD UFU6IDAgUElEOiAxIENvbW06IHN3YXBwZXIgTm90IHRhaW50ZWQgNS40LjAtcmMzLTAwMDEzLWdk ODUxOGIxYWM3MjgyICMxNyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgIAo+IFsgICAgMi4yMTA2NTVdIEhhcmR3YXJlIG5hbWU6IE9MUEMgWE8vWE8sIEJJT1Mg T0xQQyBWZXIgMS4wMC4wMSAxMC8xNi8yMDE5ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgCj4gWyAgICAyLjIxMDY1NV0gRUlQOiBz dHJsZW4rMHhiLzB4MTcgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAKPiBbICAgIDIuMjEwNjU1XSBDb2RlOiBjMyA1NSA4OSBlNSA1NiA4OSBjNiA4OSBkMCA4OCBj NCBhYyAzOCBlMCA3NCAwOSA4NCBjMCA3NSBmNyBiZSAwMSAwMCAwMCAwMCA4OSBmMCA0OCA1ZSA1 ZCBjMyA1NSA4OSBlNSA4MyBjOSBmZiA1NyA4OSBjNyAzMSBjMCA8ZjI+IGFlIGI4IGZlIGZmIGZm IGZmIDVmIDI5IGM4IDVkIGMzIDg1IGM5IDc0IDE3IDU1IDg5IGU1IDU3IDg5IGM3Cj4gWyAgICAy LjIxMDY1NV0gRUFYOiAwMDAwMDAwMCBFQlg6IDAwMDAwMDAwIEVDWDogZmZmZmZmZmYgRURYOiBm ZmZmZmZmZgo+IFsgICAgMi4yMTA2NTVdIEVTSTogYzBkMjE0YTAgRURJOiAwMDAwMDAwMCBFQlA6 IGNlNDg3ZGQ4IEVTUDogY2U0ODdkZDQKPiBbICAgIDIuMjEwNjU1XSBEUzogMDA3YiBFUzogMDA3 YiBGUzogMDAwMCBHUzogMDBlMCBTUzogMDA2OCBFRkxBR1M6IDAwMDEwMjQ2Cj4gWyAgICAyLjIx MDY1NV0gQ1IwOiA4MDA1MDAzMyBDUjI6IDAwMDAwMDAwIENSMzogMDBlMDgwMDAgQ1I0OiAwMDAw MDA5MAo+IFsgICAgMi4yMTA2NTVdIENhbGwgVHJhY2U6Cj4gWyAgICAyLjIxMDY1NV0gIHBsYXRm b3JtX2RldmljZV9hbGxvYysweDExLzB4YjIKPiBbICAgIDIuMjEwNjU1XSAgbWZkX2FkZF9kZXZp Y2VzKzB4M2MvMHgyODUKPiBbICAgIDIuMjEwNjU1XSAgY3M1NTM1X21mZF9wcm9iZSsweDk1LzB4 MTU5Cj4gWyAgICAyLjIxMDY1NV0gID8gY3M1NTM1X21mZF9yZW1vdmUrMHgyZS8weDJlCj4gWyAg ICAyLjIxMDY1NV0gIHBjaV9kZXZpY2VfcHJvYmUrMHg4My8weGU5Cj4gWyAgICAyLjIxMDY1NV0g IHJlYWxseV9wcm9iZSsweDE2Zi8weDMzNQo+IFsgICAgMi4yMTA2NTVdICBkcml2ZXJfcHJvYmVf ZGV2aWNlKzB4MTEzLzB4MTQ4Cj4gWyAgICAyLjIxMDY1NV0gIGRldmljZV9kcml2ZXJfYXR0YWNo KzB4MmUvMHg0MQo+IFsgICAgMi4yMTA2NTVdICBfX2RyaXZlcl9hdHRhY2grMHhlNC8weGVlCj4g WyAgICAyLjIxMDY1NV0gID8gZGV2aWNlX2RyaXZlcl9hdHRhY2grMHg0MS8weDQxCj4gWyAgICAy LjIxMDY1NV0gIGJ1c19mb3JfZWFjaF9kZXYrMHg1NC8weDgxCj4gWyAgICAyLjIxMDY1NV0gIGRy aXZlcl9hdHRhY2grMHgxNC8weDE2Cj4gWyAgICAyLjIxMDY1NV0gID8gZGV2aWNlX2RyaXZlcl9h dHRhY2grMHg0MS8weDQxCj4gWyAgICAyLjIxMDY1NV0gIGJ1c19hZGRfZHJpdmVyKzB4ZTkvMHgx OTAKPiBbICAgIDIuMjEwNjU1XSAgPyBtYXg4OTI1X2kyY19pbml0KzB4MmEvMHgyYQo+IFsgICAg Mi4yMTA2NTVdICBkcml2ZXJfcmVnaXN0ZXIrMHg4Ny8weGI5Cj4gWyAgICAyLjIxMDY1NV0gID8g bWF4ODkyNV9pMmNfaW5pdCsweDJhLzB4MmEKPiBbICAgIDIuMjEwNjU1XSAgX19wY2lfcmVnaXN0 ZXJfZHJpdmVyKzB4MzcvMHgzYQo+IFsgICAgMi4yMTA2NTVdICBjczU1MzVfbWZkX2RyaXZlcl9p bml0KzB4MTQvMHgxNgo+IFsgICAgMi4yMTA2NTVdICBkb19vbmVfaW5pdGNhbGwrMHg3OC8weDE2 OQo+IFsgICAgMi4yMTA2NTVdICA/IGRvX2Vhcmx5X3BhcmFtKzB4NzUvMHg3NQo+IFsgICAgMi4y MTA2NTVdICBrZXJuZWxfaW5pdF9mcmVlYWJsZSsweGU2LzB4MTZkCj4gWyAgICAyLjIxMDY1NV0g ID8gcmVzdF9pbml0KzB4OGUvMHg4ZQo+IFsgICAgMi4yMTA2NTVdICBrZXJuZWxfaW5pdCsweDgv MHhkNQo+IFsgICAgMi4yMTA2NTVdICByZXRfZnJvbV9mb3JrKzB4MmUvMHgzOAo+IFsgICAgMi4y MTA2NTVdIE1vZHVsZXMgbGlua2VkIGluOgo+IFsgICAgMi4yMTA2NTVdIENSMjogMDAwMDAwMDAw MDAwMDAwMAo+IFsgICAgMi4yMTA2NTVdIC0tLVsgZW5kIHRyYWNlIGIwMmM1NzVjODQ2M2UxNmYg XS0tLQo+IFsgICAgMi4yMTA2NTVdIEVJUDogc3RybGVuKzB4Yi8weDE3Cj4gWyAgICAyLjIxMDY1 NV0gQ29kZTogYzMgNTUgODkgZTUgNTYgODkgYzYgODkgZDAgODggYzQgYWMgMzggZTAgNzQgMDkg ODQgYzAgNzUgZjcgYmUgMDEgMDAgMDAgMDAgODkgZjAgNDggNWUgNWQgYzMgNTUgODkgZTUgODMg YzkgZmYgNTcgODkgYzcgMzEgYzAgPGYyPiBhZSBiOCBmZSBmZiBmZiBmZiA1ZiAyOSBjOCA1ZCBj MyA4NSBjOSA3NCAxNyA1NSA4OSBlNSA1NyA4OSBjNwo+IFsgICAgMi4yMTA2NTVdIEVBWDogMDAw MDAwMDAgRUJYOiAwMDAwMDAwMCBFQ1g6IGZmZmZmZmZmIEVEWDogZmZmZmZmZmYKPiBbICAgIDIu MjEwNjU1XSBFU0k6IGMwZDIxNGEwIEVESTogMDAwMDAwMDAgRUJQOiBjZTQ4N2RkOCBFU1A6IGNl NDg3ZGQ0Cj4gWyAgICAyLjIxMDY1NV0gRFM6IDAwN2IgRVM6IDAwN2IgRlM6IDAwMDAgR1M6IDAw ZTAgU1M6IDAwNjggRUZMQUdTOiAwMDAxMDI0Ngo+IFsgICAgMi4yMTA2NTVdIENSMDogODAwNTAw MzMgQ1IyOiAwMDAwMDAwMCBDUjM6IDAwZTA4MDAwIENSNDogMDAwMDAwOTAKPiBbICAgIDQuMDEy ODIzXSBLZXJuZWwgcGFuaWMgLSBub3Qgc3luY2luZzogQXR0ZW1wdGVkIHRvIGtpbGwgaW5pdCEg ZXhpdGNvZGU9MHgwMDAwMDAwOQo+IFsgICAgNC4wMjI3NzFdIEtlcm5lbCBPZmZzZXQ6IDB4MCBm cm9tIDB4YzA0MDAwMDAgKHJlbG9jYXRpb24gcmFuZ2U6IDB4YzAwMDAwMDAtMHhjZjNmZmZmZikK PiBbICAgIDQuMDIyNzcxXSAtLS1bIGVuZCBLZXJuZWwgcGFuaWMgLSBub3Qgc3luY2luZzogQXR0 ZW1wdGVkIHRvIGtpbGwgaW5pdCEgZXhpdGNvZGU9MHgwMDAwMDAwOSBdLS0tCj4gCj4gWzFdIGh0 dHA6Ly92My5zay9+bGt1bmRyYWsvbWZwLnR4dAo+IAo+IEFsc286Cj4gCj4gVGhlcmUncyBhIGJ1 aWxkIHdhcm5pbmcsIGNhdXNlZCBieSAieDg2OiBvbHBjOiBSZW1vdmUgaW52b2NhdGlvbiBvZgo+ IE1GRCdzIC5lbmFibGUoKS8uZGlzYWJsZSgpIGNhbGwtYmFja3MiIEkgc3VwcG9zZToKPiAKPiBh cmNoL3g4Ni9wbGF0Zm9ybS9vbHBjL29scGMteG8xLXBtLmM6IEluIGZ1bmN0aW9uIOKAmHhvMV9w bV9wcm9iZeKAmToKPiBhcmNoL3g4Ni9wbGF0Zm9ybS9vbHBjL29scGMteG8xLXBtLmM6MTIzOjY6 IHdhcm5pbmc6IHVudXNlZCB2YXJpYWJsZSDigJhlcnLigJkgWy1XdW51c2VkLXZhcmlhYmxlXQo+ ICAgMTIzIHwgIGludCBlcnI7Cj4gICAgICAgfCAgICAgIF5+fgo+IAo+IEkgZGlkbid0IGxvb2sg ZnVydGhlciBpbnRvIGl0LiBJJ20gaGFwcHkgdG8gZG8gc28gaWYgbmVjZXNzYXJ5IG9yIHRyeQo+ IG91dCBhIGZpeC4KPiAKPiBUYWtlIGNhcmUKPiBMdWJvCj4gCj4gPiAKPiA+ID4gPiA+IExlZSBK b25lcyAoOSk6Cj4gPiA+ID4gPiAgIG1mZDogY3M1NTM1LW1mZDogVXNlIFBMQVRGT1JNX0RFVklE XyogZGVmaW5lcyBhbmQgdGlkeSBlcnJvciBtZXNzYWdlCj4gPiA+ID4gPiAgIG1mZDogY3M1NTM1 LW1mZDogUmVtb3ZlIG1mZF9jZWxsLT5pZCBoYWNrCj4gPiA+ID4gPiAgIG1mZDogY3M1NTM1LW1m ZDogUmVxdWVzdCBzaGFyZWQgSU8gcmVnaW9ucyBjZW50cmFsbHkKPiA+ID4gPiA+ICAgbWZkOiBj czU1MzUtbWZkOiBSZWdpc3RlciBjbGllbnRzIHVzaW5nIHRoZWlyIG93biBkZWRpY2F0ZWQgTUZE IGNlbGwKPiA+ID4gPiA+ICAgICBlbnRyaWVzCj4gPiA+ID4gPiAgIG1mZDogbWZkLWNvcmU6IFJl bW92ZSBtZmRfY2xvbmVfY2VsbCgpCj4gPiA+ID4gPiAgIHg4Njogb2xwYzogUmVtb3ZlIGludm9j YXRpb24gb2YgTUZEJ3MgLmVuYWJsZSgpLy5kaXNhYmxlKCkgY2FsbC1iYWNrcwo+ID4gPiA+ID4g ICBtZmQ6IG1mZC1jb3JlOiBQcm90ZWN0IGFnYWluc3QgTlVMTCBjYWxsLWJhY2sgZnVuY3Rpb24g cG9pbnRlcgo+ID4gPiA+ID4gICBtZmQ6IG1mZC1jb3JlOiBSZW1vdmUgdXNhZ2UgY291bnRpbmcg Zm9yIC57ZW4sZGlzfWFibGUoKSBjYWxsLWJhY2tzCj4gPiA+ID4gPiAgIG1mZDogbWZkLWNvcmU6 IE1vdmUgcGRldi0+bWZkX2NlbGwgY3JlYXRpb24gYmFjayBpbnRvIG1mZF9hZGRfZGV2aWNlKCkK PiA+ID4gPiA+IAo+ID4gPiA+ID4gIGFyY2gveDg2L3BsYXRmb3JtL29scGMvb2xwYy14bzEtcG0u YyB8ICAgNiAtLQo+ID4gPiA+ID4gIGRyaXZlcnMvbWZkL2NzNTUzNS1tZmQuYyAgICAgICAgICAg ICB8IDEyNCArKysrKysrKysrKysrLS0tLS0tLS0tLS0tLS0KPiA+ID4gPiA+ICBkcml2ZXJzL21m ZC9tZmQtY29yZS5jICAgICAgICAgICAgICAgfCAxMTMgKysrKy0tLS0tLS0tLS0tLS0tLS0tLS0t Cj4gPiA+ID4gPiAgaW5jbHVkZS9saW51eC9tZmQvY29yZS5oICAgICAgICAgICAgIHwgIDIwIC0t LS0tCj4gPiA+ID4gPiAgNCBmaWxlcyBjaGFuZ2VkLCA3OSBpbnNlcnRpb25zKCspLCAxODQgZGVs ZXRpb25zKC0pCj4gPiA+ID4gPiAKPiAKCi0tIApMZWUgSm9uZXMgW+adjueQvOaWr10KTGluYXJv IFNlcnZpY2VzIFRlY2huaWNhbCBMZWFkCkxpbmFyby5vcmcg4pSCIE9wZW4gc291cmNlIHNvZnR3 YXJlIGZvciBBUk0gU29DcwpGb2xsb3cgTGluYXJvOiBGYWNlYm9vayB8IFR3aXR0ZXIgfCBCbG9n CgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1h cm0ta2VybmVsIG1haWxpbmcgbGlzdApsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5v cmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1hcm0t a2VybmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EE0B9CA9EAF for ; Mon, 21 Oct 2019 13:01:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id ACC2E2089C for ; Mon, 21 Oct 2019 13:01:18 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="bqsYQfQL" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728345AbfJUNBR (ORCPT ); Mon, 21 Oct 2019 09:01:17 -0400 Received: from mail-wr1-f66.google.com ([209.85.221.66]:38317 "EHLO mail-wr1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726767AbfJUNBR (ORCPT ); Mon, 21 Oct 2019 09:01:17 -0400 Received: by mail-wr1-f66.google.com with SMTP id v9so2632694wrq.5 for ; Mon, 21 Oct 2019 06:01:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=8ZUCK76p+L2E8XTaNFobsobEPp230uUztFZ+QUtxrJ0=; b=bqsYQfQLKVQEksQEka8qdQpOPv3Ecy1ekA081bTj5eFCNFe4tRrAwwR9PH9ag2FLhM o/GaIsZ4Z2z5CmY+sIlD7R3ELdggCmO0QeyoqbhsSNydKVlCUefXFaagUn0L3xAZhon5 pqWBG5SD25e/zXBCFmRfXrijjd1E+DBFNYrczBqQkEwciC0n/JuP08iqFPm3CHLMyrAz xUled2mExTdgE3v8Y86UbpWGzvghEIALYj0sBwaWbrp5kvf5PtFbRK6AdEQIeU+/flBD ewk9bs7wOUJg2jEm2X2wXmpeqrCEZjpIWXm83cnSA0bQNtxqC4ZG9cJbTI/QVLtyBtny zudQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=8ZUCK76p+L2E8XTaNFobsobEPp230uUztFZ+QUtxrJ0=; b=qxsMUVDD/irgVe1CiAnJcGQUucmbBVboSbhWnvizRO4uuEB1+ht+9D9uYwWHVF7ytk hOZzbRD29E+ol0h8/HI/9o1jVo8QaMYuPSkvU+EYQ0IXcyRA7MLiS0gi8iipmwFT5v8K x+9YbaR+uASKgcp3rOPaom5oUcC67BE4AlLiaMjgAhOv3m6cXxSQEJViFMsrvRGb2QGb 8NJPh5PcG073TE8rxHrGySDjSKFinQd4dIkbFy+YiFkQWCoSp0RL373D5jZVEeoDpe0t Zi+bREUP6fkI2b19TAt9h0/Ae52HyJv1SCiBopRwYRoexZLCDnfiu/KGFFIuWXvIPWky S5uw== X-Gm-Message-State: APjAAAU+N8vn0oJxDpkPBm+7fXMCy2Xb81Az4KBxhDGlv2rLnPB22mR3 FbcG0LYCI6oWzGMCUFNqYV/iIA== X-Google-Smtp-Source: APXvYqxCVuBt/shwrkMerW0kYmwBSZSGSE1GeIcI+E/tc+cZf82WHNc4SssGKl6JqbUSFwEXQIWc2A== X-Received: by 2002:a5d:6a02:: with SMTP id m2mr5033679wru.304.1571662873352; Mon, 21 Oct 2019 06:01:13 -0700 (PDT) Received: from dell ([95.149.164.99]) by smtp.gmail.com with ESMTPSA id a192sm18678335wma.1.2019.10.21.06.01.12 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 21 Oct 2019 06:01:12 -0700 (PDT) Date: Mon, 21 Oct 2019 14:01:11 +0100 From: Lee Jones To: Lubomir Rintel Cc: Arnd Bergmann , Daniel Thompson , Mark Brown , Linus Walleij , Barry Song , stephan@gerhold.net, "linux-kernel@vger.kernel.org" , Linux ARM , Daniel Drake , James Cameron Subject: Re: [PATCH v2 0/9] Simplify MFD Core Message-ID: <20191021130111.GI4365@dell> References: <20191021105822.20271-1-lee.jones@linaro.org> <20191021115339.GF4365@dell> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 21 Oct 2019, Lubomir Rintel wrote: > On Mon, 2019-10-21 at 12:53 +0100, Lee Jones wrote: > > On Mon, 21 Oct 2019, Lubomir Rintel wrote: > > > > > On Mon, 2019-10-21 at 13:29 +0200, Arnd Bergmann wrote: > > > > On Mon, Oct 21, 2019 at 12:58 PM Lee Jones wrote: > > > > > MFD currently has one over-complicated user. CS5535 uses a mixture of > > > > > cell cloning, reference counting and subsystem-level call-backs to > > > > > achieve its goal of requesting an IO memory region only once across 3 > > > > > consumers. The same can be achieved by handling the region centrally > > > > > during the parent device's .probe() sequence. Releasing can be handed > > > > > in a similar way during .remove(). > > > > > > > > > > While we're here, take the opportunity to provide some clean-ups and > > > > > error checking to issues noticed along the way. > > > > > > > > > > This also paves the way for clean cell disabling via Device Tree being > > > > > discussed at [0] > > > > > > > > > > [0] https://lkml.org/lkml/2019/10/18/612. > > > > > > > > As the CS5535 is primarily used on the OLPC XO1, it would be > > > > good to have someone test the series on such a machine. > > > > > > > > I've added a few people to Cc that may be able to help test it, or > > > > know someone who can. > > > > > > > > For the actual patches, see > > > > https://lore.kernel.org/lkml/20191021105822.20271-1-lee.jones@linaro.org/T/#t > > > > > > Thanks for the pointer. I'd by happy to test this. > > > > > > Which tree do the patches apply to? > > > Or, better, is there a tree with the patches applied that I could use? > > > > Ideal. Thank you. > > > > http://git.linaro.org/people/lee.jones/linux.git/log/?h=topic/mfd-remove-clone-cs5535-mfd > > Thanks. My boot attempt ends up in a panic [1]: Ah yes, that makes sense. I guess the subsystem doesn't like there being empty cells. Please bear with me. > [ 2.090943] cs5535-gpio cs5535-gpio: reserved resource region [io 0x1000-0x10ff] > [ 2.129084] cs5535-mfgpt cs5535-mfgpt: reserved resource region [io 0x1800-0x183f] > [ 2.173457] cs5535-mfgpt cs5535-mfgpt: 8 MFGPT timers available > [ 2.200731] BUG: kernel NULL pointer dereference, address: 00000000 > [ 2.210655] #PF: supervisor read access in kernel mode > [ 2.210655] #PF: error_code(0x0000) - not-present page > [ 2.210655] *pde = 00000000 > [ 2.210655] Oops: 0000 [#1] PREEMPT > [ 2.210655] CPU: 0 PID: 1 Comm: swapper Not tainted 5.4.0-rc3-00013-gd8518b1ac7282 #17 > [ 2.210655] Hardware name: OLPC XO/XO, BIOS OLPC Ver 1.00.01 10/16/2019 > [ 2.210655] EIP: strlen+0xb/0x17 > [ 2.210655] Code: c3 55 89 e5 56 89 c6 89 d0 88 c4 ac 38 e0 74 09 84 c0 75 f7 be 01 00 00 00 89 f0 48 5e 5d c3 55 89 e5 83 c9 ff 57 89 c7 31 c0 ae b8 fe ff ff ff 5f 29 c8 5d c3 85 c9 74 17 55 89 e5 57 89 c7 > [ 2.210655] EAX: 00000000 EBX: 00000000 ECX: ffffffff EDX: ffffffff > [ 2.210655] ESI: c0d214a0 EDI: 00000000 EBP: ce487dd8 ESP: ce487dd4 > [ 2.210655] DS: 007b ES: 007b FS: 0000 GS: 00e0 SS: 0068 EFLAGS: 00010246 > [ 2.210655] CR0: 80050033 CR2: 00000000 CR3: 00e08000 CR4: 00000090 > [ 2.210655] Call Trace: > [ 2.210655] platform_device_alloc+0x11/0xb2 > [ 2.210655] mfd_add_devices+0x3c/0x285 > [ 2.210655] cs5535_mfd_probe+0x95/0x159 > [ 2.210655] ? cs5535_mfd_remove+0x2e/0x2e > [ 2.210655] pci_device_probe+0x83/0xe9 > [ 2.210655] really_probe+0x16f/0x335 > [ 2.210655] driver_probe_device+0x113/0x148 > [ 2.210655] device_driver_attach+0x2e/0x41 > [ 2.210655] __driver_attach+0xe4/0xee > [ 2.210655] ? device_driver_attach+0x41/0x41 > [ 2.210655] bus_for_each_dev+0x54/0x81 > [ 2.210655] driver_attach+0x14/0x16 > [ 2.210655] ? device_driver_attach+0x41/0x41 > [ 2.210655] bus_add_driver+0xe9/0x190 > [ 2.210655] ? max8925_i2c_init+0x2a/0x2a > [ 2.210655] driver_register+0x87/0xb9 > [ 2.210655] ? max8925_i2c_init+0x2a/0x2a > [ 2.210655] __pci_register_driver+0x37/0x3a > [ 2.210655] cs5535_mfd_driver_init+0x14/0x16 > [ 2.210655] do_one_initcall+0x78/0x169 > [ 2.210655] ? do_early_param+0x75/0x75 > [ 2.210655] kernel_init_freeable+0xe6/0x16d > [ 2.210655] ? rest_init+0x8e/0x8e > [ 2.210655] kernel_init+0x8/0xd5 > [ 2.210655] ret_from_fork+0x2e/0x38 > [ 2.210655] Modules linked in: > [ 2.210655] CR2: 0000000000000000 > [ 2.210655] ---[ end trace b02c575c8463e16f ]--- > [ 2.210655] EIP: strlen+0xb/0x17 > [ 2.210655] Code: c3 55 89 e5 56 89 c6 89 d0 88 c4 ac 38 e0 74 09 84 c0 75 f7 be 01 00 00 00 89 f0 48 5e 5d c3 55 89 e5 83 c9 ff 57 89 c7 31 c0 ae b8 fe ff ff ff 5f 29 c8 5d c3 85 c9 74 17 55 89 e5 57 89 c7 > [ 2.210655] EAX: 00000000 EBX: 00000000 ECX: ffffffff EDX: ffffffff > [ 2.210655] ESI: c0d214a0 EDI: 00000000 EBP: ce487dd8 ESP: ce487dd4 > [ 2.210655] DS: 007b ES: 007b FS: 0000 GS: 00e0 SS: 0068 EFLAGS: 00010246 > [ 2.210655] CR0: 80050033 CR2: 00000000 CR3: 00e08000 CR4: 00000090 > [ 4.012823] Kernel panic - not syncing: Attempted to kill init! exitcode=0x00000009 > [ 4.022771] Kernel Offset: 0x0 from 0xc0400000 (relocation range: 0xc0000000-0xcf3fffff) > [ 4.022771] ---[ end Kernel panic - not syncing: Attempted to kill init! exitcode=0x00000009 ]--- > > [1] http://v3.sk/~lkundrak/mfp.txt > > Also: > > There's a build warning, caused by "x86: olpc: Remove invocation of > MFD's .enable()/.disable() call-backs" I suppose: > > arch/x86/platform/olpc/olpc-xo1-pm.c: In function ‘xo1_pm_probe’: > arch/x86/platform/olpc/olpc-xo1-pm.c:123:6: warning: unused variable ‘err’ [-Wunused-variable] > 123 | int err; > | ^~~ > > I didn't look further into it. I'm happy to do so if necessary or try > out a fix. > > Take care > Lubo > > > > > > > > Lee Jones (9): > > > > > mfd: cs5535-mfd: Use PLATFORM_DEVID_* defines and tidy error message > > > > > mfd: cs5535-mfd: Remove mfd_cell->id hack > > > > > mfd: cs5535-mfd: Request shared IO regions centrally > > > > > mfd: cs5535-mfd: Register clients using their own dedicated MFD cell > > > > > entries > > > > > mfd: mfd-core: Remove mfd_clone_cell() > > > > > x86: olpc: Remove invocation of MFD's .enable()/.disable() call-backs > > > > > mfd: mfd-core: Protect against NULL call-back function pointer > > > > > mfd: mfd-core: Remove usage counting for .{en,dis}able() call-backs > > > > > mfd: mfd-core: Move pdev->mfd_cell creation back into mfd_add_device() > > > > > > > > > > arch/x86/platform/olpc/olpc-xo1-pm.c | 6 -- > > > > > drivers/mfd/cs5535-mfd.c | 124 +++++++++++++-------------- > > > > > drivers/mfd/mfd-core.c | 113 ++++-------------------- > > > > > include/linux/mfd/core.h | 20 ----- > > > > > 4 files changed, 79 insertions(+), 184 deletions(-) > > > > > > -- Lee Jones [李琼斯] Linaro Services Technical Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog