From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 67012CA9EAF for ; Mon, 21 Oct 2019 13:20:27 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E3EE92089C for ; Mon, 21 Oct 2019 13:20:26 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="QQ1biJ7N"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="q9YWvNv9" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E3EE92089C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 289511615; Mon, 21 Oct 2019 15:19:35 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 289511615 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1571664025; bh=MuqN48+7qn8q6zcU1yqqKo3Cu1jLLZ55CUZckyet4Wo=; h=Date:From:To:References:In-Reply-To:Cc:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=QQ1biJ7NU/xjE3nPh9TfMkQ3JJUcDcsfLmE6WnLH8qRZuwyC8wRbAzOF5MV+x5jU8 S8j2oW7/I9BwB2C9+VTYMvQUBZqoHTa/dT/RuB9KIWFwurWkVkIpp7giIGvYF9Vh0m qaGqg+azAkt2GzqwAvnxrU7Zq+6dLlK7LHgdbd4k= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id A549EF80321; Mon, 21 Oct 2019 15:19:34 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 44C8DF80368; Mon, 21 Oct 2019 15:19:33 +0200 (CEST) Received: from mail-wr1-x441.google.com (mail-wr1-x441.google.com [IPv6:2a00:1450:4864:20::441]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id C6CD5F800C0 for ; Mon, 21 Oct 2019 15:19:30 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz C6CD5F800C0 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="q9YWvNv9" Received: by mail-wr1-x441.google.com with SMTP id r1so4163384wrs.9 for ; Mon, 21 Oct 2019 06:19:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=IzXM9qRz/JzRTDA5ooE2NgWm+U2lHG9aYE8mnLThYtI=; b=q9YWvNv9ifnEpmf4fcGn790DbawpBkhYQbpIVJg3hYiigRmAsjCJXHurvRjsJbr33y GKAj9CRq9suFR+sT8bkXA66eo/oOwaQ8tVIgh8xTeyUwi3LXse8r+RohW9AKTnYXoZOJ G30a0Fwt09369m1iUluNcYAKO/M8Hjw81Wl0xvLiTo4rpxSjJbUz8GYnKERP1UGsco/V 1AQp5U49KV73xRt8DhQWnoscHp1SDZ4FmHCi2q/M7u0w1ekqC+6fe7vPC9M2+U4Tu61t wRem0MnPSHUthaSTQfUD8G9zahBK5zqx0/4Wr/SUvo5wn0J5soLVVBwAEM5zeqsGdw05 /q2A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=IzXM9qRz/JzRTDA5ooE2NgWm+U2lHG9aYE8mnLThYtI=; b=EJ9LMVsQa+rgFamuTdi7tTcDk1Ng0Fg+sKHDkgyGSi8hckSS/rJjo4eNn8GGj+gm28 xWzTXR/sDviY2jcm7Ogta/iSBVO1+P3azsyhYX+YsC1UIYKbdU5sze4OxTlldChQSU8v PzRCc4OdT15hgXfhF7sCqsl+aKt4XPsvdS+U5BGnp1NlMUjWJHcL1Xl8+wbhDXgNAfgM wYg5LG11qvM2s7hmsWajp4iKWiZA8R49U7X7x41ogVlqRggsyBilLp5qBAPshnCRXCrv 1qlX73Cq4Jcq2HZXkoVjlVXbHHJ/FexwyI2NqFSQX034fGoX0eP5j2CsQsqGMg9dGtCI 8r4A== X-Gm-Message-State: APjAAAXKJ+yWP3F8a5yS9g09/YNFjInlCvW6JUjJKAHgTp+R+s2Tc0q9 rAHd1GkAEOt4C4iVuxOxiyNn5Q== X-Google-Smtp-Source: APXvYqzT82vjBtgcUeW0B+ywGszX0nXKvrB7d+PAaK9wi8U2cK7Uo07kUF1C0Fq2aDGrCrxNy/dEjw== X-Received: by 2002:a5d:4b8b:: with SMTP id b11mr5442650wrt.78.1571663969894; Mon, 21 Oct 2019 06:19:29 -0700 (PDT) Received: from dell ([95.149.164.99]) by smtp.gmail.com with ESMTPSA id v10sm11291181wmg.48.2019.10.21.06.19.29 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 21 Oct 2019 06:19:29 -0700 (PDT) Date: Mon, 21 Oct 2019 14:19:27 +0100 From: Lee Jones To: Srinivas Kandagatla Message-ID: <20191021131927.GJ4365@dell> References: <20191018001849.27205-1-srinivas.kandagatla@linaro.org> <20191018001849.27205-3-srinivas.kandagatla@linaro.org> <20191021104611.GZ4365@dell> <1af8a875-8f55-6b7e-4204-ecedc1608889@linaro.org> <20191021114520.GD4365@dell> <38dde3d9-8d7e-7dc0-7cba-137b43cea9d1@linaro.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <38dde3d9-8d7e-7dc0-7cba-137b43cea9d1@linaro.org> User-Agent: Mutt/1.9.4 (2018-02-28) Cc: robh@kernel.org, alsa-devel@alsa-project.org, bgoswami@codeaurora.org, vinod.koul@linaro.org, devicetree@vger.kernel.org, linus.walleij@linaro.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, broonie@kernel.org, spapothi@codeaurora.org Subject: Re: [alsa-devel] [PATCH v2 02/11] mfd: wcd934x: add support to wcd9340/wcd9341 codec X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" T24gTW9uLCAyMSBPY3QgMjAxOSwgU3Jpbml2YXMgS2FuZGFnYXRsYSB3cm90ZToKCj4gCj4gCj4g T24gMjEvMTAvMjAxOSAxMjo0NSwgTGVlIEpvbmVzIHdyb3RlOgo+ID4gT24gTW9uLCAyMSBPY3Qg MjAxOSwgU3Jpbml2YXMgS2FuZGFnYXRsYSB3cm90ZToKPiA+IAo+ID4gPiBUaGFua3MgTGVlIGZv ciB0YWtpbmcgdGltZSB0byByZXZpZXcuCj4gPiA+IAo+ID4gPiBJIGFncmVlIHdpdGggbW9zdCBv ZiB0aGUgc3R5bGUgcmVsYXRlZCBjb21tZW50cywgd2lsbCBmaXggdGhlbSBpbiBuZXh0Cj4gPiA+ IHZlcnNpb24uIEZvciBvdGhlcnMgSSBoYXZlIHJlcGxpZWQgaXQgaW5saW5lLgo+ID4gCj4gPiBb Li4uXQo+ID4gCj4gPiA+ID4gPiArc3RhdGljIGludCB3Y2Q5MzR4X3NsaW1fc3RhdHVzKHN0cnVj dCBzbGltX2RldmljZSAqc2RldiwKPiA+ID4gPiA+ICsJCQkgICAgICAgZW51bSBzbGltX2Rldmlj ZV9zdGF0dXMgc3RhdHVzKQo+ID4gPiA+ID4gK3sKPiA+ID4gPiA+ICsJc3RydWN0IGRldmljZSAq ZGV2ID0gJnNkZXYtPmRldjsKPiA+ID4gPiA+ICsJc3RydWN0IHdjZDkzNHhfZGF0YSAqd2NkOwo+ ID4gPiA+ID4gKwlpbnQgcmV0Owo+ID4gPiA+IAo+ID4gPiA+IFRoaXMgaXMgc2VtYW50aWNhbGx5 IG9kZCEgIFdoeSBhcmUgeW91IGRvaW5nIG1vc3Qgb2YgdGhlCj4gPiA+ID4gaW5pdGlhbGlzYXRp b24gYW5kIGJyaW5nLXVwIGluICdzdGF0dXMnIGFuZCBub3QgJ3Byb2JlJy4gIFNlZW1zCj4gPiA+ ID4gYnJva2VuIHRvIG1lLgo+ID4gPiAKPiA+ID4gU0xJTUJ1cyBkZXZpY2Ugd2lsbCBub3QgYmUg aW4gYSBzdGF0ZSB0byBjb21tdW5pY2F0ZSBiZWZvcmUgZW51bWVyYXRpb24gKGF0Cj4gPiA+IHBy b2JlKSwgc28gYWxsIHRoZSBkZXZpY2UgaW5pdGlhbGl6YXRpb24gaXMgZG9uZSBpbiBzdGF0dXMg Y2FsbGJhY2sgd2hlcmUgaXQKPiA+ID4gaXMgcmVhZHkgZm9yIGNvbW11bmljYXRpb24uCj4gPiAK PiA+IFdoeSBkbyB3ZSBuZWVkIHRoZSBkZXZpY2UgdG8gYmUgdXAgKmJlZm9yZSogY2FsbGluZyBw cm9iZT8KPiA+IAo+IAo+IFRvIEluaXRpYWxpemUgdGhlIGRldmljZS4KPiBBbmQgU0xJTWJ1cyBk ZXZpY2UgcmVnaXN0ZXJzIGFjY2VzcyBjYW4gbm90IGJlIGRvbmUgYmVmb3JlIGVudW1lcmF0aW9u LgoKSSdtIG5vdCBzdXJlIHdoeSB5b3UgbmVlZCBhbnkgaGFyZHdhcmUgdG8gYmUgZW5hYmxlZCBi ZWZvcmUgY2FsbGluZwoucHJvYmUoKS4gVGhhdCBpcyB0aGUgcHVycG9zZSBvZiAucHJvYmUoKS4g VGhlIG9ubHkgd2F5IGluIHdoaWNoIEkgY2FuCnNlZSB0aGlzIGJlaW5nIGEgcmVxdWlyZW1lbnQg aXMgaWYgaW5mb3JtYXRpb24gbG9jYXRlZCBvbiB0aGUgZGV2aWNlCmlzIHJlcXVpcmVkIGluIG9y ZGVyIHRvIGRvIGRldmljZS1kcml2ZXIgbWF0Y2hpbmcuCgpJbiB3aGljaCBjYXNlLCBob3cgd2Fz IHRoZSAuc3RhdHVzKCkgZnVuY3Rpb24gbWF0Y2hlZD8KCi0tIApMZWUgSm9uZXMgW+adjueQvOaW r10KTGluYXJvIFNlcnZpY2VzIFRlY2huaWNhbCBMZWFkCkxpbmFyby5vcmcg4pSCIE9wZW4gc291 cmNlIHNvZnR3YXJlIGZvciBBUk0gU29DcwpGb2xsb3cgTGluYXJvOiBGYWNlYm9vayB8IFR3aXR0 ZXIgfCBCbG9nCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f CkFsc2EtZGV2ZWwgbWFpbGluZyBsaXN0CkFsc2EtZGV2ZWxAYWxzYS1wcm9qZWN0Lm9yZwpodHRw czovL21haWxtYW4uYWxzYS1wcm9qZWN0Lm9yZy9tYWlsbWFuL2xpc3RpbmZvL2Fsc2EtZGV2ZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F1B33CA9EAF for ; Mon, 21 Oct 2019 13:19:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C2AC52089C for ; Mon, 21 Oct 2019 13:19:32 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="q9YWvNv9" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728850AbfJUNTc (ORCPT ); Mon, 21 Oct 2019 09:19:32 -0400 Received: from mail-wr1-f65.google.com ([209.85.221.65]:33702 "EHLO mail-wr1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728616AbfJUNTc (ORCPT ); Mon, 21 Oct 2019 09:19:32 -0400 Received: by mail-wr1-f65.google.com with SMTP id s1so5206644wro.0 for ; Mon, 21 Oct 2019 06:19:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=IzXM9qRz/JzRTDA5ooE2NgWm+U2lHG9aYE8mnLThYtI=; b=q9YWvNv9ifnEpmf4fcGn790DbawpBkhYQbpIVJg3hYiigRmAsjCJXHurvRjsJbr33y GKAj9CRq9suFR+sT8bkXA66eo/oOwaQ8tVIgh8xTeyUwi3LXse8r+RohW9AKTnYXoZOJ G30a0Fwt09369m1iUluNcYAKO/M8Hjw81Wl0xvLiTo4rpxSjJbUz8GYnKERP1UGsco/V 1AQp5U49KV73xRt8DhQWnoscHp1SDZ4FmHCi2q/M7u0w1ekqC+6fe7vPC9M2+U4Tu61t wRem0MnPSHUthaSTQfUD8G9zahBK5zqx0/4Wr/SUvo5wn0J5soLVVBwAEM5zeqsGdw05 /q2A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=IzXM9qRz/JzRTDA5ooE2NgWm+U2lHG9aYE8mnLThYtI=; b=Gl1eF0i7NTn3mjMigKG+tx/I0ndOJ0T0GREN4pduJdB/tI5OUl9qm8xiERYxv14vjn 00sbbNXhkD2JYYK4hb+SaHVsfnPC7WyJZ4rkdLAlce+jgsWm9iyU/6lOZlLoHnHG6wdt 92B8elpsj/ELitxKxHrHWb6X0+mKkgpapH2doooTe3jY34kwWZbfZk9/dWe2CUdM15Q3 Fz/0IHv/xN6APIDJTw5PP4WKpEwt2d1+DndMPgxe8DLPphzKj+dYyaBF2aE561Rbn4wb c4QjRhIy6ZPBe54GCvmqbTH1kckeMnnr2vBZFS/8ovgXDoyfqEuCCMGJVYE4296YLx7g T6Rg== X-Gm-Message-State: APjAAAWlH6DdF74HK6efu4SBZc/gHTXQI81QjnCnAq1rXD7Q3BoYr1av vdzPDxXwv0Idl/sdReDseuWQQjVZiR0= X-Google-Smtp-Source: APXvYqzT82vjBtgcUeW0B+ywGszX0nXKvrB7d+PAaK9wi8U2cK7Uo07kUF1C0Fq2aDGrCrxNy/dEjw== X-Received: by 2002:a5d:4b8b:: with SMTP id b11mr5442650wrt.78.1571663969894; Mon, 21 Oct 2019 06:19:29 -0700 (PDT) Received: from dell ([95.149.164.99]) by smtp.gmail.com with ESMTPSA id v10sm11291181wmg.48.2019.10.21.06.19.29 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 21 Oct 2019 06:19:29 -0700 (PDT) Date: Mon, 21 Oct 2019 14:19:27 +0100 From: Lee Jones To: Srinivas Kandagatla Cc: robh@kernel.org, broonie@kernel.org, linus.walleij@linaro.org, vinod.koul@linaro.org, alsa-devel@alsa-project.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, spapothi@codeaurora.org, bgoswami@codeaurora.org, linux-gpio@vger.kernel.org Subject: Re: [PATCH v2 02/11] mfd: wcd934x: add support to wcd9340/wcd9341 codec Message-ID: <20191021131927.GJ4365@dell> References: <20191018001849.27205-1-srinivas.kandagatla@linaro.org> <20191018001849.27205-3-srinivas.kandagatla@linaro.org> <20191021104611.GZ4365@dell> <1af8a875-8f55-6b7e-4204-ecedc1608889@linaro.org> <20191021114520.GD4365@dell> <38dde3d9-8d7e-7dc0-7cba-137b43cea9d1@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <38dde3d9-8d7e-7dc0-7cba-137b43cea9d1@linaro.org> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-gpio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org On Mon, 21 Oct 2019, Srinivas Kandagatla wrote: > > > On 21/10/2019 12:45, Lee Jones wrote: > > On Mon, 21 Oct 2019, Srinivas Kandagatla wrote: > > > > > Thanks Lee for taking time to review. > > > > > > I agree with most of the style related comments, will fix them in next > > > version. For others I have replied it inline. > > > > [...] > > > > > > > +static int wcd934x_slim_status(struct slim_device *sdev, > > > > > + enum slim_device_status status) > > > > > +{ > > > > > + struct device *dev = &sdev->dev; > > > > > + struct wcd934x_data *wcd; > > > > > + int ret; > > > > > > > > This is semantically odd! Why are you doing most of the > > > > initialisation and bring-up in 'status' and not 'probe'. Seems > > > > broken to me. > > > > > > SLIMBus device will not be in a state to communicate before enumeration (at > > > probe), so all the device initialization is done in status callback where it > > > is ready for communication. > > > > Why do we need the device to be up *before* calling probe? > > > > To Initialize the device. > And SLIMbus device registers access can not be done before enumeration. I'm not sure why you need any hardware to be enabled before calling .probe(). That is the purpose of .probe(). The only way in which I can see this being a requirement is if information located on the device is required in order to do device-driver matching. In which case, how was the .status() function matched? -- Lee Jones [李琼斯] Linaro Services Technical Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog