From: Jason Gunthorpe <jgg@ziepe.ca>
To: Lijun Ou <oulijun@huawei.com>
Cc: dledford@redhat.com, leon@kernel.org, linux-rdma@vger.kernel.org,
linuxarm@huawei.com
Subject: Re: [RFC PATCH V2 for-next] RDMA/hns: Add UD support for hip08
Date: Mon, 21 Oct 2019 11:13:12 -0300 [thread overview]
Message-ID: <20191021141312.GD25178@ziepe.ca> (raw)
In-Reply-To: <1571474772-2212-1-git-send-email-oulijun@huawei.com>
On Sat, Oct 19, 2019 at 04:46:12PM +0800, Lijun Ou wrote:
> index bd78ff9..722cc5f 100644
> +++ b/drivers/infiniband/hw/hns/hns_roce_qp.c
> @@ -377,6 +377,10 @@ static int hns_roce_set_user_sq_size(struct hns_roce_dev *hr_dev,
> hr_qp->sge.sge_cnt = roundup_pow_of_two(hr_qp->sq.wqe_cnt *
> (hr_qp->sq.max_gs - 2));
>
> + if (hr_qp->ibqp.qp_type == IB_QPT_UD)
> + hr_qp->sge.sge_cnt = roundup_pow_of_two(hr_qp->sq.wqe_cnt *
> + hr_qp->sq.max_gs);
> +
> if ((hr_qp->sq.max_gs > 2) && (hr_dev->pci_dev->revision == 0x20)) {
> if (hr_qp->sge.sge_cnt > hr_dev->caps.max_extend_sg) {
> dev_err(hr_dev->dev,
> @@ -1022,6 +1026,9 @@ struct ib_qp *hns_roce_create_qp(struct ib_pd *pd,
> int ret;
>
> switch (init_attr->qp_type) {
> + case IB_QPT_UD:
> + if (!capable(CAP_NET_RAW))
> + return -EPERM;
This needs a big comment explaining why this HW requires it.
Jason
next prev parent reply other threads:[~2019-10-21 14:13 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-19 8:46 [RFC PATCH V2 for-next] RDMA/hns: Add UD support for hip08 Lijun Ou
2019-10-21 14:13 ` Jason Gunthorpe [this message]
2019-10-21 14:20 ` oulijun
2019-10-21 14:58 ` Doug Ledford
2019-10-21 16:45 ` Doug Ledford
2019-10-22 5:44 ` Leon Romanovsky
2019-11-13 6:47 ` Weihang Li
2019-10-22 1:07 ` oulijun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191021141312.GD25178@ziepe.ca \
--to=jgg@ziepe.ca \
--cc=dledford@redhat.com \
--cc=leon@kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=oulijun@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.