From: Jonathan Cameron <jic23@kernel.org>
To: Gwendal Grignou <gwendal@chromium.org>
Cc: briannorris@chromium.org, knaack.h@gmx.de, lars@metafoo.de,
pmeerw@pmeerw.net, lee.jones@linaro.org, bleung@chromium.org,
enric.balletbo@collabora.com, dianders@chromium.org,
groeck@chromium.org, fabien.lahoudere@collabora.com,
linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org
Subject: Re: [PATCH v2 00/18] cros_ec: Add sensorhub driver and FIFO processing*** SUBJECT HERE
Date: Mon, 21 Oct 2019 16:29:08 +0100 [thread overview]
Message-ID: <20191021162908.67255884@archlinux> (raw)
In-Reply-To: <20191021055403.67849-1-gwendal@chromium.org>
On Sun, 20 Oct 2019 22:53:45 -0700
Gwendal Grignou <gwendal@chromium.org> wrote:
Tidy up the title for v3!
> This patchset adds a sensorhub driver for spreading sensor
> events coming from the Embedded controller sensor FIFO:
>
> +---------------+ +--------------+ +----
> | cros_ec_accel | | cros_ec_gyro | | ...
> +---------------+ +--------------+ +----
> id:0 \ id:1 | / id:..
> +------------------------------+
> | cros_ec_sensorhub |
> +------------------------------+
> | cros_ec_dev |
> +------------------------------+
> | cros_ec_i2c, cros_ec_lpc, .. |
> +------------------------------+
> |
> EC
>
> When new sensors events are present, the EC raises and interrupt,
> sensorhub reads the FIFO and uses the 'id' field to spread the event to
> the proper IIO sensors. This stack is similar to the HID sensor input
> stack.
>
> The first patch move cros_ec_proto functions documentations into the
> code to prevent rot.
>
> The inext 3 patches add a primitive cros_ec_sensorhub. MFD just have to
next
> register this driver if at least one sensor is presented by the EC.
> cros_ec_sensorhub retrieves more information from the EC to find out
> which sensors are actually present:
> mfd: cros_ec: Add sensor_count and make check_features public
> platform: cros_ec: Add cros_ec_sensor_hub driver
> platform/mfd:iio: cros_ec: Register sensor through sensorhub
>
> The next 3 patches prepare for FIFO support:
> platform: chrome: cros-ec: record event timestamp in the hard irq
> platform: chrome: cros_ec: Do not attempt to register a non-positive
> platform: chrome: cros_ec: handle MKBP more events flag
>
> That last patch fixes a regression that changes event processing.
> Revert the patches that fixed that regression.
>
> The next 3 patches add FIFO support. An interface is added to connect
> the IIO sensors with cros_ec_sensorhub, and filters are needed to spread
> the timestamp when the EC send batches of events and deal with variation
> in interrupt delay.
> platform: chrome: sensorhub: Add FIFO support
> platform: chrome: sensorhub: Add code to spread timestmap
> platform: chrome: sensorhub: Add median filter
>
> The remaining patches update IIO cros_ec drivers:
> The first patch moves cros_ec_sensor_core functions documentation into
> the .c file.
> Then we can use the FIFO function exposed by cros_ec_sensorhub:
> iio: cros_ec: Use triggered buffer only when EC does not support FIFO
>
> The power management functions are not necessary anymore, since we
> shutoff the FIFO from cros_ec_sensorhub:
> iio: cros_ec: Register to cros_ec_sensorhub when EC supports FIFO
>
> Finally, the last 3 patches present sensor information following the IIO
> ABI:
> - Configurable EC timeout to allow batch mode in buffer/hwfifo_timeout,
> in seconds.
> - Hard coded EC FIFO size in buffer/hwfifo_watermark_max
> - Sensor sampling frequency in hertz at sampling_frequency:
> iio: cros_ec: Expose hwfifo_timeout
> iio: cros_ec: Report hwfifo_watermark_max
> iio: cros_ec: Use Hertz as unit for sampling frequency
>
> For testing, libiio test tools can be used:
> A iio device link looks like:
> iio:device1 ->
> ...09:00/GOOG0004:00/cros-ec-dev.6.auto/cros-ec-sensorhub.7.auto/
> cros-ec-accel.15.auto/iio:device1
>
> When FIFO is available, no trigger are presented. Once
> sampling_freqeuncy and hwfifo_timeout are set, sensor events flow
> when listening to /dev/iio:device1:
> echo 12 > sampling_frequency # Set ODR to at least 12Hz
> echo .100 > buffer/hwfifo_timeout # do not wait more than 100ms to
> # to send samples
> iio_readdev -b 2 -T 1000 -s 2 iio:device1 2>/dev/null| od -x
> 0000000 ffd0 2e20 d990 0000 8630 b56c 07ea 0000
> 0000020 ffc0 2e10 d970 0000 877e b56c 07ea 0000
> 0000040`
>
> When FIFO is not supported by the EC, a trigger is present in the
> directory. After registering a trigger, setting sampling_frequency,
> the latest data collected by the sensor will be retrieved by the host
> when the trigger expires.
>
> When cros_ec_accel_legacy driver is used, no FIFO is supported and the
> sampling frequency for the accelerometers is hard coded at 10Hz.
>
> This set is built upon the master branch of
> git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
>
> Enrico Granata (2):
> platform: chrome: cros_ec: Do not attempt to register a non-positive
> IRQ number
> platform: chrome: cros_ec: handle MKBP more events flag
>
> Gwendal Grignou (16):
> platform: chrome: Put docs with the code
> mfd: cros_ec: Add sensor_count and make check_features public
> platform: cros_ec: Add cros_ec_sensor_hub driver
> platform/mfd:iio: cros_ec: Register sensor through sensorhub
> platform: chrome: cros-ec: record event timestamp in the hard irq
> Revert "Input: cros_ec_keyb - add back missing mask for event_type"
> Revert "Input: cros_ec_keyb: mask out extra flags in event_type"
> platform: chrome: sensorhub: Add FIFO support
> platform: chrome: sensorhub: Add code to spread timestmap
> platform: chrome: sensorhub: Add median filter
> iio: cros_ec: Move function description to .c file
> iio: cros_ec: Register to cros_ec_sensorhub when EC supports FIFO
> iio: cros_ec: Remove pm function
> iio: cros_ec: Expose hwfifo_timeout
> iio: cros_ec: Report hwfifo_watermark_max
> iio: cros_ec: Use Hertz as unit for sampling frequency
>
> drivers/iio/accel/cros_ec_accel_legacy.c | 14 +-
> drivers/iio/common/cros_ec_sensors/Kconfig | 2 +-
> .../cros_ec_sensors/cros_ec_lid_angle.c | 3 +-
> .../common/cros_ec_sensors/cros_ec_sensors.c | 19 +-
> .../cros_ec_sensors/cros_ec_sensors_core.c | 359 +++++--
> drivers/iio/light/cros_ec_light_prox.c | 21 +-
> drivers/iio/pressure/cros_ec_baro.c | 14 +-
> drivers/input/keyboard/cros_ec_keyb.c | 6 +-
> drivers/mfd/cros_ec_dev.c | 235 +----
> drivers/platform/chrome/Kconfig | 12 +
> drivers/platform/chrome/Makefile | 2 +
> drivers/platform/chrome/cros_ec.c | 80 +-
> drivers/platform/chrome/cros_ec_ishtp.c | 25 +-
> drivers/platform/chrome/cros_ec_lpc.c | 17 +-
> drivers/platform/chrome/cros_ec_proto.c | 267 ++++-
> drivers/platform/chrome/cros_ec_rpmsg.c | 23 +-
> drivers/platform/chrome/cros_ec_sensorhub.c | 263 +++++
> .../platform/chrome/cros_ec_sensorhub_ring.c | 973 ++++++++++++++++++
> .../linux/iio/common/cros_ec_sensors_core.h | 106 +-
> include/linux/platform_data/cros_ec_proto.h | 138 +--
> .../linux/platform_data/cros_ec_sensorhub.h | 171 +++
> 21 files changed, 2118 insertions(+), 632 deletions(-)
> create mode 100644 drivers/platform/chrome/cros_ec_sensorhub.c
> create mode 100644 drivers/platform/chrome/cros_ec_sensorhub_ring.c
> create mode 100644 include/linux/platform_data/cros_ec_sensorhub.h
>
prev parent reply other threads:[~2019-10-21 15:29 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-21 5:53 [PATCH v2 00/18] cros_ec: Add sensorhub driver and FIFO processing*** SUBJECT HERE Gwendal Grignou
2019-10-21 5:53 ` [PATCH v2 01/18] platform: chrome: Put docs with the code Gwendal Grignou
2019-10-21 15:31 ` Jonathan Cameron
2019-10-24 17:03 ` Enric Balletbo i Serra
2019-10-21 5:53 ` [PATCH v2 02/18] mfd: cros_ec: Add sensor_count and make check_features public Gwendal Grignou
2019-10-21 15:12 ` Enric Balletbo i Serra
2019-10-21 15:49 ` Jonathan Cameron
2019-11-01 9:00 ` Lee Jones
2019-10-21 5:53 ` [PATCH v2 03/18] platform: cros_ec: Add cros_ec_sensor_hub driver Gwendal Grignou
2019-10-21 15:59 ` Jonathan Cameron
2019-10-22 8:32 ` Enric Balletbo i Serra
2019-10-21 5:53 ` [PATCH v2 04/18] platform/mfd:iio: cros_ec: Register sensor through sensorhub Gwendal Grignou
2019-10-21 16:00 ` Jonathan Cameron
2019-10-22 9:39 ` Enric Balletbo i Serra
2019-10-21 5:53 ` [PATCH v2 05/18] platform: chrome: cros-ec: record event timestamp in the hard irq Gwendal Grignou
2019-10-22 10:03 ` Enric Balletbo i Serra
2019-10-21 5:53 ` [PATCH v2 06/18] platform: chrome: cros_ec: Do not attempt to register a non-positive IRQ number Gwendal Grignou
2019-10-22 10:05 ` Enric Balletbo i Serra
2019-10-21 5:53 ` [PATCH v2 07/18] platform: chrome: cros_ec: handle MKBP more events flag Gwendal Grignou
2019-10-21 16:07 ` Jonathan Cameron
2019-10-21 5:53 ` [PATCH v2 08/18] Revert "Input: cros_ec_keyb - add back missing mask for event_type" Gwendal Grignou
2019-10-21 5:53 ` [PATCH v2 09/18] Revert "Input: cros_ec_keyb: mask out extra flags in event_type" Gwendal Grignou
2019-10-21 5:53 ` [PATCH v2 10/18] platform: chrome: sensorhub: Add FIFO support Gwendal Grignou
2019-10-21 16:27 ` Jonathan Cameron
2019-10-21 22:09 ` Gwendal Grignou
2019-10-22 10:42 ` Jonathan Cameron
2019-10-21 5:53 ` [PATCH v2 11/18] platform: chrome: sensorhub: Add code to spread timestmap Gwendal Grignou
2019-10-21 5:53 ` [PATCH v2 12/18] platform: chrome: sensorhub: Add median filter Gwendal Grignou
2019-10-21 5:53 ` [PATCH v2 13/18] iio: cros_ec: Move function description to .c file Gwendal Grignou
2019-10-21 16:33 ` Jonathan Cameron
2019-10-21 5:53 ` [PATCH v2 14/18] iio: cros_ec: Register to cros_ec_sensorhub when EC supports FIFO Gwendal Grignou
2019-10-21 16:38 ` Jonathan Cameron
2019-10-21 5:54 ` [PATCH v2 15/18] iio: cros_ec: Remove pm function Gwendal Grignou
2019-10-21 16:39 ` Jonathan Cameron
2019-10-21 5:54 ` [PATCH v2 16/18] iio: cros_ec: Expose hwfifo_timeout Gwendal Grignou
2019-10-21 16:42 ` Jonathan Cameron
2019-10-21 5:54 ` [PATCH v2 17/18] iio: cros_ec: Report hwfifo_watermark_max Gwendal Grignou
2019-10-21 16:42 ` Jonathan Cameron
2019-10-21 5:54 ` [PATCH v2 18/18] iio: cros_ec: Use Hertz as unit for sampling frequency Gwendal Grignou
2019-10-21 16:45 ` Jonathan Cameron
2019-10-22 19:11 ` Gwendal Grignou
2019-10-21 15:29 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191021162908.67255884@archlinux \
--to=jic23@kernel.org \
--cc=bleung@chromium.org \
--cc=briannorris@chromium.org \
--cc=dianders@chromium.org \
--cc=enric.balletbo@collabora.com \
--cc=fabien.lahoudere@collabora.com \
--cc=groeck@chromium.org \
--cc=gwendal@chromium.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=lee.jones@linaro.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.