From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tony Lindgren Subject: Re: [PATCH 1/7] dt-bindings: gpu: pvrsgx: add initial bindings Date: Mon, 21 Oct 2019 10:25:57 -0700 Message-ID: <20191021172557.GB5610@atomide.com> References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: "H. Nikolaus Schaller" Cc: Rob Herring , David Airlie , Daniel Vetter , Mark Rutland , =?utf-8?Q?Beno=C3=AEt?= Cousson , dri-devel , devicetree@vger.kernel.org, "linux-kernel@vger.kernel.org" , linux-omap , Discussions about the Letux Kernel , kernel@pyra-handheld.com List-Id: linux-omap@vger.kernel.org * H. Nikolaus Schaller [191021 15:46]: > > Am 21.10.2019 um 17:07 schrieb Rob Herring : > > On Fri, Oct 18, 2019 at 1:46 PM H. Nikolaus Schaller wrote: > >> +Optional properties: > >> +- timer: the timer to be used by the driver. > > > > Needs a better description and vendor prefix at least. > > I am not yet sure if it is vendor specific or if all > SGX implementations need some timer. > > > > > Why is this needed rather than using the OS's timers? > > Because nobody understands the current (out of tree and > planned for staging) driver well enough what the timer > is doing. It is currently hard coded that some omap refer > to timer7 and others use timer11. Just configure it in the driver based on the compatible value to keep it out of the dts. It's best to stick to standard bindings. > >> +- img,cores: number of cores. Defaults to <1>. > > > > Not discoverable? > > Not sure if it is. This is probably available in undocumented > registers of the sgx. This too, and whatever non-standrd other properities you might have. Regards, Tony