Re: [PATCH v2] s390x/kvm: Set default cpu model for all machine classes

[Cornelia Huck <cohuck@redhat.com>]

On Mon, 21 Oct 2019 12:05:15 +0200
David Hildenbrand <david@redhat.com> wrote:

> We have to set the default model of all machine classes, not just for
> the active one. Otherwise, "query-machines" will indicate the wrong
> CPU model ("qemu-s390x-cpu" instead of "host-s390x-cpu") as
> "default-cpu-type".
> 
> Doing a
>     {"execute":"query-machines"}
> under KVM now results in
>     {"return": [
>         {
>             "hotpluggable-cpus": true,
>             "name": "s390-ccw-virtio-4.0",
>             "numa-mem-supported": false,
>             "default-cpu-type": "host-s390x-cpu",
>             "cpu-max": 248,
>             "deprecated": false},
>         {
>             "hotpluggable-cpus": true,
>             "name": "s390-ccw-virtio-2.7",
>             "numa-mem-supported": false,
>             "default-cpu-type": "host-s390x-cpu",
>             "cpu-max": 248,
>             "deprecated": false
>         } ...
> 
> Libvirt probes all machines via "-machine none,accel=kvm:tcg" and will
> currently see the wrong CPU model under KVM.
> 
> Reported-by: Jiri Denemark <jdenemar@redhat.com>
> Reviewed-by: Thomas Huth <thuth@redhat.com>
> Fixes: b6805e127c6b ("s390x: use generic cpu_model parsing")
> Cc: Igor Mammedov <imammedo@redhat.com>
> Signed-off-by: David Hildenbrand <david@redhat.com>
> ---
> 
> v1 -> v2:
> - Added a sentence how libvirt probes the machines/default cpu models
> - klass -> oc
> 
> ---
>  target/s390x/kvm.c | 10 ++++++++--
>  1 file changed, 8 insertions(+), 2 deletions(-)

Thanks, applied.