All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] docs/manual: clarify the reinstallation of a package
Date: Mon, 21 Oct 2019 22:03:32 +0200	[thread overview]
Message-ID: <20191021220332.16aaf3f3@windsurf> (raw)
In-Reply-To: <20191016195444.2408065-1-vivien.didelot@gmail.com>

Hello Vivien,

On Wed, 16 Oct 2019 15:54:44 -0400
Vivien Didelot <vivien.didelot@gmail.com> wrote:

> Since <package>-rebuild implies <package>-reinstall and
> <package>-reconfigure implies <package>-rebuild, it is confusing
> to mention the make and make <package> commands when describing
> the restart of the configuration, compilation and installation of
> the package.
> 
> Therefore remove the ", followed by +make+ or +make <package>+"
> portions in the "8.3. Understanding how to rebuild packages" section,
> and add a new paragraph clarifying how to include the rebuilt package
> in the filesystem image, if that is necessary.
> 
> Signed-off-by: Vivien Didelot <vivien.didelot@gmail.com>

I've applied, after doing one adjustement, see below.

> +While +<package>-rebuild+ implies +<package>-reinstall+ and
> ++<package>-reconfigure+ implies +<package>-rebuild+, these targets as well
> +as +<package>+ only act on the said package, and do not trigger re-creating
> +the root filesystem image. If re-creating the root filesystem in necessary,
> +one should run +make+ or +make all+.

change the last line to:

one should in addition run +make+ or +make all+

just to make it clear that "make" or "make all" is not sufficient to
force the rebuild of a package: it should be in addition to using
<pkg>-rebuild.

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

  reply	other threads:[~2019-10-21 20:03 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-16 19:54 [Buildroot] [PATCH] docs/manual: clarify the reinstallation of a package Vivien Didelot
2019-10-21 20:03 ` Thomas Petazzoni [this message]
2019-10-21 20:13   ` Vivien Didelot
2019-10-30 12:30 ` Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191021220332.16aaf3f3@windsurf \
    --to=thomas.petazzoni@bootlin.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.