From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C9659CA9EB7 for ; Tue, 22 Oct 2019 09:17:37 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A012F21906 for ; Tue, 22 Oct 2019 09:17:37 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="tRghL4MI" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A012F21906 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=1Dir0zc2gAuuO3JIgiSSCDnFAiye9kXwJz1vkxl/3zI=; b=tRghL4MI2xcui1 eb4wosNmOxW3pjkSPD7Gr189pKNwb8+u0mdA1kUbrZVfUpk6uC0kM+AwM7++6a9RuH2ZIIl1rgoY8 Iq1SZQrY1h6xDBrqTel56C0LNF7TU83H4nOZ1DraanASo63/X7JD1b/dkjI+00X2XEY+HXykcHeRY 0wS8crX81ULNskqfSNMAJxPeCRe4c3Yo/PJbpafr6eqzE/TyPF+KJaNXTca5yiWH/RITGF0/+4CSQ HMbFurpUeOMT9I6U3uKT31soBr1ZbaTLOiqmcjJqc5hLiI8CJuffLmLtcVnXxSTcsAJ6oyHiNJH8H k1k9YTFeUmn8bZMN/N7A==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iMqIJ-0001N2-AK; Tue, 22 Oct 2019 09:17:35 +0000 Received: from relay12.mail.gandi.net ([217.70.178.232]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iMqI0-0001C9-HA; Tue, 22 Oct 2019 09:17:18 +0000 Received: from xps13 (lfbn-1-17395-211.w86-250.abo.wanadoo.fr [86.250.200.211]) (Authenticated sender: miquel.raynal@bootlin.com) by relay12.mail.gandi.net (Postfix) with ESMTPSA id A20A320001B; Tue, 22 Oct 2019 09:17:08 +0000 (UTC) Date: Tue, 22 Oct 2019 11:17:07 +0200 From: Miquel Raynal To: Russell King - ARM Linux admin Subject: Re: [PATCH] mtd: spear_smi: Fix nonalignment not handled in memcpy_toio Message-ID: <20191022111707.4b117b99@xps13> In-Reply-To: <20191022082643.GO25745@shell.armlinux.org.uk> References: <20191018143643.29676-1-miquel.raynal@bootlin.com> <20191022082643.GO25745@shell.armlinux.org.uk> Organization: Bootlin X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191022_021716_864531_44338164 X-CRM114-Status: GOOD ( 17.39 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Vignesh Raghavendra , Tudor Ambarus , Richard Weinberger , stable@vger.kernel.org, Marek Vasut , Boris Brezillon , linux-mtd@lists.infradead.org, Thomas Petazzoni , Brian Norris , David Woodhouse , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org SGkgUnVzc2VsbCwKClJ1c3NlbGwgS2luZyAtIEFSTSBMaW51eCBhZG1pbiA8bGludXhAYXJtbGlu dXgub3JnLnVrPiB3cm90ZSBvbiBUdWUsIDIyCk9jdCAyMDE5IDA5OjI2OjQzICswMTAwOgoKPiBP biBGcmksIE9jdCAxOCwgMjAxOSBhdCAwNDozNjo0M1BNICswMjAwLCBNaXF1ZWwgUmF5bmFsIHdy b3RlOgo+ID4gQW55IHdyaXRlIHdpdGggZWl0aGVyIGRkIG9yIGZsYXNoY3AgdG8gYSBkZXZpY2Ug ZHJpdmVuIGJ5IHRoZQo+ID4gc3BlYXJfc21pLmMgZHJpdmVyIHdpbGwgcGFzcyB0aHJvdWdoIHRo ZSBzcGVhcl9zbWlfY3B5X3RvaW8oKQo+ID4gZnVuY3Rpb24uIFRoaXMgZnVuY3Rpb24gd2lsbCBn ZXQgY2FsbGVkIGZvciBjaHVua3Mgb2YgdXAgdG8gMjU2IGJ5dGVzLgo+ID4gSWYgdGhlIGFtb3Vu dCBvZiBkYXRhIGlzIHNtYWxsZXIsIHdlIG1heSBoYXZlIGEgcHJvYmxlbSBpZiB0aGUgZGF0YQo+ ID4gbGVuZ3RoIGlzIG5vdCA0LWJ5dGUgYWxpZ25lZC4gSW4gdGhpcyBzaXR1YXRpb24sIHRoZSBr ZXJuZWwgcGFuaWNzCj4gPiBkdXJpbmcgdGhlIG1lbWNweToKPiA+IAo+ID4gICAgICMgZGQgaWY9 L2Rldi91cmFuZG9tIGJzPTEwMDEgY291bnQ9MSBvZj0vZGV2L210ZDYKPiA+ICAgICBzcGVhcl9z bWlfY3B5X3RvaW8gWzYyMF0gZGVzdCBjOTA3MDAwMCwgc3JjIGM3YmU4ODAwLCBsZW4gMjU2Cj4g PiAgICAgc3BlYXJfc21pX2NweV90b2lvIFs2MjBdIGRlc3QgYzkwNzAxMDAsIHNyYyBjN2JlODkw MCwgbGVuIDI1Ngo+ID4gICAgIHNwZWFyX3NtaV9jcHlfdG9pbyBbNjIwXSBkZXN0IGM5MDcwMjAw LCBzcmMgYzdiZThhMDAsIGxlbiAyNTYKPiA+ICAgICBzcGVhcl9zbWlfY3B5X3RvaW8gWzYyMF0g ZGVzdCBjOTA3MDMwMCwgc3JjIGM3YmU4YjAwLCBsZW4gMjMzCj4gPiAgICAgVW5oYW5kbGVkIGZh dWx0OiBleHRlcm5hbCBhYm9ydCBvbiBub24tbGluZWZldGNoICgweDgwOCkgYXQgMHhjOTA3MDNl OAo+ID4gICAgIFsuLi5dCj4gPiAgICAgUEMgaXMgYXQgbWVtY3B5KzB4Y2MvMHgzMzAgIAo+IAo+ IEkgbmVlZCB0aGUgZnVsbCBvb3BzIGlmIHlvdSB3YW50IG1lIHRvIGNvbW1lbnQgb24gdGhpcy4K CkZZSSwgSSByYW4gdGhlIGRkIGNvbW1hbmQgd2l0aGluIGEgZm9yIGxvb3AsIGluY3JlbWVudGlu ZyB0aGUgYmxvY2sgc2l6ZQooYnMpIGJ5IG9uZSBieXRlLCBpZiBmYWlsZWQgd2l0aCBicz02LgoK RGlzYWJsaW5nIFdCX01PREUgKGJ1cnN0IG1vZGUpIGRvZXMgbm90IGNoYW5nZSBhbnl0aGluZy4K CkFkZGluZyBhIHdtYigpIHJpZ2h0IGFmdGVyIHRoZSBtZW1jcHlfdG9pbygpIHByZXZlbnRzIHRo ZSBmYXVsdC4KCkhlcmUgaXMgdGhlIGZ1bGwgdHJhY2Ugd2hlbiB3cml0aW5nIDEwMDEgYnl0ZXM6 CgojIGRkIGlmPS9kZXYvdXJhbmRvbSBicz0xMDAxIGNvdW50PTEgb2Y9L2Rldi9tdGQ2ClVuaGFu ZGxlZCBmYXVsdDogZXh0ZXJuYWwgYWJvcnQgb24gbm9uLWxpbmVmZXRjaCAoMHg4MDgpIGF0IDB4 YzkwNzAzZTgKcGdkID0gYzdiZTgwMDAKW2M5MDcwM2U4XSAqcGdkPWY4MDAwNDUyKGJhZCkKSW50 ZXJuYWwgZXJyb3I6IDogODA4IFsjMV0gQVJNCk1vZHVsZXMgbGlua2VkIGluOgpDUFU6IDAgUElE OiA2NjAgQ29tbTogZGQgTm90IHRhaW50ZWQgNC4xNC4wLTAwMDQ1LWdmNWQwODE5MjcwNGYtZGly dHkgIzYKSGFyZHdhcmUgbmFtZTogU1QgU1BFQXI2MDAgKEZsYXR0ZW5lZCBEZXZpY2UgVHJlZSkK dGFzazogYzdhMDUwODAgdGFzay5zdGFjazogYzdiZDIwMDAKUEMgaXMgYXQgbWVtY3B5KzB4Y2Mv MHgzMzAKTFIgaXMgYXQgMHgxM2YwZWMyOApwYyA6IFs8YzA0NDM0NGM+XSAgICBsciA6IFs8MTNm MGVjMjg+XSAgICBwc3I6IDgwMDAwMDEzCnNwIDogYzdiZDNlNDQgIGlwIDogMDAwMDAwMTggIGZw IDogMDAwMDAzZTkKcjEwOiAwMDAwMDAwMCAgcjkgOiBjN2E5OTU5YyAgcjggOiBjN2JkM2VhYwpy NyA6IGM3YTk5NTkwICByNiA6IGM3YWZiNDM4ICByNSA6IDAwMDAwMzAwICByNCA6IDUxNzE0MzZj CnIzIDogMDAwMDAwNTggIHIyIDogODAwMDAwMDAgIHIxIDogYzdiZTRiZTkgIHIwIDogYzkwNzAz ZTgKRmxhZ3M6IE56Y3YgIElSUXMgb24gIEZJUXMgb24gIE1vZGUgU1ZDXzMyICBJU0EgQVJNICBT ZWdtZW50IG5vbmUKQ29udHJvbDogMDAwNTMxN2YgIFRhYmxlOiAwN2JlODAwMCAgREFDOiAwMDAw MDA1MQpQcm9jZXNzIGRkIChwaWQ6IDY2MCwgc3RhY2sgbGltaXQgPSAweGM3YmQyMTkwKQpTdGFj azogKDB4YzdiZDNlNDQgdG8gMHhjN2JkNDAwMCkKM2U0MDogICAgICAgICAgYzkwNzAzMDAgMDAw MDAwZTkgYzAyOTBkMTQgYzkwNzAzMDAgYzdiZTRiMDAgMDAwMTA0NmYgYzkwNzAwMDAKM2U2MDog YzdhZmI0MTggMDAwMDAwMDAgYzdiZDNlOTggMDAwMDAzZTkgYzdiZDNmODggMDAwMDAzZTkgMDAw MDAwMDAgMDAwYzAwMDgKM2U4MDogMDAwMDAwNTEgYzdiZDIwMDAgYzdiZTQ4MDAgYzAyOGU1N2Mg MDAwMDAzZTkgYzdiZDNlYWMgYzdiZTQ4MDAgMDAwMDAwMDAKM2VhMDogYzdiZjczYzAgYzdhZGRj MDAgMDAwMDAzZTkgMDAwMDAzMDAgMDAwMDAwMDAgMDAwMDAwMDAgMDAwMDAwMDAgMDAwMDAwMDAK M2VjMDogMDAwMDAwMDAgMDAwMDAwMDAgMDAwMDAwMDAgMDAwMDAwMDAgMDAwMDAwMDAgMDAwMDAz ZTkgYzAyOGU0YmMgYzc5NjJhODAKM2VlMDogYzdiZDNmODggMDAwMDAwMDAgYzdiZDIwMDAgMDAw MDAwMDAgMDAwYmY5OTAgYzAwYmRiMGMgMDAwYmY5OTAgYzAwYmQ4NzgKM2YwMDogMDAwMDAwMDAg MDAwMDAwMDAgMDAwMDAwMDAgYzdiZDNmMTAgYzdhNjg4YzAgYzAwOWVlZGMgYzdiZWNiNTggMDAw YzAwMDAKM2YyMDogMDAwMDAwMDMgYzc5NjI0NjAgYzc5NjI0ODQgMDAwMDAwMDAgMDAwMDAwMDAg YzA0NWMyZjggMDAwMDAwMDMgYzAwZDllNTgKM2Y0MDogMDAwMDAzZTkgMDAwYzAwMDggYzc5NjJh ODAgYzdiZDNmODggMDAwMDAwMDAgYzdiZDIwMDAgMDAwMDAwMDAgYzAwYmRkYjQKM2Y2MDogMDAw YmY5OTAgYzAwYmRhNmMgMDAwMDAwMDAgYzc5NjJhODAgYzc5NjJhODAgMDAwYzAwMDggMDAwMDAz ZTkgYzAwMGE4MDQKM2Y4MDogYzdiZDIwMDAgYzAwYmRmYTQgMDAwMDAwMDAgMDAwMDAwMDAgMDAw MDAwMDAgMDAwYmZkOTQgMDAwMDAwMDEgMDAwYzAwMDgKM2ZhMDogMDAwMDAwMDQgYzAwMGE2NDAg MDAwYmZkOTQgMDAwMDAwMDEgMDAwMDAwMDEgMDAwYzAwMDggMDAwMDAzZTkgYmU4ZThmNTMKM2Zj MDogMDAwYmZkOTQgMDAwMDAwMDEgMDAwYzAwMDggMDAwMDAwMDQgMDAwYzAwMDggMDAwYzAwMDgg MDAwMDAzZTkgMDAwYmY5OTAKM2ZlMDogMDAwMDAwMDAgYmU4ZThiYTQgMDAwMGVhM2MgYjZlYmE3 ZWMgNjAwMDAwMTAgMDAwMDAwMDEgMDAwMDAwMDAgMDAwMDAwMDAKWzxjMDQ0MzQ0Yz5dIChtZW1j cHkpIGZyb20gWzxjMDI5MGQxND5dIChzcGVhcl9tdGRfd3JpdGUrMHgyNDAvMHgyOTQpCls8YzAy OTBkMTQ+XSAoc3BlYXJfbXRkX3dyaXRlKSBmcm9tIFs8YzAyOGU1N2M+XSAobXRkY2hhcl93cml0 ZSsweGMwLzB4MjMwKQpbPGMwMjhlNTdjPl0gKG10ZGNoYXJfd3JpdGUpIGZyb20gWzxjMDBiZGIw Yz5dIChfX3Zmc193cml0ZSsweDFjLzB4MTI4KQpbPGMwMGJkYjBjPl0gKF9fdmZzX3dyaXRlKSBm cm9tIFs8YzAwYmRkYjQ+XSAodmZzX3dyaXRlKzB4YTAvMHgxNjgpCls8YzAwYmRkYjQ+XSAodmZz X3dyaXRlKSBmcm9tIFs8YzAwYmRmYTQ+XSAoU3lTX3dyaXRlKzB4M2MvMHg5MCkKWzxjMDBiZGZh ND5dIChTeVNfd3JpdGUpIGZyb20gWzxjMDAwYTY0MD5dIChyZXRfZmFzdF9zeXNjYWxsKzB4MC8w eDQ0KQpDb2RlOiBlMWIwMmY4MiAxNGQxMzAwMSAyNGQxNDAwMSAyNGQxYzAwMSAoMTRjMDMwMDEp IAotLS1bIGVuZCB0cmFjZSBmOWE3MzZjYzI4NDFjZjE0IF0tLS0KU2VnbWVudGF0aW9uIGZhdWx0 CgoKVGhhbmtzLApNaXF1w6hsCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX18KTGludXggTVREIGRpc2N1c3Npb24gbWFpbGluZyBsaXN0Cmh0dHA6 Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtbXRkLwo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A88DACA9EA0 for ; Tue, 22 Oct 2019 09:17:20 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 797C72064B for ; Tue, 22 Oct 2019 09:17:20 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="VBJ5xe53" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 797C72064B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=KqWxkyUwX8qv3RQqYWmELMzhHKNx4UrTCsJljFCeyv4=; b=VBJ5xe53EYu5t1 zSXUYOIYX+M3qQzPZsluJzj9UpUY8jM7k+PBD0ekxzL9zdRtcAViB6NTfj4xeFsq4DL97+bRF1jV3 fl0WxpRBbwxEMdYMMPDoLWuhhddj8ytV/dIEX6m4vDVOLsio+f1+QULiKOjV//Bc/YIizh4ZAOZfu 0+CtXYrHEn06DjJau5i7NjFCCgdWHQGlJc7KK4+jMDpKGDejA2mPcOyKgwRIQ5vfKWZp102x6Z9P8 VNhbwl4vaSzY6km5ZqlVBThMrsxLn+bRqG+bdYg0EgL1tuh4DrpG8rvyN7hwMfMbagYTKU+fpgqOx 1RY+uLjqu3HcWlmfUzgg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iMqI3-0001Cl-Qe; Tue, 22 Oct 2019 09:17:19 +0000 Received: from relay12.mail.gandi.net ([217.70.178.232]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iMqI0-0001C9-HA; Tue, 22 Oct 2019 09:17:18 +0000 Received: from xps13 (lfbn-1-17395-211.w86-250.abo.wanadoo.fr [86.250.200.211]) (Authenticated sender: miquel.raynal@bootlin.com) by relay12.mail.gandi.net (Postfix) with ESMTPSA id A20A320001B; Tue, 22 Oct 2019 09:17:08 +0000 (UTC) Date: Tue, 22 Oct 2019 11:17:07 +0200 From: Miquel Raynal To: Russell King - ARM Linux admin Subject: Re: [PATCH] mtd: spear_smi: Fix nonalignment not handled in memcpy_toio Message-ID: <20191022111707.4b117b99@xps13> In-Reply-To: <20191022082643.GO25745@shell.armlinux.org.uk> References: <20191018143643.29676-1-miquel.raynal@bootlin.com> <20191022082643.GO25745@shell.armlinux.org.uk> Organization: Bootlin X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191022_021716_864531_44338164 X-CRM114-Status: GOOD ( 17.39 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Vignesh Raghavendra , Tudor Ambarus , Richard Weinberger , stable@vger.kernel.org, Marek Vasut , Boris Brezillon , linux-mtd@lists.infradead.org, Thomas Petazzoni , Brian Norris , David Woodhouse , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org SGkgUnVzc2VsbCwKClJ1c3NlbGwgS2luZyAtIEFSTSBMaW51eCBhZG1pbiA8bGludXhAYXJtbGlu dXgub3JnLnVrPiB3cm90ZSBvbiBUdWUsIDIyCk9jdCAyMDE5IDA5OjI2OjQzICswMTAwOgoKPiBP biBGcmksIE9jdCAxOCwgMjAxOSBhdCAwNDozNjo0M1BNICswMjAwLCBNaXF1ZWwgUmF5bmFsIHdy b3RlOgo+ID4gQW55IHdyaXRlIHdpdGggZWl0aGVyIGRkIG9yIGZsYXNoY3AgdG8gYSBkZXZpY2Ug ZHJpdmVuIGJ5IHRoZQo+ID4gc3BlYXJfc21pLmMgZHJpdmVyIHdpbGwgcGFzcyB0aHJvdWdoIHRo ZSBzcGVhcl9zbWlfY3B5X3RvaW8oKQo+ID4gZnVuY3Rpb24uIFRoaXMgZnVuY3Rpb24gd2lsbCBn ZXQgY2FsbGVkIGZvciBjaHVua3Mgb2YgdXAgdG8gMjU2IGJ5dGVzLgo+ID4gSWYgdGhlIGFtb3Vu dCBvZiBkYXRhIGlzIHNtYWxsZXIsIHdlIG1heSBoYXZlIGEgcHJvYmxlbSBpZiB0aGUgZGF0YQo+ ID4gbGVuZ3RoIGlzIG5vdCA0LWJ5dGUgYWxpZ25lZC4gSW4gdGhpcyBzaXR1YXRpb24sIHRoZSBr ZXJuZWwgcGFuaWNzCj4gPiBkdXJpbmcgdGhlIG1lbWNweToKPiA+IAo+ID4gICAgICMgZGQgaWY9 L2Rldi91cmFuZG9tIGJzPTEwMDEgY291bnQ9MSBvZj0vZGV2L210ZDYKPiA+ICAgICBzcGVhcl9z bWlfY3B5X3RvaW8gWzYyMF0gZGVzdCBjOTA3MDAwMCwgc3JjIGM3YmU4ODAwLCBsZW4gMjU2Cj4g PiAgICAgc3BlYXJfc21pX2NweV90b2lvIFs2MjBdIGRlc3QgYzkwNzAxMDAsIHNyYyBjN2JlODkw MCwgbGVuIDI1Ngo+ID4gICAgIHNwZWFyX3NtaV9jcHlfdG9pbyBbNjIwXSBkZXN0IGM5MDcwMjAw LCBzcmMgYzdiZThhMDAsIGxlbiAyNTYKPiA+ICAgICBzcGVhcl9zbWlfY3B5X3RvaW8gWzYyMF0g ZGVzdCBjOTA3MDMwMCwgc3JjIGM3YmU4YjAwLCBsZW4gMjMzCj4gPiAgICAgVW5oYW5kbGVkIGZh dWx0OiBleHRlcm5hbCBhYm9ydCBvbiBub24tbGluZWZldGNoICgweDgwOCkgYXQgMHhjOTA3MDNl OAo+ID4gICAgIFsuLi5dCj4gPiAgICAgUEMgaXMgYXQgbWVtY3B5KzB4Y2MvMHgzMzAgIAo+IAo+ IEkgbmVlZCB0aGUgZnVsbCBvb3BzIGlmIHlvdSB3YW50IG1lIHRvIGNvbW1lbnQgb24gdGhpcy4K CkZZSSwgSSByYW4gdGhlIGRkIGNvbW1hbmQgd2l0aGluIGEgZm9yIGxvb3AsIGluY3JlbWVudGlu ZyB0aGUgYmxvY2sgc2l6ZQooYnMpIGJ5IG9uZSBieXRlLCBpZiBmYWlsZWQgd2l0aCBicz02LgoK RGlzYWJsaW5nIFdCX01PREUgKGJ1cnN0IG1vZGUpIGRvZXMgbm90IGNoYW5nZSBhbnl0aGluZy4K CkFkZGluZyBhIHdtYigpIHJpZ2h0IGFmdGVyIHRoZSBtZW1jcHlfdG9pbygpIHByZXZlbnRzIHRo ZSBmYXVsdC4KCkhlcmUgaXMgdGhlIGZ1bGwgdHJhY2Ugd2hlbiB3cml0aW5nIDEwMDEgYnl0ZXM6 CgojIGRkIGlmPS9kZXYvdXJhbmRvbSBicz0xMDAxIGNvdW50PTEgb2Y9L2Rldi9tdGQ2ClVuaGFu ZGxlZCBmYXVsdDogZXh0ZXJuYWwgYWJvcnQgb24gbm9uLWxpbmVmZXRjaCAoMHg4MDgpIGF0IDB4 YzkwNzAzZTgKcGdkID0gYzdiZTgwMDAKW2M5MDcwM2U4XSAqcGdkPWY4MDAwNDUyKGJhZCkKSW50 ZXJuYWwgZXJyb3I6IDogODA4IFsjMV0gQVJNCk1vZHVsZXMgbGlua2VkIGluOgpDUFU6IDAgUElE OiA2NjAgQ29tbTogZGQgTm90IHRhaW50ZWQgNC4xNC4wLTAwMDQ1LWdmNWQwODE5MjcwNGYtZGly dHkgIzYKSGFyZHdhcmUgbmFtZTogU1QgU1BFQXI2MDAgKEZsYXR0ZW5lZCBEZXZpY2UgVHJlZSkK dGFzazogYzdhMDUwODAgdGFzay5zdGFjazogYzdiZDIwMDAKUEMgaXMgYXQgbWVtY3B5KzB4Y2Mv MHgzMzAKTFIgaXMgYXQgMHgxM2YwZWMyOApwYyA6IFs8YzA0NDM0NGM+XSAgICBsciA6IFs8MTNm MGVjMjg+XSAgICBwc3I6IDgwMDAwMDEzCnNwIDogYzdiZDNlNDQgIGlwIDogMDAwMDAwMTggIGZw IDogMDAwMDAzZTkKcjEwOiAwMDAwMDAwMCAgcjkgOiBjN2E5OTU5YyAgcjggOiBjN2JkM2VhYwpy NyA6IGM3YTk5NTkwICByNiA6IGM3YWZiNDM4ICByNSA6IDAwMDAwMzAwICByNCA6IDUxNzE0MzZj CnIzIDogMDAwMDAwNTggIHIyIDogODAwMDAwMDAgIHIxIDogYzdiZTRiZTkgIHIwIDogYzkwNzAz ZTgKRmxhZ3M6IE56Y3YgIElSUXMgb24gIEZJUXMgb24gIE1vZGUgU1ZDXzMyICBJU0EgQVJNICBT ZWdtZW50IG5vbmUKQ29udHJvbDogMDAwNTMxN2YgIFRhYmxlOiAwN2JlODAwMCAgREFDOiAwMDAw MDA1MQpQcm9jZXNzIGRkIChwaWQ6IDY2MCwgc3RhY2sgbGltaXQgPSAweGM3YmQyMTkwKQpTdGFj azogKDB4YzdiZDNlNDQgdG8gMHhjN2JkNDAwMCkKM2U0MDogICAgICAgICAgYzkwNzAzMDAgMDAw MDAwZTkgYzAyOTBkMTQgYzkwNzAzMDAgYzdiZTRiMDAgMDAwMTA0NmYgYzkwNzAwMDAKM2U2MDog YzdhZmI0MTggMDAwMDAwMDAgYzdiZDNlOTggMDAwMDAzZTkgYzdiZDNmODggMDAwMDAzZTkgMDAw MDAwMDAgMDAwYzAwMDgKM2U4MDogMDAwMDAwNTEgYzdiZDIwMDAgYzdiZTQ4MDAgYzAyOGU1N2Mg MDAwMDAzZTkgYzdiZDNlYWMgYzdiZTQ4MDAgMDAwMDAwMDAKM2VhMDogYzdiZjczYzAgYzdhZGRj MDAgMDAwMDAzZTkgMDAwMDAzMDAgMDAwMDAwMDAgMDAwMDAwMDAgMDAwMDAwMDAgMDAwMDAwMDAK M2VjMDogMDAwMDAwMDAgMDAwMDAwMDAgMDAwMDAwMDAgMDAwMDAwMDAgMDAwMDAwMDAgMDAwMDAz ZTkgYzAyOGU0YmMgYzc5NjJhODAKM2VlMDogYzdiZDNmODggMDAwMDAwMDAgYzdiZDIwMDAgMDAw MDAwMDAgMDAwYmY5OTAgYzAwYmRiMGMgMDAwYmY5OTAgYzAwYmQ4NzgKM2YwMDogMDAwMDAwMDAg MDAwMDAwMDAgMDAwMDAwMDAgYzdiZDNmMTAgYzdhNjg4YzAgYzAwOWVlZGMgYzdiZWNiNTggMDAw YzAwMDAKM2YyMDogMDAwMDAwMDMgYzc5NjI0NjAgYzc5NjI0ODQgMDAwMDAwMDAgMDAwMDAwMDAg YzA0NWMyZjggMDAwMDAwMDMgYzAwZDllNTgKM2Y0MDogMDAwMDAzZTkgMDAwYzAwMDggYzc5NjJh ODAgYzdiZDNmODggMDAwMDAwMDAgYzdiZDIwMDAgMDAwMDAwMDAgYzAwYmRkYjQKM2Y2MDogMDAw YmY5OTAgYzAwYmRhNmMgMDAwMDAwMDAgYzc5NjJhODAgYzc5NjJhODAgMDAwYzAwMDggMDAwMDAz ZTkgYzAwMGE4MDQKM2Y4MDogYzdiZDIwMDAgYzAwYmRmYTQgMDAwMDAwMDAgMDAwMDAwMDAgMDAw MDAwMDAgMDAwYmZkOTQgMDAwMDAwMDEgMDAwYzAwMDgKM2ZhMDogMDAwMDAwMDQgYzAwMGE2NDAg MDAwYmZkOTQgMDAwMDAwMDEgMDAwMDAwMDEgMDAwYzAwMDggMDAwMDAzZTkgYmU4ZThmNTMKM2Zj MDogMDAwYmZkOTQgMDAwMDAwMDEgMDAwYzAwMDggMDAwMDAwMDQgMDAwYzAwMDggMDAwYzAwMDgg MDAwMDAzZTkgMDAwYmY5OTAKM2ZlMDogMDAwMDAwMDAgYmU4ZThiYTQgMDAwMGVhM2MgYjZlYmE3 ZWMgNjAwMDAwMTAgMDAwMDAwMDEgMDAwMDAwMDAgMDAwMDAwMDAKWzxjMDQ0MzQ0Yz5dIChtZW1j cHkpIGZyb20gWzxjMDI5MGQxND5dIChzcGVhcl9tdGRfd3JpdGUrMHgyNDAvMHgyOTQpCls8YzAy OTBkMTQ+XSAoc3BlYXJfbXRkX3dyaXRlKSBmcm9tIFs8YzAyOGU1N2M+XSAobXRkY2hhcl93cml0 ZSsweGMwLzB4MjMwKQpbPGMwMjhlNTdjPl0gKG10ZGNoYXJfd3JpdGUpIGZyb20gWzxjMDBiZGIw Yz5dIChfX3Zmc193cml0ZSsweDFjLzB4MTI4KQpbPGMwMGJkYjBjPl0gKF9fdmZzX3dyaXRlKSBm cm9tIFs8YzAwYmRkYjQ+XSAodmZzX3dyaXRlKzB4YTAvMHgxNjgpCls8YzAwYmRkYjQ+XSAodmZz X3dyaXRlKSBmcm9tIFs8YzAwYmRmYTQ+XSAoU3lTX3dyaXRlKzB4M2MvMHg5MCkKWzxjMDBiZGZh ND5dIChTeVNfd3JpdGUpIGZyb20gWzxjMDAwYTY0MD5dIChyZXRfZmFzdF9zeXNjYWxsKzB4MC8w eDQ0KQpDb2RlOiBlMWIwMmY4MiAxNGQxMzAwMSAyNGQxNDAwMSAyNGQxYzAwMSAoMTRjMDMwMDEp IAotLS1bIGVuZCB0cmFjZSBmOWE3MzZjYzI4NDFjZjE0IF0tLS0KU2VnbWVudGF0aW9uIGZhdWx0 CgoKVGhhbmtzLApNaXF1w6hsCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fXwpsaW51eC1hcm0ta2VybmVsIG1haWxpbmcgbGlzdApsaW51eC1hcm0ta2VybmVs QGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9s aXN0aW5mby9saW51eC1hcm0ta2VybmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C1C62CA9EA0 for ; Tue, 22 Oct 2019 09:17:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9EB062064B for ; Tue, 22 Oct 2019 09:17:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388155AbfJVJRN convert rfc822-to-8bit (ORCPT ); Tue, 22 Oct 2019 05:17:13 -0400 Received: from relay12.mail.gandi.net ([217.70.178.232]:50863 "EHLO relay12.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388006AbfJVJRN (ORCPT ); Tue, 22 Oct 2019 05:17:13 -0400 Received: from xps13 (lfbn-1-17395-211.w86-250.abo.wanadoo.fr [86.250.200.211]) (Authenticated sender: miquel.raynal@bootlin.com) by relay12.mail.gandi.net (Postfix) with ESMTPSA id A20A320001B; Tue, 22 Oct 2019 09:17:08 +0000 (UTC) Date: Tue, 22 Oct 2019 11:17:07 +0200 From: Miquel Raynal To: Russell King - ARM Linux admin Cc: Richard Weinberger , David Woodhouse , Brian Norris , Marek Vasut , Tudor Ambarus , Vignesh Raghavendra , stable@vger.kernel.org, Boris Brezillon , linux-mtd@lists.infradead.org, Thomas Petazzoni , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] mtd: spear_smi: Fix nonalignment not handled in memcpy_toio Message-ID: <20191022111707.4b117b99@xps13> In-Reply-To: <20191022082643.GO25745@shell.armlinux.org.uk> References: <20191018143643.29676-1-miquel.raynal@bootlin.com> <20191022082643.GO25745@shell.armlinux.org.uk> Organization: Bootlin X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org Hi Russell, Russell King - ARM Linux admin wrote on Tue, 22 Oct 2019 09:26:43 +0100: > On Fri, Oct 18, 2019 at 04:36:43PM +0200, Miquel Raynal wrote: > > Any write with either dd or flashcp to a device driven by the > > spear_smi.c driver will pass through the spear_smi_cpy_toio() > > function. This function will get called for chunks of up to 256 bytes. > > If the amount of data is smaller, we may have a problem if the data > > length is not 4-byte aligned. In this situation, the kernel panics > > during the memcpy: > > > > # dd if=/dev/urandom bs=1001 count=1 of=/dev/mtd6 > > spear_smi_cpy_toio [620] dest c9070000, src c7be8800, len 256 > > spear_smi_cpy_toio [620] dest c9070100, src c7be8900, len 256 > > spear_smi_cpy_toio [620] dest c9070200, src c7be8a00, len 256 > > spear_smi_cpy_toio [620] dest c9070300, src c7be8b00, len 233 > > Unhandled fault: external abort on non-linefetch (0x808) at 0xc90703e8 > > [...] > > PC is at memcpy+0xcc/0x330 > > I need the full oops if you want me to comment on this. FYI, I ran the dd command within a for loop, incrementing the block size (bs) by one byte, if failed with bs=6. Disabling WB_MODE (burst mode) does not change anything. Adding a wmb() right after the memcpy_toio() prevents the fault. Here is the full trace when writing 1001 bytes: # dd if=/dev/urandom bs=1001 count=1 of=/dev/mtd6 Unhandled fault: external abort on non-linefetch (0x808) at 0xc90703e8 pgd = c7be8000 [c90703e8] *pgd=f8000452(bad) Internal error: : 808 [#1] ARM Modules linked in: CPU: 0 PID: 660 Comm: dd Not tainted 4.14.0-00045-gf5d08192704f-dirty #6 Hardware name: ST SPEAr600 (Flattened Device Tree) task: c7a05080 task.stack: c7bd2000 PC is at memcpy+0xcc/0x330 LR is at 0x13f0ec28 pc : [] lr : [<13f0ec28>] psr: 80000013 sp : c7bd3e44 ip : 00000018 fp : 000003e9 r10: 00000000 r9 : c7a9959c r8 : c7bd3eac r7 : c7a99590 r6 : c7afb438 r5 : 00000300 r4 : 5171436c r3 : 00000058 r2 : 80000000 r1 : c7be4be9 r0 : c90703e8 Flags: Nzcv IRQs on FIQs on Mode SVC_32 ISA ARM Segment none Control: 0005317f Table: 07be8000 DAC: 00000051 Process dd (pid: 660, stack limit = 0xc7bd2190) Stack: (0xc7bd3e44 to 0xc7bd4000) 3e40: c9070300 000000e9 c0290d14 c9070300 c7be4b00 0001046f c9070000 3e60: c7afb418 00000000 c7bd3e98 000003e9 c7bd3f88 000003e9 00000000 000c0008 3e80: 00000051 c7bd2000 c7be4800 c028e57c 000003e9 c7bd3eac c7be4800 00000000 3ea0: c7bf73c0 c7addc00 000003e9 00000300 00000000 00000000 00000000 00000000 3ec0: 00000000 00000000 00000000 00000000 00000000 000003e9 c028e4bc c7962a80 3ee0: c7bd3f88 00000000 c7bd2000 00000000 000bf990 c00bdb0c 000bf990 c00bd878 3f00: 00000000 00000000 00000000 c7bd3f10 c7a688c0 c009eedc c7becb58 000c0000 3f20: 00000003 c7962460 c7962484 00000000 00000000 c045c2f8 00000003 c00d9e58 3f40: 000003e9 000c0008 c7962a80 c7bd3f88 00000000 c7bd2000 00000000 c00bddb4 3f60: 000bf990 c00bda6c 00000000 c7962a80 c7962a80 000c0008 000003e9 c000a804 3f80: c7bd2000 c00bdfa4 00000000 00000000 00000000 000bfd94 00000001 000c0008 3fa0: 00000004 c000a640 000bfd94 00000001 00000001 000c0008 000003e9 be8e8f53 3fc0: 000bfd94 00000001 000c0008 00000004 000c0008 000c0008 000003e9 000bf990 3fe0: 00000000 be8e8ba4 0000ea3c b6eba7ec 60000010 00000001 00000000 00000000 [] (memcpy) from [] (spear_mtd_write+0x240/0x294) [] (spear_mtd_write) from [] (mtdchar_write+0xc0/0x230) [] (mtdchar_write) from [] (__vfs_write+0x1c/0x128) [] (__vfs_write) from [] (vfs_write+0xa0/0x168) [] (vfs_write) from [] (SyS_write+0x3c/0x90) [] (SyS_write) from [] (ret_fast_syscall+0x0/0x44) Code: e1b02f82 14d13001 24d14001 24d1c001 (14c03001) ---[ end trace f9a736cc2841cf14 ]--- Segmentation fault Thanks, Miquèl