From: Anatolij Gustschin <agust@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] imx: imx8: fix loading container image from eMMC boot partitions
Date: Tue, 22 Oct 2019 12:16:52 +0200 [thread overview]
Message-ID: <20191022121652.6ed5674b@crub> (raw)
In-Reply-To: <AM0PR04MB448179F5527773C12197C8BE88680@AM0PR04MB4481.eurprd04.prod.outlook.com>
On Tue, 22 Oct 2019 10:08:42 +0000
Peng Fan peng.fan at nxp.com wrote:
...
> > > From common/spl/spl_mmc.c, there is boot partition switch there, Why
> > > need to add such logic in imx8/image.c?
> >
> > spl_mmc_load() reads the container header before partition switching.
>
> Oh. Indeeded. Not took care of emmc when adding spl_mmc_get_uboot_raw_sector (:
I think we should avoid adding partition switching in get_container_size(),
it looks like container header is read several times which is suboptimal.
I'll have to rethink this patch, don't have time for this now.
--
Anatolij
next prev parent reply other threads:[~2019-10-22 10:16 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-21 15:21 [U-Boot] [PATCH] imx: imx8: fix loading container image from eMMC boot partitions Anatolij Gustschin
2019-10-22 2:43 ` Peng Fan
2019-10-22 7:34 ` Anatolij Gustschin
2019-10-22 8:13 ` Peng Fan
2019-10-22 9:49 ` Anatolij Gustschin
2019-10-22 10:08 ` Peng Fan
2019-10-22 10:16 ` Anatolij Gustschin [this message]
2019-10-22 10:18 ` Peng Fan
2019-10-22 10:19 ` Anatolij Gustschin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191022121652.6ed5674b@crub \
--to=agust@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.