From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH v3 08/13] drm/bridge: analogix-anx78xx: Avoid drm_dp_link helpers Date: Tue, 22 Oct 2019 15:29:06 +0200 Message-ID: <20191022132906.GK11828@phenom.ffwll.local> References: <20191021143437.1477719-1-thierry.reding@gmail.com> <20191021143437.1477719-9-thierry.reding@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wr1-x443.google.com (mail-wr1-x443.google.com [IPv6:2a00:1450:4864:20::443]) by gabe.freedesktop.org (Postfix) with ESMTPS id 708F96E7B2 for ; Tue, 22 Oct 2019 13:29:15 +0000 (UTC) Received: by mail-wr1-x443.google.com with SMTP id q13so13102773wrs.12 for ; Tue, 22 Oct 2019 06:29:15 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20191021143437.1477719-9-thierry.reding@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Thierry Reding Cc: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org T24gTW9uLCBPY3QgMjEsIDIwMTkgYXQgMDQ6MzQ6MzJQTSArMDIwMCwgVGhpZXJyeSBSZWRpbmcg d3JvdGU6Cj4gRnJvbTogVGhpZXJyeSBSZWRpbmcgPHRyZWRpbmdAbnZpZGlhLmNvbT4KPiAKPiBE dXJpbmcgdGhlIGRpc2N1c3Npb24gb2YgcGF0Y2hlcyB0aGF0IGVuaGFuY2UgdGhlIGRybV9kcF9s aW5rIGhlbHBlcnMgaXQKPiB3YXMgY29uY2x1ZGVkIHRoYXQgdGhlc2UgaGVscGVycyBhcmVuJ3Qg dmVyeSB1c2VmdWwgdG8gYmVnaW4gd2l0aC4gU3RhcnQKPiBwdXNoaW5nIHRoZSBlcXVpdmFsZW50 IGNvZGUgaW50byBpbmRpdmlkdWFsIGRyaXZlcnMgdG8gdWx0aW1hdGVseSByZW1vdmUKPiB0aGVt Lgo+IAo+IFNpZ25lZC1vZmYtYnk6IFRoaWVycnkgUmVkaW5nIDx0cmVkaW5nQG52aWRpYS5jb20+ Cj4gLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9icmlkZ2UvYW5hbG9naXgtYW54Nzh4eC5jIHwgNTcg KysrKysrKysrKysrKysrKystLS0tLS0KPiAgMSBmaWxlIGNoYW5nZWQsIDQyIGluc2VydGlvbnMo KyksIDE1IGRlbGV0aW9ucygtKQo+IAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vYnJp ZGdlL2FuYWxvZ2l4LWFueDc4eHguYyBiL2RyaXZlcnMvZ3B1L2RybS9icmlkZ2UvYW5hbG9naXgt YW54Nzh4eC5jCj4gaW5kZXggOWRkYzFmM2NmODQxLi44YmI0NzkzZjM4MmIgMTAwNjQ0Cj4gLS0t IGEvZHJpdmVycy9ncHUvZHJtL2JyaWRnZS9hbmFsb2dpeC1hbng3OHh4LmMKPiArKysgYi9kcml2 ZXJzL2dwdS9kcm0vYnJpZGdlL2FuYWxvZ2l4LWFueDc4eHguYwo+IEBAIC03MSw3ICs3MSw2IEBA IHN0cnVjdCBhbng3OHh4IHsKPiAgCXN0cnVjdCBpMmNfY2xpZW50ICpjbGllbnQ7Cj4gIAlzdHJ1 Y3QgZWRpZCAqZWRpZDsKPiAgCXN0cnVjdCBkcm1fY29ubmVjdG9yIGNvbm5lY3RvcjsKPiAtCXN0 cnVjdCBkcm1fZHBfbGluayBsaW5rOwo+ICAJc3RydWN0IGFueDc4eHhfcGxhdGZvcm1fZGF0YSBw ZGF0YTsKPiAgCXN0cnVjdCBtdXRleCBsb2NrOwo+ICAKPiBAQCAtODAxLDE4ICs4MDAsMzQgQEAg c3RhdGljIGludCBhbng3OHh4X2RwX2xpbmtfdHJhaW5pbmcoc3RydWN0IGFueDc4eHggKmFueDc4 eHgpCj4gIAlpZiAoZXJyKQo+ICAJCXJldHVybiBlcnI7Cj4gIAo+IC0JLyogQ2hlY2sgbGluayBj YXBhYmlsaXRpZXMgKi8KPiAtCWVyciA9IGRybV9kcF9saW5rX3Byb2JlKCZhbng3OHh4LT5hdXgs ICZhbng3OHh4LT5saW5rKTsKPiAtCWlmIChlcnIgPCAwKSB7Cj4gLQkJRFJNX0VSUk9SKCJGYWls ZWQgdG8gcHJvYmUgbGluayBjYXBhYmlsaXRpZXM6ICVkXG4iLCBlcnIpOwo+IC0JCXJldHVybiBl cnI7Cj4gLQl9Cj4gKwkvKgo+ICsJICogUG93ZXIgdXAgdGhlIHNpbmsgKERQX1NFVF9QT1dFUiBy ZWdpc3RlciBpcyBvbmx5IGF2YWlsYWJsZSBvbiBEUENECj4gKwkgKiB2MS4xIGFuZCBsYXRlciku Cj4gKwkgKi8KPiArCWlmIChhbng3OHh4LT5kcGNkW0RQX0RQQ0RfUkVWXSA+PSAweDExKSB7Cj4g KwkJZXJyID0gZHJtX2RwX2RwY2RfcmVhZGIoJmFueDc4eHgtPmF1eCwgRFBfU0VUX1BPV0VSLCAm dmFsdWUpOwo+ICsJCWlmIChlcnIgPCAwKSB7Cj4gKwkJCURSTV9FUlJPUigiRmFpbGVkIHRvIHJl YWQgRFBfU0VUX1BPV0VSIHJlZ2lzdGVyOiAlZFxuIiwKPiArCQkJCSAgZXJyKTsKPiArCQkJcmV0 dXJuIGVycjsKPiArCQl9Cj4gIAo+IC0JLyogUG93ZXIgdXAgdGhlIHNpbmsgKi8KPiAtCWVyciA9 IGRybV9kcF9saW5rX3Bvd2VyX3VwKCZhbng3OHh4LT5hdXgsICZhbng3OHh4LT5saW5rKTsKPiAt CWlmIChlcnIgPCAwKSB7Cj4gLQkJRFJNX0VSUk9SKCJGYWlsZWQgdG8gcG93ZXIgdXAgRGlzcGxh eVBvcnQgbGluazogJWRcbiIsIGVycik7Cj4gLQkJcmV0dXJuIGVycjsKPiArCQl2YWx1ZSAmPSB+ RFBfU0VUX1BPV0VSX01BU0s7Cj4gKwkJdmFsdWUgfD0gRFBfU0VUX1BPV0VSX0QwOwo+ICsKPiAr CQllcnIgPSBkcm1fZHBfZHBjZF93cml0ZWIoJmFueDc4eHgtPmF1eCwgRFBfU0VUX1BPV0VSLCB2 YWx1ZSk7Cj4gKwkJaWYgKGVyciA8IDApIHsKPiArCQkJRFJNX0VSUk9SKCJGYWlsZWQgdG8gcG93 ZXIgdXAgRGlzcGxheVBvcnQgbGluazogJWRcbiIsCj4gKwkJCQkgIGVycik7Cj4gKwkJCXJldHVy biBlcnI7Cj4gKwkJfQo+ICsKPiArCQkvKgo+ICsJCSAqIEFjY29yZGluZyB0byB0aGUgRFAgMS4x IHNwZWNpZmljYXRpb24sIGEgIlNpbmsgRGV2aWNlIG11c3QKPiArCQkgKiBleGl0IHRoZSBwb3dl ciBzYXZpbmcgc3RhdGUgd2l0aGluIDEgbXMiIChTZWN0aW9uIDIuNS4zLjEsCj4gKwkJICogVGFi bGUgNS01MiwgIlNpbmsgQ29udHJvbCBGaWVsZCIgKHJlZ2lzdGVyIDB4NjAwKS4KPiArCQkgKi8K PiArCQl1c2xlZXBfcmFuZ2UoMTAwMCwgMjAwMCk7Cj4gIAl9Cj4gIAo+ICAJLyogUG9zc2libHkg ZW5hYmxlIGRvd25zcHJlYWQgb24gdGhlIHNpbmsgKi8KPiBAQCAtODUxLDE1ICs4NjYsMjcgQEAg c3RhdGljIGludCBhbng3OHh4X2RwX2xpbmtfdHJhaW5pbmcoc3RydWN0IGFueDc4eHggKmFueDc4 eHgpCj4gIAlpZiAoZXJyKQo+ICAJCXJldHVybiBlcnI7Cj4gIAo+IC0JdmFsdWUgPSBkcm1fZHBf bGlua19yYXRlX3RvX2J3X2NvZGUoYW54Nzh4eC0+bGluay5yYXRlKTsKPiArCXZhbHVlID0gZHJt X2RwX21heF9saW5rX3JhdGUoYW54Nzh4eC0+ZHBjZCk7Cj4gKwl2YWx1ZSA9IGRybV9kcF9saW5r X3JhdGVfdG9fYndfY29kZSh2YWx1ZSk7Cj4gIAllcnIgPSByZWdtYXBfd3JpdGUoYW54Nzh4eC0+ bWFwW0kyQ19JRFhfVFhfUDBdLAo+ICAJCQkgICBTUF9EUF9NQUlOX0xJTktfQldfU0VUX1JFRywg dmFsdWUpOwo+ICAJaWYgKGVycikKPiAgCQlyZXR1cm4gZXJyOwo+ICAKPiAtCWVyciA9IGRybV9k cF9saW5rX2NvbmZpZ3VyZSgmYW54Nzh4eC0+YXV4LCAmYW54Nzh4eC0+bGluayk7Cj4gKwllcnIg PSBkcm1fZHBfZHBjZF93cml0ZWIoJmFueDc4eHgtPmF1eCwgRFBfTElOS19CV19TRVQsIHZhbHVl KTsKPiArCWlmIChlcnIgPCAwKSB7Cj4gKwkJRFJNX0VSUk9SKCJGYWlsZWQgdG8gc2V0IGxpbmsg YmFuZHdpZHRoOiAlZFxuIiwgZXJyKTsKPiArCQlyZXR1cm4gZXJyOwo+ICsJfQo+ICsKPiArCXZh bHVlID0gZHJtX2RwX21heF9sYW5lX2NvdW50KGFueDc4eHgtPmRwY2QpOwo+ICsKPiArCWlmIChk cm1fZHBfZW5oYW5jZWRfZnJhbWVfY2FwKGFueDc4eHgtPmRwY2QpKQo+ICsJCXZhbHVlIHw9IERQ X0xBTkVfQ09VTlRfRU5IQU5DRURfRlJBTUVfRU47Cj4gKwo+ICsJZXJyID0gZHJtX2RwX2RwY2Rf d3JpdGViKCZhbng3OHh4LT5hdXgsIERQX0xBTkVfQ09VTlRfU0VULCB2YWx1ZSk7Cj4gIAlpZiAo ZXJyIDwgMCkgewo+IC0JCURSTV9FUlJPUigiRmFpbGVkIHRvIGNvbmZpZ3VyZSBEaXNwbGF5UG9y dCBsaW5rOiAlZFxuIiwgZXJyKTsKPiArCQlEUk1fRVJST1IoIkZhaWxlZCB0byBzZXQgbGluayBs YW5lIGNvdW50OiAlZFxuIiwgZXJyKTsKPiAgCQlyZXR1cm4gZXJyOwoKU3BsaXRzIHRoZSBsYXN0 IHR3byB3cml0ZXMgaW50byAyIHRyYW5zYWN0aW9ucywgb3RoZXJ3aXNlIGxvb2tzCmVxdWl2YWxl bnQuCgpSZXZpZXdlZC1ieTogRGFuaWVsIFZldHRlciA8ZGFuaWVsLnZldHRlckBmZndsbC5jaD4K Cj4gIAl9Cj4gIAo+IC0tIAo+IDIuMjMuMAo+IAoKLS0gCkRhbmllbCBWZXR0ZXIKU29mdHdhcmUg RW5naW5lZXIsIEludGVsIENvcnBvcmF0aW9uCmh0dHA6Ly9ibG9nLmZmd2xsLmNoCl9fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5n IGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVk ZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbA==