From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH v3 11/13] drm/msm: edp: Avoid drm_dp_link helpers Date: Tue, 22 Oct 2019 15:53:32 +0200 Message-ID: <20191022135332.GM11828@phenom.ffwll.local> References: <20191021143437.1477719-1-thierry.reding@gmail.com> <20191021143437.1477719-12-thierry.reding@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wm1-x343.google.com (mail-wm1-x343.google.com [IPv6:2a00:1450:4864:20::343]) by gabe.freedesktop.org (Postfix) with ESMTPS id AF0776E7EA for ; Tue, 22 Oct 2019 13:53:37 +0000 (UTC) Received: by mail-wm1-x343.google.com with SMTP id v9so340409wml.0 for ; Tue, 22 Oct 2019 06:53:37 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20191021143437.1477719-12-thierry.reding@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Thierry Reding Cc: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org T24gTW9uLCBPY3QgMjEsIDIwMTkgYXQgMDQ6MzQ6MzVQTSArMDIwMCwgVGhpZXJyeSBSZWRpbmcg d3JvdGU6Cj4gRnJvbTogVGhpZXJyeSBSZWRpbmcgPHRyZWRpbmdAbnZpZGlhLmNvbT4KPiAKPiBE dXJpbmcgdGhlIGRpc2N1c3Npb24gb2YgcGF0Y2hlcyB0aGF0IGVuaGFuY2UgdGhlIGRybV9kcF9s aW5rIGhlbHBlcnMgaXQKPiB3YXMgY29uY2x1ZGVkIHRoYXQgdGhlc2UgaGVscGVycyBhcmVuJ3Qg dmVyeSB1c2VmdWwgdG8gYmVnaW4gd2l0aC4gU3RhcnQKPiBwdXNoaW5nIHRoZSBlcXVpdmFsZW50 IGNvZGUgaW50byBpbmRpdmlkdWFsIGRyaXZlcnMgdG8gdWx0aW1hdGVseSByZW1vdmUKPiB0aGVt Lgo+IAo+IFNpZ25lZC1vZmYtYnk6IFRoaWVycnkgUmVkaW5nIDx0cmVkaW5nQG52aWRpYS5jb20+ Cj4gLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9tc20vZWRwL2VkcF9jdHJsLmMgfCA3MCArKysrKysr KysrKysrKysrKysrKystLS0tLS0tLS0KPiAgMSBmaWxlIGNoYW5nZWQsIDQ5IGluc2VydGlvbnMo KyksIDIxIGRlbGV0aW9ucygtKQo+IAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vbXNt L2VkcC9lZHBfY3RybC5jIGIvZHJpdmVycy9ncHUvZHJtL21zbS9lZHAvZWRwX2N0cmwuYwo+IGlu ZGV4IDdmM2RkM2ZmZTJjOS4uMGQ5NjU3Y2M3MGRiIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1 L2RybS9tc20vZWRwL2VkcF9jdHJsLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vbXNtL2VkcC9l ZHBfY3RybC5jCj4gQEAgLTg5LDcgKzg5LDYgQEAgc3RydWN0IGVkcF9jdHJsIHsKPiAgCS8qIGVk aWQgcmF3IGRhdGEgKi8KPiAgCXN0cnVjdCBlZGlkICplZGlkOwo+ICAKPiAtCXN0cnVjdCBkcm1f ZHBfbGluayBkcF9saW5rOwo+ICAJc3RydWN0IGRybV9kcF9hdXggKmRybV9hdXg7Cj4gIAo+ICAJ LyogZHBjZCByYXcgZGF0YSAqLwo+IEBAIC00MDMsNyArNDAyLDcgQEAgc3RhdGljIHZvaWQgZWRw X2ZpbGxfbGlua19jZmcoc3RydWN0IGVkcF9jdHJsICpjdHJsKQo+ICAJdTMyIHByYXRlOwo+ICAJ dTMyIGxyYXRlOwo+ICAJdTMyIGJwcDsKPiAtCXU4IG1heF9sYW5lID0gY3RybC0+ZHBfbGluay5u dW1fbGFuZXM7Cj4gKwl1OCBtYXhfbGFuZSA9IGRybV9kcF9tYXhfbGFuZV9jb3VudChjdHJsLT5k cGNkKTsKPiAgCXU4IGxhbmU7Cj4gIAo+ICAJcHJhdGUgPSBjdHJsLT5waXhlbF9yYXRlOwo+IEBA IC00MTMsNyArNDEyLDcgQEAgc3RhdGljIHZvaWQgZWRwX2ZpbGxfbGlua19jZmcoc3RydWN0IGVk cF9jdHJsICpjdHJsKQo+ICAJICogQnkgZGVmYXVsdCwgdXNlIHRoZSBtYXhpbXVtIGxpbmsgcmF0 ZSBhbmQgbWluaW11bSBsYW5lIGNvdW50LAo+ICAJICogc28gdGhhdCB3ZSBjYW4gZG8gcmF0ZSBk b3duIHNoaWZ0IGR1cmluZyBsaW5rIHRyYWluaW5nLgo+ICAJICovCj4gLQljdHJsLT5saW5rX3Jh dGUgPSBkcm1fZHBfbGlua19yYXRlX3RvX2J3X2NvZGUoY3RybC0+ZHBfbGluay5yYXRlKTsKPiAr CWN0cmwtPmxpbmtfcmF0ZSA9IGN0cmwtPmRwY2RbRFBfTUFYX0xJTktfUkFURV07Cj4gIAo+ICAJ cHJhdGUgKj0gYnBwOwo+ICAJcHJhdGUgLz0gODsgLyogaW4ga0J5dGUgKi8KPiBAQCAtNDM5LDcg KzQzOCw3IEBAIHN0YXRpYyB2b2lkIGVkcF9jb25maWdfY3RybChzdHJ1Y3QgZWRwX2N0cmwgKmN0 cmwpCj4gIAo+ICAJZGF0YSA9IEVEUF9DT05GSUdVUkFUSU9OX0NUUkxfTEFORVMoY3RybC0+bGFu ZV9jbnQgLSAxKTsKPiAgCj4gLQlpZiAoY3RybC0+ZHBfbGluay5jYXBhYmlsaXRpZXMgJiBEUF9M SU5LX0NBUF9FTkhBTkNFRF9GUkFNSU5HKQo+ICsJaWYgKGRybV9kcF9lbmhhbmNlZF9mcmFtZV9j YXAoY3RybC0+ZHBjZCkpCj4gIAkJZGF0YSB8PSBFRFBfQ09ORklHVVJBVElPTl9DVFJMX0VOSEFO Q0VEX0ZSQU1JTkc7Cj4gIAo+ICAJZGVwdGggPSBFRFBfNkJJVDsKPiBAQCAtNzAxLDcgKzcwMCw3 IEBAIHN0YXRpYyBpbnQgZWRwX2xpbmtfcmF0ZV9kb3duX3NoaWZ0KHN0cnVjdCBlZHBfY3RybCAq Y3RybCkKPiAgCj4gIAlyYXRlID0gY3RybC0+bGlua19yYXRlOwo+ICAJbGFuZSA9IGN0cmwtPmxh bmVfY250Owo+IC0JbWF4X2xhbmUgPSBjdHJsLT5kcF9saW5rLm51bV9sYW5lczsKPiArCW1heF9s YW5lID0gZHJtX2RwX21heF9sYW5lX2NvdW50KGN0cmwtPmRwY2QpOwo+ICAKPiAgCWJwcCA9IGN0 cmwtPmNvbG9yX2RlcHRoICogMzsKPiAgCXByYXRlID0gY3RybC0+cGl4ZWxfcmF0ZTsKPiBAQCAt NzUxLDE4ICs3NTAsMjIgQEAgc3RhdGljIGludCBlZHBfY2xlYXJfdHJhaW5pbmdfcGF0dGVybihz dHJ1Y3QgZWRwX2N0cmwgKmN0cmwpCj4gIAo+ICBzdGF0aWMgaW50IGVkcF9kb19saW5rX3RyYWlu KHN0cnVjdCBlZHBfY3RybCAqY3RybCkKPiAgewo+ICsJdTggdmFsdWVzWzJdOwo+ICAJaW50IHJl dDsKPiAtCXN0cnVjdCBkcm1fZHBfbGluayBkcF9saW5rOwo+ICAKPiAgCURCRygiIik7Cj4gIAkv Kgo+ICAJICogU2V0IHRoZSBjdXJyZW50IGxpbmsgcmF0ZSBhbmQgbGFuZSBjbnQgdG8gcGFuZWwu IFRoZXkgbWF5IGhhdmUgYmVlbgo+ICAJICogYWRqdXN0ZWQgYW5kIHRoZSB2YWx1ZXMgYXJlIGRp ZmZlcmVudCBmcm9tIHRoZW0gaW4gRFBDRCBDQVAKPiAgCSAqLwo+IC0JZHBfbGluay5udW1fbGFu ZXMgPSBjdHJsLT5sYW5lX2NudDsKPiAtCWRwX2xpbmsucmF0ZSA9IGRybV9kcF9id19jb2RlX3Rv X2xpbmtfcmF0ZShjdHJsLT5saW5rX3JhdGUpOwo+IC0JZHBfbGluay5jYXBhYmlsaXRpZXMgPSBj dHJsLT5kcF9saW5rLmNhcGFiaWxpdGllczsKPiAtCWlmIChkcm1fZHBfbGlua19jb25maWd1cmUo Y3RybC0+ZHJtX2F1eCwgJmRwX2xpbmspIDwgMCkKPiArCXZhbHVlc1swXSA9IGN0cmwtPmxhbmVf Y250Owo+ICsJdmFsdWVzWzFdID0gY3RybC0+bGlua19yYXRlOwo+ICsKPiArCWlmIChkcm1fZHBf ZW5oYW5jZWRfZnJhbWVfY2FwKGN0cmwtPmRwY2QpKQo+ICsJCXZhbHVlc1sxXSB8PSBEUF9MQU5F X0NPVU5UX0VOSEFOQ0VEX0ZSQU1FX0VOOwo+ICsKPiArCWlmIChkcm1fZHBfZHBjZF93cml0ZShj dHJsLT5kcm1fYXV4LCBEUF9MSU5LX0JXX1NFVCwgdmFsdWVzLAo+ICsJCQkgICAgICBzaXplb2Yo dmFsdWVzKSkgPCAwKQo+ICAJCXJldHVybiBFRFBfVFJBSU5fRkFJTDsKPiAgCj4gIAljdHJsLT52 X2xldmVsID0gMDsgLyogc3RhcnQgZnJvbSBkZWZhdWx0IGxldmVsICovCj4gQEAgLTk1Miw2ICs5 NTUsNyBAQCBzdGF0aWMgdm9pZCBlZHBfY3RybF9vbl93b3JrZXIoc3RydWN0IHdvcmtfc3RydWN0 ICp3b3JrKQo+ICB7Cj4gIAlzdHJ1Y3QgZWRwX2N0cmwgKmN0cmwgPSBjb250YWluZXJfb2YoCj4g IAkJCQl3b3JrLCBzdHJ1Y3QgZWRwX2N0cmwsIG9uX3dvcmspOwo+ICsJdTggdmFsdWU7Cj4gIAlp bnQgcmV0Owo+ICAKPiAgCW11dGV4X2xvY2soJmN0cmwtPmRldl9tdXRleCk7Cj4gQEAgLTk2NSw5 ICs5NjksMjcgQEAgc3RhdGljIHZvaWQgZWRwX2N0cmxfb25fd29ya2VyKHN0cnVjdCB3b3JrX3N0 cnVjdCAqd29yaykKPiAgCWVkcF9jdHJsX2xpbmtfZW5hYmxlKGN0cmwsIDEpOwo+ICAKPiAgCWVk cF9jdHJsX2lycV9lbmFibGUoY3RybCwgMSk7Cj4gLQlyZXQgPSBkcm1fZHBfbGlua19wb3dlcl91 cChjdHJsLT5kcm1fYXV4LCAmY3RybC0+ZHBfbGluayk7Cj4gLQlpZiAocmV0KQo+IC0JCWdvdG8g ZmFpbDsKPiArCj4gKwkvKiBEUF9TRVRfUE9XRVIgcmVnaXN0ZXIgaXMgb25seSBhdmFpbGFibGUg b24gRFBDRCB2MS4xIGFuZCBsYXRlciAqLwo+ICsJaWYgKGN0cmwtPmRwY2RbRFBfRFBDRF9SRVZd ID49IDB4MTEpIHsKPiArCQlyZXQgPSBkcm1fZHBfZHBjZF9yZWFkYihjdHJsLT5kcm1fYXV4LCBE UF9TRVRfUE9XRVIsICZ2YWx1ZSk7Cj4gKwkJaWYgKHJldCA8IDApCj4gKwkJCWdvdG8gZmFpbDsK PiArCj4gKwkJdmFsdWUgJj0gfkRQX1NFVF9QT1dFUl9NQVNLOwo+ICsJCXZhbHVlIHw9IERQX1NF VF9QT1dFUl9EMDsKPiArCj4gKwkJcmV0ID0gZHJtX2RwX2RwY2Rfd3JpdGViKGN0cmwtPmRybV9h dXgsIERQX1NFVF9QT1dFUiwgdmFsdWUpOwo+ICsJCWlmIChyZXQgPCAwKQo+ICsJCQlnb3RvIGZh aWw7Cj4gKwo+ICsJCS8qCj4gKwkJICogQWNjb3JkaW5nIHRvIHRoZSBEUCAxLjEgc3BlY2lmaWNh dGlvbiwgYSAiU2luayBEZXZpY2UgbXVzdAo+ICsJCSAqIGV4aXQgdGhlIHBvd2VyIHNhdmluZyBz dGF0ZSB3aXRoaW4gMSBtcyIgKFNlY3Rpb24gMi41LjMuMSwKPiArCQkgKiBUYWJsZSA1LTUyLCAi U2luayBDb250cm9sIEZpZWxkIiAocmVnaXN0ZXIgMHg2MDApLgo+ICsJCSAqLwo+ICsJCXVzbGVl cF9yYW5nZSgxMDAwLCAyMDAwKTsKPiArCX0KPiAgCj4gIAljdHJsLT5wb3dlcl9vbiA9IHRydWU7 Cj4gIAo+IEBAIC0xMDExLDcgKzEwMzMsMTkgQEAgc3RhdGljIHZvaWQgZWRwX2N0cmxfb2ZmX3dv cmtlcihzdHJ1Y3Qgd29ya19zdHJ1Y3QgKndvcmspCj4gIAo+ICAJZWRwX3N0YXRlX2N0cmwoY3Ry bCwgMCk7Cj4gIAo+IC0JZHJtX2RwX2xpbmtfcG93ZXJfZG93bihjdHJsLT5kcm1fYXV4LCAmY3Ry bC0+ZHBfbGluayk7Cj4gKwkvKiBEUF9TRVRfUE9XRVIgcmVnaXN0ZXIgaXMgb25seSBhdmFpbGFi bGUgb24gRFBDRCB2MS4xIGFuZCBsYXRlciAqLwo+ICsJaWYgKGN0cmwtPmRwY2RbRFBfRFBDRF9S RVZdID49IDB4MTEpIHsKPiArCQl1OCB2YWx1ZTsKPiArCQlpbnQgcmV0Owo+ICsKPiArCQlyZXQg PSBkcm1fZHBfZHBjZF9yZWFkYihjdHJsLT5kcm1fYXV4LCBEUF9TRVRfUE9XRVIsICZ2YWx1ZSk7 Cj4gKwkJaWYgKHJldCA+IDApIHsKPiArCQkJdmFsdWUgJj0gfkRQX1NFVF9QT1dFUl9NQVNLOwo+ ICsJCQl2YWx1ZSB8PSBEUF9TRVRfUE9XRVJfRDM7Cj4gKwo+ICsJCQlkcm1fZHBfZHBjZF93cml0 ZWIoY3RybC0+ZHJtX2F1eCwgRFBfU0VUX1BPV0VSLCB2YWx1ZSk7Cj4gKwkJfQo+ICsJfQo+ICAK PiAgCWVkcF9jdHJsX2lycV9lbmFibGUoY3RybCwgMCk7Cj4gIAo+IEBAIC0xMjI1LDE0ICsxMjU5 LDggQEAgaW50IG1zbV9lZHBfY3RybF9nZXRfcGFuZWxfaW5mbyhzdHJ1Y3QgZWRwX2N0cmwgKmN0 cmwsCj4gIAkJZWRwX2N0cmxfaXJxX2VuYWJsZShjdHJsLCAxKTsKPiAgCX0KPiAgCj4gLQlyZXQg PSBkcm1fZHBfbGlua19wcm9iZShjdHJsLT5kcm1fYXV4LCAmY3RybC0+ZHBfbGluayk7Cj4gLQlp ZiAocmV0KSB7Cj4gLQkJcHJfZXJyKCIlczogcmVhZCBkcGNkIGNhcCBmYWlsZWQsICVkXG4iLCBf X2Z1bmNfXywgcmV0KTsKPiAtCQlnb3RvIGRpc2FibGVfcmV0Owo+IC0JfQo+IC0KPiAgCS8qIElu aXRpYWxpemUgbGluayByYXRlIGFzIHBhbmVsIG1heCBsaW5rIHJhdGUgKi8KPiAtCWN0cmwtPmxp bmtfcmF0ZSA9IGRybV9kcF9saW5rX3JhdGVfdG9fYndfY29kZShjdHJsLT5kcF9saW5rLnJhdGUp Owo+ICsJY3RybC0+bGlua19yYXRlID0gY3RybC0+ZHBjZFtEUF9NQVhfTElOS19SQVRFXTsKPiAg Cj4gIAljdHJsLT5lZGlkID0gZHJtX2dldF9lZGlkKGNvbm5lY3RvciwgJmN0cmwtPmRybV9hdXgt PmRkYyk7Cj4gIAlpZiAoIWN0cmwtPmVkaWQpIHsKClJldmlld2VkLWJ5OiBEYW5pZWwgVmV0dGVy IDxkYW5pZWwudmV0dGVyQGZmd2xsLmNoPgoKPiAtLSAKPiAyLjIzLjAKPiAKCi0tIApEYW5pZWwg VmV0dGVyClNvZnR3YXJlIEVuZ2luZWVyLCBJbnRlbCBDb3Jwb3JhdGlvbgpodHRwOi8vYmxvZy5m ZndsbC5jaApfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpk cmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0 cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWw=