From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH v3 12/13] drm/rockchip: Avoid drm_dp_link helpers Date: Tue, 22 Oct 2019 16:01:59 +0200 Message-ID: <20191022140159.GN11828@phenom.ffwll.local> References: <20191021143437.1477719-1-thierry.reding@gmail.com> <20191021143437.1477719-13-thierry.reding@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wr1-x442.google.com (mail-wr1-x442.google.com [IPv6:2a00:1450:4864:20::442]) by gabe.freedesktop.org (Postfix) with ESMTPS id 08B266E7EC for ; Tue, 22 Oct 2019 14:02:09 +0000 (UTC) Received: by mail-wr1-x442.google.com with SMTP id w18so17675793wrt.3 for ; Tue, 22 Oct 2019 07:02:08 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20191021143437.1477719-13-thierry.reding@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Thierry Reding Cc: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org T24gTW9uLCBPY3QgMjEsIDIwMTkgYXQgMDQ6MzQ6MzZQTSArMDIwMCwgVGhpZXJyeSBSZWRpbmcg d3JvdGU6Cj4gRnJvbTogVGhpZXJyeSBSZWRpbmcgPHRyZWRpbmdAbnZpZGlhLmNvbT4KPiAKPiBE dXJpbmcgdGhlIGRpc2N1c3Npb24gb2YgcGF0Y2hlcyB0aGF0IGVuaGFuY2UgdGhlIGRybV9kcF9s aW5rIGhlbHBlcnMgaXQKPiB3YXMgY29uY2x1ZGVkIHRoYXQgdGhlc2UgaGVscGVycyBhcmVuJ3Qg dmVyeSB1c2VmdWwgdG8gYmVnaW4gd2l0aC4gU3RhcnQKPiBwdXNoaW5nIHRoZSBlcXVpdmFsZW50 IGNvZGUgaW50byBpbmRpdmlkdWFsIGRyaXZlcnMgdG8gdWx0aW1hdGVseSByZW1vdmUKPiB0aGVt Lgo+IAo+IFNpZ25lZC1vZmYtYnk6IFRoaWVycnkgUmVkaW5nIDx0cmVkaW5nQG52aWRpYS5jb20+ Cj4gLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9yb2NrY2hpcC9jZG4tZHAtY29yZS5jIHwgMTIgKysr KysrLS0tLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9yb2NrY2hpcC9jZG4tZHAtY29yZS5oIHwgIDMg KystCj4gIGRyaXZlcnMvZ3B1L2RybS9yb2NrY2hpcC9jZG4tZHAtcmVnLmMgIHwgMTkgKysrKysr KysrLS0tLS0tLS0tLQo+ICAzIGZpbGVzIGNoYW5nZWQsIDE3IGluc2VydGlvbnMoKyksIDE3IGRl bGV0aW9ucygtKQo+IAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vcm9ja2NoaXAvY2Ru LWRwLWNvcmUuYyBiL2RyaXZlcnMvZ3B1L2RybS9yb2NrY2hpcC9jZG4tZHAtY29yZS5jCj4gaW5k ZXggZDUwNWVhN2Q1Mzg0Li5lZWQ1OTRiZDM4ZDMgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUv ZHJtL3JvY2tjaGlwL2Nkbi1kcC1jb3JlLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vcm9ja2No aXAvY2RuLWRwLWNvcmUuYwo+IEBAIC00NzcsOCArNDc3LDggQEAgc3RhdGljIGludCBjZG5fZHBf ZGlzYWJsZShzdHJ1Y3QgY2RuX2RwX2RldmljZSAqZHApCj4gIAljZG5fZHBfc2V0X2Zpcm13YXJl X2FjdGl2ZShkcCwgZmFsc2UpOwo+ICAJY2RuX2RwX2Nsa19kaXNhYmxlKGRwKTsKPiAgCWRwLT5h Y3RpdmUgPSBmYWxzZTsKPiAtCWRwLT5saW5rLnJhdGUgPSAwOwo+IC0JZHAtPmxpbmsubnVtX2xh bmVzID0gMDsKPiArCWRwLT5tYXhfbGFuZXMgPSAwOwo+ICsJZHAtPm1heF9yYXRlID0gMDsKPiAg CWlmICghZHAtPmNvbm5lY3RlZCkgewo+ICAJCWtmcmVlKGRwLT5lZGlkKTsKPiAgCQlkcC0+ZWRp ZCA9IE5VTEw7Cj4gQEAgLTU3MCw3ICs1NzAsNyBAQCBzdGF0aWMgYm9vbCBjZG5fZHBfY2hlY2tf bGlua19zdGF0dXMoc3RydWN0IGNkbl9kcF9kZXZpY2UgKmRwKQo+ICAJc3RydWN0IGNkbl9kcF9w b3J0ICpwb3J0ID0gY2RuX2RwX2Nvbm5lY3RlZF9wb3J0KGRwKTsKPiAgCXU4IHNpbmtfbGFuZXMg PSBkcm1fZHBfbWF4X2xhbmVfY291bnQoZHAtPmRwY2QpOwo+ICAKPiAtCWlmICghcG9ydCB8fCAh ZHAtPmxpbmsucmF0ZSB8fCAhZHAtPmxpbmsubnVtX2xhbmVzKQo+ICsJaWYgKCFwb3J0IHx8ICFk cC0+bWF4X3JhdGUgfHwgIWRwLT5tYXhfbGFuZXMpCj4gIAkJcmV0dXJuIGZhbHNlOwo+ICAKPiAg CWlmIChjZG5fZHBfZHBjZF9yZWFkKGRwLCBEUF9MQU5FMF8xX1NUQVRVUywgbGlua19zdGF0dXMs Cj4gQEAgLTk1Miw4ICs5NTIsOCBAQCBzdGF0aWMgdm9pZCBjZG5fZHBfcGRfZXZlbnRfd29yayhz dHJ1Y3Qgd29ya19zdHJ1Y3QgKndvcmspCj4gIAo+ICAJLyogRW5hYmxlZCBhbmQgY29ubmVjdGVk IHdpdGggYSBzaW5rLCByZS10cmFpbiBpZiByZXF1ZXN0ZWQgKi8KPiAgCX0gZWxzZSBpZiAoIWNk bl9kcF9jaGVja19saW5rX3N0YXR1cyhkcCkpIHsKPiAtCQl1bnNpZ25lZCBpbnQgcmF0ZSA9IGRw LT5saW5rLnJhdGU7Cj4gLQkJdW5zaWduZWQgaW50IGxhbmVzID0gZHAtPmxpbmsubnVtX2xhbmVz Owo+ICsJCXVuc2lnbmVkIGludCByYXRlID0gZHAtPm1heF9yYXRlOwo+ICsJCXVuc2lnbmVkIGlu dCBsYW5lcyA9IGRwLT5tYXhfbGFuZXM7Cj4gIAkJc3RydWN0IGRybV9kaXNwbGF5X21vZGUgKm1v ZGUgPSAmZHAtPm1vZGU7Cj4gIAo+ICAJCURSTV9ERVZfSU5GTyhkcC0+ZGV2LCAiQ29ubmVjdGVk IHdpdGggc2luay4gUmUtdHJhaW4gbGlua1xuIik7Cj4gQEAgLTk2Niw3ICs5NjYsNyBAQCBzdGF0 aWMgdm9pZCBjZG5fZHBfcGRfZXZlbnRfd29yayhzdHJ1Y3Qgd29ya19zdHJ1Y3QgKndvcmspCj4g IAo+ICAJCS8qIElmIHRyYWluaW5nIHJlc3VsdCBpcyBjaGFuZ2VkLCB1cGRhdGUgdGhlIHZpZGVv IGNvbmZpZyAqLwo+ICAJCWlmIChtb2RlLT5jbG9jayAmJgo+IC0JCSAgICAocmF0ZSAhPSBkcC0+ bGluay5yYXRlIHx8IGxhbmVzICE9IGRwLT5saW5rLm51bV9sYW5lcykpIHsKPiArCQkgICAgKHJh dGUgIT0gZHAtPm1heF9yYXRlIHx8IGxhbmVzICE9IGRwLT5tYXhfbGFuZXMpKSB7Cj4gIAkJCXJl dCA9IGNkbl9kcF9jb25maWdfdmlkZW8oZHApOwo+ICAJCQlpZiAocmV0KSB7Cj4gIAkJCQlkcC0+ Y29ubmVjdGVkID0gZmFsc2U7Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9yb2NrY2hp cC9jZG4tZHAtY29yZS5oIGIvZHJpdmVycy9ncHUvZHJtL3JvY2tjaGlwL2Nkbi1kcC1jb3JlLmgK PiBpbmRleCBiODVlYTg5ZWI2MGIuLjgzYzQ1ODY2NjViNCAxMDA2NDQKPiAtLS0gYS9kcml2ZXJz L2dwdS9kcm0vcm9ja2NoaXAvY2RuLWRwLWNvcmUuaAo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9y b2NrY2hpcC9jZG4tZHAtY29yZS5oCj4gQEAgLTkyLDkgKzkyLDEwIEBAIHN0cnVjdCBjZG5fZHBf ZGV2aWNlIHsKPiAgCXN0cnVjdCByZXNldF9jb250cm9sICpjb3JlX3JzdDsKPiAgCXN0cnVjdCBh dWRpb19pbmZvIGF1ZGlvX2luZm87Cj4gIAlzdHJ1Y3QgdmlkZW9faW5mbyB2aWRlb19pbmZvOwo+ IC0Jc3RydWN0IGRybV9kcF9saW5rIGxpbms7Cj4gIAlzdHJ1Y3QgY2RuX2RwX3BvcnQgKnBvcnRb TUFYX1BIWV07Cj4gIAl1OCBwb3J0czsKPiArCXU4IG1heF9sYW5lczsKPiArCXU4IG1heF9yYXRl Owo+ICAJdTggbGFuZXM7Cj4gIAlpbnQgYWN0aXZlX3BvcnQ7Cj4gIAo+IGRpZmYgLS1naXQgYS9k cml2ZXJzL2dwdS9kcm0vcm9ja2NoaXAvY2RuLWRwLXJlZy5jIGIvZHJpdmVycy9ncHUvZHJtL3Jv Y2tjaGlwL2Nkbi1kcC1yZWcuYwo+IGluZGV4IDA3N2M4NzAyMTkwOC4uNzM2MWMwN2NiNGE3IDEw MDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9yb2NrY2hpcC9jZG4tZHAtcmVnLmMKPiArKysg Yi9kcml2ZXJzL2dwdS9kcm0vcm9ja2NoaXAvY2RuLWRwLXJlZy5jCj4gQEAgLTUzNSw4ICs1MzUs OCBAQCBzdGF0aWMgaW50IGNkbl9kcF9nZXRfdHJhaW5pbmdfc3RhdHVzKHN0cnVjdCBjZG5fZHBf ZGV2aWNlICpkcCkKPiAgCWlmIChyZXQpCj4gIAkJZ290byBlcnJfZ2V0X3RyYWluaW5nX3N0YXR1 czsKPiAgCj4gLQlkcC0+bGluay5yYXRlID0gZHJtX2RwX2J3X2NvZGVfdG9fbGlua19yYXRlKHN0 YXR1c1swXSk7Cj4gLQlkcC0+bGluay5udW1fbGFuZXMgPSBzdGF0dXNbMV07Cj4gKwlkcC0+bWF4 X3JhdGUgPSBkcm1fZHBfYndfY29kZV90b19saW5rX3JhdGUoc3RhdHVzWzBdKTsKPiArCWRwLT5t YXhfbGFuZXMgPSBzdGF0dXNbMV07Cj4gIAo+ICBlcnJfZ2V0X3RyYWluaW5nX3N0YXR1czoKPiAg CWlmIChyZXQpCj4gQEAgLTU2MCw4ICs1NjAsOCBAQCBpbnQgY2RuX2RwX3RyYWluX2xpbmsoc3Ry dWN0IGNkbl9kcF9kZXZpY2UgKmRwKQo+ICAJCXJldHVybiByZXQ7Cj4gIAl9Cj4gIAo+IC0JRFJN X0RFVl9ERUJVR19LTVMoZHAtPmRldiwgInJhdGU6MHgleCwgbGFuZXM6JWRcbiIsIGRwLT5saW5r LnJhdGUsCj4gLQkJCSAgZHAtPmxpbmsubnVtX2xhbmVzKTsKPiArCURSTV9ERVZfREVCVUdfS01T KGRwLT5kZXYsICJyYXRlOjB4JXgsIGxhbmVzOiVkXG4iLCBkcC0+bWF4X3JhdGUsCj4gKwkJCSAg ZHAtPm1heF9sYW5lcyk7Cj4gIAlyZXR1cm4gcmV0Owo+ICB9Cj4gIAo+IEBAIC02MzksNyArNjM5 LDcgQEAgaW50IGNkbl9kcF9jb25maWdfdmlkZW8oc3RydWN0IGNkbl9kcF9kZXZpY2UgKmRwKQo+ ICAJYml0X3Blcl9waXggPSAodmlkZW8tPmNvbG9yX2ZtdCA9PSBZQ0JDUl80XzJfMikgPwo+ICAJ CSAgICAgICh2aWRlby0+Y29sb3JfZGVwdGggKiAyKSA6ICh2aWRlby0+Y29sb3JfZGVwdGggKiAz KTsKPiAgCj4gLQlsaW5rX3JhdGUgPSBkcC0+bGluay5yYXRlIC8gMTAwMDsKPiArCWxpbmtfcmF0 ZSA9IGRwLT5tYXhfcmF0ZSAvIDEwMDA7Cj4gIAo+ICAJcmV0ID0gY2RuX2RwX3JlZ193cml0ZShk cCwgQk5EX0hTWU5DMlZTWU5DLCBWSUZfQllQQVNTX0lOVEVSTEFDRSk7Cj4gIAlpZiAocmV0KQo+ IEBAIC02NTksMTQgKzY1OSwxMyBAQCBpbnQgY2RuX2RwX2NvbmZpZ192aWRlbyhzdHJ1Y3QgY2Ru X2RwX2RldmljZSAqZHApCj4gIAlkbyB7Cj4gIAkJdHVfc2l6ZV9yZWcgKz0gMjsKPiAgCQlzeW1i b2wgPSB0dV9zaXplX3JlZyAqIG1vZGUtPmNsb2NrICogYml0X3Blcl9waXg7Cj4gLQkJZG9fZGl2 KHN5bWJvbCwgZHAtPmxpbmsubnVtX2xhbmVzICogbGlua19yYXRlICogOCk7Cj4gKwkJZG9fZGl2 KHN5bWJvbCwgZHAtPm1heF9sYW5lcyAqIGxpbmtfcmF0ZSAqIDgpOwo+ICAJCXJlbSA9IGRvX2Rp dihzeW1ib2wsIDEwMDApOwo+ICAJCWlmICh0dV9zaXplX3JlZyA+IDY0KSB7Cj4gIAkJCXJldCA9 IC1FSU5WQUw7Cj4gIAkJCURSTV9ERVZfRVJST1IoZHAtPmRldiwKPiAgCQkJCSAgICAgICJ0dSBl cnJvciwgY2xrOiVkLCBsYW5lczolZCwgcmF0ZTolZFxuIiwKPiAtCQkJCSAgICAgIG1vZGUtPmNs b2NrLCBkcC0+bGluay5udW1fbGFuZXMsCj4gLQkJCQkgICAgICBsaW5rX3JhdGUpOwo+ICsJCQkJ ICAgICAgbW9kZS0+Y2xvY2ssIGRwLT5tYXhfbGFuZXMsIGxpbmtfcmF0ZSk7Cj4gIAkJCWdvdG8g ZXJyX2NvbmZpZ192aWRlbzsKPiAgCQl9Cj4gIAl9IHdoaWxlICgoc3ltYm9sIDw9IDEpIHx8ICh0 dV9zaXplX3JlZyAtIHN5bWJvbCA8IDQpIHx8Cj4gQEAgLTY4MCw3ICs2NzksNyBAQCBpbnQgY2Ru X2RwX2NvbmZpZ192aWRlbyhzdHJ1Y3QgY2RuX2RwX2RldmljZSAqZHApCj4gIAo+ICAJLyogc2V0 IHRoZSBGSUZPIEJ1ZmZlciBzaXplICovCj4gIAl2YWwgPSBkaXZfdTY0KG1vZGUtPmNsb2NrICog KHN5bWJvbCArIDEpLCAxMDAwKSArIGxpbmtfcmF0ZTsKPiAtCXZhbCAvPSAoZHAtPmxpbmsubnVt X2xhbmVzICogbGlua19yYXRlKTsKPiArCXZhbCAvPSAoZHAtPm1heF9sYW5lcyAqIGxpbmtfcmF0 ZSk7Cj4gIAl2YWwgPSBkaXZfdTY0KDggKiAoc3ltYm9sICsgMSksIGJpdF9wZXJfcGl4KSAtIHZh bDsKPiAgCXZhbCArPSAyOwo+ICAJcmV0ID0gY2RuX2RwX3JlZ193cml0ZShkcCwgRFBfVkNfVEFC TEUoMTUpLCB2YWwpOwo+IEBAIC04MzMsNyArODMyLDcgQEAgc3RhdGljIHZvaWQgY2RuX2RwX2F1 ZGlvX2NvbmZpZ19pMnMoc3RydWN0IGNkbl9kcF9kZXZpY2UgKmRwLAo+ICAJdTMyIHZhbDsKPiAg Cj4gIAlpZiAoYXVkaW8tPmNoYW5uZWxzID09IDIpIHsKPiAtCQlpZiAoZHAtPmxpbmsubnVtX2xh bmVzID09IDEpCj4gKwkJaWYgKGRwLT5tYXhfbGFuZXMgPT0gMSkKPiAgCQkJc3ViX3Bja3RfbnVt ID0gMjsKPiAgCQllbHNlCj4gIAkJCXN1Yl9wY2t0X251bSA9IDQ7CgpSZXZpZXdlZC1ieTogRGFu aWVsIFZldHRlciA8ZGFuaWVsLnZldHRlckBmZndsbC5jaD4KCj4gLS0gCj4gMi4yMy4wCj4gCgot LSAKRGFuaWVsIFZldHRlcgpTb2Z0d2FyZSBFbmdpbmVlciwgSW50ZWwgQ29ycG9yYXRpb24KaHR0 cDovL2Jsb2cuZmZ3bGwuY2gKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0 b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJp LWRldmVs