diff for duplicates of <20191022152827.GC2343@linux.intel.com> diff --git a/a/1.txt b/N1/1.txt index 33dac4a..9e01b08 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -6,7 +6,7 @@ On Tue, Oct 22, 2019 at 04:04:18PM +0200, Paolo Bonzini wrote: > > + struct kvm_memory_slot *mslots = slots->memslots; > > + int i; > > + -> > + if (WARN_ON_ONCE(slots->id_to_index[new->id] = -1) || +> > + if (WARN_ON_ONCE(slots->id_to_index[new->id] == -1) || > > + WARN_ON_ONCE(!slots->used_slots)) > > + return -1; > > + @@ -14,7 +14,7 @@ On Tue, Oct 22, 2019 at 04:04:18PM +0200, Paolo Bonzini wrote: > > + if (new->base_gfn > mslots[i + 1].base_gfn) > > + break; > > + -> > + WARN_ON_ONCE(new->base_gfn = mslots[i + 1].base_gfn); +> > + WARN_ON_ONCE(new->base_gfn == mslots[i + 1].base_gfn); > > + > > + /* Shift the next memslot forward one and update its index. */ > > + mslots[i] = mslots[i + 1]; @@ -32,5 +32,9 @@ On Tue, Oct 22, 2019 at 04:04:18PM +0200, Paolo Bonzini wrote: I assume you're talking about this blurb in particular? - * The ">=" is needed when creating a slot with base_gfn = 0, - * so that it moves before all those with base_gfn = npages = 0. + * The ">=" is needed when creating a slot with base_gfn == 0, + * so that it moves before all those with base_gfn == npages == 0. +_______________________________________________ +kvmarm mailing list +kvmarm@lists.cs.columbia.edu +https://lists.cs.columbia.edu/mailman/listinfo/kvmarm diff --git a/a/content_digest b/N1/content_digest index 23c31dd..6fd3992 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -3,29 +3,25 @@ "ref\0642f73ee-9425-0149-f4f4-f56be9ae5713@redhat.com\0" "From\0Sean Christopherson <sean.j.christopherson@intel.com>\0" "Subject\0Re: [PATCH v2 14/15] KVM: Terminate memslot walks via used_slots\0" - "Date\0Tue, 22 Oct 2019 15:28:27 +0000\0" + "Date\0Tue, 22 Oct 2019 08:28:27 -0700\0" "To\0Paolo Bonzini <pbonzini@redhat.com>\0" - "Cc\0James Hogan <jhogan@kernel.org>" - Paul Mackerras <paulus@ozlabs.org> - Christian Borntraeger <borntraeger@de.ibm.com> - Janosch Frank <frankja@linux.ibm.com> - " Radim Kr\304\215m\303\241\305\231 <rkrcmar@redhat.com>" - Marc Zyngier <maz@kernel.org> - David Hildenbrand <david@redhat.com> - Cornelia Huck <cohuck@redhat.com> - Vitaly Kuznetsov <vkuznets@redhat.com> + "Cc\0Cornelia Huck <cohuck@redhat.com>" Wanpeng Li <wanpengli@tencent.com> - Jim Mattson <jmattson@google.com> + Janosch Frank <frankja@linux.ibm.com> + kvm@vger.kernel.org + James Hogan <jhogan@kernel.org> Joerg Roedel <joro@8bytes.org> - James Morse <james.morse@arm.com> - Julien Thierry <julien.thierry.kdev@gmail.com> - Suzuki K Poulose <suzuki.poulose@arm.com> + David Hildenbrand <david@redhat.com> linux-mips@vger.kernel.org kvm-ppc@vger.kernel.org - kvm@vger.kernel.org + linux-kernel@vger.kernel.org + Paul Mackerras <paulus@ozlabs.org> + Christian Borntraeger <borntraeger@de.ibm.com> linux-arm-kernel@lists.infradead.org + Marc Zyngier <maz@kernel.org> + Vitaly Kuznetsov <vkuznets@redhat.com> kvmarm@lists.cs.columbia.edu - " linux-kernel@vger.kernel.org\0" + " Jim Mattson <jmattson@google.com>\0" "\00:1\0" "b\0" "On Tue, Oct 22, 2019 at 04:04:18PM +0200, Paolo Bonzini wrote:\n" @@ -36,7 +32,7 @@ "> > +\tstruct kvm_memory_slot *mslots = slots->memslots;\n" "> > +\tint i;\n" "> > +\n" - "> > +\tif (WARN_ON_ONCE(slots->id_to_index[new->id] = -1) ||\n" + "> > +\tif (WARN_ON_ONCE(slots->id_to_index[new->id] == -1) ||\n" "> > +\t WARN_ON_ONCE(!slots->used_slots))\n" "> > +\t\treturn -1;\n" "> > +\n" @@ -44,7 +40,7 @@ "> > +\t\tif (new->base_gfn > mslots[i + 1].base_gfn)\n" "> > +\t\t\tbreak;\n" "> > +\n" - "> > +\t\tWARN_ON_ONCE(new->base_gfn = mslots[i + 1].base_gfn);\n" + "> > +\t\tWARN_ON_ONCE(new->base_gfn == mslots[i + 1].base_gfn);\n" "> > +\n" "> > +\t\t/* Shift the next memslot forward one and update its index. */\n" "> > +\t\tmslots[i] = mslots[i + 1];\n" @@ -62,7 +58,11 @@ "\n" "I assume you're talking about this blurb in particular?\n" "\n" - "\t * The \">=\" is needed when creating a slot with base_gfn = 0,\n" - "\t * so that it moves before all those with base_gfn = npages = 0." + "\t * The \">=\" is needed when creating a slot with base_gfn == 0,\n" + "\t * so that it moves before all those with base_gfn == npages == 0.\n" + "_______________________________________________\n" + "kvmarm mailing list\n" + "kvmarm@lists.cs.columbia.edu\n" + https://lists.cs.columbia.edu/mailman/listinfo/kvmarm -759143f8304975d0141433b4991fa3d282741dc8104b9d7e33fa4601bf42c498 +bb6daf2bbb54f15c5b75e26cb692f8c724b443f8440a0aeddb6dffdbb580fd5a
diff --git a/a/1.txt b/N2/1.txt index 33dac4a..3ed85c2 100644 --- a/a/1.txt +++ b/N2/1.txt @@ -6,7 +6,7 @@ On Tue, Oct 22, 2019 at 04:04:18PM +0200, Paolo Bonzini wrote: > > + struct kvm_memory_slot *mslots = slots->memslots; > > + int i; > > + -> > + if (WARN_ON_ONCE(slots->id_to_index[new->id] = -1) || +> > + if (WARN_ON_ONCE(slots->id_to_index[new->id] == -1) || > > + WARN_ON_ONCE(!slots->used_slots)) > > + return -1; > > + @@ -14,7 +14,7 @@ On Tue, Oct 22, 2019 at 04:04:18PM +0200, Paolo Bonzini wrote: > > + if (new->base_gfn > mslots[i + 1].base_gfn) > > + break; > > + -> > + WARN_ON_ONCE(new->base_gfn = mslots[i + 1].base_gfn); +> > + WARN_ON_ONCE(new->base_gfn == mslots[i + 1].base_gfn); > > + > > + /* Shift the next memslot forward one and update its index. */ > > + mslots[i] = mslots[i + 1]; @@ -32,5 +32,5 @@ On Tue, Oct 22, 2019 at 04:04:18PM +0200, Paolo Bonzini wrote: I assume you're talking about this blurb in particular? - * The ">=" is needed when creating a slot with base_gfn = 0, - * so that it moves before all those with base_gfn = npages = 0. + * The ">=" is needed when creating a slot with base_gfn == 0, + * so that it moves before all those with base_gfn == npages == 0. diff --git a/a/content_digest b/N2/content_digest index 23c31dd..bdbd8d6 100644 --- a/a/content_digest +++ b/N2/content_digest @@ -3,7 +3,7 @@ "ref\0642f73ee-9425-0149-f4f4-f56be9ae5713@redhat.com\0" "From\0Sean Christopherson <sean.j.christopherson@intel.com>\0" "Subject\0Re: [PATCH v2 14/15] KVM: Terminate memslot walks via used_slots\0" - "Date\0Tue, 22 Oct 2019 15:28:27 +0000\0" + "Date\0Tue, 22 Oct 2019 08:28:27 -0700\0" "To\0Paolo Bonzini <pbonzini@redhat.com>\0" "Cc\0James Hogan <jhogan@kernel.org>" Paul Mackerras <paulus@ozlabs.org> @@ -36,7 +36,7 @@ "> > +\tstruct kvm_memory_slot *mslots = slots->memslots;\n" "> > +\tint i;\n" "> > +\n" - "> > +\tif (WARN_ON_ONCE(slots->id_to_index[new->id] = -1) ||\n" + "> > +\tif (WARN_ON_ONCE(slots->id_to_index[new->id] == -1) ||\n" "> > +\t WARN_ON_ONCE(!slots->used_slots))\n" "> > +\t\treturn -1;\n" "> > +\n" @@ -44,7 +44,7 @@ "> > +\t\tif (new->base_gfn > mslots[i + 1].base_gfn)\n" "> > +\t\t\tbreak;\n" "> > +\n" - "> > +\t\tWARN_ON_ONCE(new->base_gfn = mslots[i + 1].base_gfn);\n" + "> > +\t\tWARN_ON_ONCE(new->base_gfn == mslots[i + 1].base_gfn);\n" "> > +\n" "> > +\t\t/* Shift the next memslot forward one and update its index. */\n" "> > +\t\tmslots[i] = mslots[i + 1];\n" @@ -62,7 +62,7 @@ "\n" "I assume you're talking about this blurb in particular?\n" "\n" - "\t * The \">=\" is needed when creating a slot with base_gfn = 0,\n" - "\t * so that it moves before all those with base_gfn = npages = 0." + "\t * The \">=\" is needed when creating a slot with base_gfn == 0,\n" + "\t * so that it moves before all those with base_gfn == npages == 0." -759143f8304975d0141433b4991fa3d282741dc8104b9d7e33fa4601bf42c498 +84299380d054910a446e62e77a0045af5b48045886f73c0f590396580add2a06
diff --git a/a/1.txt b/N3/1.txt index 33dac4a..c554c0b 100644 --- a/a/1.txt +++ b/N3/1.txt @@ -6,7 +6,7 @@ On Tue, Oct 22, 2019 at 04:04:18PM +0200, Paolo Bonzini wrote: > > + struct kvm_memory_slot *mslots = slots->memslots; > > + int i; > > + -> > + if (WARN_ON_ONCE(slots->id_to_index[new->id] = -1) || +> > + if (WARN_ON_ONCE(slots->id_to_index[new->id] == -1) || > > + WARN_ON_ONCE(!slots->used_slots)) > > + return -1; > > + @@ -14,7 +14,7 @@ On Tue, Oct 22, 2019 at 04:04:18PM +0200, Paolo Bonzini wrote: > > + if (new->base_gfn > mslots[i + 1].base_gfn) > > + break; > > + -> > + WARN_ON_ONCE(new->base_gfn = mslots[i + 1].base_gfn); +> > + WARN_ON_ONCE(new->base_gfn == mslots[i + 1].base_gfn); > > + > > + /* Shift the next memslot forward one and update its index. */ > > + mslots[i] = mslots[i + 1]; @@ -32,5 +32,10 @@ On Tue, Oct 22, 2019 at 04:04:18PM +0200, Paolo Bonzini wrote: I assume you're talking about this blurb in particular? - * The ">=" is needed when creating a slot with base_gfn = 0, - * so that it moves before all those with base_gfn = npages = 0. + * The ">=" is needed when creating a slot with base_gfn == 0, + * so that it moves before all those with base_gfn == npages == 0. + +_______________________________________________ +linux-arm-kernel mailing list +linux-arm-kernel@lists.infradead.org +http://lists.infradead.org/mailman/listinfo/linux-arm-kernel diff --git a/a/content_digest b/N3/content_digest index 23c31dd..5e49369 100644 --- a/a/content_digest +++ b/N3/content_digest @@ -3,29 +3,29 @@ "ref\0642f73ee-9425-0149-f4f4-f56be9ae5713@redhat.com\0" "From\0Sean Christopherson <sean.j.christopherson@intel.com>\0" "Subject\0Re: [PATCH v2 14/15] KVM: Terminate memslot walks via used_slots\0" - "Date\0Tue, 22 Oct 2019 15:28:27 +0000\0" + "Date\0Tue, 22 Oct 2019 08:28:27 -0700\0" "To\0Paolo Bonzini <pbonzini@redhat.com>\0" - "Cc\0James Hogan <jhogan@kernel.org>" - Paul Mackerras <paulus@ozlabs.org> - Christian Borntraeger <borntraeger@de.ibm.com> + "Cc\0Cornelia Huck <cohuck@redhat.com>" + Wanpeng Li <wanpengli@tencent.com> Janosch Frank <frankja@linux.ibm.com> + kvm@vger.kernel.org " Radim Kr\304\215m\303\241\305\231 <rkrcmar@redhat.com>" - Marc Zyngier <maz@kernel.org> - David Hildenbrand <david@redhat.com> - Cornelia Huck <cohuck@redhat.com> - Vitaly Kuznetsov <vkuznets@redhat.com> - Wanpeng Li <wanpengli@tencent.com> - Jim Mattson <jmattson@google.com> + James Hogan <jhogan@kernel.org> Joerg Roedel <joro@8bytes.org> - James Morse <james.morse@arm.com> - Julien Thierry <julien.thierry.kdev@gmail.com> - Suzuki K Poulose <suzuki.poulose@arm.com> + David Hildenbrand <david@redhat.com> linux-mips@vger.kernel.org kvm-ppc@vger.kernel.org - kvm@vger.kernel.org + linux-kernel@vger.kernel.org + Paul Mackerras <paulus@ozlabs.org> + Christian Borntraeger <borntraeger@de.ibm.com> + James Morse <james.morse@arm.com> linux-arm-kernel@lists.infradead.org + Marc Zyngier <maz@kernel.org> + Vitaly Kuznetsov <vkuznets@redhat.com> + Suzuki K Poulose <suzuki.poulose@arm.com> kvmarm@lists.cs.columbia.edu - " linux-kernel@vger.kernel.org\0" + Julien Thierry <julien.thierry.kdev@gmail.com> + " Jim Mattson <jmattson@google.com>\0" "\00:1\0" "b\0" "On Tue, Oct 22, 2019 at 04:04:18PM +0200, Paolo Bonzini wrote:\n" @@ -36,7 +36,7 @@ "> > +\tstruct kvm_memory_slot *mslots = slots->memslots;\n" "> > +\tint i;\n" "> > +\n" - "> > +\tif (WARN_ON_ONCE(slots->id_to_index[new->id] = -1) ||\n" + "> > +\tif (WARN_ON_ONCE(slots->id_to_index[new->id] == -1) ||\n" "> > +\t WARN_ON_ONCE(!slots->used_slots))\n" "> > +\t\treturn -1;\n" "> > +\n" @@ -44,7 +44,7 @@ "> > +\t\tif (new->base_gfn > mslots[i + 1].base_gfn)\n" "> > +\t\t\tbreak;\n" "> > +\n" - "> > +\t\tWARN_ON_ONCE(new->base_gfn = mslots[i + 1].base_gfn);\n" + "> > +\t\tWARN_ON_ONCE(new->base_gfn == mslots[i + 1].base_gfn);\n" "> > +\n" "> > +\t\t/* Shift the next memslot forward one and update its index. */\n" "> > +\t\tmslots[i] = mslots[i + 1];\n" @@ -62,7 +62,12 @@ "\n" "I assume you're talking about this blurb in particular?\n" "\n" - "\t * The \">=\" is needed when creating a slot with base_gfn = 0,\n" - "\t * so that it moves before all those with base_gfn = npages = 0." + "\t * The \">=\" is needed when creating a slot with base_gfn == 0,\n" + "\t * so that it moves before all those with base_gfn == npages == 0.\n" + "\n" + "_______________________________________________\n" + "linux-arm-kernel mailing list\n" + "linux-arm-kernel@lists.infradead.org\n" + http://lists.infradead.org/mailman/listinfo/linux-arm-kernel -759143f8304975d0141433b4991fa3d282741dc8104b9d7e33fa4601bf42c498 +50702c8d8c1be26886a448099f0129c08aac97a4758d8e8251d1272ede2973ef
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.