All of lore.kernel.org
 help / color / mirror / Atom feed
diff for duplicates of <20191022155220.GD2343@linux.intel.com>

diff --git a/a/1.txt b/N1/1.txt
index 19dbb6f..1077182 100644
--- a/a/1.txt
+++ b/N1/1.txt
@@ -8,7 +8,7 @@ On Tue, Oct 22, 2019 at 05:30:58PM +0200, Paolo Bonzini wrote:
 > >>> +	struct kvm_memory_slot *mslots = slots->memslots;
 > >>> +	int i;
 > >>> +
-> >>> +	if (WARN_ON_ONCE(slots->id_to_index[new->id] = -1) ||
+> >>> +	if (WARN_ON_ONCE(slots->id_to_index[new->id] == -1) ||
 > >>> +	    WARN_ON_ONCE(!slots->used_slots))
 > >>> +		return -1;
 > >>> +
@@ -16,7 +16,7 @@ On Tue, Oct 22, 2019 at 05:30:58PM +0200, Paolo Bonzini wrote:
 > >>> +		if (new->base_gfn > mslots[i + 1].base_gfn)
 > >>> +			break;
 > >>> +
-> >>> +		WARN_ON_ONCE(new->base_gfn = mslots[i + 1].base_gfn);
+> >>> +		WARN_ON_ONCE(new->base_gfn == mslots[i + 1].base_gfn);
 > >>> +
 > >>> +		/* Shift the next memslot forward one and update its index. */
 > >>> +		mslots[i] = mslots[i + 1];
@@ -34,8 +34,8 @@ On Tue, Oct 22, 2019 at 05:30:58PM +0200, Paolo Bonzini wrote:
 > > 
 > > I assume you're talking about this blurb in particular?
 > > 
-> > 	 * The ">=" is needed when creating a slot with base_gfn = 0,
-> > 	 * so that it moves before all those with base_gfn = npages = 0.
+> > 	 * The ">=" is needed when creating a slot with base_gfn == 0,
+> > 	 * so that it moves before all those with base_gfn == npages == 0.
 > 
 > Yes, well all of the comments.  You can also keep them in the caller, as
 > you prefer.
@@ -57,3 +57,7 @@ Anyways, I'm not at all opposed to adding comments, just want to make sure
 I'm not forgetting something.  If it's ok with you, I'll comment the code
 and/or functions and reply here to refine them without having to respin
 the whole series.
+_______________________________________________
+kvmarm mailing list
+kvmarm@lists.cs.columbia.edu
+https://lists.cs.columbia.edu/mailman/listinfo/kvmarm
diff --git a/a/content_digest b/N1/content_digest
index f795e3c..2dd7818 100644
--- a/a/content_digest
+++ b/N1/content_digest
@@ -5,29 +5,25 @@
  "ref\0625e511f-bd35-3b92-0c6d-550c10fc5827@redhat.com\0"
  "From\0Sean Christopherson <sean.j.christopherson@intel.com>\0"
  "Subject\0Re: [PATCH v2 14/15] KVM: Terminate memslot walks via used_slots\0"
- "Date\0Tue, 22 Oct 2019 15:52:20 +0000\0"
+ "Date\0Tue, 22 Oct 2019 08:52:20 -0700\0"
  "To\0Paolo Bonzini <pbonzini@redhat.com>\0"
- "Cc\0James Hogan <jhogan@kernel.org>"
-  Paul Mackerras <paulus@ozlabs.org>
-  Christian Borntraeger <borntraeger@de.ibm.com>
-  Janosch Frank <frankja@linux.ibm.com>
- " Radim Kr\304\215m\303\241\305\231 <rkrcmar@redhat.com>"
-  Marc Zyngier <maz@kernel.org>
-  David Hildenbrand <david@redhat.com>
-  Cornelia Huck <cohuck@redhat.com>
-  Vitaly Kuznetsov <vkuznets@redhat.com>
+ "Cc\0Cornelia Huck <cohuck@redhat.com>"
   Wanpeng Li <wanpengli@tencent.com>
-  Jim Mattson <jmattson@google.com>
+  Janosch Frank <frankja@linux.ibm.com>
+  kvm@vger.kernel.org
+  James Hogan <jhogan@kernel.org>
   Joerg Roedel <joro@8bytes.org>
-  James Morse <james.morse@arm.com>
-  Julien Thierry <julien.thierry.kdev@gmail.com>
-  Suzuki K Poulose <suzuki.poulose@arm.com>
+  David Hildenbrand <david@redhat.com>
   linux-mips@vger.kernel.org
   kvm-ppc@vger.kernel.org
-  kvm@vger.kernel.org
+  linux-kernel@vger.kernel.org
+  Paul Mackerras <paulus@ozlabs.org>
+  Christian Borntraeger <borntraeger@de.ibm.com>
   linux-arm-kernel@lists.infradead.org
+  Marc Zyngier <maz@kernel.org>
+  Vitaly Kuznetsov <vkuznets@redhat.com>
   kvmarm@lists.cs.columbia.edu
- " linux-kernel@vger.kernel.org\0"
+ " Jim Mattson <jmattson@google.com>\0"
  "\00:1\0"
  "b\0"
  "On Tue, Oct 22, 2019 at 05:30:58PM +0200, Paolo Bonzini wrote:\n"
@@ -40,7 +36,7 @@
  "> >>> +\tstruct kvm_memory_slot *mslots = slots->memslots;\n"
  "> >>> +\tint i;\n"
  "> >>> +\n"
- "> >>> +\tif (WARN_ON_ONCE(slots->id_to_index[new->id] = -1) ||\n"
+ "> >>> +\tif (WARN_ON_ONCE(slots->id_to_index[new->id] == -1) ||\n"
  "> >>> +\t    WARN_ON_ONCE(!slots->used_slots))\n"
  "> >>> +\t\treturn -1;\n"
  "> >>> +\n"
@@ -48,7 +44,7 @@
  "> >>> +\t\tif (new->base_gfn > mslots[i + 1].base_gfn)\n"
  "> >>> +\t\t\tbreak;\n"
  "> >>> +\n"
- "> >>> +\t\tWARN_ON_ONCE(new->base_gfn = mslots[i + 1].base_gfn);\n"
+ "> >>> +\t\tWARN_ON_ONCE(new->base_gfn == mslots[i + 1].base_gfn);\n"
  "> >>> +\n"
  "> >>> +\t\t/* Shift the next memslot forward one and update its index. */\n"
  "> >>> +\t\tmslots[i] = mslots[i + 1];\n"
@@ -66,8 +62,8 @@
  "> > \n"
  "> > I assume you're talking about this blurb in particular?\n"
  "> > \n"
- "> > \t * The \">=\" is needed when creating a slot with base_gfn = 0,\n"
- "> > \t * so that it moves before all those with base_gfn = npages = 0.\n"
+ "> > \t * The \">=\" is needed when creating a slot with base_gfn == 0,\n"
+ "> > \t * so that it moves before all those with base_gfn == npages == 0.\n"
  "> \n"
  "> Yes, well all of the comments.  You can also keep them in the caller, as\n"
  "> you prefer.\n"
@@ -88,6 +84,10 @@
  "Anyways, I'm not at all opposed to adding comments, just want to make sure\n"
  "I'm not forgetting something.  If it's ok with you, I'll comment the code\n"
  "and/or functions and reply here to refine them without having to respin\n"
- the whole series.
+ "the whole series.\n"
+ "_______________________________________________\n"
+ "kvmarm mailing list\n"
+ "kvmarm@lists.cs.columbia.edu\n"
+ https://lists.cs.columbia.edu/mailman/listinfo/kvmarm
 
-2f10af9d75d5b2bafae0c6537a55f01eae402403a747e65ae9d543a6737ffd09
+acc1c09437f2eac10fb5aff94fafa5081c60678ed391650a90d9639e7ac2c329

diff --git a/a/1.txt b/N2/1.txt
index 19dbb6f..6c6162b 100644
--- a/a/1.txt
+++ b/N2/1.txt
@@ -8,7 +8,7 @@ On Tue, Oct 22, 2019 at 05:30:58PM +0200, Paolo Bonzini wrote:
 > >>> +	struct kvm_memory_slot *mslots = slots->memslots;
 > >>> +	int i;
 > >>> +
-> >>> +	if (WARN_ON_ONCE(slots->id_to_index[new->id] = -1) ||
+> >>> +	if (WARN_ON_ONCE(slots->id_to_index[new->id] == -1) ||
 > >>> +	    WARN_ON_ONCE(!slots->used_slots))
 > >>> +		return -1;
 > >>> +
@@ -16,7 +16,7 @@ On Tue, Oct 22, 2019 at 05:30:58PM +0200, Paolo Bonzini wrote:
 > >>> +		if (new->base_gfn > mslots[i + 1].base_gfn)
 > >>> +			break;
 > >>> +
-> >>> +		WARN_ON_ONCE(new->base_gfn = mslots[i + 1].base_gfn);
+> >>> +		WARN_ON_ONCE(new->base_gfn == mslots[i + 1].base_gfn);
 > >>> +
 > >>> +		/* Shift the next memslot forward one and update its index. */
 > >>> +		mslots[i] = mslots[i + 1];
@@ -34,8 +34,8 @@ On Tue, Oct 22, 2019 at 05:30:58PM +0200, Paolo Bonzini wrote:
 > > 
 > > I assume you're talking about this blurb in particular?
 > > 
-> > 	 * The ">=" is needed when creating a slot with base_gfn = 0,
-> > 	 * so that it moves before all those with base_gfn = npages = 0.
+> > 	 * The ">=" is needed when creating a slot with base_gfn == 0,
+> > 	 * so that it moves before all those with base_gfn == npages == 0.
 > 
 > Yes, well all of the comments.  You can also keep them in the caller, as
 > you prefer.
diff --git a/a/content_digest b/N2/content_digest
index f795e3c..b2efc63 100644
--- a/a/content_digest
+++ b/N2/content_digest
@@ -5,7 +5,7 @@
  "ref\0625e511f-bd35-3b92-0c6d-550c10fc5827@redhat.com\0"
  "From\0Sean Christopherson <sean.j.christopherson@intel.com>\0"
  "Subject\0Re: [PATCH v2 14/15] KVM: Terminate memslot walks via used_slots\0"
- "Date\0Tue, 22 Oct 2019 15:52:20 +0000\0"
+ "Date\0Tue, 22 Oct 2019 08:52:20 -0700\0"
  "To\0Paolo Bonzini <pbonzini@redhat.com>\0"
  "Cc\0James Hogan <jhogan@kernel.org>"
   Paul Mackerras <paulus@ozlabs.org>
@@ -40,7 +40,7 @@
  "> >>> +\tstruct kvm_memory_slot *mslots = slots->memslots;\n"
  "> >>> +\tint i;\n"
  "> >>> +\n"
- "> >>> +\tif (WARN_ON_ONCE(slots->id_to_index[new->id] = -1) ||\n"
+ "> >>> +\tif (WARN_ON_ONCE(slots->id_to_index[new->id] == -1) ||\n"
  "> >>> +\t    WARN_ON_ONCE(!slots->used_slots))\n"
  "> >>> +\t\treturn -1;\n"
  "> >>> +\n"
@@ -48,7 +48,7 @@
  "> >>> +\t\tif (new->base_gfn > mslots[i + 1].base_gfn)\n"
  "> >>> +\t\t\tbreak;\n"
  "> >>> +\n"
- "> >>> +\t\tWARN_ON_ONCE(new->base_gfn = mslots[i + 1].base_gfn);\n"
+ "> >>> +\t\tWARN_ON_ONCE(new->base_gfn == mslots[i + 1].base_gfn);\n"
  "> >>> +\n"
  "> >>> +\t\t/* Shift the next memslot forward one and update its index. */\n"
  "> >>> +\t\tmslots[i] = mslots[i + 1];\n"
@@ -66,8 +66,8 @@
  "> > \n"
  "> > I assume you're talking about this blurb in particular?\n"
  "> > \n"
- "> > \t * The \">=\" is needed when creating a slot with base_gfn = 0,\n"
- "> > \t * so that it moves before all those with base_gfn = npages = 0.\n"
+ "> > \t * The \">=\" is needed when creating a slot with base_gfn == 0,\n"
+ "> > \t * so that it moves before all those with base_gfn == npages == 0.\n"
  "> \n"
  "> Yes, well all of the comments.  You can also keep them in the caller, as\n"
  "> you prefer.\n"
@@ -90,4 +90,4 @@
  "and/or functions and reply here to refine them without having to respin\n"
  the whole series.
 
-2f10af9d75d5b2bafae0c6537a55f01eae402403a747e65ae9d543a6737ffd09
+4e70ba41008c8263213a4408cc399f2147c5e4b99ee88170e0af96ac475f27ba

diff --git a/a/1.txt b/N3/1.txt
index 19dbb6f..d4b8db7 100644
--- a/a/1.txt
+++ b/N3/1.txt
@@ -8,7 +8,7 @@ On Tue, Oct 22, 2019 at 05:30:58PM +0200, Paolo Bonzini wrote:
 > >>> +	struct kvm_memory_slot *mslots = slots->memslots;
 > >>> +	int i;
 > >>> +
-> >>> +	if (WARN_ON_ONCE(slots->id_to_index[new->id] = -1) ||
+> >>> +	if (WARN_ON_ONCE(slots->id_to_index[new->id] == -1) ||
 > >>> +	    WARN_ON_ONCE(!slots->used_slots))
 > >>> +		return -1;
 > >>> +
@@ -16,7 +16,7 @@ On Tue, Oct 22, 2019 at 05:30:58PM +0200, Paolo Bonzini wrote:
 > >>> +		if (new->base_gfn > mslots[i + 1].base_gfn)
 > >>> +			break;
 > >>> +
-> >>> +		WARN_ON_ONCE(new->base_gfn = mslots[i + 1].base_gfn);
+> >>> +		WARN_ON_ONCE(new->base_gfn == mslots[i + 1].base_gfn);
 > >>> +
 > >>> +		/* Shift the next memslot forward one and update its index. */
 > >>> +		mslots[i] = mslots[i + 1];
@@ -34,8 +34,8 @@ On Tue, Oct 22, 2019 at 05:30:58PM +0200, Paolo Bonzini wrote:
 > > 
 > > I assume you're talking about this blurb in particular?
 > > 
-> > 	 * The ">=" is needed when creating a slot with base_gfn = 0,
-> > 	 * so that it moves before all those with base_gfn = npages = 0.
+> > 	 * The ">=" is needed when creating a slot with base_gfn == 0,
+> > 	 * so that it moves before all those with base_gfn == npages == 0.
 > 
 > Yes, well all of the comments.  You can also keep them in the caller, as
 > you prefer.
@@ -57,3 +57,8 @@ Anyways, I'm not at all opposed to adding comments, just want to make sure
 I'm not forgetting something.  If it's ok with you, I'll comment the code
 and/or functions and reply here to refine them without having to respin
 the whole series.
+
+_______________________________________________
+linux-arm-kernel mailing list
+linux-arm-kernel@lists.infradead.org
+http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
diff --git a/a/content_digest b/N3/content_digest
index f795e3c..bcae267 100644
--- a/a/content_digest
+++ b/N3/content_digest
@@ -5,29 +5,29 @@
  "ref\0625e511f-bd35-3b92-0c6d-550c10fc5827@redhat.com\0"
  "From\0Sean Christopherson <sean.j.christopherson@intel.com>\0"
  "Subject\0Re: [PATCH v2 14/15] KVM: Terminate memslot walks via used_slots\0"
- "Date\0Tue, 22 Oct 2019 15:52:20 +0000\0"
+ "Date\0Tue, 22 Oct 2019 08:52:20 -0700\0"
  "To\0Paolo Bonzini <pbonzini@redhat.com>\0"
- "Cc\0James Hogan <jhogan@kernel.org>"
-  Paul Mackerras <paulus@ozlabs.org>
-  Christian Borntraeger <borntraeger@de.ibm.com>
+ "Cc\0Cornelia Huck <cohuck@redhat.com>"
+  Wanpeng Li <wanpengli@tencent.com>
   Janosch Frank <frankja@linux.ibm.com>
+  kvm@vger.kernel.org
  " Radim Kr\304\215m\303\241\305\231 <rkrcmar@redhat.com>"
-  Marc Zyngier <maz@kernel.org>
-  David Hildenbrand <david@redhat.com>
-  Cornelia Huck <cohuck@redhat.com>
-  Vitaly Kuznetsov <vkuznets@redhat.com>
-  Wanpeng Li <wanpengli@tencent.com>
-  Jim Mattson <jmattson@google.com>
+  James Hogan <jhogan@kernel.org>
   Joerg Roedel <joro@8bytes.org>
-  James Morse <james.morse@arm.com>
-  Julien Thierry <julien.thierry.kdev@gmail.com>
-  Suzuki K Poulose <suzuki.poulose@arm.com>
+  David Hildenbrand <david@redhat.com>
   linux-mips@vger.kernel.org
   kvm-ppc@vger.kernel.org
-  kvm@vger.kernel.org
+  linux-kernel@vger.kernel.org
+  Paul Mackerras <paulus@ozlabs.org>
+  Christian Borntraeger <borntraeger@de.ibm.com>
+  James Morse <james.morse@arm.com>
   linux-arm-kernel@lists.infradead.org
+  Marc Zyngier <maz@kernel.org>
+  Vitaly Kuznetsov <vkuznets@redhat.com>
+  Suzuki K Poulose <suzuki.poulose@arm.com>
   kvmarm@lists.cs.columbia.edu
- " linux-kernel@vger.kernel.org\0"
+  Julien Thierry <julien.thierry.kdev@gmail.com>
+ " Jim Mattson <jmattson@google.com>\0"
  "\00:1\0"
  "b\0"
  "On Tue, Oct 22, 2019 at 05:30:58PM +0200, Paolo Bonzini wrote:\n"
@@ -40,7 +40,7 @@
  "> >>> +\tstruct kvm_memory_slot *mslots = slots->memslots;\n"
  "> >>> +\tint i;\n"
  "> >>> +\n"
- "> >>> +\tif (WARN_ON_ONCE(slots->id_to_index[new->id] = -1) ||\n"
+ "> >>> +\tif (WARN_ON_ONCE(slots->id_to_index[new->id] == -1) ||\n"
  "> >>> +\t    WARN_ON_ONCE(!slots->used_slots))\n"
  "> >>> +\t\treturn -1;\n"
  "> >>> +\n"
@@ -48,7 +48,7 @@
  "> >>> +\t\tif (new->base_gfn > mslots[i + 1].base_gfn)\n"
  "> >>> +\t\t\tbreak;\n"
  "> >>> +\n"
- "> >>> +\t\tWARN_ON_ONCE(new->base_gfn = mslots[i + 1].base_gfn);\n"
+ "> >>> +\t\tWARN_ON_ONCE(new->base_gfn == mslots[i + 1].base_gfn);\n"
  "> >>> +\n"
  "> >>> +\t\t/* Shift the next memslot forward one and update its index. */\n"
  "> >>> +\t\tmslots[i] = mslots[i + 1];\n"
@@ -66,8 +66,8 @@
  "> > \n"
  "> > I assume you're talking about this blurb in particular?\n"
  "> > \n"
- "> > \t * The \">=\" is needed when creating a slot with base_gfn = 0,\n"
- "> > \t * so that it moves before all those with base_gfn = npages = 0.\n"
+ "> > \t * The \">=\" is needed when creating a slot with base_gfn == 0,\n"
+ "> > \t * so that it moves before all those with base_gfn == npages == 0.\n"
  "> \n"
  "> Yes, well all of the comments.  You can also keep them in the caller, as\n"
  "> you prefer.\n"
@@ -88,6 +88,11 @@
  "Anyways, I'm not at all opposed to adding comments, just want to make sure\n"
  "I'm not forgetting something.  If it's ok with you, I'll comment the code\n"
  "and/or functions and reply here to refine them without having to respin\n"
- the whole series.
+ "the whole series.\n"
+ "\n"
+ "_______________________________________________\n"
+ "linux-arm-kernel mailing list\n"
+ "linux-arm-kernel@lists.infradead.org\n"
+ http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
 
-2f10af9d75d5b2bafae0c6537a55f01eae402403a747e65ae9d543a6737ffd09
+df1d5c5fbc6d914840567761127513163999e889a1ea764346efbeb09be062af

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.