From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tony Lindgren Subject: Re: [RFC] ARM: omap3: Enable HWMODS for HW Random Number Generator Date: Tue, 22 Oct 2019 09:06:43 -0700 Message-ID: <20191022160643.GR5610@atomide.com> References: <20190828150037.2640-1-aford173@gmail.com> <20190905230443.GA52127@atomide.com> <20190909134033.s26eiurpat3iekse@pali> <20190909163543.GQ52127@atomide.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Adam Ford Cc: Pali =?utf-8?B?Um9ow6Fy?= , Linux-OMAP , Tero Kristo , Aaro Koskinen , Adam Ford , =?utf-8?Q?Beno=C3=AEt?= Cousson , Rob Herring , Mark Rutland , Russell King , Paul Walmsley , devicetree , Linux Kernel Mailing List , arm-soc List-Id: linux-omap@vger.kernel.org * Adam Ford [191022 12:13]: > On Mon, Sep 9, 2019 at 11:35 AM Tony Lindgren wrote: > > > > * Pali Rohár [190909 13:41]: > > > On Monday 09 September 2019 08:37:09 Adam Ford wrote: > > > > I applied this on 5.3 and it is working. I assume the same is true in for-next. > > > > Hmm I noticed I stopped getting RNG data after several rmmod modprobe > > cycles, or several hd /dev/random reads. Anybody else seeing that? > > > > > > Do you want to submit a formal patch? I can mark it as 'tested-by' > > > > This really helps speed up the startup sequence on boards with sshd > > > > because it delays for nearly 80 seconds waiting for entropy without > > > > the hwrng. > > > > > > Hi! When applying a patch, could you please disable this rng for n900? > > > > > > In omap3-n900.dts for rng should be status = "disabled" (as Tony already > > > wrote), similarly like for aes. > > > > Yeah I'll post a proper patch after -rc1. > > Tony, > > I am just following up on this. Without the HWRNG there are some > tools and daemons like sshd which wait a long time at startup. The > patch you sent really helps speed up the startup time in these cases. > At least in my case, it shaves 80 seconds off by eliminating the > delays. > > Do you think you'll have time to post a more formal patch? If not, I > can do it. I just don't know which mailing list is the more > appropriate. I was able to verity your patch on a DM3730 and OMAP3530 Yeah sorry for the delays, I'll post it when I get a chance to work on that again. I need to first deal with the other pending patches for v5.5, and we've had quite a few fixes for v5.4. Regards, Tony From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 98A27CA9EA0 for ; Tue, 22 Oct 2019 16:06:59 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 613EF20B7C for ; Tue, 22 Oct 2019 16:06:59 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="n3Xk4PLr" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 613EF20B7C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=atomide.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=SrQSI+fl8zEQz7QreHhoo/fmqKyKRFxMkoWiKpO2dyA=; b=n3Xk4PLrTpcwxp EE2dKj0DhCbFhq+/IbZpkBDu/gUUPZzTsWqQG6GqL2jIHYePGOYIoAR2z00pp80+Hng2P8r0MPJPe VKpGH564AKrkrJx7EdeXHXzr7GSqxvy0z52FEqEjcdleBiOcSHPwqCDaoxGeenoLQXW9bW0cs3ZDc 0yVbYCvrWkeDf22oq0m8Rbi0k88L0Epk7S6xgFn79CMf5HRSv/5rjkzqDyaa4tUAjnur61bmvj8jg wZgWJLbuzkzTvt2txjSHWJR0Vwj+AOhFJ+xtD2vyqNo8sFPjRMDuf6nmuP9cyejE6/N0R09GnHU31 EDjgDqxfe2MJ46B8iqtQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iMwgQ-000890-OU; Tue, 22 Oct 2019 16:06:54 +0000 Received: from muru.com ([72.249.23.125]) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iMwgN-00087r-UH for linux-arm-kernel@lists.infradead.org; Tue, 22 Oct 2019 16:06:53 +0000 Received: from atomide.com (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id 4304680FA; Tue, 22 Oct 2019 16:07:21 +0000 (UTC) Date: Tue, 22 Oct 2019 09:06:43 -0700 From: Tony Lindgren To: Adam Ford Subject: Re: [RFC] ARM: omap3: Enable HWMODS for HW Random Number Generator Message-ID: <20191022160643.GR5610@atomide.com> References: <20190828150037.2640-1-aford173@gmail.com> <20190905230443.GA52127@atomide.com> <20190909134033.s26eiurpat3iekse@pali> <20190909163543.GQ52127@atomide.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.12.1 (2019-06-15) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191022_090652_014214_EB40062F X-CRM114-Status: GOOD ( 20.08 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree , Paul Walmsley , Aaro Koskinen , Russell King , Linux Kernel Mailing List , Tero Kristo , Rob Herring , =?utf-8?Q?Beno=C3=AEt?= Cousson , Pali =?utf-8?B?Um9ow6Fy?= , Linux-OMAP , Adam Ford , arm-soc Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org KiBBZGFtIEZvcmQgPGFmb3JkMTczQGdtYWlsLmNvbT4gWzE5MTAyMiAxMjoxM106Cj4gT24gTW9u LCBTZXAgOSwgMjAxOSBhdCAxMTozNSBBTSBUb255IExpbmRncmVuIDx0b255QGF0b21pZGUuY29t PiB3cm90ZToKPiA+Cj4gPiAqIFBhbGkgUm9ow6FyIDxwYWxpLnJvaGFyQGdtYWlsLmNvbT4gWzE5 MDkwOSAxMzo0MV06Cj4gPiA+IE9uIE1vbmRheSAwOSBTZXB0ZW1iZXIgMjAxOSAwODozNzowOSBB ZGFtIEZvcmQgd3JvdGU6Cj4gPiA+ID4gSSBhcHBsaWVkIHRoaXMgb24gNS4zIGFuZCBpdCBpcyB3 b3JraW5nLiAgSSBhc3N1bWUgdGhlIHNhbWUgaXMgdHJ1ZSBpbiBmb3ItbmV4dC4KPiA+Cj4gPiBI bW0gSSBub3RpY2VkIEkgc3RvcHBlZCBnZXR0aW5nIFJORyBkYXRhIGFmdGVyIHNldmVyYWwgcm1t b2QgbW9kcHJvYmUKPiA+IGN5Y2xlcywgb3Igc2V2ZXJhbCBoZCAvZGV2L3JhbmRvbSByZWFkcy4g QW55Ym9keSBlbHNlIHNlZWluZyB0aGF0Pwo+ID4KPiA+ID4gPiBEbyB5b3Ugd2FudCB0byBzdWJt aXQgYSBmb3JtYWwgcGF0Y2g/ICBJICBjYW4gbWFyayBpdCBhcyAndGVzdGVkLWJ5Jwo+ID4gPiA+ IFRoaXMgcmVhbGx5IGhlbHBzIHNwZWVkIHVwIHRoZSBzdGFydHVwIHNlcXVlbmNlIG9uIGJvYXJk cyB3aXRoIHNzaGQKPiA+ID4gPiBiZWNhdXNlIGl0IGRlbGF5cyBmb3IgbmVhcmx5IDgwIHNlY29u ZHMgd2FpdGluZyBmb3IgZW50cm9weSB3aXRob3V0Cj4gPiA+ID4gdGhlIGh3cm5nLgo+ID4gPgo+ ID4gPiBIaSEgV2hlbiBhcHBseWluZyBhIHBhdGNoLCBjb3VsZCB5b3UgcGxlYXNlIGRpc2FibGUg dGhpcyBybmcgZm9yIG45MDA/Cj4gPiA+Cj4gPiA+IEluIG9tYXAzLW45MDAuZHRzIGZvciBybmcg c2hvdWxkIGJlIHN0YXR1cyA9ICJkaXNhYmxlZCIgKGFzIFRvbnkgYWxyZWFkeQo+ID4gPiB3cm90 ZSksIHNpbWlsYXJseSBsaWtlIGZvciBhZXMuCj4gPgo+ID4gWWVhaCBJJ2xsIHBvc3QgYSBwcm9w ZXIgcGF0Y2ggYWZ0ZXIgLXJjMS4KPiAKPiBUb255LAo+IAo+IEkgYW0ganVzdCBmb2xsb3dpbmcg dXAgb24gdGhpcy4gIFdpdGhvdXQgdGhlIEhXUk5HIHRoZXJlIGFyZSBzb21lCj4gdG9vbHMgYW5k IGRhZW1vbnMgbGlrZSBzc2hkIHdoaWNoIHdhaXQgYSBsb25nIHRpbWUgYXQgc3RhcnR1cC4gIFRo ZQo+IHBhdGNoIHlvdSBzZW50IHJlYWxseSBoZWxwcyBzcGVlZCB1cCB0aGUgc3RhcnR1cCB0aW1l IGluIHRoZXNlIGNhc2VzLgo+IEF0IGxlYXN0IGluIG15IGNhc2UsIGl0IHNoYXZlcyA4MCBzZWNv bmRzIG9mZiBieSBlbGltaW5hdGluZyB0aGUKPiBkZWxheXMuCj4gCj4gRG8geW91IHRoaW5rIHlv dSdsbCBoYXZlIHRpbWUgdG8gcG9zdCBhIG1vcmUgZm9ybWFsIHBhdGNoPyAgSWYgbm90LCBJCj4g Y2FuIGRvIGl0LiAgSSBqdXN0IGRvbid0IGtub3cgd2hpY2ggbWFpbGluZyBsaXN0IGlzIHRoZSBt b3JlCj4gYXBwcm9wcmlhdGUuICBJIHdhcyBhYmxlIHRvIHZlcml0eSB5b3VyIHBhdGNoIG9uIGEg RE0zNzMwIGFuZCBPTUFQMzUzMAoKWWVhaCBzb3JyeSBmb3IgdGhlIGRlbGF5cywgSSdsbCBwb3N0 IGl0IHdoZW4gSSBnZXQgYSBjaGFuY2UgdG8Kd29yayBvbiB0aGF0IGFnYWluLiBJIG5lZWQgdG8g Zmlyc3QgZGVhbCB3aXRoIHRoZSBvdGhlciBwZW5kaW5nCnBhdGNoZXMgZm9yIHY1LjUsIGFuZCB3 ZSd2ZSBoYWQgcXVpdGUgYSBmZXcgZml4ZXMgZm9yIHY1LjQuCgpSZWdhcmRzLAoKVG9ueQoKX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgtYXJtLWtl cm5lbCBtYWlsaW5nIGxpc3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0 dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5l bAo=