Re: [PATCH 2/2] drm/vc4: Use drm_hdmi_avi_infoframe_bars()

From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: dri-devel@lists.freedesktop.org
Cc: Boris Brezillon <boris.brezillon@collabora.com>
Subject: Re: [PATCH 2/2] drm/vc4: Use drm_hdmi_avi_infoframe_bars()
Date: Tue, 22 Oct 2019 19:23:52 +0300	[thread overview]
Message-ID: <20191022162352.GO1208@intel.com> (raw)
In-Reply-To: <20191008164814.5894-2-ville.syrjala@linux.intel.com>

On Tue, Oct 08, 2019 at 07:48:14PM +0300, Ville Syrjala wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> 
> Use the new drm_hdmi_avi_infoframe_bars() helper instead
> of hand rolling it.
> 
> Cc: Eric Anholt <eric@anholt.net>
> Cc: Boris Brezillon <boris.brezillon@bootlin.com>
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>

Series pushed to drm-misc-next with Boris's irc rb:

19:03 < vsyrjala> anholt: bbrezillon: thoughts on https://patchwork.freedesktop.org/series/67742/ ?
19:05 < bbrezillon> vsyrjala: R-b

Thanks.

> ---
>  drivers/gpu/drm/vc4/vc4_hdmi.c | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
> 
> diff --git a/drivers/gpu/drm/vc4/vc4_hdmi.c b/drivers/gpu/drm/vc4/vc4_hdmi.c
> index 0853b980bcb3..1c62c6c9244b 100644
> --- a/drivers/gpu/drm/vc4/vc4_hdmi.c
> +++ b/drivers/gpu/drm/vc4/vc4_hdmi.c
> @@ -398,10 +398,7 @@ static void vc4_hdmi_set_avi_infoframe(struct drm_encoder *encoder)
>  					   HDMI_QUANTIZATION_RANGE_LIMITED :
>  					   HDMI_QUANTIZATION_RANGE_FULL);
>  
> -	frame.avi.right_bar = cstate->tv.margins.right;
> -	frame.avi.left_bar = cstate->tv.margins.left;
> -	frame.avi.top_bar = cstate->tv.margins.top;
> -	frame.avi.bottom_bar = cstate->tv.margins.bottom;
> +	drm_hdmi_avi_infoframe_bars(&frame.avi, cstate);
>  
>  	vc4_hdmi_write_infoframe(encoder, &frame);
>  }
> -- 
> 2.21.0

-- 
Ville Syrjälä
Intel
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel