From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2 2/2] package/ofono: use target ell library if enabled
Date: Tue, 22 Oct 2019 22:18:00 +0200 [thread overview]
Message-ID: <20191022221800.55e4bb76@windsurf> (raw)
In-Reply-To: <20191022134341.34426-2-nicolas.serafini@sensefly.com>
Hello Nicolas,
On Tue, 22 Oct 2019 13:44:08 +0000
Nicolas Serafini <nicolas.serafini@sensefly.com> wrote:
> +ifeq ($(BR2_PACKAGE_ELL),y)
> +OFONO_DEPENDENCIES += ell
> +OFONO_CONF_OPTS += --enable-external-ell
> +else
> +OFONO_CONF_OPTS += --disable-external-ell
> +endif
If I understand correctly the code, ell is in fact always needed by
ofono. If ell is not available externally, it uses a bundled version of
ell.
In this case, Buildroot prefers to always use the external library, so
could you turn ell into a mandatory dependency of ofono, and pass
--enable-external-ell unconditionally?
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2019-10-22 20:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-22 13:44 [Buildroot] [PATCH v2 1/2] package/ofono: remove forced autoreconf Nicolas Serafini
2019-10-22 13:44 ` [Buildroot] [PATCH v2 2/2] package/ofono: use target ell library if enabled Nicolas Serafini
2019-10-22 20:18 ` Thomas Petazzoni [this message]
2019-10-23 8:37 ` Nicolas Serafini
2019-10-22 20:17 ` [Buildroot] [PATCH v2 1/2] package/ofono: remove forced autoreconf Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191022221800.55e4bb76@windsurf \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.