From: AKASHI Takahiro <takahiro.akashi@linaro.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v1 1/3] lib: rsa: decouple rsa from FIT image verification
Date: Wed, 23 Oct 2019 14:10:33 +0900 [thread overview]
Message-ID: <20191023051032.GA10448@linaro.org> (raw)
In-Reply-To: <CAPnjgZ2=gPvazTQAQj22PSubWHoBH3yi+7MQtNOy+yi=72JHHw@mail.gmail.com>
On Mon, Oct 21, 2019 at 06:17:02PM -0600, Simon Glass wrote:
> Hi Takahiro,
>
> On Tue, 8 Oct 2019 at 23:27, AKASHI Takahiro <takahiro.akashi@linaro.org> wrote:
> >
> > Introduce new configuration, CONFIG_RSA_VERIFY which will decouple building
> > RSA functions from FIT verification and allow for adding a RSA-based
> > signature verification for other file formats, in particular PE file
> > for UEFI secure boot.
> >
> > Signed-off-by: AKASHI Takahiro <takahiro.akashi@linaro.org>
> > ---
> > Kconfig | 1 +
> > common/Makefile | 3 +-
> > common/image-fit-sig.c | 417 +++++++++++++++++++++++++++++++++++++++++
> > common/image-fit.c | 6 +-
> > common/image-sig.c | 396 --------------------------------------
> > include/image.h | 14 +-
> > lib/rsa/Kconfig | 12 ++
> > lib/rsa/Makefile | 2 +-
> > lib/rsa/rsa-verify.c | 2 +
> > tools/Makefile | 2 +-
> > 10 files changed, 452 insertions(+), 403 deletions(-)
> > create mode 100644 common/image-fit-sig.c
>
> [..]
>
> > diff --git a/include/image.h b/include/image.h
> > index c1065c06f9bd..e37011b7e463 100644
> > --- a/include/image.h
> > +++ b/include/image.h
> > @@ -18,6 +18,15 @@
> > #include "compiler.h"
> > #include <asm/byteorder.h>
> > #include <stdbool.h>
> > +#if 1
> > +#ifndef USE_HOSTCC
> > +/*
> > + * We should not include kconfig.h> on host, otherwise it may cause
> > + * build errors due to unexpected CONFIG_* defined.
> > + */
> > +#include <linux/kconfig.h>
> > +#endif
> > +#endif
>
> Can we remove all this somehow? We seem to have got this far without
> including kconfig.h
I don't remember why I added this #ifndef here. As I can't reproduce
an issue, I will remove it.
-Takahiro Akashi
> Other than that it looks good.
>
>
> - Simon
next prev parent reply other threads:[~2019-10-23 5:10 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-09 5:30 [U-Boot] [PATCH v1 0/3] rsa: extend rsa_verify() for UEFI secure boot AKASHI Takahiro
2019-10-09 5:30 ` [U-Boot] [PATCH v1 1/3] lib: rsa: decouple rsa from FIT image verification AKASHI Takahiro
2019-10-22 0:17 ` Simon Glass
2019-10-23 5:10 ` AKASHI Takahiro [this message]
2019-10-09 5:30 ` [U-Boot] [PATCH v1 2/3] lib: rsa: generate additional parameters for public key AKASHI Takahiro
2019-10-22 0:17 ` Simon Glass
2019-10-23 5:23 ` AKASHI Takahiro
2019-10-24 21:36 ` Simon Glass
2019-10-25 18:27 ` Tom Rini
2019-10-25 18:29 ` Simon Glass
2019-10-28 0:20 ` AKASHI Takahiro
2019-10-30 1:49 ` Simon Glass
2019-10-09 5:30 ` [U-Boot] [PATCH v1 3/3] lib: rsa: add rsa_verify_with_pkey() AKASHI Takahiro
2019-10-09 17:56 ` Heinrich Schuchardt
2019-10-10 1:04 ` AKASHI Takahiro
2019-10-12 12:47 ` Heinrich Schuchardt
2019-10-15 7:17 ` AKASHI Takahiro
2019-10-17 7:37 ` AKASHI Takahiro
2019-10-10 7:02 ` AKASHI Takahiro
2019-10-13 14:16 ` [U-Boot] [PATCH v1 0/3] rsa: extend rsa_verify() for UEFI secure boot Heinrich Schuchardt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191023051032.GA10448@linaro.org \
--to=takahiro.akashi@linaro.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.