Re: [PATCH v2] net: add tulip (dec21143) driver

[Sven Schnelle <svens@stackframe.org>]

On Tue, Oct 22, 2019 at 05:00:16PM +0100, Peter Maydell wrote:
> 
> There are a couple of minor wrong-indent nits:
> 
> > +static void tulip_update_ts(TULIPState *s, int state)
> > +{
> > +        s->csr[5] &= ~(CSR5_TS_MASK << CSR5_TS_SHIFT);
> > +        s->csr[5] |= (state & CSR5_TS_MASK) << CSR5_TS_SHIFT;
> > +        trace_tulip_tx_state(tulip_tx_state_name(state));
> > +}
> 
> > +struct tulip_descriptor {
> > +        uint32_t status;
> > +        uint32_t control;
> > +        uint32_t buf_addr1;
> > +        uint32_t buf_addr2;
> > +};
> 
> but maybe Jason can fix those up when he takes the patch ?

I'll send an updated version soon - there are some other small things
that i need to address.

Thanks
Sven