From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH v4] drm/bridge: analogix-anx78xx: Avoid drm_dp_link helpers Date: Wed, 23 Oct 2019 11:13:50 +0200 Message-ID: <20191023091350.GW11828@phenom.ffwll.local> References: <20191022132906.GK11828@phenom.ffwll.local> <20191022145211.2258525-1-thierry.reding@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wr1-x442.google.com (mail-wr1-x442.google.com [IPv6:2a00:1450:4864:20::442]) by gabe.freedesktop.org (Postfix) with ESMTPS id C9AA56EA08 for ; Wed, 23 Oct 2019 09:13:54 +0000 (UTC) Received: by mail-wr1-x442.google.com with SMTP id s1so12441563wro.0 for ; Wed, 23 Oct 2019 02:13:54 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20191022145211.2258525-1-thierry.reding@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Thierry Reding Cc: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org T24gVHVlLCBPY3QgMjIsIDIwMTkgYXQgMDQ6NTI6MTFQTSArMDIwMCwgVGhpZXJyeSBSZWRpbmcg d3JvdGU6Cj4gRnJvbTogVGhpZXJyeSBSZWRpbmcgPHRyZWRpbmdAbnZpZGlhLmNvbT4KPiAKPiBE dXJpbmcgdGhlIGRpc2N1c3Npb24gb2YgcGF0Y2hlcyB0aGF0IGVuaGFuY2UgdGhlIGRybV9kcF9s aW5rIGhlbHBlcnMgaXQKPiB3YXMgY29uY2x1ZGVkIHRoYXQgdGhlc2UgaGVscGVycyBhcmVuJ3Qg dmVyeSB1c2VmdWwgdG8gYmVnaW4gd2l0aC4gU3RhcnQKPiBwdXNoaW5nIHRoZSBlcXVpdmFsZW50 IGNvZGUgaW50byBpbmRpdmlkdWFsIGRyaXZlcnMgdG8gdWx0aW1hdGVseSByZW1vdmUKPiB0aGVt Lgo+IAo+IHY0OiB1c2UgYnVsayBEUENEIHdyaXRlcyBpZiBwb3NzaWJsZSAoRGFuaWVsIFZldHRl cikKPiAKPiBTaWduZWQtb2ZmLWJ5OiBUaGllcnJ5IFJlZGluZyA8dHJlZGluZ0BudmlkaWEuY29t PgoKUmV2aWV3ZWQtYnk6IERhbmllbCBWZXR0ZXIgPGRhbmllbC52ZXR0ZXJAZmZ3bGwuY2g+Cgo+ IC0tLQo+ICBkcml2ZXJzL2dwdS9kcm0vYnJpZGdlL2FuYWxvZ2l4LWFueDc4eHguYyB8IDU2ICsr KysrKysrKysrKysrKystLS0tLS0tCj4gIDEgZmlsZSBjaGFuZ2VkLCAzOSBpbnNlcnRpb25zKCsp LCAxNyBkZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2JyaWRn ZS9hbmFsb2dpeC1hbng3OHh4LmMgYi9kcml2ZXJzL2dwdS9kcm0vYnJpZGdlL2FuYWxvZ2l4LWFu eDc4eHguYwo+IGluZGV4IDlkZGMxZjNjZjg0MS4uMjc0OTg5Zjk2YTkxIDEwMDY0NAo+IC0tLSBh L2RyaXZlcnMvZ3B1L2RybS9icmlkZ2UvYW5hbG9naXgtYW54Nzh4eC5jCj4gKysrIGIvZHJpdmVy cy9ncHUvZHJtL2JyaWRnZS9hbmFsb2dpeC1hbng3OHh4LmMKPiBAQCAtNzEsNyArNzEsNiBAQCBz dHJ1Y3QgYW54Nzh4eCB7Cj4gIAlzdHJ1Y3QgaTJjX2NsaWVudCAqY2xpZW50Owo+ICAJc3RydWN0 IGVkaWQgKmVkaWQ7Cj4gIAlzdHJ1Y3QgZHJtX2Nvbm5lY3RvciBjb25uZWN0b3I7Cj4gLQlzdHJ1 Y3QgZHJtX2RwX2xpbmsgbGluazsKPiAgCXN0cnVjdCBhbng3OHh4X3BsYXRmb3JtX2RhdGEgcGRh dGE7Cj4gIAlzdHJ1Y3QgbXV0ZXggbG9jazsKPiAgCj4gQEAgLTc0OCw3ICs3NDcsNyBAQCBzdGF0 aWMgaW50IGFueDc4eHhfaW5pdF9wZGF0YShzdHJ1Y3QgYW54Nzh4eCAqYW54Nzh4eCkKPiAgCj4g IHN0YXRpYyBpbnQgYW54Nzh4eF9kcF9saW5rX3RyYWluaW5nKHN0cnVjdCBhbng3OHh4ICphbng3 OHh4KQo+ICB7Cj4gLQl1OCBkcF9idywgdmFsdWU7Cj4gKwl1OCBkcF9idywgZHBjZFsyXTsKPiAg CWludCBlcnI7Cj4gIAo+ICAJZXJyID0gcmVnbWFwX3dyaXRlKGFueDc4eHgtPm1hcFtJMkNfSURY X1JYX1AwXSwgU1BfSERNSV9NVVRFX0NUUkxfUkVHLAo+IEBAIC04MDEsMTggKzgwMCwzNCBAQCBz dGF0aWMgaW50IGFueDc4eHhfZHBfbGlua190cmFpbmluZyhzdHJ1Y3QgYW54Nzh4eCAqYW54Nzh4 eCkKPiAgCWlmIChlcnIpCj4gIAkJcmV0dXJuIGVycjsKPiAgCj4gLQkvKiBDaGVjayBsaW5rIGNh cGFiaWxpdGllcyAqLwo+IC0JZXJyID0gZHJtX2RwX2xpbmtfcHJvYmUoJmFueDc4eHgtPmF1eCwg JmFueDc4eHgtPmxpbmspOwo+IC0JaWYgKGVyciA8IDApIHsKPiAtCQlEUk1fRVJST1IoIkZhaWxl ZCB0byBwcm9iZSBsaW5rIGNhcGFiaWxpdGllczogJWRcbiIsIGVycik7Cj4gLQkJcmV0dXJuIGVy cjsKPiAtCX0KPiArCS8qCj4gKwkgKiBQb3dlciB1cCB0aGUgc2luayAoRFBfU0VUX1BPV0VSIHJl Z2lzdGVyIGlzIG9ubHkgYXZhaWxhYmxlIG9uIERQQ0QKPiArCSAqIHYxLjEgYW5kIGxhdGVyKS4K PiArCSAqLwo+ICsJaWYgKGFueDc4eHgtPmRwY2RbRFBfRFBDRF9SRVZdID49IDB4MTEpIHsKPiAr CQllcnIgPSBkcm1fZHBfZHBjZF9yZWFkYigmYW54Nzh4eC0+YXV4LCBEUF9TRVRfUE9XRVIsICZk cGNkWzBdKTsKPiArCQlpZiAoZXJyIDwgMCkgewo+ICsJCQlEUk1fRVJST1IoIkZhaWxlZCB0byBy ZWFkIERQX1NFVF9QT1dFUiByZWdpc3RlcjogJWRcbiIsCj4gKwkJCQkgIGVycik7Cj4gKwkJCXJl dHVybiBlcnI7Cj4gKwkJfQo+ICAKPiAtCS8qIFBvd2VyIHVwIHRoZSBzaW5rICovCj4gLQllcnIg PSBkcm1fZHBfbGlua19wb3dlcl91cCgmYW54Nzh4eC0+YXV4LCAmYW54Nzh4eC0+bGluayk7Cj4g LQlpZiAoZXJyIDwgMCkgewo+IC0JCURSTV9FUlJPUigiRmFpbGVkIHRvIHBvd2VyIHVwIERpc3Bs YXlQb3J0IGxpbms6ICVkXG4iLCBlcnIpOwo+IC0JCXJldHVybiBlcnI7Cj4gKwkJZHBjZFswXSAm PSB+RFBfU0VUX1BPV0VSX01BU0s7Cj4gKwkJZHBjZFswXSB8PSBEUF9TRVRfUE9XRVJfRDA7Cj4g Kwo+ICsJCWVyciA9IGRybV9kcF9kcGNkX3dyaXRlYigmYW54Nzh4eC0+YXV4LCBEUF9TRVRfUE9X RVIsIGRwY2RbMF0pOwo+ICsJCWlmIChlcnIgPCAwKSB7Cj4gKwkJCURSTV9FUlJPUigiRmFpbGVk IHRvIHBvd2VyIHVwIERpc3BsYXlQb3J0IGxpbms6ICVkXG4iLAo+ICsJCQkJICBlcnIpOwo+ICsJ CQlyZXR1cm4gZXJyOwo+ICsJCX0KPiArCj4gKwkJLyoKPiArCQkgKiBBY2NvcmRpbmcgdG8gdGhl IERQIDEuMSBzcGVjaWZpY2F0aW9uLCBhICJTaW5rIERldmljZSBtdXN0Cj4gKwkJICogZXhpdCB0 aGUgcG93ZXIgc2F2aW5nIHN0YXRlIHdpdGhpbiAxIG1zIiAoU2VjdGlvbiAyLjUuMy4xLAo+ICsJ CSAqIFRhYmxlIDUtNTIsICJTaW5rIENvbnRyb2wgRmllbGQiIChyZWdpc3RlciAweDYwMCkuCj4g KwkJICovCj4gKwkJdXNsZWVwX3JhbmdlKDEwMDAsIDIwMDApOwo+ICAJfQo+ICAKPiAgCS8qIFBv c3NpYmx5IGVuYWJsZSBkb3duc3ByZWFkIG9uIHRoZSBzaW5rICovCj4gQEAgLTg1MSwxNSArODY2 LDIyIEBAIHN0YXRpYyBpbnQgYW54Nzh4eF9kcF9saW5rX3RyYWluaW5nKHN0cnVjdCBhbng3OHh4 ICphbng3OHh4KQo+ICAJaWYgKGVycikKPiAgCQlyZXR1cm4gZXJyOwo+ICAKPiAtCXZhbHVlID0g ZHJtX2RwX2xpbmtfcmF0ZV90b19id19jb2RlKGFueDc4eHgtPmxpbmsucmF0ZSk7Cj4gKwlkcGNk WzBdID0gZHJtX2RwX21heF9saW5rX3JhdGUoYW54Nzh4eC0+ZHBjZCk7Cj4gKwlkcGNkWzBdID0g ZHJtX2RwX2xpbmtfcmF0ZV90b19id19jb2RlKGRwY2RbMF0pOwo+ICAJZXJyID0gcmVnbWFwX3dy aXRlKGFueDc4eHgtPm1hcFtJMkNfSURYX1RYX1AwXSwKPiAtCQkJICAgU1BfRFBfTUFJTl9MSU5L X0JXX1NFVF9SRUcsIHZhbHVlKTsKPiArCQkJICAgU1BfRFBfTUFJTl9MSU5LX0JXX1NFVF9SRUcs IGRwY2RbMF0pOwo+ICAJaWYgKGVycikKPiAgCQlyZXR1cm4gZXJyOwo+ICAKPiAtCWVyciA9IGRy bV9kcF9saW5rX2NvbmZpZ3VyZSgmYW54Nzh4eC0+YXV4LCAmYW54Nzh4eC0+bGluayk7Cj4gKwlk cGNkWzFdID0gZHJtX2RwX21heF9sYW5lX2NvdW50KGFueDc4eHgtPmRwY2QpOwo+ICsKPiArCWlm IChkcm1fZHBfZW5oYW5jZWRfZnJhbWVfY2FwKGFueDc4eHgtPmRwY2QpKQo+ICsJCWRwY2RbMV0g fD0gRFBfTEFORV9DT1VOVF9FTkhBTkNFRF9GUkFNRV9FTjsKPiArCj4gKwllcnIgPSBkcm1fZHBf ZHBjZF93cml0ZSgmYW54Nzh4eC0+YXV4LCBEUF9MSU5LX0JXX1NFVCwgZHBjZCwKPiArCQkJCXNp emVvZihkcGNkKSk7Cj4gIAlpZiAoZXJyIDwgMCkgewo+IC0JCURSTV9FUlJPUigiRmFpbGVkIHRv IGNvbmZpZ3VyZSBEaXNwbGF5UG9ydCBsaW5rOiAlZFxuIiwgZXJyKTsKPiArCQlEUk1fRVJST1Io IkZhaWxlZCB0byBjb25maWd1cmUgbGluazogJWRcbiIsIGVycik7Cj4gIAkJcmV0dXJuIGVycjsK PiAgCX0KPiAgCj4gLS0gCj4gMi4yMy4wCj4gCgotLSAKRGFuaWVsIFZldHRlcgpTb2Z0d2FyZSBF bmdpbmVlciwgSW50ZWwgQ29ycG9yYXRpb24KaHR0cDovL2Jsb2cuZmZ3bGwuY2gKX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcg bGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRl c2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVs