All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stephen Hemminger <stephen@networkplumber.org>
To: "Michał Łyszczek" <michal.lyszczek@bofc.pl>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH iproute2] ipnetns: do not check netns NAME when -all is specified
Date: Wed, 23 Oct 2019 09:21:45 -0700	[thread overview]
Message-ID: <20191023092145.0daebf54@hermes.lan> (raw)
In-Reply-To: <20191022200923.17366-1-michal.lyszczek@bofc.pl>

On Tue, 22 Oct 2019 22:09:23 +0200
Michał Łyszczek <michal.lyszczek@bofc.pl> wrote:

> When `-all' argument is specified netns runs cmd on all namespaces
> and NAME is not used, but netns nevertheless checks if argv[1] is a
> valid namespace name ignoring the fact that argv[1] contains cmd
> and not NAME. This results in bug where user cannot specify
> absolute path to command.
> 
>     # ip -all netns exec /usr/bin/whoami
>     Invalid netns name "/usr/bin/whoami"
> 
> This forces user to have his command in PATH.
> 
> Solution is simply to not validate argv[1] when `-all' argument is
> specified.
> 
> Signed-off-by: Michał Łyszczek <michal.lyszczek@bofc.pl>

Looks good, applied thanks


      reply	other threads:[~2019-10-23 16:21 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-22 20:09 [PATCH iproute2] ipnetns: do not check netns NAME when -all is specified Michał Łyszczek
2019-10-23 16:21 ` Stephen Hemminger [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191023092145.0daebf54@hermes.lan \
    --to=stephen@networkplumber.org \
    --cc=michal.lyszczek@bofc.pl \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.