From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9C881CA9EB6 for ; Wed, 23 Oct 2019 12:47:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6BBCF21920 for ; Wed, 23 Oct 2019 12:47:57 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=onstation.org header.i=@onstation.org header.b="Ty01jSUZ" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2405385AbfJWMr4 (ORCPT ); Wed, 23 Oct 2019 08:47:56 -0400 Received: from onstation.org ([52.200.56.107]:33894 "EHLO onstation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2405381AbfJWMr4 (ORCPT ); Wed, 23 Oct 2019 08:47:56 -0400 Received: from localhost (c-98-239-145-235.hsd1.wv.comcast.net [98.239.145.235]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: masneyb) by onstation.org (Postfix) with ESMTPSA id F35C83E951; Wed, 23 Oct 2019 12:47:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=onstation.org; s=default; t=1571834875; bh=0kqhIdrcdwTaeOk++zBCxLaWbwoAfqHJ5bwvzT6eofE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Ty01jSUZZyZs/E5U7fYrVJsqd7rCW3TaZaBl4f6bW9Imrc+LwyG/rkLvdy1HnEelF yz54byi8l52QHKOb+vJbMLzFSvC5pmQg29NgewohrS2cpj2QCPLe7MwSxSaRhAcH7K 8lU1zbQPw4nW+ClZbLkZrp8GCMt2MEyGq6n/hcZU= Date: Wed, 23 Oct 2019 08:47:53 -0400 From: Brian Masney To: Georgi Djakov Cc: agross@kernel.org, bjorn.andersson@linaro.org, robh+dt@kernel.org, mark.rutland@arm.com, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 5/5] ARM: dts: qcom: msm8974: add interconnect nodes Message-ID: <20191023124753.GA14218@onstation.org> References: <20191013080804.10231-1-masneyb@onstation.org> <20191013080804.10231-6-masneyb@onstation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Wed, Oct 23, 2019 at 02:50:19PM +0300, Georgi Djakov wrote: > On 13.10.19 г. 11:08 ч., Brian Masney wrote: > > Add interconnect nodes that's needed to support bus scaling. > > > > Signed-off-by: Brian Masney > > --- > > arch/arm/boot/dts/qcom-msm8974.dtsi | 60 +++++++++++++++++++++++++++++ > > 1 file changed, 60 insertions(+) > > > > diff --git a/arch/arm/boot/dts/qcom-msm8974.dtsi b/arch/arm/boot/dts/qcom-msm8974.dtsi > > @@ -1152,6 +1207,11 @@ > > "core", > > "vsync"; > > > > + interconnects = <&mmssnoc MNOC_MAS_GRAPHICS_3D &bimc BIMC_SLV_EBI_CH0>, > > + <&ocmemnoc OCMEM_VNOC_MAS_GFX3D &ocmemnoc OCMEM_SLV_OCMEM>; > > Who will be the requesting bandwidth to DDR and ocmem? Is it the display or GPU > or both? The above seem like GPU-related interconnects, so maybe these > properties should be in the GPU DT node. The display is what currently requests the interconnect path, specifically mdp5_setup_interconnect() in drivers/gpu/drm/msm/disp/mdp5/mdp5_kms.c. The Freedreno GPU bindings currently don't have interconnect support. Maybe this is something that I should add to that driver as well? > > + interconnect-names = "mdp0-mem", > > + "mdp1-mem"; > > As the second path is not to DDR, but to ocmem, it might be better to call it > something like "gpu-ocmem". I used what mdp5_kms.c expected. Brian From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 05769CA9EB6 for ; Wed, 23 Oct 2019 12:48:06 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CB24820640 for ; Wed, 23 Oct 2019 12:48:05 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="NCMrA72t"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=onstation.org header.i=@onstation.org header.b="Ty01jSUZ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CB24820640 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=onstation.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ES5yzpc0moX/WJaJJ+gvoaQSAeA5hFj0m0QOs2Cm09g=; b=NCMrA72tKKmyhV iAgXQfVakyhE4XuybGIpK7K/JObveCV9Jl4EEcnJvSe4wVsPVqC/v9/cwwwn9TkhinzaIK4oXPieJ oWxvduarcItCho6CarT/HZIvZv6SDKhOYgfBXhqKxV9le0Mh47ACopSQiBUAXbnhLpI3Uf0c/eRvf zkFD69Tmdai1YpJ50ElD78iSrPdldsmerDYN7HDRcv4jsrIbbASbt8bfrQxOTUjCv1ibWjy6+nR3O DHjFr+vZ26CUvQrhyIE4wfksNGu2w1cAHDSz/g9TrCig2I+03nrHoblYG6KFREPNJrCxN5iVujCvi nPJq0kG+ub0CokDDgVwQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iNG3Z-0001wb-9y; Wed, 23 Oct 2019 12:48:05 +0000 Received: from onstation.org ([52.200.56.107]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iNG3V-0001vN-KX for linux-arm-kernel@lists.infradead.org; Wed, 23 Oct 2019 12:48:03 +0000 Received: from localhost (c-98-239-145-235.hsd1.wv.comcast.net [98.239.145.235]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: masneyb) by onstation.org (Postfix) with ESMTPSA id F35C83E951; Wed, 23 Oct 2019 12:47:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=onstation.org; s=default; t=1571834875; bh=0kqhIdrcdwTaeOk++zBCxLaWbwoAfqHJ5bwvzT6eofE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Ty01jSUZZyZs/E5U7fYrVJsqd7rCW3TaZaBl4f6bW9Imrc+LwyG/rkLvdy1HnEelF yz54byi8l52QHKOb+vJbMLzFSvC5pmQg29NgewohrS2cpj2QCPLe7MwSxSaRhAcH7K 8lU1zbQPw4nW+ClZbLkZrp8GCMt2MEyGq6n/hcZU= Date: Wed, 23 Oct 2019 08:47:53 -0400 From: Brian Masney To: Georgi Djakov Subject: Re: [PATCH 5/5] ARM: dts: qcom: msm8974: add interconnect nodes Message-ID: <20191023124753.GA14218@onstation.org> References: <20191013080804.10231-1-masneyb@onstation.org> <20191013080804.10231-6-masneyb@onstation.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191023_054801_737074_6E5AB64B X-CRM114-Status: GOOD ( 16.19 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mark.rutland@arm.com, devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, robh+dt@kernel.org, bjorn.andersson@linaro.org, agross@kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gV2VkLCBPY3QgMjMsIDIwMTkgYXQgMDI6NTA6MTlQTSArMDMwMCwgR2VvcmdpIERqYWtvdiB3 cm90ZToKPiBPbiAxMy4xMC4xOSDQsy4gMTE6MDgg0YcuLCBCcmlhbiBNYXNuZXkgd3JvdGU6Cj4g PiBBZGQgaW50ZXJjb25uZWN0IG5vZGVzIHRoYXQncyBuZWVkZWQgdG8gc3VwcG9ydCBidXMgc2Nh bGluZy4KPiA+IAo+ID4gU2lnbmVkLW9mZi1ieTogQnJpYW4gTWFzbmV5IDxtYXNuZXliQG9uc3Rh dGlvbi5vcmc+Cj4gPiAtLS0KPiA+ICBhcmNoL2FybS9ib290L2R0cy9xY29tLW1zbTg5NzQuZHRz aSB8IDYwICsrKysrKysrKysrKysrKysrKysrKysrKysrKysrCj4gPiAgMSBmaWxlIGNoYW5nZWQs IDYwIGluc2VydGlvbnMoKykKPiA+IAo+ID4gZGlmZiAtLWdpdCBhL2FyY2gvYXJtL2Jvb3QvZHRz L3Fjb20tbXNtODk3NC5kdHNpIGIvYXJjaC9hcm0vYm9vdC9kdHMvcWNvbS1tc204OTc0LmR0c2kK PiA+IEBAIC0xMTUyLDYgKzEyMDcsMTEgQEAKPiA+ICAJCQkJICAgICAgICAgICAgICAiY29yZSIs Cj4gPiAgCQkJCSAgICAgICAgICAgICAgInZzeW5jIjsKPiA+ICAKPiA+ICsJCQkJaW50ZXJjb25u ZWN0cyA9IDwmbW1zc25vYyBNTk9DX01BU19HUkFQSElDU18zRCAmYmltYyBCSU1DX1NMVl9FQklf Q0gwPiwKPiA+ICsJCQkJICAgICAgICAgICAgICAgIDwmb2NtZW1ub2MgT0NNRU1fVk5PQ19NQVNf R0ZYM0QgJm9jbWVtbm9jIE9DTUVNX1NMVl9PQ01FTT47Cj4gCj4gV2hvIHdpbGwgYmUgdGhlIHJl cXVlc3RpbmcgYmFuZHdpZHRoIHRvIEREUiBhbmQgb2NtZW0/IElzIGl0IHRoZSBkaXNwbGF5IG9y IEdQVQo+IG9yIGJvdGg/IFRoZSBhYm92ZSBzZWVtIGxpa2UgR1BVLXJlbGF0ZWQgaW50ZXJjb25u ZWN0cywgc28gbWF5YmUgdGhlc2UKPiBwcm9wZXJ0aWVzIHNob3VsZCBiZSBpbiB0aGUgR1BVIERU IG5vZGUuCgpUaGUgZGlzcGxheSBpcyB3aGF0IGN1cnJlbnRseSByZXF1ZXN0cyB0aGUgaW50ZXJj b25uZWN0IHBhdGgsCnNwZWNpZmljYWxseSBtZHA1X3NldHVwX2ludGVyY29ubmVjdCgpIGluCmRy aXZlcnMvZ3B1L2RybS9tc20vZGlzcC9tZHA1L21kcDVfa21zLmMuIFRoZSBGcmVlZHJlbm8gR1BV IGJpbmRpbmdzCmN1cnJlbnRseSBkb24ndCBoYXZlIGludGVyY29ubmVjdCBzdXBwb3J0LiBNYXli ZSB0aGlzIGlzIHNvbWV0aGluZyB0aGF0Ckkgc2hvdWxkIGFkZCB0byB0aGF0IGRyaXZlciBhcyB3 ZWxsPwoKPiA+ICsJCQkJaW50ZXJjb25uZWN0LW5hbWVzID0gIm1kcDAtbWVtIiwKPiA+ICsJCQkJ ICAgICAgICAgICAgICAgICAgICAgIm1kcDEtbWVtIjsKPiAKPiBBcyB0aGUgc2Vjb25kIHBhdGgg aXMgbm90IHRvIEREUiwgYnV0IHRvIG9jbWVtLCBpdCBtaWdodCBiZSBiZXR0ZXIgdG8gY2FsbCBp dAo+IHNvbWV0aGluZyBsaWtlICJncHUtb2NtZW0iLgoKSSB1c2VkIHdoYXQgbWRwNV9rbXMuYyBl eHBlY3RlZC4KCkJyaWFuCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fXwpsaW51eC1hcm0ta2VybmVsIG1haWxpbmcgbGlzdApsaW51eC1hcm0ta2VybmVsQGxp c3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0 aW5mby9saW51eC1hcm0ta2VybmVsCg==