From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 57EA0CA9EB6 for ; Wed, 23 Oct 2019 12:51:55 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5749820640 for ; Wed, 23 Oct 2019 12:51:54 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="myZjKihr" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5749820640 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 3C0BF1615; Wed, 23 Oct 2019 14:51:02 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 3C0BF1615 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1571835112; bh=Q4aW7ZqHXkSCM9bArD2tjL5cR7dYmwQuztP8VHuDaak=; h=Date:From:To:References:In-Reply-To:Cc:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=myZjKihratt+qfHfVHQ9oMOGNzdmzIvfYQ/If8lun5iDIroryWcB9Hzh1qhPCe+/b HwFb8rGp6Dea/S1nVpC+9Fcsm/FdIEXyg6adc/QySTkMkhG4+Wiz/w/HJiql81ovcV VSwwMpQtiU99A451V26fJ7sVAsIZR7HkL9bYsDhQ= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 93954F80321; Wed, 23 Oct 2019 14:51:01 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 0C854F80368; Wed, 23 Oct 2019 14:51:00 +0200 (CEST) Received: from mail-ed1-f68.google.com (mail-ed1-f68.google.com [209.85.208.68]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 95878F80274 for ; Wed, 23 Oct 2019 14:50:56 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 95878F80274 Received: by mail-ed1-f68.google.com with SMTP id c4so15668359edl.0 for ; Wed, 23 Oct 2019 05:50:56 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=oT2q812vkwR6lQz5u4dP7bLM7jh35Rq8yHei8+lOv9w=; b=DHwgjVrzGy4EaDBB2XfkzgEnaGM1zda7ZHVbgkV4+qdO1gcyelrdclnF/DeCNNEeNb j02Re3kCkzum5SzpbA/gbE4x1q7SOC5Krwn3BRmjr6cGYt1AUNIiW+zPRsgeM1UJc0KW 6aSW7ZOysgmeDlvBzYs8DuJp5yhwxpot5hksHBYlaEFeXJ2DQ48JuAZ34DkpQkAV8xRF LtEOoBH4k4ZXeO0E+Rwa7Sziq7zpdF2MaNOpiqF3Xhhda4fCBkX7TC1GxKH8DeFltQzx 0LD3rwnQ0aiG2iHEV4cSX6nMZLCujpc9oIu72ro0+FVGXK9mXKJmcXnJ+IeV5QFTMGKw CY3g== X-Gm-Message-State: APjAAAVd2/3Li4zgpvzAqtAZDDSPN6qyZWqoKhDQWO+iJhOSeB8AwGra U14SLFrmsVCky5sCSjc+CYY= X-Google-Smtp-Source: APXvYqzLq1IwwtENOWtlyqBj9T2iqCV94L/4HoNoJFxSLjEVDtlX9NMAHQ1sSA9Bd3uXFYj6DR034w== X-Received: by 2002:a05:6402:88c:: with SMTP id e12mr23305215edy.170.1571835056324; Wed, 23 Oct 2019 05:50:56 -0700 (PDT) Received: from pi3 ([194.230.155.217]) by smtp.googlemail.com with ESMTPSA id i63sm780337edi.65.2019.10.23.05.50.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 23 Oct 2019 05:50:55 -0700 (PDT) Date: Wed, 23 Oct 2019 14:50:53 +0200 From: Krzysztof Kozlowski To: Arnd Bergmann Message-ID: <20191023125053.GF11048@pi3> References: <20191010202802.1132272-1-arnd@arndb.de> <20191010203043.1241612-1-arnd@arndb.de> <20191010203043.1241612-21-arnd@arndb.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20191010203043.1241612-21-arnd@arndb.de> User-Agent: Mutt/1.12.1 (2019-06-15) Cc: Ulf Hansson , linux-samsung-soc@vger.kernel.org, alsa-devel@alsa-project.org, Sangbeom Kim , linux-kernel@vger.kernel.org, linus.walleij@linaro.org, Takashi Iwai , Liam Girdwood , Mark Brown , Kukjin Kim , Sylwester Nawrocki , linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org Subject: Re: [alsa-devel] [PATCH 21/36] ARM: s3c: move iis pinctrl config into boards X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Thu, Oct 10, 2019 at 10:30:05PM +0200, Arnd Bergmann wrote: > The s3c_gpio_cfgall_range() function is an internal interface of > the samsung gpio driver and should not be called directly by drivers, > so move the iis pin initialization into the boards. > > Note that the s3c2412-i2s driver has no boards using it in > mainline linux, the driver gets selected for the jive machine > but is never instantiated. > > Signed-off-by: Arnd Bergmann > --- > arch/arm/mach-s3c24xx/mach-gta02.c | 4 ++++ > arch/arm/mach-s3c24xx/mach-h1940.c | 3 +++ > arch/arm/mach-s3c24xx/mach-mini2440.c | 5 +++++ > arch/arm/mach-s3c24xx/mach-n30.c | 5 +++++ > arch/arm/mach-s3c24xx/mach-nexcoder.c | 5 +++++ > arch/arm/mach-s3c24xx/mach-otom.c | 6 ++++++ > arch/arm/mach-s3c24xx/mach-qt2410.c | 3 +++ > arch/arm/mach-s3c24xx/mach-rx1950.c | 3 +++ > arch/arm/mach-s3c24xx/mach-rx3715.c | 4 ++++ > arch/arm/mach-s3c24xx/mach-smdk2410.c | 5 +++++ > arch/arm/mach-s3c24xx/mach-smdk2413.c | 4 ++++ > arch/arm/mach-s3c24xx/mach-smdk2440.c | 6 +++++- > arch/arm/mach-s3c24xx/mach-vstms.c | 6 +++++- > arch/arm/mach-s3c24xx/simtec-audio.c | 6 ++++++ > sound/soc/samsung/s3c2412-i2s.c | 7 ------- > sound/soc/samsung/s3c24xx-i2s.c | 7 ------- > 16 files changed, 63 insertions(+), 16 deletions(-) > > diff --git a/arch/arm/mach-s3c24xx/mach-gta02.c b/arch/arm/mach-s3c24xx/mach-gta02.c > index 526fd0933289..1ca0460d82f4 100644 > --- a/arch/arm/mach-s3c24xx/mach-gta02.c > +++ b/arch/arm/mach-s3c24xx/mach-gta02.c > @@ -540,6 +540,10 @@ static void __init gta02_machine_init(void) > > i2c_register_board_info(0, gta02_i2c_devs, ARRAY_SIZE(gta02_i2c_devs)); > > + /* Configure the I2S pins (GPE0...GPE4) in correct mode */ > + s3c_gpio_cfgall_range(S3C2410_GPE(0), 5, S3C_GPIO_SFN(2), > + S3C_GPIO_PULL_NONE); This is not entirely equivalent move as before this was probe (so being executed also on rebinds) and now it is init. I guess it should not make any difference so let it be. Best regards, Krzysztof _______________________________________________ Alsa-devel mailing list Alsa-devel@alsa-project.org https://mailman.alsa-project.org/mailman/listinfo/alsa-devel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 31253CA9EB9 for ; Wed, 23 Oct 2019 12:50:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 075C22173B for ; Wed, 23 Oct 2019 12:50:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1571835059; bh=T2Glx9RTjlFT9FkGXOCt1ml4fZ8gy+uQGlUDPcU+y0M=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=bVdGhh663pTbrrW/oGH2f+/OnoJ5WCm+ZBEz6PN85UD7IMoZv7O+GOlXP5sZIZG5Q Jwf2zwj6pDqn77ExqJ5RndsedrilyKy0a7JnK0b9q0DI466JpS92J5tAIldQDysuli iiXVGEDgqARIgCK3Mn9xJWQJmTYDxJ9HRu+L6GgM= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2391777AbfJWMu6 (ORCPT ); Wed, 23 Oct 2019 08:50:58 -0400 Received: from mail-ed1-f68.google.com ([209.85.208.68]:44020 "EHLO mail-ed1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2391683AbfJWMu6 (ORCPT ); Wed, 23 Oct 2019 08:50:58 -0400 Received: by mail-ed1-f68.google.com with SMTP id q24so9673114edr.10; Wed, 23 Oct 2019 05:50:57 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=oT2q812vkwR6lQz5u4dP7bLM7jh35Rq8yHei8+lOv9w=; b=kS1X1nMGBxMBPVs/M7fHz1EIhJYTK5VXNdrni33UKnpObnrwXXYVH6fn0KOf9bKwoU AW85dcb6wsRJFPc4zQUdMAUgkQNAPIXxpncjoqVxjQY9/XRrLViA44CdN4vOUKyTNKi/ zXju32QZ75DXz9DG++kQZ78+DWkBUnMLgb7fWert/XXmLzmrgA6to/JCu76aHCrId3OQ Yh2GRAmKQm9pK9eO+dfwIVdm4fabBBtN4uNOgXN3xtzi/gnyjJdeCqCpFLqeMRYFXTr/ bY4ZW29SZxgt7O6wWjX2pAy2+qCdPMSPwqrZAA3jqvQldFaUz8DrPGNnvSUTC1wzQ/sf bPGQ== X-Gm-Message-State: APjAAAUda0nJG6OO3H4NVW185qbYkKj7/oTiA8Ru29YTw4UxEc0XmgbN P8gh8mbU2jCO3n89X2K33fM= X-Google-Smtp-Source: APXvYqzLq1IwwtENOWtlyqBj9T2iqCV94L/4HoNoJFxSLjEVDtlX9NMAHQ1sSA9Bd3uXFYj6DR034w== X-Received: by 2002:a05:6402:88c:: with SMTP id e12mr23305215edy.170.1571835056324; Wed, 23 Oct 2019 05:50:56 -0700 (PDT) Received: from pi3 ([194.230.155.217]) by smtp.googlemail.com with ESMTPSA id i63sm780337edi.65.2019.10.23.05.50.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 23 Oct 2019 05:50:55 -0700 (PDT) Date: Wed, 23 Oct 2019 14:50:53 +0200 From: Krzysztof Kozlowski To: Arnd Bergmann Cc: Kukjin Kim , Sangbeom Kim , Sylwester Nawrocki , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linus.walleij@linaro.org, Ulf Hansson , linux-kernel@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, alsa-devel@alsa-project.org Subject: Re: [PATCH 21/36] ARM: s3c: move iis pinctrl config into boards Message-ID: <20191023125053.GF11048@pi3> References: <20191010202802.1132272-1-arnd@arndb.de> <20191010203043.1241612-1-arnd@arndb.de> <20191010203043.1241612-21-arnd@arndb.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20191010203043.1241612-21-arnd@arndb.de> User-Agent: Mutt/1.12.1 (2019-06-15) Sender: linux-samsung-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-samsung-soc@vger.kernel.org On Thu, Oct 10, 2019 at 10:30:05PM +0200, Arnd Bergmann wrote: > The s3c_gpio_cfgall_range() function is an internal interface of > the samsung gpio driver and should not be called directly by drivers, > so move the iis pin initialization into the boards. > > Note that the s3c2412-i2s driver has no boards using it in > mainline linux, the driver gets selected for the jive machine > but is never instantiated. > > Signed-off-by: Arnd Bergmann > --- > arch/arm/mach-s3c24xx/mach-gta02.c | 4 ++++ > arch/arm/mach-s3c24xx/mach-h1940.c | 3 +++ > arch/arm/mach-s3c24xx/mach-mini2440.c | 5 +++++ > arch/arm/mach-s3c24xx/mach-n30.c | 5 +++++ > arch/arm/mach-s3c24xx/mach-nexcoder.c | 5 +++++ > arch/arm/mach-s3c24xx/mach-otom.c | 6 ++++++ > arch/arm/mach-s3c24xx/mach-qt2410.c | 3 +++ > arch/arm/mach-s3c24xx/mach-rx1950.c | 3 +++ > arch/arm/mach-s3c24xx/mach-rx3715.c | 4 ++++ > arch/arm/mach-s3c24xx/mach-smdk2410.c | 5 +++++ > arch/arm/mach-s3c24xx/mach-smdk2413.c | 4 ++++ > arch/arm/mach-s3c24xx/mach-smdk2440.c | 6 +++++- > arch/arm/mach-s3c24xx/mach-vstms.c | 6 +++++- > arch/arm/mach-s3c24xx/simtec-audio.c | 6 ++++++ > sound/soc/samsung/s3c2412-i2s.c | 7 ------- > sound/soc/samsung/s3c24xx-i2s.c | 7 ------- > 16 files changed, 63 insertions(+), 16 deletions(-) > > diff --git a/arch/arm/mach-s3c24xx/mach-gta02.c b/arch/arm/mach-s3c24xx/mach-gta02.c > index 526fd0933289..1ca0460d82f4 100644 > --- a/arch/arm/mach-s3c24xx/mach-gta02.c > +++ b/arch/arm/mach-s3c24xx/mach-gta02.c > @@ -540,6 +540,10 @@ static void __init gta02_machine_init(void) > > i2c_register_board_info(0, gta02_i2c_devs, ARRAY_SIZE(gta02_i2c_devs)); > > + /* Configure the I2S pins (GPE0...GPE4) in correct mode */ > + s3c_gpio_cfgall_range(S3C2410_GPE(0), 5, S3C_GPIO_SFN(2), > + S3C_GPIO_PULL_NONE); This is not entirely equivalent move as before this was probe (so being executed also on rebinds) and now it is init. I guess it should not make any difference so let it be. Best regards, Krzysztof From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7C64DCA9EB9 for ; Wed, 23 Oct 2019 12:51:07 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 51EAD2173B for ; Wed, 23 Oct 2019 12:51:07 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="sHL56lwc" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 51EAD2173B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=IjSuFBH2HLngExo0AEn0toPMEMBj9kwdu6tpxiewefg=; b=sHL56lwcbwtFt+ KOS8xxi5oPeLiZBCRJYKhZMbrb9fWfUsdunCY/oCtKew1XtoSMGY6nEMxUP5X5nAtTogQz6ROEZMo yYqpGWbEj6TpsVVuEQTjlhKhkmCUjr92pl7zZXhw3AS82E40OqxDSn4R3dSU0hHoAIjABvTePc6Ex 0py8fUFZvUJxAVdjtNqpGuoxHzxFJ22ateWaorA4v2cMshBNQk3XxsVsMGIx43TYX93SSveXGJDVh hpVeygx5HQDfhGoKfQYFPq2YW0e+zG21Cp4kr9in8Todj0YfjNYp+DdPeibPLdMQqu1h6QMSGVOGS 6HJrrTdy/RcynIW8+ofA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iNG6O-0003b7-RH; Wed, 23 Oct 2019 12:51:00 +0000 Received: from mail-ed1-f65.google.com ([209.85.208.65]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iNG6L-0003am-NZ for linux-arm-kernel@lists.infradead.org; Wed, 23 Oct 2019 12:50:59 +0000 Received: by mail-ed1-f65.google.com with SMTP id l25so4408639edt.6 for ; Wed, 23 Oct 2019 05:50:57 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=oT2q812vkwR6lQz5u4dP7bLM7jh35Rq8yHei8+lOv9w=; b=mWeMxW49vOvUp8/fJ4zQ1xWUO35Wim3Ow0KmvBs0sOiSLbmlXP2t/eB23mwa2kx5oK 0sWZOi/ZrFFc3aa19an9MyfX49bXiMaiO+leDtZU9h6UgyT1NMgQpTkq9o1CaEWHCRVd hbl6Ya9bt0n9n/7i0bPlAE8Yz7h9OSwsXf9T9wFPGQLdQp9UHLmwrwJcRRhf0duciNPT GcRDl0/8VVpn2KTPYCiQE6pk8RRU4YJDDb1/3w9KGQJ7QTNzvknCyTRWLyiIailMqQ3a zreJEJuzIHEdJ1FNtKIm9Ey4XzA2z9MSt3kv/Hxvu5cLcK8Ra3s+RMdOJVOa47XcjVHV T0QQ== X-Gm-Message-State: APjAAAUXoIs5tS4L3fGGCs5mZxA8BVCx5bxsotcphQHvVc0O/YIHGBS0 2incetrkhbAxPPJSBN0yKvk= X-Google-Smtp-Source: APXvYqzLq1IwwtENOWtlyqBj9T2iqCV94L/4HoNoJFxSLjEVDtlX9NMAHQ1sSA9Bd3uXFYj6DR034w== X-Received: by 2002:a05:6402:88c:: with SMTP id e12mr23305215edy.170.1571835056324; Wed, 23 Oct 2019 05:50:56 -0700 (PDT) Received: from pi3 ([194.230.155.217]) by smtp.googlemail.com with ESMTPSA id i63sm780337edi.65.2019.10.23.05.50.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 23 Oct 2019 05:50:55 -0700 (PDT) Date: Wed, 23 Oct 2019 14:50:53 +0200 From: Krzysztof Kozlowski To: Arnd Bergmann Subject: Re: [PATCH 21/36] ARM: s3c: move iis pinctrl config into boards Message-ID: <20191023125053.GF11048@pi3> References: <20191010202802.1132272-1-arnd@arndb.de> <20191010203043.1241612-1-arnd@arndb.de> <20191010203043.1241612-21-arnd@arndb.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20191010203043.1241612-21-arnd@arndb.de> User-Agent: Mutt/1.12.1 (2019-06-15) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191023_055057_772753_3299D318 X-CRM114-Status: GOOD ( 17.89 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Ulf Hansson , linux-samsung-soc@vger.kernel.org, alsa-devel@alsa-project.org, Sangbeom Kim , linux-kernel@vger.kernel.org, linus.walleij@linaro.org, Takashi Iwai , Liam Girdwood , Jaroslav Kysela , Mark Brown , Kukjin Kim , Sylwester Nawrocki , linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Oct 10, 2019 at 10:30:05PM +0200, Arnd Bergmann wrote: > The s3c_gpio_cfgall_range() function is an internal interface of > the samsung gpio driver and should not be called directly by drivers, > so move the iis pin initialization into the boards. > > Note that the s3c2412-i2s driver has no boards using it in > mainline linux, the driver gets selected for the jive machine > but is never instantiated. > > Signed-off-by: Arnd Bergmann > --- > arch/arm/mach-s3c24xx/mach-gta02.c | 4 ++++ > arch/arm/mach-s3c24xx/mach-h1940.c | 3 +++ > arch/arm/mach-s3c24xx/mach-mini2440.c | 5 +++++ > arch/arm/mach-s3c24xx/mach-n30.c | 5 +++++ > arch/arm/mach-s3c24xx/mach-nexcoder.c | 5 +++++ > arch/arm/mach-s3c24xx/mach-otom.c | 6 ++++++ > arch/arm/mach-s3c24xx/mach-qt2410.c | 3 +++ > arch/arm/mach-s3c24xx/mach-rx1950.c | 3 +++ > arch/arm/mach-s3c24xx/mach-rx3715.c | 4 ++++ > arch/arm/mach-s3c24xx/mach-smdk2410.c | 5 +++++ > arch/arm/mach-s3c24xx/mach-smdk2413.c | 4 ++++ > arch/arm/mach-s3c24xx/mach-smdk2440.c | 6 +++++- > arch/arm/mach-s3c24xx/mach-vstms.c | 6 +++++- > arch/arm/mach-s3c24xx/simtec-audio.c | 6 ++++++ > sound/soc/samsung/s3c2412-i2s.c | 7 ------- > sound/soc/samsung/s3c24xx-i2s.c | 7 ------- > 16 files changed, 63 insertions(+), 16 deletions(-) > > diff --git a/arch/arm/mach-s3c24xx/mach-gta02.c b/arch/arm/mach-s3c24xx/mach-gta02.c > index 526fd0933289..1ca0460d82f4 100644 > --- a/arch/arm/mach-s3c24xx/mach-gta02.c > +++ b/arch/arm/mach-s3c24xx/mach-gta02.c > @@ -540,6 +540,10 @@ static void __init gta02_machine_init(void) > > i2c_register_board_info(0, gta02_i2c_devs, ARRAY_SIZE(gta02_i2c_devs)); > > + /* Configure the I2S pins (GPE0...GPE4) in correct mode */ > + s3c_gpio_cfgall_range(S3C2410_GPE(0), 5, S3C_GPIO_SFN(2), > + S3C_GPIO_PULL_NONE); This is not entirely equivalent move as before this was probe (so being executed also on rebinds) and now it is init. I guess it should not make any difference so let it be. Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel