From mboxrd@z Thu Jan 1 00:00:00 1970 From: Krzysztof Kozlowski Date: Wed, 23 Oct 2019 13:13:21 +0000 Subject: Re: [PATCH 28/36] fbdev: s3c2410fb: remove mach header dependency Message-Id: <20191023131321.GH11048@pi3> List-Id: References: <20191010202802.1132272-1-arnd@arndb.de> <20191010203043.1241612-1-arnd@arndb.de> <20191010203043.1241612-28-arnd@arndb.de> In-Reply-To: <20191010203043.1241612-28-arnd@arndb.de> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Arnd Bergmann Cc: linux-fbdev@vger.kernel.org, linux-samsung-soc@vger.kernel.org, Bartlomiej Zolnierkiewicz , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Kukjin Kim , linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org On Thu, Oct 10, 2019 at 10:30:12PM +0200, Arnd Bergmann wrote: > The s3c2410fb driver is too deeply intertwined with the s3c24xx > platform code. Change it in a way that avoids the use of platform > header files but having all interface data in a platform_data > header, and the private register definitions next to the driver > itself. > > One ugly bit here is that the driver pokes directly into gpio > registers, which are owned by another driver. Passing the > mapped addresses in platform_data is somewhat suboptimal, but > it is a small improvement over the previous version. > > Signed-off-by: Arnd Bergmann > --- > arch/arm/mach-s3c24xx/include/mach/fb.h | 2 -- > arch/arm/mach-s3c24xx/mach-amlm5900.c | 7 ++-- > arch/arm/mach-s3c24xx/mach-anubis.c | 1 - > arch/arm/mach-s3c24xx/mach-at2440evb.c | 3 +- > arch/arm/mach-s3c24xx/mach-bast.c | 3 +- > arch/arm/mach-s3c24xx/mach-gta02.c | 2 +- > arch/arm/mach-s3c24xx/mach-h1940.c | 7 ++-- > arch/arm/mach-s3c24xx/mach-jive.c | 10 ++++-- > arch/arm/mach-s3c24xx/mach-mini2440.c | 9 +++-- > arch/arm/mach-s3c24xx/mach-n30.c | 3 +- > arch/arm/mach-s3c24xx/mach-osiris.c | 1 - > arch/arm/mach-s3c24xx/mach-qt2410.c | 3 +- > arch/arm/mach-s3c24xx/mach-rx1950.c | 8 +++-- > arch/arm/mach-s3c24xx/mach-rx3715.c | 7 ++-- > arch/arm/mach-s3c24xx/mach-smdk2413.c | 3 +- > arch/arm/mach-s3c24xx/mach-smdk2416.c | 1 - > arch/arm/mach-s3c24xx/mach-smdk2440.c | 8 +++-- > arch/arm/mach-s3c24xx/mach-smdk2443.c | 3 +- > arch/arm/mach-s3c24xx/mach-vstms.c | 3 +- > arch/arm/plat-samsung/devs.c | 2 +- > .../video/fbdev/s3c2410fb-regs-lcd.h | 28 ++++------------ > drivers/video/fbdev/s3c2410fb.c | 16 +++++---- > .../linux/platform_data}/fb-s3c2410.h | 33 ++++++++++++++++++- > 23 files changed, 98 insertions(+), 65 deletions(-) > delete mode 100644 arch/arm/mach-s3c24xx/include/mach/fb.h > rename arch/arm/mach-s3c24xx/include/mach/regs-lcd.h => drivers/video/fbdev/s3c2410fb-regs-lcd.h (84%) > rename {arch/arm/plat-samsung/include/plat => include/linux/platform_data}/fb-s3c2410.h (57%) > > diff --git a/arch/arm/mach-s3c24xx/include/mach/fb.h b/arch/arm/mach-s3c24xx/include/mach/fb.h > deleted file mode 100644 > index 4e539cb8b884..000000000000 > --- a/arch/arm/mach-s3c24xx/include/mach/fb.h > +++ /dev/null > @@ -1,2 +0,0 @@ > -/* SPDX-License-Identifier: GPL-2.0 */ > -#include > diff --git a/arch/arm/mach-s3c24xx/mach-amlm5900.c b/arch/arm/mach-s3c24xx/mach-amlm5900.c > index 40ad23b52bc0..ef6de1b1d0c6 100644 > --- a/arch/arm/mach-s3c24xx/mach-amlm5900.c > +++ b/arch/arm/mach-s3c24xx/mach-amlm5900.c > @@ -30,9 +30,8 @@ > #include > #include > #include > -#include > +#include > > -#include > #include > #include > > @@ -194,13 +193,17 @@ static struct s3c2410fb_mach_info __initdata amlm5900_fb_info = { > > .gpccon = 0xaaaaaaaa, > .gpccon_mask = 0xffffffff, > + .gpccon_reg = S3C2410_GPCCON, > .gpcup = 0x0000ffff, > .gpcup_mask = 0xffffffff, > + .gpcup_reg = S3C2410_GPCUP, > > .gpdcon = 0xaaaaaaaa, > .gpdcon_mask = 0xffffffff, > + .gpdcon_reg = S3C2410_GPDCON, > .gpdup = 0x0000ffff, > .gpdup_mask = 0xffffffff, > + .gpdup_reg = S3C2410_GPDUP, > }; > #endif > > diff --git a/arch/arm/mach-s3c24xx/mach-anubis.c b/arch/arm/mach-s3c24xx/mach-anubis.c > index 072966dcad78..e1a73274e90b 100644 > --- a/arch/arm/mach-s3c24xx/mach-anubis.c > +++ b/arch/arm/mach-s3c24xx/mach-anubis.c > @@ -29,7 +29,6 @@ > #include > > #include > -#include > #include > #include > #include > diff --git a/arch/arm/mach-s3c24xx/mach-at2440evb.c b/arch/arm/mach-s3c24xx/mach-at2440evb.c > index b2199906e678..bfda6dd2a9d5 100644 > --- a/arch/arm/mach-s3c24xx/mach-at2440evb.c > +++ b/arch/arm/mach-s3c24xx/mach-at2440evb.c > @@ -25,12 +25,11 @@ > #include > > #include > -#include > +#include > #include > #include > > #include > -#include > #include > #include > #include > diff --git a/arch/arm/mach-s3c24xx/mach-bast.c b/arch/arm/mach-s3c24xx/mach-bast.c > index a7c3955ae8f6..cc941b5030ea 100644 > --- a/arch/arm/mach-s3c24xx/mach-bast.c > +++ b/arch/arm/mach-s3c24xx/mach-bast.c > @@ -40,10 +40,9 @@ > #include > #include > > -#include > #include > +#include > #include > -#include > #include > > #include > diff --git a/arch/arm/mach-s3c24xx/mach-gta02.c b/arch/arm/mach-s3c24xx/mach-gta02.c > index 61b8c6badeb8..1e42782dbd30 100644 > --- a/arch/arm/mach-s3c24xx/mach-gta02.c > +++ b/arch/arm/mach-s3c24xx/mach-gta02.c > @@ -57,8 +57,8 @@ > #include > #include > #include > +#include > > -#include > #include > #include > #include > diff --git a/arch/arm/mach-s3c24xx/mach-h1940.c b/arch/arm/mach-s3c24xx/mach-h1940.c > index 446891e23511..d56e3befa459 100644 > --- a/arch/arm/mach-s3c24xx/mach-h1940.c > +++ b/arch/arm/mach-s3c24xx/mach-h1940.c > @@ -47,11 +47,10 @@ > > #include > > -#include > +#include > #include > #include > #include > -#include > #include > > #include > @@ -211,12 +210,16 @@ static struct s3c2410fb_mach_info h1940_fb_info __initdata = { > .lpcsel = 0x02, > .gpccon = 0xaa940659, > .gpccon_mask = 0xffffc0f0, > + .gpccon_reg = S3C2410_GPCCON, > .gpcup = 0x0000ffff, > .gpcup_mask = 0xffffffff, > + .gpcup_reg = S3C2410_GPCUP, > .gpdcon = 0xaa84aaa0, > .gpdcon_mask = 0xffffffff, > + .gpdcon_reg = S3C2410_GPDCON, > .gpdup = 0x0000faff, > .gpdup_mask = 0xffffffff, > + .gpdup_reg = S3C2410_GPDUP, > }; > > static int power_supply_init(struct device *dev) > diff --git a/arch/arm/mach-s3c24xx/mach-jive.c b/arch/arm/mach-s3c24xx/mach-jive.c > index 885e8f12e4b9..3b33132b2334 100644 > --- a/arch/arm/mach-s3c24xx/mach-jive.c > +++ b/arch/arm/mach-s3c24xx/mach-jive.c > @@ -32,8 +32,7 @@ > #include > > #include > -#include > -#include > +#include > #include > > #include > @@ -321,6 +320,7 @@ static struct s3c2410fb_mach_info jive_lcd_config = { > * data. */ > > .gpcup = (0xf << 1) | (0x3f << 10), > + .gpcup_reg = S3C2410_GPCUP, Nits: indentation before/after '=' looks wrong. Tab should be before '=', one space after. Best regards, Krzysztof From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 19D6ACA9EB6 for ; Wed, 23 Oct 2019 13:13:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D1E5221920 for ; Wed, 23 Oct 2019 13:13:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1571836412; bh=E4BmCUwdrjVET435icDqHZy9e//AptIUo5JrQiKd85U=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=mYLAWqoKQFSNFkfQNmvNOVqIU/8wTD9VFi6dFeZuqN9a2WQf9/LRv4ExjvySZHPPI 67H1jIVuIN35N10VYIiYfKITAuXDcnh5XBRyn2RsyQKJ9jzBF5KWMw+QUH4fSA/Xfi V5EoI8zImNJy0jdhOlIuKRBhaZb+3Rfepc6ChxYY= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2405735AbfJWNN2 (ORCPT ); Wed, 23 Oct 2019 09:13:28 -0400 Received: from mail-ed1-f67.google.com ([209.85.208.67]:33027 "EHLO mail-ed1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2405714AbfJWNN1 (ORCPT ); Wed, 23 Oct 2019 09:13:27 -0400 Received: by mail-ed1-f67.google.com with SMTP id c4so15728049edl.0; Wed, 23 Oct 2019 06:13:25 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=o54Jyg7LaPMTM/R2ezpXAUg6vHkjUZaxwTxf8dd6jXk=; b=qhqmL5gdouqSgD5QVpG81sTI3R3KOtcjzZIrNZIWSUG5ZNYdmCdOSslCn64pZVgdx/ fSNfEVAfob6EaqnuYgeqbxGu0U/g8vvB1wYTAd/4KfRUFvBglWwhAn1WZDBHvB6cYsDk 2GZL75nT+dNoVkm6qPGmFK7QCI55HwhXqqXm60tzluR75iHixp7SLOc3aUUK57XOrKqk QqO2PGSnGtdt4+J+sQ6HL4mgSthVMsER3kfgR3PWy0aneNGir1rpeCqnIOncIVDOgQSX mQf5zo7fKjgVVKnB48oRKlE0CupCC0ai0bo7HygthNy3BVQ1dnALnZeEEePGRvQSdda8 8v1w== X-Gm-Message-State: APjAAAXUEd9o+7iii/oUQVATVpHwGd/BlFGWRMWRpeWyp+0z9i7GHenX hrNctcFeighXUFUCCPY4WSA= X-Google-Smtp-Source: APXvYqxJH5rltespiv1WDhAborQbNiDE5+2CReq8AP71JjFfyUdkdzYR7L1/bvADJTpzB8Q1SXMf1g== X-Received: by 2002:a17:906:704:: with SMTP id y4mr32582518ejb.259.1571836404632; Wed, 23 Oct 2019 06:13:24 -0700 (PDT) Received: from pi3 ([194.230.155.217]) by smtp.googlemail.com with ESMTPSA id v5sm269620edd.90.2019.10.23.06.13.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 23 Oct 2019 06:13:23 -0700 (PDT) Date: Wed, 23 Oct 2019 15:13:21 +0200 From: Krzysztof Kozlowski To: Arnd Bergmann Cc: Kukjin Kim , Bartlomiej Zolnierkiewicz , linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linus.walleij@linaro.org, linux-kernel@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org Subject: Re: [PATCH 28/36] fbdev: s3c2410fb: remove mach header dependency Message-ID: <20191023131321.GH11048@pi3> References: <20191010202802.1132272-1-arnd@arndb.de> <20191010203043.1241612-1-arnd@arndb.de> <20191010203043.1241612-28-arnd@arndb.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20191010203043.1241612-28-arnd@arndb.de> User-Agent: Mutt/1.12.1 (2019-06-15) Sender: linux-samsung-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-samsung-soc@vger.kernel.org On Thu, Oct 10, 2019 at 10:30:12PM +0200, Arnd Bergmann wrote: > The s3c2410fb driver is too deeply intertwined with the s3c24xx > platform code. Change it in a way that avoids the use of platform > header files but having all interface data in a platform_data > header, and the private register definitions next to the driver > itself. > > One ugly bit here is that the driver pokes directly into gpio > registers, which are owned by another driver. Passing the > mapped addresses in platform_data is somewhat suboptimal, but > it is a small improvement over the previous version. > > Signed-off-by: Arnd Bergmann > --- > arch/arm/mach-s3c24xx/include/mach/fb.h | 2 -- > arch/arm/mach-s3c24xx/mach-amlm5900.c | 7 ++-- > arch/arm/mach-s3c24xx/mach-anubis.c | 1 - > arch/arm/mach-s3c24xx/mach-at2440evb.c | 3 +- > arch/arm/mach-s3c24xx/mach-bast.c | 3 +- > arch/arm/mach-s3c24xx/mach-gta02.c | 2 +- > arch/arm/mach-s3c24xx/mach-h1940.c | 7 ++-- > arch/arm/mach-s3c24xx/mach-jive.c | 10 ++++-- > arch/arm/mach-s3c24xx/mach-mini2440.c | 9 +++-- > arch/arm/mach-s3c24xx/mach-n30.c | 3 +- > arch/arm/mach-s3c24xx/mach-osiris.c | 1 - > arch/arm/mach-s3c24xx/mach-qt2410.c | 3 +- > arch/arm/mach-s3c24xx/mach-rx1950.c | 8 +++-- > arch/arm/mach-s3c24xx/mach-rx3715.c | 7 ++-- > arch/arm/mach-s3c24xx/mach-smdk2413.c | 3 +- > arch/arm/mach-s3c24xx/mach-smdk2416.c | 1 - > arch/arm/mach-s3c24xx/mach-smdk2440.c | 8 +++-- > arch/arm/mach-s3c24xx/mach-smdk2443.c | 3 +- > arch/arm/mach-s3c24xx/mach-vstms.c | 3 +- > arch/arm/plat-samsung/devs.c | 2 +- > .../video/fbdev/s3c2410fb-regs-lcd.h | 28 ++++------------ > drivers/video/fbdev/s3c2410fb.c | 16 +++++---- > .../linux/platform_data}/fb-s3c2410.h | 33 ++++++++++++++++++- > 23 files changed, 98 insertions(+), 65 deletions(-) > delete mode 100644 arch/arm/mach-s3c24xx/include/mach/fb.h > rename arch/arm/mach-s3c24xx/include/mach/regs-lcd.h => drivers/video/fbdev/s3c2410fb-regs-lcd.h (84%) > rename {arch/arm/plat-samsung/include/plat => include/linux/platform_data}/fb-s3c2410.h (57%) > > diff --git a/arch/arm/mach-s3c24xx/include/mach/fb.h b/arch/arm/mach-s3c24xx/include/mach/fb.h > deleted file mode 100644 > index 4e539cb8b884..000000000000 > --- a/arch/arm/mach-s3c24xx/include/mach/fb.h > +++ /dev/null > @@ -1,2 +0,0 @@ > -/* SPDX-License-Identifier: GPL-2.0 */ > -#include > diff --git a/arch/arm/mach-s3c24xx/mach-amlm5900.c b/arch/arm/mach-s3c24xx/mach-amlm5900.c > index 40ad23b52bc0..ef6de1b1d0c6 100644 > --- a/arch/arm/mach-s3c24xx/mach-amlm5900.c > +++ b/arch/arm/mach-s3c24xx/mach-amlm5900.c > @@ -30,9 +30,8 @@ > #include > #include > #include > -#include > +#include > > -#include > #include > #include > > @@ -194,13 +193,17 @@ static struct s3c2410fb_mach_info __initdata amlm5900_fb_info = { > > .gpccon = 0xaaaaaaaa, > .gpccon_mask = 0xffffffff, > + .gpccon_reg = S3C2410_GPCCON, > .gpcup = 0x0000ffff, > .gpcup_mask = 0xffffffff, > + .gpcup_reg = S3C2410_GPCUP, > > .gpdcon = 0xaaaaaaaa, > .gpdcon_mask = 0xffffffff, > + .gpdcon_reg = S3C2410_GPDCON, > .gpdup = 0x0000ffff, > .gpdup_mask = 0xffffffff, > + .gpdup_reg = S3C2410_GPDUP, > }; > #endif > > diff --git a/arch/arm/mach-s3c24xx/mach-anubis.c b/arch/arm/mach-s3c24xx/mach-anubis.c > index 072966dcad78..e1a73274e90b 100644 > --- a/arch/arm/mach-s3c24xx/mach-anubis.c > +++ b/arch/arm/mach-s3c24xx/mach-anubis.c > @@ -29,7 +29,6 @@ > #include > > #include > -#include > #include > #include > #include > diff --git a/arch/arm/mach-s3c24xx/mach-at2440evb.c b/arch/arm/mach-s3c24xx/mach-at2440evb.c > index b2199906e678..bfda6dd2a9d5 100644 > --- a/arch/arm/mach-s3c24xx/mach-at2440evb.c > +++ b/arch/arm/mach-s3c24xx/mach-at2440evb.c > @@ -25,12 +25,11 @@ > #include > > #include > -#include > +#include > #include > #include > > #include > -#include > #include > #include > #include > diff --git a/arch/arm/mach-s3c24xx/mach-bast.c b/arch/arm/mach-s3c24xx/mach-bast.c > index a7c3955ae8f6..cc941b5030ea 100644 > --- a/arch/arm/mach-s3c24xx/mach-bast.c > +++ b/arch/arm/mach-s3c24xx/mach-bast.c > @@ -40,10 +40,9 @@ > #include > #include > > -#include > #include > +#include > #include > -#include > #include > > #include > diff --git a/arch/arm/mach-s3c24xx/mach-gta02.c b/arch/arm/mach-s3c24xx/mach-gta02.c > index 61b8c6badeb8..1e42782dbd30 100644 > --- a/arch/arm/mach-s3c24xx/mach-gta02.c > +++ b/arch/arm/mach-s3c24xx/mach-gta02.c > @@ -57,8 +57,8 @@ > #include > #include > #include > +#include > > -#include > #include > #include > #include > diff --git a/arch/arm/mach-s3c24xx/mach-h1940.c b/arch/arm/mach-s3c24xx/mach-h1940.c > index 446891e23511..d56e3befa459 100644 > --- a/arch/arm/mach-s3c24xx/mach-h1940.c > +++ b/arch/arm/mach-s3c24xx/mach-h1940.c > @@ -47,11 +47,10 @@ > > #include > > -#include > +#include > #include > #include > #include > -#include > #include > > #include > @@ -211,12 +210,16 @@ static struct s3c2410fb_mach_info h1940_fb_info __initdata = { > .lpcsel = 0x02, > .gpccon = 0xaa940659, > .gpccon_mask = 0xffffc0f0, > + .gpccon_reg = S3C2410_GPCCON, > .gpcup = 0x0000ffff, > .gpcup_mask = 0xffffffff, > + .gpcup_reg = S3C2410_GPCUP, > .gpdcon = 0xaa84aaa0, > .gpdcon_mask = 0xffffffff, > + .gpdcon_reg = S3C2410_GPDCON, > .gpdup = 0x0000faff, > .gpdup_mask = 0xffffffff, > + .gpdup_reg = S3C2410_GPDUP, > }; > > static int power_supply_init(struct device *dev) > diff --git a/arch/arm/mach-s3c24xx/mach-jive.c b/arch/arm/mach-s3c24xx/mach-jive.c > index 885e8f12e4b9..3b33132b2334 100644 > --- a/arch/arm/mach-s3c24xx/mach-jive.c > +++ b/arch/arm/mach-s3c24xx/mach-jive.c > @@ -32,8 +32,7 @@ > #include > > #include > -#include > -#include > +#include > #include > > #include > @@ -321,6 +320,7 @@ static struct s3c2410fb_mach_info jive_lcd_config = { > * data. */ > > .gpcup = (0xf << 1) | (0x3f << 10), > + .gpcup_reg = S3C2410_GPCUP, Nits: indentation before/after '=' looks wrong. Tab should be before '=', one space after. Best regards, Krzysztof From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4498BCA9EB6 for ; Wed, 23 Oct 2019 13:13:48 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 12E9121906 for ; Wed, 23 Oct 2019 13:13:48 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="lQ7mBDGk" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 12E9121906 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ECp7n5ebirLPAL7tFP8fId1ScXcBjRyPlm8ZYZ2Mdgs=; b=lQ7mBDGkPQo3qr /rGmJ3IKJOfHi24Oqj656DXqdy7dGSZ/+FNtqDY5BWWd76su2bV+myuOPb3QBFeZ7fsL+X1Ldk/+m uA4fXEXShQB7cLBdXYi2bcTCaGBw8LaOnUT39l4AuQnry0GWKKJolgxcWFOY/wl75EvWyj/n2zZ2y tQAUkWKoVJUUyOHpcQ/CY7vQ4Q92B0YIXNgYtQ3Rn/n3ueCgokl83KCjnJV2Rf2nKtJnoej00PHyt ctT9sI6RPTRagq6hlFmvamRjvOoIj3K3/R1l8ZI4SHNg5TzW9clJAMnaXAnfmjJiREeRHqUGsTPoO aT0isz1C7r4gmPh0r3Og==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iNGSI-0004ss-LF; Wed, 23 Oct 2019 13:13:38 +0000 Received: from mail-ed1-f66.google.com ([209.85.208.66]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iNGS6-0004gt-5l for linux-arm-kernel@lists.infradead.org; Wed, 23 Oct 2019 13:13:28 +0000 Received: by mail-ed1-f66.google.com with SMTP id h2so15721028edn.3 for ; Wed, 23 Oct 2019 06:13:26 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=o54Jyg7LaPMTM/R2ezpXAUg6vHkjUZaxwTxf8dd6jXk=; b=rOG8jhHktB2w//AiZD4olPS4OMwn/n+4REJfkuG9L+dww1uKUbfXHwrdU21xi7wcba uCtzVK40m1T4XuKameSEzH+2pcj4jYD6A5lububDqfuDFJ72f4m91zMCrIAxqn5zMqmR vKuj1ODu4ToaazVOV5lUepFd5C5YC0uThX9csI0q9l3rmvZGtufHlp+RmRi0Mn9VdgrA DtibI5FJTHdS0NAbwZdoAEsD40jyzLef73oxUAnEZ6WDEBO+j8eiM8LLLalma7l7DqRF OE0CeDQXq6emhKzsI6hkaNRNppxddYk8Xy8n1rJklF7eM2/xD7f9KgSPA5gpcwfDP0Fv Pdug== X-Gm-Message-State: APjAAAVBQpr5RlxHDArPsINbjjXxYN0j6arzL/qmxcooKzG78hs51h5W vQbQIiG673CfkStC3rsxTHU= X-Google-Smtp-Source: APXvYqxJH5rltespiv1WDhAborQbNiDE5+2CReq8AP71JjFfyUdkdzYR7L1/bvADJTpzB8Q1SXMf1g== X-Received: by 2002:a17:906:704:: with SMTP id y4mr32582518ejb.259.1571836404632; Wed, 23 Oct 2019 06:13:24 -0700 (PDT) Received: from pi3 ([194.230.155.217]) by smtp.googlemail.com with ESMTPSA id v5sm269620edd.90.2019.10.23.06.13.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 23 Oct 2019 06:13:23 -0700 (PDT) Date: Wed, 23 Oct 2019 15:13:21 +0200 From: Krzysztof Kozlowski To: Arnd Bergmann Subject: Re: [PATCH 28/36] fbdev: s3c2410fb: remove mach header dependency Message-ID: <20191023131321.GH11048@pi3> References: <20191010202802.1132272-1-arnd@arndb.de> <20191010203043.1241612-1-arnd@arndb.de> <20191010203043.1241612-28-arnd@arndb.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20191010203043.1241612-28-arnd@arndb.de> User-Agent: Mutt/1.12.1 (2019-06-15) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191023_061326_303774_0AF7AA60 X-CRM114-Status: GOOD ( 19.61 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-fbdev@vger.kernel.org, linux-samsung-soc@vger.kernel.org, Bartlomiej Zolnierkiewicz , linus.walleij@linaro.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Kukjin Kim , linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Oct 10, 2019 at 10:30:12PM +0200, Arnd Bergmann wrote: > The s3c2410fb driver is too deeply intertwined with the s3c24xx > platform code. Change it in a way that avoids the use of platform > header files but having all interface data in a platform_data > header, and the private register definitions next to the driver > itself. > > One ugly bit here is that the driver pokes directly into gpio > registers, which are owned by another driver. Passing the > mapped addresses in platform_data is somewhat suboptimal, but > it is a small improvement over the previous version. > > Signed-off-by: Arnd Bergmann > --- > arch/arm/mach-s3c24xx/include/mach/fb.h | 2 -- > arch/arm/mach-s3c24xx/mach-amlm5900.c | 7 ++-- > arch/arm/mach-s3c24xx/mach-anubis.c | 1 - > arch/arm/mach-s3c24xx/mach-at2440evb.c | 3 +- > arch/arm/mach-s3c24xx/mach-bast.c | 3 +- > arch/arm/mach-s3c24xx/mach-gta02.c | 2 +- > arch/arm/mach-s3c24xx/mach-h1940.c | 7 ++-- > arch/arm/mach-s3c24xx/mach-jive.c | 10 ++++-- > arch/arm/mach-s3c24xx/mach-mini2440.c | 9 +++-- > arch/arm/mach-s3c24xx/mach-n30.c | 3 +- > arch/arm/mach-s3c24xx/mach-osiris.c | 1 - > arch/arm/mach-s3c24xx/mach-qt2410.c | 3 +- > arch/arm/mach-s3c24xx/mach-rx1950.c | 8 +++-- > arch/arm/mach-s3c24xx/mach-rx3715.c | 7 ++-- > arch/arm/mach-s3c24xx/mach-smdk2413.c | 3 +- > arch/arm/mach-s3c24xx/mach-smdk2416.c | 1 - > arch/arm/mach-s3c24xx/mach-smdk2440.c | 8 +++-- > arch/arm/mach-s3c24xx/mach-smdk2443.c | 3 +- > arch/arm/mach-s3c24xx/mach-vstms.c | 3 +- > arch/arm/plat-samsung/devs.c | 2 +- > .../video/fbdev/s3c2410fb-regs-lcd.h | 28 ++++------------ > drivers/video/fbdev/s3c2410fb.c | 16 +++++---- > .../linux/platform_data}/fb-s3c2410.h | 33 ++++++++++++++++++- > 23 files changed, 98 insertions(+), 65 deletions(-) > delete mode 100644 arch/arm/mach-s3c24xx/include/mach/fb.h > rename arch/arm/mach-s3c24xx/include/mach/regs-lcd.h => drivers/video/fbdev/s3c2410fb-regs-lcd.h (84%) > rename {arch/arm/plat-samsung/include/plat => include/linux/platform_data}/fb-s3c2410.h (57%) > > diff --git a/arch/arm/mach-s3c24xx/include/mach/fb.h b/arch/arm/mach-s3c24xx/include/mach/fb.h > deleted file mode 100644 > index 4e539cb8b884..000000000000 > --- a/arch/arm/mach-s3c24xx/include/mach/fb.h > +++ /dev/null > @@ -1,2 +0,0 @@ > -/* SPDX-License-Identifier: GPL-2.0 */ > -#include > diff --git a/arch/arm/mach-s3c24xx/mach-amlm5900.c b/arch/arm/mach-s3c24xx/mach-amlm5900.c > index 40ad23b52bc0..ef6de1b1d0c6 100644 > --- a/arch/arm/mach-s3c24xx/mach-amlm5900.c > +++ b/arch/arm/mach-s3c24xx/mach-amlm5900.c > @@ -30,9 +30,8 @@ > #include > #include > #include > -#include > +#include > > -#include > #include > #include > > @@ -194,13 +193,17 @@ static struct s3c2410fb_mach_info __initdata amlm5900_fb_info = { > > .gpccon = 0xaaaaaaaa, > .gpccon_mask = 0xffffffff, > + .gpccon_reg = S3C2410_GPCCON, > .gpcup = 0x0000ffff, > .gpcup_mask = 0xffffffff, > + .gpcup_reg = S3C2410_GPCUP, > > .gpdcon = 0xaaaaaaaa, > .gpdcon_mask = 0xffffffff, > + .gpdcon_reg = S3C2410_GPDCON, > .gpdup = 0x0000ffff, > .gpdup_mask = 0xffffffff, > + .gpdup_reg = S3C2410_GPDUP, > }; > #endif > > diff --git a/arch/arm/mach-s3c24xx/mach-anubis.c b/arch/arm/mach-s3c24xx/mach-anubis.c > index 072966dcad78..e1a73274e90b 100644 > --- a/arch/arm/mach-s3c24xx/mach-anubis.c > +++ b/arch/arm/mach-s3c24xx/mach-anubis.c > @@ -29,7 +29,6 @@ > #include > > #include > -#include > #include > #include > #include > diff --git a/arch/arm/mach-s3c24xx/mach-at2440evb.c b/arch/arm/mach-s3c24xx/mach-at2440evb.c > index b2199906e678..bfda6dd2a9d5 100644 > --- a/arch/arm/mach-s3c24xx/mach-at2440evb.c > +++ b/arch/arm/mach-s3c24xx/mach-at2440evb.c > @@ -25,12 +25,11 @@ > #include > > #include > -#include > +#include > #include > #include > > #include > -#include > #include > #include > #include > diff --git a/arch/arm/mach-s3c24xx/mach-bast.c b/arch/arm/mach-s3c24xx/mach-bast.c > index a7c3955ae8f6..cc941b5030ea 100644 > --- a/arch/arm/mach-s3c24xx/mach-bast.c > +++ b/arch/arm/mach-s3c24xx/mach-bast.c > @@ -40,10 +40,9 @@ > #include > #include > > -#include > #include > +#include > #include > -#include > #include > > #include > diff --git a/arch/arm/mach-s3c24xx/mach-gta02.c b/arch/arm/mach-s3c24xx/mach-gta02.c > index 61b8c6badeb8..1e42782dbd30 100644 > --- a/arch/arm/mach-s3c24xx/mach-gta02.c > +++ b/arch/arm/mach-s3c24xx/mach-gta02.c > @@ -57,8 +57,8 @@ > #include > #include > #include > +#include > > -#include > #include > #include > #include > diff --git a/arch/arm/mach-s3c24xx/mach-h1940.c b/arch/arm/mach-s3c24xx/mach-h1940.c > index 446891e23511..d56e3befa459 100644 > --- a/arch/arm/mach-s3c24xx/mach-h1940.c > +++ b/arch/arm/mach-s3c24xx/mach-h1940.c > @@ -47,11 +47,10 @@ > > #include > > -#include > +#include > #include > #include > #include > -#include > #include > > #include > @@ -211,12 +210,16 @@ static struct s3c2410fb_mach_info h1940_fb_info __initdata = { > .lpcsel = 0x02, > .gpccon = 0xaa940659, > .gpccon_mask = 0xffffc0f0, > + .gpccon_reg = S3C2410_GPCCON, > .gpcup = 0x0000ffff, > .gpcup_mask = 0xffffffff, > + .gpcup_reg = S3C2410_GPCUP, > .gpdcon = 0xaa84aaa0, > .gpdcon_mask = 0xffffffff, > + .gpdcon_reg = S3C2410_GPDCON, > .gpdup = 0x0000faff, > .gpdup_mask = 0xffffffff, > + .gpdup_reg = S3C2410_GPDUP, > }; > > static int power_supply_init(struct device *dev) > diff --git a/arch/arm/mach-s3c24xx/mach-jive.c b/arch/arm/mach-s3c24xx/mach-jive.c > index 885e8f12e4b9..3b33132b2334 100644 > --- a/arch/arm/mach-s3c24xx/mach-jive.c > +++ b/arch/arm/mach-s3c24xx/mach-jive.c > @@ -32,8 +32,7 @@ > #include > > #include > -#include > -#include > +#include > #include > > #include > @@ -321,6 +320,7 @@ static struct s3c2410fb_mach_info jive_lcd_config = { > * data. */ > > .gpcup = (0xf << 1) | (0x3f << 10), > + .gpcup_reg = S3C2410_GPCUP, Nits: indentation before/after '=' looks wrong. Tab should be before '=', one space after. Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 From: Krzysztof Kozlowski Subject: Re: [PATCH 28/36] fbdev: s3c2410fb: remove mach header dependency Date: Wed, 23 Oct 2019 15:13:21 +0200 Message-ID: <20191023131321.GH11048@pi3> References: <20191010202802.1132272-1-arnd@arndb.de> <20191010203043.1241612-1-arnd@arndb.de> <20191010203043.1241612-28-arnd@arndb.de> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-ed1-f67.google.com (mail-ed1-f67.google.com [209.85.208.67]) by gabe.freedesktop.org (Postfix) with ESMTPS id 3F2D36EA98 for ; Wed, 23 Oct 2019 13:13:26 +0000 (UTC) Received: by mail-ed1-f67.google.com with SMTP id r16so15687523edq.11 for ; Wed, 23 Oct 2019 06:13:26 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20191010203043.1241612-28-arnd@arndb.de> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Arnd Bergmann Cc: linux-fbdev@vger.kernel.org, linux-samsung-soc@vger.kernel.org, Bartlomiej Zolnierkiewicz , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Kukjin Kim , linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org List-Id: dri-devel@lists.freedesktop.org T24gVGh1LCBPY3QgMTAsIDIwMTkgYXQgMTA6MzA6MTJQTSArMDIwMCwgQXJuZCBCZXJnbWFubiB3 cm90ZToKPiBUaGUgczNjMjQxMGZiIGRyaXZlciBpcyB0b28gZGVlcGx5IGludGVydHdpbmVkIHdp dGggdGhlIHMzYzI0eHgKPiBwbGF0Zm9ybSBjb2RlLiBDaGFuZ2UgaXQgaW4gYSB3YXkgdGhhdCBh dm9pZHMgdGhlIHVzZSBvZiBwbGF0Zm9ybQo+IGhlYWRlciBmaWxlcyBidXQgaGF2aW5nIGFsbCBp bnRlcmZhY2UgZGF0YSBpbiBhIHBsYXRmb3JtX2RhdGEKPiBoZWFkZXIsIGFuZCB0aGUgcHJpdmF0 ZSByZWdpc3RlciBkZWZpbml0aW9ucyBuZXh0IHRvIHRoZSBkcml2ZXIKPiBpdHNlbGYuCj4gCj4g T25lIHVnbHkgYml0IGhlcmUgaXMgdGhhdCB0aGUgZHJpdmVyIHBva2VzIGRpcmVjdGx5IGludG8g Z3Bpbwo+IHJlZ2lzdGVycywgd2hpY2ggYXJlIG93bmVkIGJ5IGFub3RoZXIgZHJpdmVyLiBQYXNz aW5nIHRoZQo+IG1hcHBlZCBhZGRyZXNzZXMgaW4gcGxhdGZvcm1fZGF0YSBpcyBzb21ld2hhdCBz dWJvcHRpbWFsLCBidXQKPiBpdCBpcyBhIHNtYWxsIGltcHJvdmVtZW50IG92ZXIgdGhlIHByZXZp b3VzIHZlcnNpb24uCj4gCj4gU2lnbmVkLW9mZi1ieTogQXJuZCBCZXJnbWFubiA8YXJuZEBhcm5k Yi5kZT4KPiAtLS0KPiAgYXJjaC9hcm0vbWFjaC1zM2MyNHh4L2luY2x1ZGUvbWFjaC9mYi5oICAg ICAgIHwgIDIgLS0KPiAgYXJjaC9hcm0vbWFjaC1zM2MyNHh4L21hY2gtYW1sbTU5MDAuYyAgICAg ICAgIHwgIDcgKystLQo+ICBhcmNoL2FybS9tYWNoLXMzYzI0eHgvbWFjaC1hbnViaXMuYyAgICAg ICAgICAgfCAgMSAtCj4gIGFyY2gvYXJtL21hY2gtczNjMjR4eC9tYWNoLWF0MjQ0MGV2Yi5jICAg ICAgICB8ICAzICstCj4gIGFyY2gvYXJtL21hY2gtczNjMjR4eC9tYWNoLWJhc3QuYyAgICAgICAg ICAgICB8ICAzICstCj4gIGFyY2gvYXJtL21hY2gtczNjMjR4eC9tYWNoLWd0YTAyLmMgICAgICAg ICAgICB8ICAyICstCj4gIGFyY2gvYXJtL21hY2gtczNjMjR4eC9tYWNoLWgxOTQwLmMgICAgICAg ICAgICB8ICA3ICsrLS0KPiAgYXJjaC9hcm0vbWFjaC1zM2MyNHh4L21hY2gtaml2ZS5jICAgICAg ICAgICAgIHwgMTAgKysrKy0tCj4gIGFyY2gvYXJtL21hY2gtczNjMjR4eC9tYWNoLW1pbmkyNDQw LmMgICAgICAgICB8ICA5ICsrKy0tCj4gIGFyY2gvYXJtL21hY2gtczNjMjR4eC9tYWNoLW4zMC5j ICAgICAgICAgICAgICB8ICAzICstCj4gIGFyY2gvYXJtL21hY2gtczNjMjR4eC9tYWNoLW9zaXJp cy5jICAgICAgICAgICB8ICAxIC0KPiAgYXJjaC9hcm0vbWFjaC1zM2MyNHh4L21hY2gtcXQyNDEw LmMgICAgICAgICAgIHwgIDMgKy0KPiAgYXJjaC9hcm0vbWFjaC1zM2MyNHh4L21hY2gtcngxOTUw LmMgICAgICAgICAgIHwgIDggKysrLS0KPiAgYXJjaC9hcm0vbWFjaC1zM2MyNHh4L21hY2gtcngz NzE1LmMgICAgICAgICAgIHwgIDcgKystLQo+ICBhcmNoL2FybS9tYWNoLXMzYzI0eHgvbWFjaC1z bWRrMjQxMy5jICAgICAgICAgfCAgMyArLQo+ICBhcmNoL2FybS9tYWNoLXMzYzI0eHgvbWFjaC1z bWRrMjQxNi5jICAgICAgICAgfCAgMSAtCj4gIGFyY2gvYXJtL21hY2gtczNjMjR4eC9tYWNoLXNt ZGsyNDQwLmMgICAgICAgICB8ICA4ICsrKy0tCj4gIGFyY2gvYXJtL21hY2gtczNjMjR4eC9tYWNo LXNtZGsyNDQzLmMgICAgICAgICB8ICAzICstCj4gIGFyY2gvYXJtL21hY2gtczNjMjR4eC9tYWNo LXZzdG1zLmMgICAgICAgICAgICB8ICAzICstCj4gIGFyY2gvYXJtL3BsYXQtc2Ftc3VuZy9kZXZz LmMgICAgICAgICAgICAgICAgICB8ICAyICstCj4gIC4uLi92aWRlby9mYmRldi9zM2MyNDEwZmIt cmVncy1sY2QuaCAgICAgICAgICB8IDI4ICsrKystLS0tLS0tLS0tLS0KPiAgZHJpdmVycy92aWRl by9mYmRldi9zM2MyNDEwZmIuYyAgICAgICAgICAgICAgIHwgMTYgKysrKystLS0tCj4gIC4uLi9s aW51eC9wbGF0Zm9ybV9kYXRhfS9mYi1zM2MyNDEwLmggICAgICAgICB8IDMzICsrKysrKysrKysr KysrKysrKy0KPiAgMjMgZmlsZXMgY2hhbmdlZCwgOTggaW5zZXJ0aW9ucygrKSwgNjUgZGVsZXRp b25zKC0pCj4gIGRlbGV0ZSBtb2RlIDEwMDY0NCBhcmNoL2FybS9tYWNoLXMzYzI0eHgvaW5jbHVk ZS9tYWNoL2ZiLmgKPiAgcmVuYW1lIGFyY2gvYXJtL21hY2gtczNjMjR4eC9pbmNsdWRlL21hY2gv cmVncy1sY2QuaCA9PiBkcml2ZXJzL3ZpZGVvL2ZiZGV2L3MzYzI0MTBmYi1yZWdzLWxjZC5oICg4 NCUpCj4gIHJlbmFtZSB7YXJjaC9hcm0vcGxhdC1zYW1zdW5nL2luY2x1ZGUvcGxhdCA9PiBpbmNs dWRlL2xpbnV4L3BsYXRmb3JtX2RhdGF9L2ZiLXMzYzI0MTAuaCAoNTclKQo+IAo+IGRpZmYgLS1n aXQgYS9hcmNoL2FybS9tYWNoLXMzYzI0eHgvaW5jbHVkZS9tYWNoL2ZiLmggYi9hcmNoL2FybS9t YWNoLXMzYzI0eHgvaW5jbHVkZS9tYWNoL2ZiLmgKPiBkZWxldGVkIGZpbGUgbW9kZSAxMDA2NDQK PiBpbmRleCA0ZTUzOWNiOGI4ODQuLjAwMDAwMDAwMDAwMAo+IC0tLSBhL2FyY2gvYXJtL21hY2gt czNjMjR4eC9pbmNsdWRlL21hY2gvZmIuaAo+ICsrKyAvZGV2L251bGwKPiBAQCAtMSwyICswLDAg QEAKPiAtLyogU1BEWC1MaWNlbnNlLUlkZW50aWZpZXI6IEdQTC0yLjAgKi8KPiAtI2luY2x1ZGUg PHBsYXQvZmItczNjMjQxMC5oPgo+IGRpZmYgLS1naXQgYS9hcmNoL2FybS9tYWNoLXMzYzI0eHgv bWFjaC1hbWxtNTkwMC5jIGIvYXJjaC9hcm0vbWFjaC1zM2MyNHh4L21hY2gtYW1sbTU5MDAuYwo+ IGluZGV4IDQwYWQyM2I1MmJjMC4uZWY2ZGUxYjFkMGM2IDEwMDY0NAo+IC0tLSBhL2FyY2gvYXJt L21hY2gtczNjMjR4eC9tYWNoLWFtbG01OTAwLmMKPiArKysgYi9hcmNoL2FybS9tYWNoLXMzYzI0 eHgvbWFjaC1hbWxtNTkwMC5jCj4gQEAgLTMwLDkgKzMwLDggQEAKPiAgI2luY2x1ZGUgPG1hY2gv aGFyZHdhcmUuaD4KPiAgI2luY2x1ZGUgPGFzbS9pcnEuaD4KPiAgI2luY2x1ZGUgPGFzbS9tYWNo LXR5cGVzLmg+Cj4gLSNpbmNsdWRlIDxtYWNoL2ZiLmg+Cj4gKyNpbmNsdWRlIDxsaW51eC9wbGF0 Zm9ybV9kYXRhL2ZiLXMzYzI0MTAuaD4KPiAgCj4gLSNpbmNsdWRlIDxtYWNoL3JlZ3MtbGNkLmg+ Cj4gICNpbmNsdWRlIDxtYWNoL3JlZ3MtZ3Bpby5oPgo+ICAjaW5jbHVkZSA8bWFjaC9ncGlvLXNh bXN1bmcuaD4KPiAgCj4gQEAgLTE5NCwxMyArMTkzLDE3IEBAIHN0YXRpYyBzdHJ1Y3QgczNjMjQx MGZiX21hY2hfaW5mbyBfX2luaXRkYXRhIGFtbG01OTAwX2ZiX2luZm8gPSB7Cj4gIAo+ICAJLmdw Y2NvbiA9CTB4YWFhYWFhYWEsCj4gIAkuZ3BjY29uX21hc2sgPQkweGZmZmZmZmZmLAo+ICsJLmdw Y2Nvbl9yZWcgPQlTM0MyNDEwX0dQQ0NPTiwKPiAgCS5ncGN1cCA9CTB4MDAwMGZmZmYsCj4gIAku Z3BjdXBfbWFzayA9CTB4ZmZmZmZmZmYsCj4gKwkuZ3BjdXBfcmVnID0JUzNDMjQxMF9HUENVUCwK PiAgCj4gIAkuZ3BkY29uID0JMHhhYWFhYWFhYSwKPiAgCS5ncGRjb25fbWFzayA9CTB4ZmZmZmZm ZmYsCj4gKwkuZ3BkY29uX3JlZyA9CVMzQzI0MTBfR1BEQ09OLAo+ICAJLmdwZHVwID0JMHgwMDAw ZmZmZiwKPiAgCS5ncGR1cF9tYXNrID0JMHhmZmZmZmZmZiwKPiArCS5ncGR1cF9yZWcgPQlTM0My NDEwX0dQRFVQLAo+ICB9Owo+ICAjZW5kaWYKPiAgCj4gZGlmZiAtLWdpdCBhL2FyY2gvYXJtL21h Y2gtczNjMjR4eC9tYWNoLWFudWJpcy5jIGIvYXJjaC9hcm0vbWFjaC1zM2MyNHh4L21hY2gtYW51 YmlzLmMKPiBpbmRleCAwNzI5NjZkY2FkNzguLmUxYTczMjc0ZTkwYiAxMDA2NDQKPiAtLS0gYS9h cmNoL2FybS9tYWNoLXMzYzI0eHgvbWFjaC1hbnViaXMuYwo+ICsrKyBiL2FyY2gvYXJtL21hY2gt czNjMjR4eC9tYWNoLWFudWJpcy5jCj4gQEAgLTI5LDcgKzI5LDYgQEAKPiAgI2luY2x1ZGUgPGFz bS9tYWNoLXR5cGVzLmg+Cj4gIAo+ICAjaW5jbHVkZSA8bWFjaC9yZWdzLWdwaW8uaD4KPiAtI2lu Y2x1ZGUgPG1hY2gvcmVncy1sY2QuaD4KPiAgI2luY2x1ZGUgPG1hY2gvZ3Bpby1zYW1zdW5nLmg+ Cj4gICNpbmNsdWRlIDxsaW51eC9wbGF0Zm9ybV9kYXRhL210ZC1uYW5kLXMzYzI0MTAuaD4KPiAg I2luY2x1ZGUgPGxpbnV4L3BsYXRmb3JtX2RhdGEvaTJjLXMzYzI0MTAuaD4KPiBkaWZmIC0tZ2l0 IGEvYXJjaC9hcm0vbWFjaC1zM2MyNHh4L21hY2gtYXQyNDQwZXZiLmMgYi9hcmNoL2FybS9tYWNo LXMzYzI0eHgvbWFjaC1hdDI0NDBldmIuYwo+IGluZGV4IGIyMTk5OTA2ZTY3OC4uYmZkYTZkZDJh OWQ1IDEwMDY0NAo+IC0tLSBhL2FyY2gvYXJtL21hY2gtczNjMjR4eC9tYWNoLWF0MjQ0MGV2Yi5j Cj4gKysrIGIvYXJjaC9hcm0vbWFjaC1zM2MyNHh4L21hY2gtYXQyNDQwZXZiLmMKPiBAQCAtMjUs MTIgKzI1LDExIEBACj4gICNpbmNsdWRlIDxhc20vbWFjaC9pcnEuaD4KPiAgCj4gICNpbmNsdWRl IDxtYWNoL2hhcmR3YXJlLmg+Cj4gLSNpbmNsdWRlIDxtYWNoL2ZiLmg+Cj4gKyNpbmNsdWRlIDxs aW51eC9wbGF0Zm9ybV9kYXRhL2ZiLXMzYzI0MTAuaD4KPiAgI2luY2x1ZGUgPGFzbS9pcnEuaD4K PiAgI2luY2x1ZGUgPGFzbS9tYWNoLXR5cGVzLmg+Cj4gIAo+ICAjaW5jbHVkZSA8bWFjaC9yZWdz LWdwaW8uaD4KPiAtI2luY2x1ZGUgPG1hY2gvcmVncy1sY2QuaD4KPiAgI2luY2x1ZGUgPG1hY2gv Z3Bpby1zYW1zdW5nLmg+Cj4gICNpbmNsdWRlIDxsaW51eC9wbGF0Zm9ybV9kYXRhL210ZC1uYW5k LXMzYzI0MTAuaD4KPiAgI2luY2x1ZGUgPGxpbnV4L3BsYXRmb3JtX2RhdGEvaTJjLXMzYzI0MTAu aD4KPiBkaWZmIC0tZ2l0IGEvYXJjaC9hcm0vbWFjaC1zM2MyNHh4L21hY2gtYmFzdC5jIGIvYXJj aC9hcm0vbWFjaC1zM2MyNHh4L21hY2gtYmFzdC5jCj4gaW5kZXggYTdjMzk1NWFlOGY2Li5jYzk0 MWI1MDMwZWEgMTAwNjQ0Cj4gLS0tIGEvYXJjaC9hcm0vbWFjaC1zM2MyNHh4L21hY2gtYmFzdC5j Cj4gKysrIGIvYXJjaC9hcm0vbWFjaC1zM2MyNHh4L21hY2gtYmFzdC5jCj4gQEAgLTQwLDEwICs0 MCw5IEBACj4gICNpbmNsdWRlIDxhc20vbWFjaC9pcnEuaD4KPiAgI2luY2x1ZGUgPGFzbS9tYWNo LXR5cGVzLmg+Cj4gIAo+IC0jaW5jbHVkZSA8bWFjaC9mYi5oPgo+ICAjaW5jbHVkZSA8bWFjaC9o YXJkd2FyZS5oPgo+ICsjaW5jbHVkZSA8bGludXgvcGxhdGZvcm1fZGF0YS9mYi1zM2MyNDEwLmg+ Cj4gICNpbmNsdWRlIDxtYWNoL3JlZ3MtZ3Bpby5oPgo+IC0jaW5jbHVkZSA8bWFjaC9yZWdzLWxj ZC5oPgo+ICAjaW5jbHVkZSA8bWFjaC9ncGlvLXNhbXN1bmcuaD4KPiAgCj4gICNpbmNsdWRlIDxw bGF0L2NwdS5oPgo+IGRpZmYgLS1naXQgYS9hcmNoL2FybS9tYWNoLXMzYzI0eHgvbWFjaC1ndGEw Mi5jIGIvYXJjaC9hcm0vbWFjaC1zM2MyNHh4L21hY2gtZ3RhMDIuYwo+IGluZGV4IDYxYjhjNmJh ZGViOC4uMWU0Mjc4MmRiZDMwIDEwMDY0NAo+IC0tLSBhL2FyY2gvYXJtL21hY2gtczNjMjR4eC9t YWNoLWd0YTAyLmMKPiArKysgYi9hcmNoL2FybS9tYWNoLXMzYzI0eHgvbWFjaC1ndGEwMi5jCj4g QEAgLTU3LDggKzU3LDggQEAKPiAgI2luY2x1ZGUgPGxpbnV4L3BsYXRmb3JtX2RhdGEvdG91Y2hz Y3JlZW4tczNjMjQxMC5oPgo+ICAjaW5jbHVkZSA8bGludXgvcGxhdGZvcm1fZGF0YS91c2Itb2hj aS1zM2MyNDEwLmg+Cj4gICNpbmNsdWRlIDxsaW51eC9wbGF0Zm9ybV9kYXRhL3VzYi1zM2MyNDEw X3VkYy5oPgo+ICsjaW5jbHVkZSA8bGludXgvcGxhdGZvcm1fZGF0YS9mYi1zM2MyNDEwLmg+Cj4g IAo+IC0jaW5jbHVkZSA8bWFjaC9mYi5oPgo+ICAjaW5jbHVkZSA8bWFjaC9oYXJkd2FyZS5oPgo+ ICAjaW5jbHVkZSA8bWFjaC9yZWdzLWdwaW8uaD4KPiAgI2luY2x1ZGUgPG1hY2gvcmVncy1pcnEu aD4KPiBkaWZmIC0tZ2l0IGEvYXJjaC9hcm0vbWFjaC1zM2MyNHh4L21hY2gtaDE5NDAuYyBiL2Fy Y2gvYXJtL21hY2gtczNjMjR4eC9tYWNoLWgxOTQwLmMKPiBpbmRleCA0NDY4OTFlMjM1MTEuLmQ1 NmUzYmVmYTQ1OSAxMDA2NDQKPiAtLS0gYS9hcmNoL2FybS9tYWNoLXMzYzI0eHgvbWFjaC1oMTk0 MC5jCj4gKysrIGIvYXJjaC9hcm0vbWFjaC1zM2MyNHh4L21hY2gtaDE5NDAuYwo+IEBAIC00Nywx MSArNDcsMTAgQEAKPiAgCj4gICNpbmNsdWRlIDxzb3VuZC91ZGExMzgwLmg+Cj4gIAo+IC0jaW5j bHVkZSA8bWFjaC9mYi5oPgo+ICsjaW5jbHVkZSA8bGludXgvcGxhdGZvcm1fZGF0YS9mYi1zM2My NDEwLmg+Cj4gICNpbmNsdWRlIDxtYWNoL2hhcmR3YXJlLmg+Cj4gICNpbmNsdWRlIDxtYWNoL3Jl Z3MtY2xvY2suaD4KPiAgI2luY2x1ZGUgPG1hY2gvcmVncy1ncGlvLmg+Cj4gLSNpbmNsdWRlIDxt YWNoL3JlZ3MtbGNkLmg+Cj4gICNpbmNsdWRlIDxtYWNoL2dwaW8tc2Ftc3VuZy5oPgo+ICAKPiAg I2luY2x1ZGUgPHBsYXQvY3B1Lmg+Cj4gQEAgLTIxMSwxMiArMjEwLDE2IEBAIHN0YXRpYyBzdHJ1 Y3QgczNjMjQxMGZiX21hY2hfaW5mbyBoMTk0MF9mYl9pbmZvIF9faW5pdGRhdGEgPSB7Cj4gIAku bHBjc2VsID0JMHgwMiwKPiAgCS5ncGNjb24gPQkweGFhOTQwNjU5LAo+ICAJLmdwY2Nvbl9tYXNr ID0JMHhmZmZmYzBmMCwKPiArCS5ncGNjb25fcmVnID0JUzNDMjQxMF9HUENDT04sCj4gIAkuZ3Bj dXAgPQkweDAwMDBmZmZmLAo+ICAJLmdwY3VwX21hc2sgPQkweGZmZmZmZmZmLAo+ICsJLmdwY3Vw X3JlZyA9CVMzQzI0MTBfR1BDVVAsCj4gIAkuZ3BkY29uID0JMHhhYTg0YWFhMCwKPiAgCS5ncGRj b25fbWFzayA9CTB4ZmZmZmZmZmYsCj4gKwkuZ3BkY29uX3JlZyA9CVMzQzI0MTBfR1BEQ09OLAo+ ICAJLmdwZHVwID0JMHgwMDAwZmFmZiwKPiAgCS5ncGR1cF9tYXNrID0JMHhmZmZmZmZmZiwKPiAr CS5ncGR1cF9yZWcgPQlTM0MyNDEwX0dQRFVQLAo+ICB9Owo+ICAKPiAgc3RhdGljIGludCBwb3dl cl9zdXBwbHlfaW5pdChzdHJ1Y3QgZGV2aWNlICpkZXYpCj4gZGlmZiAtLWdpdCBhL2FyY2gvYXJt L21hY2gtczNjMjR4eC9tYWNoLWppdmUuYyBiL2FyY2gvYXJtL21hY2gtczNjMjR4eC9tYWNoLWpp dmUuYwo+IGluZGV4IDg4NWU4ZjEyZTRiOS4uM2IzMzEzMmIyMzM0IDEwMDY0NAo+IC0tLSBhL2Fy Y2gvYXJtL21hY2gtczNjMjR4eC9tYWNoLWppdmUuYwo+ICsrKyBiL2FyY2gvYXJtL21hY2gtczNj MjR4eC9tYWNoLWppdmUuYwo+IEBAIC0zMiw4ICszMiw3IEBACj4gICNpbmNsdWRlIDxsaW51eC9w bGF0Zm9ybV9kYXRhL2kyYy1zM2MyNDEwLmg+Cj4gIAo+ICAjaW5jbHVkZSA8bWFjaC9yZWdzLWdw aW8uaD4KPiAtI2luY2x1ZGUgPG1hY2gvcmVncy1sY2QuaD4KPiAtI2luY2x1ZGUgPG1hY2gvZmIu aD4KPiArI2luY2x1ZGUgPGxpbnV4L3BsYXRmb3JtX2RhdGEvZmItczNjMjQxMC5oPgo+ICAjaW5j bHVkZSA8bWFjaC9ncGlvLXNhbXN1bmcuaD4KPiAgCj4gICNpbmNsdWRlIDxhc20vbWFjaC10eXBl cy5oPgo+IEBAIC0zMjEsNiArMzIwLDcgQEAgc3RhdGljIHN0cnVjdCBzM2MyNDEwZmJfbWFjaF9p bmZvIGppdmVfbGNkX2NvbmZpZyA9IHsKPiAgCSAqIGRhdGEuICovCj4gIAo+ICAJLmdwY3VwCQk9 ICgweGYgPDwgMSkgfCAoMHgzZiA8PCAxMCksCj4gKwkuZ3BjdXBfcmVnID0JUzNDMjQxMF9HUENV UCwKCk5pdHM6IGluZGVudGF0aW9uIGJlZm9yZS9hZnRlciAnPScgbG9va3Mgd3JvbmcuIFRhYiBz aG91bGQgYmUKYmVmb3JlICc9Jywgb25lIHNwYWNlIGFmdGVyLgoKQmVzdCByZWdhcmRzLApLcnp5 c3p0b2YKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRy aS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRw czovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbA==