From: Tony Lindgren <tony@atomide.com>
To: Vinod Koul <vkoul@kernel.org>
Cc: Dan Williams <dan.j.williams@intel.com>,
Vinod Koul <vinod.koul@intel.com>,
Alexandre Bailon <abailon@baylibre.com>,
Andy Shevchenko <andy.shevchenko@gmail.com>,
Bin Liu <b-liu@ti.com>, Daniel Mack <zonque@gmail.com>,
Felipe Balbi <felipe.balbi@linux.intel.com>,
George Cherian <george.cherian@ti.com>,
Grygorii Strashko <grygorii.strashko@ti.com>,
Johan Hovold <johan@kernel.org>,
Peter Ujfalusi <peter.ujfalusi@ti.com>,
Sekhar Nori <nsekhar@ti.com>,
Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>,
dmaengine@vger.kernel.org, linux-usb@vger.kernel.org,
linux-omap@vger.kernel.org,
giulio.benetti@benettiengineering.com,
Sebastian Reichel <sre@kernel.org>,
Skvortsov <andrej.skvortzov@gmail.com>,
Yegor Yefremov <yegorslists@googlemail.com>
Subject: Re: [PATCH] dmaengine: cppi41: Fix issue with musb and ftdi uart
Date: Wed, 23 Oct 2019 08:27:55 -0700 [thread overview]
Message-ID: <20191023152755.GK5610@atomide.com> (raw)
In-Reply-To: <20191023045333.GO2654@vkoul-mobl>
* Vinod Koul <vkoul@kernel.org> [191023 04:54]:
> Hi Tony,
>
> On 22-10-19, 07:55, Tony Lindgren wrote:
>
> Patch subject should reflect the patch changes not the fix. The patch
> title here is not telling me anything about the change below. Pls
> consider updating the title.
Sure, I'll resend with updated description using:
dmaengine: cppi41: Fix cppi41_dma_prep_slave_sg() when idle
> > The first dma call done by musb_ep_program() must wait if cppi41 is PM
> > runtime suspended. Otherwise musb_ep_program() continues with other
> > non-dma packets before the DMA transfer is started causing at least ftdi
> > uarts to fail to receive data.
> >
> > Let's fix the issue by waking up cppi41 with PM runtime calls added to
> > cppi41_dma_prep_slave_sg() and return NULL if still idled. This way we
> > have musb_ep_program() continue with PIO until cppi41 is awake.
> >
> > Fixes: fdea2d09b997 ("dmaengine: cppi41: Add basic PM runtime support")
>
> Cc stable?
Yes please.
Regards,
Tony
prev parent reply other threads:[~2019-10-23 15:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-22 14:55 [PATCH] dmaengine: cppi41: Fix issue with musb and ftdi uart Tony Lindgren
2019-10-23 4:53 ` Vinod Koul
2019-10-23 15:27 ` Tony Lindgren [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191023152755.GK5610@atomide.com \
--to=tony@atomide.com \
--cc=abailon@baylibre.com \
--cc=andrej.skvortzov@gmail.com \
--cc=andy.shevchenko@gmail.com \
--cc=b-liu@ti.com \
--cc=bigeasy@linutronix.de \
--cc=dan.j.williams@intel.com \
--cc=dmaengine@vger.kernel.org \
--cc=felipe.balbi@linux.intel.com \
--cc=george.cherian@ti.com \
--cc=giulio.benetti@benettiengineering.com \
--cc=grygorii.strashko@ti.com \
--cc=johan@kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=nsekhar@ti.com \
--cc=peter.ujfalusi@ti.com \
--cc=sergei.shtylyov@cogentembedded.com \
--cc=sre@kernel.org \
--cc=vinod.koul@intel.com \
--cc=vkoul@kernel.org \
--cc=yegorslists@googlemail.com \
--cc=zonque@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.