[MPTCP] Re: [PATCH v2 0/4] mptcp: switch mptcp_poll to use parent sock wait queue

[Florian Westphal <fw at strlen.de>]

[-- Attachment #1: Type: text/plain, Size: 1869 bytes --]

Paolo Abeni <pabeni(a)redhat.com> wrote:
> On Wed, 2019-10-23 at 16:23 +0200, Florian Westphal wrote:
> > No major changes, except the rebase on current export branch.
> > Selftest still passes.
> > 
> > This series is needed for sendmsg refactor, without it we can't
> > make mptcp sendmsg wait on the mptcp socket wait queue because we don't
> > get the needed wakeup events from the subflow layer.
> > 
> > The following changes since commit 85c93de446d3fd90e47605ba8ff161bef7558f09:
> > 
> >   mptcp: Implement basic path manager (2019-10-23 01:31:04 +0000)
> > 
> > are available in the Git repository at:
> > 
> >   git://git.breakpoint.cc/fw/mptcp-next.git mptcp_poll_07
> > 
> > for you to fetch changes up to 864dd47df1293e4b8bfc70be0d459286b6dddc3a:
> > 
> >   mptcp: switch mptcp_poll to mptcp socket wait queue (2019-10-23 15:20:28 +0200)
> > 
> > ----------------------------------------------------------------
> > Florian Westphal (4):
> >       mptcp: add and use subflow_write_space
> >       subflow: wake parent mptcp socket on subflow state change
> >       net: tcp: add __tcp_poll helper
> >       mptcp: switch mptcp_poll to mptcp socket wait queue
> > 
> >  include/net/tcp.h    |  1 +
> >  net/ipv4/tcp.c       | 12 ++++++++----
> >  net/mptcp/protocol.c |  4 +++-
> >  net/mptcp/subflow.c  | 34 ++++++++++++++++++++++++++++++++++
> >  4 files changed, 46 insertions(+), 5 deletions(-)
> > 
> > _______________________________________________
> > mptcp mailing list -- mptcp(a)lists.01.org
> > To unsubscribe send an email to mptcp-leave(a)lists.01.org
> 
> Series LGTM
> 
> I think we could include patch 3/4 in the "first chunk"/preparatory
> patches - e.g. apply just after "tcp, ulp: Add clone operation to
> tcp_ulp_ops" - and squash 4/4 in "mptcp: add mptcp_poll"
> 
> WDYT?

Seems good, yes.