Re: [PATCH v6 0/2] BLAKE2b generic implementation

[David Sterba <dsterba@suse.cz>]

On Wed, Oct 23, 2019 at 11:01:25AM +0200, Ard Biesheuvel wrote:
> On Wed, 23 Oct 2019 at 02:12, David Sterba <dsterba@suse.com> wrote:
> > Tested on x86_64 with KASAN and SLUB_DEBUG.
> 
> Tested-by: Ard Biesheuvel <ard.biesheuvel@linaro.org> # arm64 big-endian

Thanks!

> >  crypto/Kconfig           |  17 ++
> >  crypto/Makefile          |   1 +
> >  crypto/blake2b_generic.c | 413 +++++++++++++++++++++++++++++++++++++++
> >  crypto/testmgr.c         |  28 +++
> >  crypto/testmgr.h         | 307 +++++++++++++++++++++++++++++
> >  include/crypto/blake2b.h |  46 +++++
> 
> Final nit: do we need this header file at all? Could we move the
> contents into crypto/blake2b_generic.c? Or is the btrfs code going to
> #include it?

The only interesting part for btrfs would be the definition of
BLAKE2B_256_DIGEST_SIZE instead of hardcoding the number. As the patches
go through separate trees I have to use the hardcoded number anyway.

The header would make sense for the library version of blake2b, similar
to what the wireguard blake2s patches do, but there's no need for that
right now so I guess the header can be folded to .c.