From: Emily Shaffer <emilyshaffer@google.com>
To: Heba Waly via GitGitGadget <gitgitgadget@gmail.com>
Cc: git@vger.kernel.org, Heba Waly <heba.waly@gmail.com>,
Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH v3 1/1] config: move documentation to config.h
Date: Wed, 23 Oct 2019 14:38:34 -0700 [thread overview]
Message-ID: <20191023213834.GA124161@google.com> (raw)
In-Reply-To: <d6cbb3197af2c59f0222c7806ab6a6fcdf83869a.1571808652.git.gitgitgadget@gmail.com>
On Wed, Oct 23, 2019 at 05:30:52AM +0000, Heba Waly via GitGitGadget wrote:
> From: Heba Waly <heba.waly@gmail.com>
>
> Move the documentation from Documentation/technical/api-config.txt into
> config.h as it's easier for the developers to find the usage information
> beside the code instead of looking for it in another doc file, also
> documentation/technical/api-config.txt is removed because the information
> it has is now redundant and it'll be hard to keep it up to date and
> syncronized with the documentation in config.h
>
> Signed-off-by: Heba Waly <heba.waly@gmail.com>
Reviewed-by: Emily Shaffer <emilyshaffer@google.com>
Thanks for the effort, Heba. (I guess you are an expert on git-config
now!)
- Emily
next prev parent reply other threads:[~2019-10-23 21:38 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-18 0:06 [PATCH 0/1] config: add documentation to config.h Heba Waly via GitGitGadget
2019-10-18 0:06 ` [PATCH 1/1] " Heba Waly via GitGitGadget
2019-10-18 22:07 ` Jonathan Tan
2019-10-20 8:05 ` Heba Waly
2019-10-18 22:51 ` Emily Shaffer
2019-10-20 8:35 ` Heba Waly
2019-10-22 20:42 ` Emily Shaffer
2019-10-22 7:05 ` [PATCH v2 0/1] [Outreachy] config: move " Heba Waly via GitGitGadget
2019-10-22 7:05 ` [PATCH v2 1/1] " Heba Waly via GitGitGadget
2019-10-22 20:59 ` Emily Shaffer
2019-10-23 2:14 ` Junio C Hamano
2019-10-23 4:55 ` Heba Waly
2019-10-23 5:30 ` [PATCH v3 0/1] [Outreachy] " Heba Waly via GitGitGadget
2019-10-23 5:30 ` [PATCH v3 1/1] " Heba Waly via GitGitGadget
2019-10-23 21:38 ` Emily Shaffer [this message]
2019-10-24 2:14 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191023213834.GA124161@google.com \
--to=emilyshaffer@google.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=gitster@pobox.com \
--cc=heba.waly@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.