All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ye Xiaolong <xiaolong.ye@intel.com>
To: Congwen Zhang <zhang.congwen@zte.com.cn>
Cc: wenzhuo.lu@intel.com, dev@dpdk.org, stable@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v3] net/ixgbe: fix rss_conf sizeof argument
Date: Thu, 24 Oct 2019 15:44:02 +0800	[thread overview]
Message-ID: <20191024074402.GL72825@intel.com> (raw)
In-Reply-To: <1565228527-3969-1-git-send-email-zhang.congwen@zte.com.cn>

On 08/08, Congwen Zhang wrote:
>In function ixgbe_parse_rss_filter, memset(rss_conf, 0,
>sizeof(struct rte_eth_rss_conf)) is using
>memset(aaa, 0, sizeof(struct bbb)) format,
>maybe it's better to make it consistent with others.
>
>Fixes: 518cc3927b13 ("net/ixgbe: move RSS to flow API")
>Cc: stable@dpdk.org
>
>Signed-off-by: Congwen Zhang <zhang.congwen@zte.com.cn>
>---
> drivers/net/ixgbe/ixgbe_flow.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/drivers/net/ixgbe/ixgbe_flow.c b/drivers/net/ixgbe/ixgbe_flow.c
>index 92377b8..b2a2bfc 100644
>--- a/drivers/net/ixgbe/ixgbe_flow.c
>+++ b/drivers/net/ixgbe/ixgbe_flow.c
>@@ -2874,7 +2874,7 @@ static inline uint8_t signature_match(const struct rte_flow_item pattern[])
> 	/* check if the next not void item is END */
> 	act = next_no_void_action(actions, act);
> 	if (act->type != RTE_FLOW_ACTION_TYPE_END) {
>-		memset(rss_conf, 0, sizeof(struct rte_eth_rss_conf));
>+		memset(rss_conf, 0, sizeof(struct ixgbe_rte_flow_rss_conf));
> 		rte_flow_error_set(error, EINVAL,
> 			RTE_FLOW_ERROR_TYPE_ACTION,
> 			act, "Not supported action.");
>-- 
>1.8.3.1
>

Reviewed-by: Xiaolong Ye <xiaolong.ye@intel.com>

Applied to dpdk-next-net-intel. Thanks.

      parent reply	other threads:[~2019-10-24  7:47 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-08  1:42 [dpdk-dev] [PATCH v3] net/ixgbe: fix rss_conf sizeof argument Congwen Zhang
2019-08-08  2:41 ` Ye Xiaolong
2019-10-24  7:44 ` Ye Xiaolong [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191024074402.GL72825@intel.com \
    --to=xiaolong.ye@intel.com \
    --cc=dev@dpdk.org \
    --cc=stable@dpdk.org \
    --cc=wenzhuo.lu@intel.com \
    --cc=zhang.congwen@zte.com.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.