From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] package/dbus-python: Fix build with python 3.8
Date: Thu, 24 Oct 2019 10:06:44 +0200 [thread overview]
Message-ID: <20191024100644.0d2091e8@windsurf> (raw)
In-Reply-To: <20191024100534.73b352bb@windsurf>
On Thu, 24 Oct 2019 10:05:34 +0200
Thomas Petazzoni <thomas.petazzoni@bootlin.com> wrote:
> On Wed, 23 Oct 2019 21:19:21 +0000
> Grzegorz Blach <grzegorz@blach.pl> wrote:
>
> > test/import-repeatedly.c uses an embedded python interpreter
> > and PYTHON_EXTRA_LIBS is used only for building this test case,
> > so set PYTHON_EXTRA_LIBS with `python3-config --libs --embed`
> > to build this test case and don't link the module with libpython3.so.
> >
> > Fixes:
> > - http://autobuild.buildroot.org/results/b30/b308eeb5c5d95ab9f1dbfc19f9183f2ba3ba0ce3/
> > - http://autobuild.buildroot.org/results/0dd/0dd9203f859b97ee5a3b6358644c26f8ab784ed8/
> > and many similar failures.
> >
> > Signed-off-by: Grzegorz Blach <grzegorz@blach.pl>
> > ---
> > Changes v1 -> v2:
> > - Set PYTHON_EXTRA_LIBS with `python3-config --libs --embed`
> > instead of appending --embed to PYTHON_LIBS
>
> This doesn't change the fix, which I think still isn't correct (but I
> haven't checked in details). A Python extension should not need the
> --embed option.
And I replied too fast, without reading your commit log. Reading it, it
makes more sense. However, I think it should be fixed in the
dbus-python build system itself, so that the fix can be upstreamed.
Could you have a look at that ?
Of course, it's not trivial, because you need to pass --embed for
Python >= 3.8, but not for older versions of Python.
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2019-10-24 8:06 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-23 21:19 [Buildroot] [PATCH] package/dbus-python: Fix build with python 3.8 Grzegorz Blach
2019-10-24 8:05 ` Thomas Petazzoni
2019-10-24 8:06 ` Thomas Petazzoni [this message]
2019-10-24 8:43 ` Arnout Vandecappelle
2019-10-24 17:27 ` [Buildroot] [PATCH v3] " Grzegorz Blach
2019-10-25 16:22 ` [Buildroot] [PATCH] " Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191024100644.0d2091e8@windsurf \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.