From: Cyril Hrubis <chrubis@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] Rename tst_test_* to tst_require_*
Date: Thu, 24 Oct 2019 14:28:14 +0200 [thread overview]
Message-ID: <20191024122814.GC27782@rei.lan> (raw)
In-Reply-To: <20191011140015.GA27627@dell5510>
Hi!
> > > If we use needs or require ? Hard question - when I search for synonyms
> > > from one or the other, I don't see a big different. Without looking on
> > > the impact, require sounds also more descriptive.
>
> > There is about thousand of uses of *NEEDS_FOO and *needs_foo in the new
> > library tests, so renaming to tst_needs_foo would be the least painful.
> +1.
>
> Sorry for starting such a big discussion just about API naming.
> I care about these things, because good docs and consistent API are less
> important than good quality code, but helps new users.
>
> Thank you for all your input, I agree with points other raised, but getting it
> right would be to intrusive change (touching every test is a bit too much).
I would like to end the bikeshedding now and also get the tests fixed so
here is the proposal. If anyone wants to send a patch that unifies the
API on tst_needs_* please do so. If no one starts at least working on
that in a week or two, let's merge this patchset. Does that sound
reasonable to everyone?
--
Cyril Hrubis
chrubis@suse.cz
next prev parent reply other threads:[~2019-10-24 12:28 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-11 9:07 [LTP] Rename tst_test_* to tst_require_* Joerg Vehlow
2019-10-11 9:07 ` [LTP] [PATCH 1/2] shell: Rename s/tst_test_cmds/tst_require_cmds/ Joerg Vehlow
2019-10-11 9:07 ` [LTP] [PATCH 2/2] shell: Rename s/tst_test_drivers/tst_require_drivers/ Joerg Vehlow
2019-10-11 10:06 ` [LTP] Rename tst_test_* to tst_require_* Petr Vorel
2019-10-11 12:36 ` Cyril Hrubis
2019-10-11 13:03 ` Clemens Famulla-Conrad
2019-10-11 13:10 ` Cyril Hrubis
2019-10-11 14:00 ` Petr Vorel
2019-10-24 12:28 ` Cyril Hrubis [this message]
2019-10-24 12:48 ` Petr Vorel
2019-11-06 16:26 ` Cyril Hrubis
2019-11-06 17:01 ` Petr Vorel
2019-11-07 11:09 ` Petr Vorel
2019-11-07 11:32 ` Petr Vorel
2019-10-11 13:28 ` Li Wang
2019-10-11 13:39 ` Joerg Vehlow
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191024122814.GC27782@rei.lan \
--to=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.