From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH] drm/prime: Fix mmap fake offset for drm_gem_object_funcs.mmap Date: Thu, 24 Oct 2019 14:32:14 +0200 Message-ID: <20191024123214.GE11828@phenom.ffwll.local> References: <20191023222226.9064-1-robh@kernel.org> <20191024090240.jnmbo5ikivdbkbbg@sirius.home.kraxel.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wr1-x443.google.com (mail-wr1-x443.google.com [IPv6:2a00:1450:4864:20::443]) by gabe.freedesktop.org (Postfix) with ESMTPS id 161DD6E394 for ; Thu, 24 Oct 2019 12:32:18 +0000 (UTC) Received: by mail-wr1-x443.google.com with SMTP id a11so9789787wra.6 for ; Thu, 24 Oct 2019 05:32:18 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20191024090240.jnmbo5ikivdbkbbg@sirius.home.kraxel.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Gerd Hoffmann Cc: dri-devel@lists.freedesktop.org, Daniel Vetter List-Id: dri-devel@lists.freedesktop.org T24gVGh1LCBPY3QgMjQsIDIwMTkgYXQgMTE6MDI6NDBBTSArMDIwMCwgR2VyZCBIb2ZmbWFubiB3 cm90ZToKPiBPbiBXZWQsIE9jdCAyMywgMjAxOSBhdCAwNToyMjoyNlBNIC0wNTAwLCBSb2IgSGVy cmluZyB3cm90ZToKPiA+IENvbW1pdCBjNDAwNjljYjdiZDYgKCJkcm06IGFkZCBtbWFwKCkgdG8g ZHJtX2dlbV9vYmplY3RfZnVuY3MiKQo+ID4gaW50cm9kdWNlZCBhIEdFTSBvYmplY3QgbW1hcCgp IGhvb2sgd2hpY2ggaXMgZXhwZWN0ZWQgdG8gc3VidHJhY3QgdGhlCj4gPiBmYWtlIG9mZnNldCBm cm9tIHZtX3Bnb2ZmLgo+IAo+IExvbmctdGVybSBpdCBpcyBwcm9iYWJseSBhIGdvb2QgaWRlYSB0 byBqdXN0IHJlbW92ZSB0aGUgZmFrZSBvZmZzZXQKPiBoYW5kbGluZyBmcm9tIGRyaXZlcnMuICBC dXQgdGhhdCdsbCBvbmx5IHdvcmsgb25jZSBhbGwgZHJpdmVycyBzd2l0Y2hlZAo+IGF3YXkgZnJv bSBjdXN0b20gZm9wcy0+bW1hcCBoYW5kbGVycyBzbyB3ZSBjYW4gaGFuZGxlIHRoZSBvZmZzZXQg LT4gb2JqCj4gbG9va3VwIGluIHRoZSBkcm0gY29yZSBmb3IgZXZlcnlib2R5Lgo+IAo+IFNvIGxl dCdzIGdvIHRoaXMgd2F5IGZvciBub3cuCj4gCj4gQWNrZWQtYnk6IEdlcmQgSG9mZm1hbm4gPGty YXhlbEByZWRoYXQuY29tPgoKVWggdGhpcyBzb3VuZHMgbGlrZSBkb3VibGluZyBkb3duIG9uIHJh dGhlciBob3JyaWJsZSBzZW1hbnRpY3MuIENhbiB3ZSBhdApsZWFzdCBzdG9wIHRoZSBtZXNzIGlu c3RlYWQgb2YgYmFraW5nIGl0IGluIGZvciByZWFsPyBUaGUgaG9vayBpcyB2ZXJ5CnZlcnkgbmV3 IGFmdGVyIGFsbC4gSS5lLgotIERvY3VtZW50IHRoYXQgb2JqLT5mdW5jcy0+bW1hcCB3aWxsIGhh dmUgMCBvZmZzZXQgaW4gdGhlIGtlcm5lbGRvYy4KLSBSZW1vdmUgdGhlIHN1YnRyYWN0aW5nIGZy b20gdGhlIHNobWVtIGhlbHBlcgotIEluIHR0bV9ib19tbWFwX29iaiByZS1hZGQgdGhlIG9mZnNl dCB3aXRoIGEgaHVnZSBGSVhNRSBjb21tZW50LgotIEFkanVzdCBkcm1fZ2VtX21tYXBfb2JqIHRv IGRvIHRoYXQgc2FtZSBmb3Igb2JqLT5mdW5jcy0+bW1hcCBhbmQgYWxzbwogIGRvY3VtZW50IHRo ZSBleHBlY3RhdGlvbiB0aGVyZSB0b28uCgpUaGlzIGZlZWxzIGxpa2UgdmVyeSBtdWNoIGdvaW5n IHRoZSB3cm9uZyBkaXJlY3Rpb24gLi4uCgpBbHNvIEkgZ3Vlc3MgR2VyZCBkaWRuJ3QgcmVhbGx5 IHRlc3QgdGhpcyBwcmltZSBtbWFwIHN1cHBvcnQ/CgpUaGFua3MsIERhbmllbAo+IAo+ID4gSG93 ZXZlciwgZm9yIG1tYXAoKSBvbiBkbWFidWZzLCB0aGVyZSBpcyBub3QKPiA+IGEgZmFrZSBvZmZz ZXQuIFRvIGZpeCB0aGlzLCB3ZSBuZWVkIHRvIGFkZCB0aGUgZmFrZSBvZmZzZXQganVzdCBsaWtl IHRoZQo+ID4gZHJpdmVyLT5mb3BzLT5tbWFwKCkgY29kZSBwYXRoLgo+ID4gCj4gPiBGaXhlczog YzQwMDY5Y2I3YmQ2ICgiZHJtOiBhZGQgbW1hcCgpIHRvIGRybV9nZW1fb2JqZWN0X2Z1bmNzIikK PiA+IENjOiBHZXJkIEhvZmZtYW5uIDxrcmF4ZWxAcmVkaGF0LmNvbT4KPiA+IENjOiBEYW5pZWwg VmV0dGVyIDxkYW5pZWwudmV0dGVyQGZmd2xsLmNoPgo+ID4gU2lnbmVkLW9mZi1ieTogUm9iIEhl cnJpbmcgPHJvYmhAa2VybmVsLm9yZz4KPiA+IC0tLQo+ID4gSSByYW4gaW50byB0aGlzIHdoaWxl IHdvcmtpbmcgb24gY29udmVydGluZyB2Z2VtIHRvIHNobWVtIGhlbHBlcnMgYW5kCj4gPiB0aGUg SUdUIHZnZW1fYmFzaWMgZG1hYnVmLW1tYXAgdGVzdCBmYWlsZWQuIFRoaXMgZml4ZXMgc2htZW0s IGJ1dCBJCj4gPiBoYXZlIGNoZWNrZWQgYW55IG90aGVyIHVzZXJzIG9mIHRoZSBuZXcgbW1hcCBo b29rLgo+ID4gUm9iCj4gPiAKPiA+ICBkcml2ZXJzL2dwdS9kcm0vZHJtX3ByaW1lLmMgfCA0ICsr LS0KPiA+ICAxIGZpbGUgY2hhbmdlZCwgMiBpbnNlcnRpb25zKCspLCAyIGRlbGV0aW9ucygtKQo+ ID4gCj4gPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2RybV9wcmltZS5jIGIvZHJpdmVy cy9ncHUvZHJtL2RybV9wcmltZS5jCj4gPiBpbmRleCAwODE0MjExYjBmM2YuLjVkMDY2OTBhMmU5 ZCAxMDA2NDQKPiA+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9kcm1fcHJpbWUuYwo+ID4gKysrIGIv ZHJpdmVycy9ncHUvZHJtL2RybV9wcmltZS5jCj4gPiBAQCAtNzEzLDYgKzcxMyw4IEBAIGludCBk cm1fZ2VtX3ByaW1lX21tYXAoc3RydWN0IGRybV9nZW1fb2JqZWN0ICpvYmosIHN0cnVjdCB2bV9h cmVhX3N0cnVjdCAqdm1hKQo+ID4gIAlzdHJ1Y3QgZmlsZSAqZmlsOwo+ID4gIAlpbnQgcmV0Owo+ ID4gIAo+ID4gKwl2bWEtPnZtX3Bnb2ZmICs9IGRybV92bWFfbm9kZV9zdGFydCgmb2JqLT52bWFf bm9kZSk7Cj4gPiArCj4gPiAgCWlmIChvYmotPmZ1bmNzICYmIG9iai0+ZnVuY3MtPm1tYXApIHsK PiA+ICAJCXJldCA9IG9iai0+ZnVuY3MtPm1tYXAob2JqLCB2bWEpOwo+ID4gIAkJaWYgKHJldCkK PiA+IEBAIC03MzcsOCArNzM5LDYgQEAgaW50IGRybV9nZW1fcHJpbWVfbW1hcChzdHJ1Y3QgZHJt X2dlbV9vYmplY3QgKm9iaiwgc3RydWN0IHZtX2FyZWFfc3RydWN0ICp2bWEpCj4gPiAgCWlmIChy ZXQpCj4gPiAgCQlnb3RvIG91dDsKPiA+ICAKPiA+IC0Jdm1hLT52bV9wZ29mZiArPSBkcm1fdm1h X25vZGVfc3RhcnQoJm9iai0+dm1hX25vZGUpOwo+ID4gLQo+ID4gIAlyZXQgPSBvYmotPmRldi0+ ZHJpdmVyLT5mb3BzLT5tbWFwKGZpbCwgdm1hKTsKPiA+ICAKPiA+ICAJZHJtX3ZtYV9ub2RlX3Jl dm9rZSgmb2JqLT52bWFfbm9kZSwgcHJpdik7Cj4gPiAtLSAKPiA+IDIuMjAuMQo+ID4gCj4gCgot LSAKRGFuaWVsIFZldHRlcgpTb2Z0d2FyZSBFbmdpbmVlciwgSW50ZWwgQ29ycG9yYXRpb24KaHR0 cDovL2Jsb2cuZmZ3bGwuY2gKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0 b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJp LWRldmVs