From: Tony Lindgren <tony@atomide.com>
To: Tero Kristo <t-kristo@ti.com>
Cc: linux-clk@vger.kernel.org, sboyd@kernel.org,
mturquette@baylibre.com, linux-omap@vger.kernel.org,
aford173@gmail.com, tomi.valkeinen@ti.com
Subject: Re: [PATCH 0/4] clk: ti: re-work divider clock support
Date: Thu, 24 Oct 2019 06:40:00 -0700 [thread overview]
Message-ID: <20191024134000.GV5610@atomide.com> (raw)
In-Reply-To: <1115e221-1523-1a60-02a3-1f1939170e64@ti.com>
* Tero Kristo <t-kristo@ti.com> [191024 08:04]:
> On 02/10/2019 15:06, Tero Kristo wrote:
> > Hi,
> >
> > The existing divider clock support appears to have an inherent bug
> > because of the bit field width implementation and limitation of divider
> > values based on this. The limitation by bit field only is not enough,
> > as we can have divider settings which accept only certain range of
> > dividers within the full range of the bit-field.
> >
> > Because of this, the divider clock is re-implemented to use min,max,mask
> > values instead of just the bit-field.
>
> Queued this up for 5.4 fixes, thanks.
>
> Tony, do you have anything against the DT patch going in with the rest of
> this or should it be dropped?
No that won't cause merge conflicts so please merge the dts change
along with the rest of the series. So for the dts change:
Acked-by: Tony Lindgren <tony@atomide.com>
next prev parent reply other threads:[~2019-10-24 13:40 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-02 12:06 [PATCH 0/4] clk: ti: re-work divider clock support Tero Kristo
2019-10-02 12:06 ` [PATCH 1/4] clk: ti: divider: cleanup _register_divider and ti_clk_get_div_table Tero Kristo
2019-10-02 12:41 ` Adam Ford
2019-10-02 12:06 ` [PATCH 2/4] clk: ti: divider: cleanup ti_clk_parse_divider_data API Tero Kristo
2019-10-02 12:06 ` [PATCH 3/4] clk: ti: divider: convert to use min,max,mask instead of width Tero Kristo
2019-10-02 12:06 ` [PATCH 4/4] ARM: dts: omap3: fix DPLL4 M4 divider max value Tero Kristo
2019-10-24 8:03 ` [PATCH 0/4] clk: ti: re-work divider clock support Tero Kristo
2019-10-24 13:40 ` Tony Lindgren [this message]
2019-10-28 9:59 ` Stephen Boyd
2019-10-28 10:23 ` Tero Kristo
2019-10-28 11:36 ` Tomi Valkeinen
2019-10-28 13:57 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191024134000.GV5610@atomide.com \
--to=tony@atomide.com \
--cc=aford173@gmail.com \
--cc=linux-clk@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=sboyd@kernel.org \
--cc=t-kristo@ti.com \
--cc=tomi.valkeinen@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.