From: Andrew Lunn <andrew@lunn.ch>
To: "Michal Vokáč" <michal.vokac@ysoft.com>
Cc: Vivien Didelot <vivien.didelot@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <jakub.kicinski@netronome.com>,
Florian Fainelli <f.fainelli@gmail.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next] net: dsa: qca8k: Initialize the switch with correct number of ports
Date: Thu, 24 Oct 2019 16:12:11 +0200 [thread overview]
Message-ID: <20191024141211.GC30147@lunn.ch> (raw)
In-Reply-To: <1571924818-27725-1-git-send-email-michal.vokac@ysoft.com>
On Thu, Oct 24, 2019 at 03:46:58PM +0200, Michal Vokáč wrote:
> Since commit 0394a63acfe2 ("net: dsa: enable and disable all ports")
> the dsa core disables all unused ports of a switch. In this case
> disabling ports with numbers higher than QCA8K_NUM_PORTS causes that
> some switch registers are overwritten with incorrect content.
Humm.
The same problem might exist in other drivers:
linux/drivers/net/dsa$ grep -r "ds->num_ports = DSA_MAX_PORTS"
qca8k.c: priv->ds->num_ports = DSA_MAX_PORTS;
b53/b53_common.c: ds->num_ports = DSA_MAX_PORTS;
mt7530.c: priv->ds->num_ports = DSA_MAX_PORTS;
microchip/ksz_common.c: ds->num_ports = DSA_MAX_PORTS;
dsa_loop.c: ds->num_ports = DSA_MAX_PORTS;
dsa_loop.c looks O.K, it does support DSA_MAX_PORTS ports.
But the others?
Andrew
next prev parent reply other threads:[~2019-10-24 14:12 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-24 13:46 [PATCH net-next] net: dsa: qca8k: Initialize the switch with correct number of ports Michal Vokáč
2019-10-24 13:58 ` Andrew Lunn
2019-10-24 14:12 ` Andrew Lunn [this message]
2019-10-24 16:33 ` Florian Fainelli
2019-10-25 10:50 ` Michal Vokáč
2019-10-28 20:39 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191024141211.GC30147@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=jakub.kicinski@netronome.com \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.vokac@ysoft.com \
--cc=netdev@vger.kernel.org \
--cc=vivien.didelot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.