From: Kevin Wolf <kwolf@redhat.com>
To: qemu-block@nongnu.org
Cc: kwolf@redhat.com, psyhomb@gmail.com, michael@weiser.dinsnail.net,
vsementsov@virtuozzo.com, den@virtuozzo.com,
qemu-devel@nongnu.org, qemu-stable@nongnu.org,
dgilbert@redhat.com, mreitz@redhat.com, lersek@redhat.com
Subject: [PATCH v2 0/2] qcow2: Fix image corruption bug in 4.1
Date: Thu, 24 Oct 2019 16:26:56 +0200 [thread overview]
Message-ID: <20191024142658.22306-1-kwolf@redhat.com> (raw)
This series fixes an image corruption bug that was introduced in commit
69f47505e ('block: avoid recursive block_status call if possible'),
first contained in the QEMU 4.1.0 release.
This bug was reported by Michael Weiser on Launchpad:
https://bugs.launchpad.net/qemu/+bug/1846427
v2:
- Dropped the assertion in qcow2_cache_do_get() for now. Making sure
that it actually holds true for all callers requires more work and
getting the corruption fix in quickly is important.
- Use atomic_read() and add comment to qemu_co_mutex_assert_locked()
implementation [Denis]
Kevin Wolf (2):
coroutine: Add qemu_co_mutex_assert_locked()
qcow2: Fix corruption bug in qcow2_detect_metadata_preallocation()
include/qemu/coroutine.h | 15 +++++++++++++++
block/qcow2-refcount.c | 2 ++
block/qcow2.c | 3 ++-
3 files changed, 19 insertions(+), 1 deletion(-)
--
2.20.1
next reply other threads:[~2019-10-24 16:14 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-24 14:26 Kevin Wolf [this message]
2019-10-24 14:26 ` [PATCH v2 1/2] coroutine: Add qemu_co_mutex_assert_locked() Kevin Wolf
2019-10-24 15:35 ` Vladimir Sementsov-Ogievskiy
2019-10-24 15:50 ` Denis Lunev
2019-10-24 14:26 ` [PATCH v2 2/2] qcow2: Fix corruption bug in qcow2_detect_metadata_preallocation() Kevin Wolf
2019-10-25 10:44 ` [PATCH v2 0/2] qcow2: Fix image corruption bug in 4.1 Max Reitz
2019-10-25 14:42 ` Michael Weiser
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191024142658.22306-1-kwolf@redhat.com \
--to=kwolf@redhat.com \
--cc=den@virtuozzo.com \
--cc=dgilbert@redhat.com \
--cc=lersek@redhat.com \
--cc=michael@weiser.dinsnail.net \
--cc=mreitz@redhat.com \
--cc=psyhomb@gmail.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-stable@nongnu.org \
--cc=vsementsov@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.