From: Jason Gunthorpe <jgg@ziepe.ca>
To: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
Cc: Hans de Goede <hdegoede@redhat.com>,
Peter Huewe <peterhuewe@gmx.de>, Arnd Bergmann <arnd@arndb.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-integrity@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH] tpm: Switch to platform_get_irq_optional()
Date: Thu, 24 Oct 2019 12:36:22 -0300 [thread overview]
Message-ID: <20191024153622.GU23952@ziepe.ca> (raw)
In-Reply-To: <20191023113248.GA21973@linux.intel.com>
On Wed, Oct 23, 2019 at 02:32:48PM +0300, Jarkko Sakkinen wrote:
> On Mon, Oct 21, 2019 at 11:05:02AM -0300, Jason Gunthorpe wrote:
> > On Sat, Oct 19, 2019 at 11:45:28AM +0200, Hans de Goede wrote:
> > > Since commit 7723f4c5ecdb ("driver core: platform: Add an error message to
> > > platform_get_irq*()"), platform_get_irq() will call dev_err() on an error,
> > > as the IRQ usage in the tpm_tis driver is optional, this is undesirable.
> >
> > This should have a fixes line for the above, or maybe the commit that
> > addtion the _optional version..
>
> Is this fixing something?
Yes, an earlier commit caused new bogus warnings to appear, this is
fixing that regression
Jason
next prev parent reply other threads:[~2019-10-24 15:36 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-19 9:45 [PATCH] tpm: Switch to platform_get_irq_optional() Hans de Goede
2019-10-21 14:05 ` Jason Gunthorpe
2019-10-23 11:32 ` Jarkko Sakkinen
2019-10-24 15:36 ` Jason Gunthorpe [this message]
2019-10-21 15:49 ` Jarkko Sakkinen
2019-10-21 15:56 ` Hans de Goede
2019-10-23 11:37 ` Jarkko Sakkinen
2019-10-23 14:32 ` Hans de Goede
2019-10-24 14:25 ` Jarkko Sakkinen
2019-10-24 14:27 ` Hans de Goede
2019-10-24 19:09 ` Jarkko Sakkinen
2019-10-24 19:11 ` Jason Gunthorpe
2019-10-25 9:13 ` Hans de Goede
2019-10-28 20:47 ` Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191024153622.GU23952@ziepe.ca \
--to=jgg@ziepe.ca \
--cc=arnd@arndb.de \
--cc=gregkh@linuxfoundation.org \
--cc=hdegoede@redhat.com \
--cc=jarkko.sakkinen@linux.intel.com \
--cc=linux-integrity@vger.kernel.org \
--cc=peterhuewe@gmx.de \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.