From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sean Christopherson Date: Thu, 24 Oct 2019 19:42:14 +0000 Subject: Re: [PATCH v2 14/15] KVM: Terminate memslot walks via used_slots Message-Id: <20191024194214.GB28043@linux.intel.com> List-Id: References: <20191022003537.13013-1-sean.j.christopherson@intel.com> <20191022003537.13013-15-sean.j.christopherson@intel.com> <642f73ee-9425-0149-f4f4-f56be9ae5713@redhat.com> <20191022152827.GC2343@linux.intel.com> <625e511f-bd35-3b92-0c6d-550c10fc5827@redhat.com> <20191022155220.GD2343@linux.intel.com> <5c61c094-ee32-4dcf-b3ae-092eba0159c5@redhat.com> <20191024193856.GA28043@linux.intel.com> In-Reply-To: <20191024193856.GA28043@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Paolo Bonzini Cc: James Hogan , Paul Mackerras , Christian Borntraeger , Janosch Frank , Radim =?utf-8?B?S3LEjW3DocWZ?= , Marc Zyngier , David Hildenbrand , Cornelia Huck , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , James Morse , Julien Thierry , Suzuki K Poulose , linux-mips@vger.kernel.org, kvm-ppc@vger.kernel.org, kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, linux-kernel@vger.kernel.org On Thu, Oct 24, 2019 at 12:38:56PM -0700, Sean Christopherson wrote: > On Tue, Oct 22, 2019 at 05:53:27PM +0200, Paolo Bonzini wrote: > > On 22/10/19 17:52, Sean Christopherson wrote: > > > > > > Anyways, I'm not at all opposed to adding comments, just want to make sure > > > I'm not forgetting something. If it's ok with you, I'll comment the code > > > and/or functions and reply here to refine them without having to respin > > > the whole series. > > > > Yes, I agree this is better. > > Here's what I ended up with. I also added kvm_memslot_insert_back() to > help document the purpose of incrementing used_slots, and renamed > kvm_shift_memslots_forward()->kvm_memslot_move_backward() and > kvm_shift_memslots_backward()->kvm_memslot_move_forward() because I was > having trouble reconciling having the comments focus on the changed > memslot while the names of the functions reflected what happens to the > other memslots. Oh, and I need to respin the series to fix build bugs on MIPS and PPC, I'll wait to do that until I get a thumbs up on this code. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9A52ECA9EAF for ; Thu, 24 Oct 2019 19:42:21 +0000 (UTC) Received: from mm01.cs.columbia.edu (mm01.cs.columbia.edu [128.59.11.253]) by mail.kernel.org (Postfix) with ESMTP id 351F921929 for ; Thu, 24 Oct 2019 19:42:21 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 351F921929 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvmarm-bounces@lists.cs.columbia.edu Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id AB14E4A5C6; Thu, 24 Oct 2019 15:42:20 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id jqA3K2sp8EL5; Thu, 24 Oct 2019 15:42:19 -0400 (EDT) Received: from mm01.cs.columbia.edu (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 8A84A4A5D9; Thu, 24 Oct 2019 15:42:19 -0400 (EDT) Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 37B8B4A5C5 for ; Thu, 24 Oct 2019 15:42:18 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id v7T+iD-buMYh for ; Thu, 24 Oct 2019 15:42:17 -0400 (EDT) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by mm01.cs.columbia.edu (Postfix) with ESMTPS id E1BF14A3A3 for ; Thu, 24 Oct 2019 15:42:16 -0400 (EDT) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 24 Oct 2019 12:42:15 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.68,225,1569308400"; d="scan'208";a="399877874" Received: from sjchrist-coffee.jf.intel.com (HELO linux.intel.com) ([10.54.74.41]) by fmsmga006.fm.intel.com with ESMTP; 24 Oct 2019 12:42:15 -0700 Date: Thu, 24 Oct 2019 12:42:14 -0700 From: Sean Christopherson To: Paolo Bonzini Subject: Re: [PATCH v2 14/15] KVM: Terminate memslot walks via used_slots Message-ID: <20191024194214.GB28043@linux.intel.com> References: <20191022003537.13013-1-sean.j.christopherson@intel.com> <20191022003537.13013-15-sean.j.christopherson@intel.com> <642f73ee-9425-0149-f4f4-f56be9ae5713@redhat.com> <20191022152827.GC2343@linux.intel.com> <625e511f-bd35-3b92-0c6d-550c10fc5827@redhat.com> <20191022155220.GD2343@linux.intel.com> <5c61c094-ee32-4dcf-b3ae-092eba0159c5@redhat.com> <20191024193856.GA28043@linux.intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20191024193856.GA28043@linux.intel.com> User-Agent: Mutt/1.5.24 (2015-08-30) Cc: Cornelia Huck , Wanpeng Li , Janosch Frank , kvm@vger.kernel.org, James Hogan , Joerg Roedel , David Hildenbrand , linux-mips@vger.kernel.org, kvm-ppc@vger.kernel.org, linux-kernel@vger.kernel.org, Paul Mackerras , Christian Borntraeger , linux-arm-kernel@lists.infradead.org, Marc Zyngier , Vitaly Kuznetsov , kvmarm@lists.cs.columbia.edu, Jim Mattson X-BeenThere: kvmarm@lists.cs.columbia.edu X-Mailman-Version: 2.1.14 Precedence: list List-Id: Where KVM/ARM decisions are made List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: kvmarm-bounces@lists.cs.columbia.edu Sender: kvmarm-bounces@lists.cs.columbia.edu On Thu, Oct 24, 2019 at 12:38:56PM -0700, Sean Christopherson wrote: > On Tue, Oct 22, 2019 at 05:53:27PM +0200, Paolo Bonzini wrote: > > On 22/10/19 17:52, Sean Christopherson wrote: > > > > > > Anyways, I'm not at all opposed to adding comments, just want to make sure > > > I'm not forgetting something. If it's ok with you, I'll comment the code > > > and/or functions and reply here to refine them without having to respin > > > the whole series. > > > > Yes, I agree this is better. > > Here's what I ended up with. I also added kvm_memslot_insert_back() to > help document the purpose of incrementing used_slots, and renamed > kvm_shift_memslots_forward()->kvm_memslot_move_backward() and > kvm_shift_memslots_backward()->kvm_memslot_move_forward() because I was > having trouble reconciling having the comments focus on the changed > memslot while the names of the functions reflected what happens to the > other memslots. Oh, and I need to respin the series to fix build bugs on MIPS and PPC, I'll wait to do that until I get a thumbs up on this code. _______________________________________________ kvmarm mailing list kvmarm@lists.cs.columbia.edu https://lists.cs.columbia.edu/mailman/listinfo/kvmarm From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0227CCA9EAF for ; Thu, 24 Oct 2019 19:42:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C1DBA21655 for ; Thu, 24 Oct 2019 19:42:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2406722AbfJXTmQ (ORCPT ); Thu, 24 Oct 2019 15:42:16 -0400 Received: from mga06.intel.com ([134.134.136.31]:19209 "EHLO mga06.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2406601AbfJXTmQ (ORCPT ); Thu, 24 Oct 2019 15:42:16 -0400 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 24 Oct 2019 12:42:15 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.68,225,1569308400"; d="scan'208";a="399877874" Received: from sjchrist-coffee.jf.intel.com (HELO linux.intel.com) ([10.54.74.41]) by fmsmga006.fm.intel.com with ESMTP; 24 Oct 2019 12:42:15 -0700 Date: Thu, 24 Oct 2019 12:42:14 -0700 From: Sean Christopherson To: Paolo Bonzini Cc: James Hogan , Paul Mackerras , Christian Borntraeger , Janosch Frank , Radim =?utf-8?B?S3LEjW3DocWZ?= , Marc Zyngier , David Hildenbrand , Cornelia Huck , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , James Morse , Julien Thierry , Suzuki K Poulose , linux-mips@vger.kernel.org, kvm-ppc@vger.kernel.org, kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 14/15] KVM: Terminate memslot walks via used_slots Message-ID: <20191024194214.GB28043@linux.intel.com> References: <20191022003537.13013-1-sean.j.christopherson@intel.com> <20191022003537.13013-15-sean.j.christopherson@intel.com> <642f73ee-9425-0149-f4f4-f56be9ae5713@redhat.com> <20191022152827.GC2343@linux.intel.com> <625e511f-bd35-3b92-0c6d-550c10fc5827@redhat.com> <20191022155220.GD2343@linux.intel.com> <5c61c094-ee32-4dcf-b3ae-092eba0159c5@redhat.com> <20191024193856.GA28043@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191024193856.GA28043@linux.intel.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-mips-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-mips@vger.kernel.org On Thu, Oct 24, 2019 at 12:38:56PM -0700, Sean Christopherson wrote: > On Tue, Oct 22, 2019 at 05:53:27PM +0200, Paolo Bonzini wrote: > > On 22/10/19 17:52, Sean Christopherson wrote: > > > > > > Anyways, I'm not at all opposed to adding comments, just want to make sure > > > I'm not forgetting something. If it's ok with you, I'll comment the code > > > and/or functions and reply here to refine them without having to respin > > > the whole series. > > > > Yes, I agree this is better. > > Here's what I ended up with. I also added kvm_memslot_insert_back() to > help document the purpose of incrementing used_slots, and renamed > kvm_shift_memslots_forward()->kvm_memslot_move_backward() and > kvm_shift_memslots_backward()->kvm_memslot_move_forward() because I was > having trouble reconciling having the comments focus on the changed > memslot while the names of the functions reflected what happens to the > other memslots. Oh, and I need to respin the series to fix build bugs on MIPS and PPC, I'll wait to do that until I get a thumbs up on this code. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3BEAECA9EAF for ; Thu, 24 Oct 2019 19:42:34 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0D52A21655 for ; Thu, 24 Oct 2019 19:42:33 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="UcoAcQYC" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0D52A21655 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=B6X00/vs7eL3CBzyADeXZ4HcNtG1kj4gQphauTkQabE=; b=UcoAcQYCnzlydO kLnUFJgIEGOy8LHAwfGjs4N0XroeoqKbPXg3K8VwF6qnomiIxEiFws0DRTrpTcgRGnrTqGm9252kv Q0NDu6U68u6y+KmyH9i7Y3HsYtxyh+3+N7sgZtDWEyEhxHdKyF6C6zpeQK4MFjtOj9FZGryTvjKg0 ipgnYzagobV791QAfhLLA7K9hn64O2U7i4cIdVXgmmKHmvuLGZIuBY1bgYoyiNcH6vpbJfpbW7Uio ecVlrEcds4PFr1x11zgENfkuwpoBQ+ALdJPxkRkINaBzwW0sxj0zU4bSbxDvWFoPJYe2BHWQLgmQv 0OJJVZB8hpJo+a1JUuMQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iNj08-0004aZ-NC; Thu, 24 Oct 2019 19:42:28 +0000 Received: from mga12.intel.com ([192.55.52.136]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iNj06-0004aD-1y for linux-arm-kernel@lists.infradead.org; Thu, 24 Oct 2019 19:42:27 +0000 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 24 Oct 2019 12:42:15 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.68,225,1569308400"; d="scan'208";a="399877874" Received: from sjchrist-coffee.jf.intel.com (HELO linux.intel.com) ([10.54.74.41]) by fmsmga006.fm.intel.com with ESMTP; 24 Oct 2019 12:42:15 -0700 Date: Thu, 24 Oct 2019 12:42:14 -0700 From: Sean Christopherson To: Paolo Bonzini Subject: Re: [PATCH v2 14/15] KVM: Terminate memslot walks via used_slots Message-ID: <20191024194214.GB28043@linux.intel.com> References: <20191022003537.13013-1-sean.j.christopherson@intel.com> <20191022003537.13013-15-sean.j.christopherson@intel.com> <642f73ee-9425-0149-f4f4-f56be9ae5713@redhat.com> <20191022152827.GC2343@linux.intel.com> <625e511f-bd35-3b92-0c6d-550c10fc5827@redhat.com> <20191022155220.GD2343@linux.intel.com> <5c61c094-ee32-4dcf-b3ae-092eba0159c5@redhat.com> <20191024193856.GA28043@linux.intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20191024193856.GA28043@linux.intel.com> User-Agent: Mutt/1.5.24 (2015-08-30) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191024_124226_108383_E001C4EB X-CRM114-Status: GOOD ( 14.18 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Cornelia Huck , Wanpeng Li , Janosch Frank , kvm@vger.kernel.org, Radim =?utf-8?B?S3LEjW3DocWZ?= , James Hogan , Joerg Roedel , David Hildenbrand , linux-mips@vger.kernel.org, kvm-ppc@vger.kernel.org, linux-kernel@vger.kernel.org, Paul Mackerras , Christian Borntraeger , James Morse , linux-arm-kernel@lists.infradead.org, Marc Zyngier , Vitaly Kuznetsov , Suzuki K Poulose , kvmarm@lists.cs.columbia.edu, Julien Thierry , Jim Mattson Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Oct 24, 2019 at 12:38:56PM -0700, Sean Christopherson wrote: > On Tue, Oct 22, 2019 at 05:53:27PM +0200, Paolo Bonzini wrote: > > On 22/10/19 17:52, Sean Christopherson wrote: > > > > > > Anyways, I'm not at all opposed to adding comments, just want to make sure > > > I'm not forgetting something. If it's ok with you, I'll comment the code > > > and/or functions and reply here to refine them without having to respin > > > the whole series. > > > > Yes, I agree this is better. > > Here's what I ended up with. I also added kvm_memslot_insert_back() to > help document the purpose of incrementing used_slots, and renamed > kvm_shift_memslots_forward()->kvm_memslot_move_backward() and > kvm_shift_memslots_backward()->kvm_memslot_move_forward() because I was > having trouble reconciling having the comments focus on the changed > memslot while the names of the functions reflected what happens to the > other memslots. Oh, and I need to respin the series to fix build bugs on MIPS and PPC, I'll wait to do that until I get a thumbs up on this code. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel