From: Sean Christopherson <sean.j.christopherson@intel.com>
To: Jim Mattson <jmattson@google.com>
Cc: kvm@vger.kernel.org, Paolo Bonzini <pbonzini@redhat.com>,
Ken Hofsass <hofsass@google.com>, Peter Shier <pshier@google.com>
Subject: Re: [PATCH v2] kvm: x86: Add cr3 to struct kvm_debug_exit_arch
Date: Thu, 24 Oct 2019 13:21:36 -0700 [thread overview]
Message-ID: <20191024202136.GC28043@linux.intel.com> (raw)
In-Reply-To: <20191024195431.183667-1-jmattson@google.com>
On Thu, Oct 24, 2019 at 12:54:31PM -0700, Jim Mattson wrote:
> From: Ken Hofsass <hofsass@google.com>
>
> A userspace agent can use cr3 to quickly determine whether a
> KVM_EXIT_DEBUG is associated with a guest process of interest.
>
> KVM_CAP_DEBUG_EVENT_PDBR indicates support for the extension.
Isn't PDBR x86-specific terminology? If we're going to use something that
is x86-specific then just call it GUEST_CR3. If there's a chance that
this is useful on other architectures then it'd probably be better to go
with Linux's own terminology, e.g. KVM_CAP_DEBUG_EVENT_GUEST_PGD.
> Signed-off-by: Ken Hofsass <hofsass@google.com>
> Signed-off-by: Jim Mattson <jmattson@google.com>
> Cc: Peter Shier <pshier@google.com>
> ---
> v1 -> v2: Changed KVM_CAP_DEBUG_EVENT_PG_BASE_ADDR to KVM_CAP_DEBUG_EVENT_PDBR
> Set debug.arch.cr3 in kvm_vcpu_do_singlestep and
> kvm_vcpu_check_breakpoint
> Added svm support
Heh, I wonder what the record is for longest time between legitimate
versions of a single patch.
next prev parent reply other threads:[~2019-10-24 20:21 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-24 19:54 [PATCH v2] kvm: x86: Add cr3 to struct kvm_debug_exit_arch Jim Mattson
2019-10-24 20:21 ` Sean Christopherson [this message]
2019-10-24 22:17 ` Paolo Bonzini
2019-10-25 17:07 ` Ken Hofsass
2019-11-05 19:59 ` Jim Mattson
2019-11-05 22:23 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191024202136.GC28043@linux.intel.com \
--to=sean.j.christopherson@intel.com \
--cc=hofsass@google.com \
--cc=jmattson@google.com \
--cc=kvm@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=pshier@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.